107439 2013-01-21 04:48:03 -0800 [Soup] Random thread crashes 2013-01-22 22:12:53 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Soup P2 Normal --- 107432 1 svillar svillar danw gustavo mrobinson rakuco s.choi svillar oldest_to_newest 812035 0 svillar 2013-01-21 04:48:03 -0800 GLib (gthread-posix.c): Unexpected error from C library during 'pthread_mutex_lock': Invalid argument. Aborting. Program received signal SIGABRT, Aborted. 0x00007ffff016b475 in *__GI_raise (sig=<optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 64 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) bt #0 0x00007ffff016b475 in *__GI_raise (sig=<optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 #1 0x00007ffff016e6f0 in *__GI_abort () at abort.c:92 #2 0x00007ffff0db020b in g_thread_abort (status=22, function=0x7ffff0e3a52f "pthread_mutex_lock") at gthread-posix.c:76 #3 0x00007ffff0db0397 in g_mutex_lock (mutex=0x21c1730) at gthread-posix.c:211 #4 0x00007ffff0d60d56 in g_main_context_find_source_by_user_data (context=0x21c1730, user_data=0x77b1a0) at gmain.c:2050 #5 0x00007ffff41feefe in soup_session_real_kick_queue (session=0x77b180) at soup-session.c:2123 #6 0x00007ffff41fefbc in soup_session_kick_queue (session=0x77b180) at soup-session.c:2141 #7 0x00007ffff4201d20 in soup_session_send_async (session=0x77b180, msg=0x2646d90, cancellable=0x227be40, callback=0x7ffff41f641c <http_input_stream_ready_cb>, user_data=0x22de0e0) at soup-session.c:3909 #8 0x00007ffff41f65b9 in soup_request_http_send_async (request=0x22f25e0, cancellable=0x227be40, callback=0x7ffff5e11c70 <WebCore::sendRequestCallback(_GObject*, _GAsyncResult*, void*)>, user_data=0x7fff8853d768) at soup-request-http.c:143 #9 0x00007ffff41f5170 in soup_request_send_async (request=0x22f25e0, cancellable=0x227be40, callback=0x7ffff5e11c70 <WebCore::sendRequestCallback(_GObject*, _GAsyncResult*, void*)>, user_data=0x7fff8853d768) at soup-request.c:244 #10 0x00007ffff5e11ba4 in WebCore::ResourceHandle::start(WebCore::NetworkingContext*) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #11 0x00007ffff5e02931 in WebCore::ResourceHandle::create(WebCore::NetworkingContext*, WebCore::ResourceRequest const&, WebCore::ResourceHandleClient*, bool, bool) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #12 0x00007ffff561ef6c in WebCore::ResourceLoader::start() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #13 0x00007ffff5623f8a in WebCore::ResourceLoadScheduler::servePendingRequests(WebCore::ResourceLoadScheduler::HostInformation*, WebCore::ResourceLoadPriority) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #14 0x00007ffff56244ae in WebCore::ResourceLoadScheduler::scheduleSubresourceLoad(WebCore::Frame*, WebCore::CachedResource*, WebCore::ResourceRequest const&, WebCore::ResourceLoadPriority, WebCore::ResourceLoaderOptions const&) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #15 0x00007ffff55b921c in WebCore::CachedResource::load(WebCore::CachedResourceLoader*, WebCore::ResourceLoaderOptions const&) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #16 0x00007ffff55bedd9 in WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #17 0x00007ffff55c0658 in WebCore::CachedResourceLoader::requestCSSStyleSheet(WebCore::CachedResourceRequest&) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 812036 1 svillar 2013-01-21 04:49:21 -0800 BTW I can consistently reproduce it just by trying to log in http://twitter.com 812044 2 svillar 2013-01-21 05:04:32 -0800 OK, so I've just realized that it only happens if I'm using the patch for bug 107432. Dan, is there any problem on mixing async and sync calls for accessing a given stream? (that patch is synchronously closing a stream that have been read asynchronously). 812151 3 danw 2013-01-21 07:58:21 -0800 It's supposed to work... and if it was going to fail, I wouldn't expect it to fail like this, which looks like a refcounting problem or something... double-check that there isn't something else wrong in the sync close patch? 812190 4 svillar 2013-01-21 08:26:33 -0800 (In reply to comment #3) > It's supposed to work... and if it was going to fail, I wouldn't expect it to fail like this, which looks like a refcounting problem or something... double-check that there isn't something else wrong in the sync close patch? I got some slightly different backtraces, most of them when loading resources synchronously, which requires some push/pop_thread magic. Could it be related to that? 812545 5 183872 jschuh 2013-01-21 19:49:56 -0800 Created attachment 183872 Patch 812547 6 183872 jschuh 2013-01-21 19:52:40 -0800 Comment on attachment 183872 Patch Please ignore. I fat-fingered a bug number. 813103 7 svillar 2013-01-22 09:46:41 -0800 OK I found what's going on. So there was a mixture of things. There is a bug in libsoup which was somehow uncovered by the patch for https://bugs.webkit.org/show_bug.cgi?id=107432. But I think there is also a bug in our network stack for synchronous requests. We directly stop the inner main loop we create to emulate synchronous requests in didFinishLoading() but we do not check if we have pending sources in that context we create. 813114 8 184001 svillar 2013-01-22 09:54:44 -0800 Created attachment 184001 Patch 813119 9 184001 mrobinson 2013-01-22 10:04:24 -0800 Comment on attachment 184001 Patch Okay. This seems reasonable. 813255 10 184001 svillar 2013-01-22 11:26:29 -0800 Comment on attachment 184001 Patch Clearing flags on attachment: 184001 Committed r140445: <http://trac.webkit.org/changeset/140445> 813256 11 svillar 2013-01-22 11:26:35 -0800 All reviewed patches have been landed. Closing bug. 183872 2013-01-21 19:49:56 -0800 2013-01-21 19:52:39 -0800 Patch bug-107439-20130121194652.patch text/plain 731 jschuh SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVUcmVlLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVRyZWUuaAkocmV2aXNpb24gMTQwMzQ5KQorKysgU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVRyZWUuaAkod29ya2luZyBjb3B5KQpAQCAtMjAsNyArMjAsNiBA QAogI2lmbmRlZiBGcmFtZVRyZWVfaAogI2RlZmluZSBGcmFtZVRyZWVfaAogCi0jaW5jbHVkZSA8 d3RmL05vdEZvdW5kLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQXRvbWljU3RyaW5nLmg+CiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKQEAgLTMxLDcgKzMwLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgIGNsYXNzIEZyYW1lVHJlZSB7CiAgICAgICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEZyYW1l VHJlZSk7CiAgICAgcHVibGljOgotICAgICAgICBjb25zdCBzdGF0aWMgdW5zaWduZWQgaW52YWxp ZENvdW50ID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KFdURjo6bm90Rm91bmQpOworICAgICAgICBj b25zdCBzdGF0aWMgdW5zaWduZWQgaW52YWxpZENvdW50ID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+ KC0xKTsKIAogICAgICAgICBGcmFtZVRyZWUoRnJhbWUqIHRoaXNGcmFtZSwgRnJhbWUqIHBhcmVu dEZyYW1lKSAKICAgICAgICAgICAgIDogbV90aGlzRnJhbWUodGhpc0ZyYW1lKQo= 184001 2013-01-22 09:54:44 -0800 2013-01-22 11:26:29 -0800 Patch bug-107439-20130122185137.patch text/plain 1729 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MxMWM2MTZkYjVmNjU2 NmEwZjkxMTgwOWJmNjY3NjRmYWYyZmJlZC4uMTFiNzU5NjdjN2FkZDIxZTlmN2FmNGIyOTE2ZGUy MTdiODdjOGUzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTIyICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtTb3VwXSBS YW5kb20gdGhyZWFkIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNzQzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFByb2Nlc3MgYWxsIHBlbmRpbmcgcmVxdWVzdHMgaW4gdGhlIGlubmVyIEdN YWluQ29udGV4dCBjcmVhdGVkIHRvCisgICAgICAgIHBlcmZvcm0gc3luY2hyb25vdXMgcmVxdWVz dHMgYmVmb3JlIHJlc3RvcmluZyB0aGUgdGhyZWFkIGRlZmF1bHQuIE5vCisgICAgICAgIG5ldyB0 ZXN0cyByZXF1aXJlZCwgYWxyZWFkeSBjb3ZlcmVkIGJ5IG5ldHdvcmsgdGVzdHMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OldlYkNvcmVTeW5jaHJvbm91c0xvYWRlcjo6fldlYkNvcmVTeW5jaHJvbm91 c0xvYWRlcik6CisKIDIwMTMtMDEtMTkgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291 cC5jcHAKaW5kZXggYTY0YTQzMDhjNzQyNGMxZDY1OTYwODgzMGY1YmQyYzJjMzVhNjUzNy4uNTdh YmU5ZWY0MGYxZjI4YmViN2U3Mzk4YTEyMTc5MTE0YTU2NDA5MSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291 cC5jcHAKQEAgLTExNyw3ICsxMTcsMTIgQEAgcHVibGljOgogICAgIH5XZWJDb3JlU3luY2hyb25v dXNMb2FkZXIoKQogICAgIHsKICAgICAgICAgYWRqdXN0TWF4Q29ubmVjdGlvbnMoLTEpOwotICAg ICAgICBnX21haW5fY29udGV4dF9wb3BfdGhyZWFkX2RlZmF1bHQoZ19tYWluX2NvbnRleHRfZ2V0 X3RocmVhZF9kZWZhdWx0KCkpOworCisgICAgICAgIEdNYWluQ29udGV4dCogY29udGV4dCA9IGdf bWFpbl9jb250ZXh0X2dldF90aHJlYWRfZGVmYXVsdCgpOworICAgICAgICB3aGlsZSAoZ19tYWlu X2NvbnRleHRfcGVuZGluZyhjb250ZXh0KSkKKyAgICAgICAgICAgIGdfbWFpbl9jb250ZXh0X2l0 ZXJhdGlvbihjb250ZXh0LCBGQUxTRSk7CisKKyAgICAgICAgZ19tYWluX2NvbnRleHRfcG9wX3Ro cmVhZF9kZWZhdWx0KGNvbnRleHQpOwogICAgICAgICBsb2FkaW5nU3luY2hyb25vdXNSZXF1ZXN0 ID0gZmFsc2U7CiAgICAgfQogCg==