107437 2013-01-21 03:38:14 -0800 QtTestBrowser should provide way to clear selected elements 2013-01-21 04:46:54 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vivekg vivek.vg hausmann ossy vivek.vg webkit.review.bot oldest_to_newest 812010 0 vivekg 2013-01-21 03:38:14 -0800 Steps: 1. Launch QtTestBrowser using ./Tools/Scripts/run-launcher --qt 2. Navigate to "Develop->Select Elements..." menu to enter the name of elements and press enter 3. The elements are highlighted on the page 4. Repeat step 2 with some other element name(valid/invalid element names) and press enter Expected outcome: Previously highlighted items should be restored while highlighting new elements if available. Actual outcome: Both the elements are hightlighted Proposed Solution: Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight. Patch to follow. 812013 1 183754 vivek.vg 2013-01-21 03:46:00 -0800 Created attachment 183754 Patch 812015 2 183755 vivek.vg 2013-01-21 03:51:55 -0800 Created attachment 183755 Patch 812019 3 183755 hausmann 2013-01-21 03:57:40 -0800 Comment on attachment 183755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183755&action=review > Tools/QtTestBrowser/launcherwindow.cpp:76 > +struct ElementHighlight { How about calling this HighlightedElement? > Tools/QtTestBrowser/launcherwindow.cpp:78 > + QString m_styleValue; And this field m_oldStyle or m_previousStyle to emphasize the fact that this is the style from _before_ the element was highlighted. > Tools/QtTestBrowser/launcherwindow.cpp:825 > + ElementHighlight el = {e, e.styleProperty("background-color", QWebElement::InlineStyle)}; Space needed after { and before }. Does this even compile? I thought semicolon is needed after the styleProperty() call? > Tools/QtTestBrowser/launcherwindow.cpp:838 > +} You should clear the list here. > Tools/QtTestBrowser/launcherwindow.h:231 > + QList<ElementHighlight> m_previousHighlightElements; I suggest to call this m_highlightedElements to stress that this holds the list of currently highlighted elements, not the ones from the previous selection. 812024 4 183758 vivek.vg 2013-01-21 04:06:00 -0800 Created attachment 183758 Patch 812027 5 183755 vivekg 2013-01-21 04:08:52 -0800 Comment on attachment 183755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183755&action=review Thank you for your comments. Uploaded a new patch. >> Tools/QtTestBrowser/launcherwindow.cpp:76 >> +struct ElementHighlight { > > How about calling this HighlightedElement? Done. >> Tools/QtTestBrowser/launcherwindow.cpp:78 >> + QString m_styleValue; > > And this field m_oldStyle or m_previousStyle to emphasize the fact that this is the style from _before_ the element was highlighted. Done. >> Tools/QtTestBrowser/launcherwindow.cpp:825 >> + ElementHighlight el = {e, e.styleProperty("background-color", QWebElement::InlineStyle)}; > > Space needed after { and before }. Does this even compile? I thought semicolon is needed after the styleProperty() call? Done. Yes it compiles :) >> Tools/QtTestBrowser/launcherwindow.cpp:838 >> +} > > You should clear the list here. Done. >> Tools/QtTestBrowser/launcherwindow.h:231 >> + QList<ElementHighlight> m_previousHighlightElements; > > I suggest to call this m_highlightedElements to stress that this holds the list of currently highlighted elements, not the ones from the previous selection. Done. 812033 6 183758 webkit.review.bot 2013-01-21 04:46:51 -0800 Comment on attachment 183758 Patch Clearing flags on attachment: 183758 Committed r140323: <http://trac.webkit.org/changeset/140323> 812034 7 webkit.review.bot 2013-01-21 04:46:54 -0800 All reviewed patches have been landed. Closing bug. 183754 2013-01-21 03:46:00 -0800 2013-01-21 03:51:45 -0800 Patch bug-107437-20130121171351.patch text/plain 3906 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJkMGI4MTZlMjMyNjQ3YjlmMTc1MDhhNzNhZTRkM2Q4 N2VkZDhjOC4uZjNjNTAxZTNiMTg4ZjRiM2E4NjRmMTQ4ZTU4MDc3NzhjOGQxZWJkMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTAxLTIxICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgor CisgICAgICAgIFF0VGVzdEJyb3dzZXIgc2hvdWxkIHByb3ZpZGUgd2F5IHRvIGNsZWFyIHNlbGVj dGVkIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDc0MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQcm92aWRlIGEgd2F5IHRvICJDbGVhciBzZWxlY3Rpb24iIGluIHRoZSAiRGV2ZWxvcCIg bWVudSB0byBjbGVhciB0aGUgcHJldmlvdXMgc2VhcmNoIGhpZ2hsaWdodC4KKyAgICAgICAgSW52 b2tlIHRoZSBjbGVhclNlbGVjdGlvbiBwcmlvciB0byBoaWdobGlnaHRpbmcgbmV3IGVsZW1lbnRz LgorCisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHA6CisgICAgICAg IChFbGVtZW50SGlnaGxpZ2h0KToKKyAgICAgICAgKExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJv bWUpOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OnNlbGVjdEVsZW1lbnRzKToKKyAgICAgICAg KExhdW5jaGVyV2luZG93OjpjbGVhclNlbGVjdGlvbik6CisgICAgICAgICogUXRUZXN0QnJvd3Nl ci9sYXVuY2hlcndpbmRvdy5oOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3cpOgorCiAyMDEzLTAx LTE3ICBGcmFuayBGYXJ6YW4gIDxmcmFua2ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZsYWtp bmVzcyBkYXNoYm9hcmQ6IEFkZCBDaHJvbWl1bUZZSSBtYXN0ZXIKZGlmZiAtLWdpdCBhL1Rvb2xz L1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9s YXVuY2hlcndpbmRvdy5jcHAKaW5kZXggY2EwMDg5MjYyZDM0OTAwMTRmODg5MGM1NTRmZGZkOTM2 MmUwYTk4YS4uOGFiNWM5MzIwYzlhZTVhYjJlYjI4NmJjZTI0NDY0ZGQzYTRjNDk0ZiAxMDA2NDQK LS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKKysrIGIvVG9vbHMv UXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKQEAgLTczLDYgKzczLDExIEBACiAjaW5j bHVkZSA8UXROZXR3b3JrL1FOZXR3b3JrRGlza0NhY2hlPgogI2VuZGlmCiAKK3N0cnVjdCBFbGVt ZW50SGlnaGxpZ2h0IHsKKyAgICBRV2ViRWxlbWVudCBtX2VsZW1lbnQ7CisgICAgUVN0cmluZyBt X3N0eWxlVmFsdWU7Cit9OworCiBjb25zdCBpbnQgZ0V4aXRDbGlja0FyZWEgPSA4MDsKIFFWZWN0 b3I8aW50PiBMYXVuY2hlcldpbmRvdzo6bV96b29tTGV2ZWxzOwogCkBAIC0zNjIsNiArMzY3LDgg QEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKCkKIAogICAgIHRvb2xzTWVudS0+ YWRkQWN0aW9uKCJTZWxlY3QgRWxlbWVudHMuLi4iLCB0aGlzLCBTTE9UKHNlbGVjdEVsZW1lbnRz KCkpKTsKIAorICAgIHRvb2xzTWVudS0+YWRkQWN0aW9uKCJDbGVhciBzZWxlY3Rpb24iLCB0aGlz LCBTTE9UKGNsZWFyU2VsZWN0aW9uKCkpKTsKKwogICAgIFFBY3Rpb24qIHNob3dJbnNwZWN0b3JB Y3Rpb24gPSB0b29sc01lbnUtPmFkZEFjdGlvbigiU2hvdyBXZWIgSW5zcGVjdG9yIiwgbV9pbnNw ZWN0b3IsIFNMT1Qoc2V0VmlzaWJsZShib29sKSksIFFLZXlTZXF1ZW5jZShRdDo6Q1RSTCB8IFF0 OjpBTFQgfCBRdDo6S2V5X0kpKTsKICAgICBzaG93SW5zcGVjdG9yQWN0aW9uLT5zZXRDaGVja2Fi bGUodHJ1ZSk7CiAgICAgc2hvd0luc3BlY3RvckFjdGlvbi0+Y29ubmVjdChtX2luc3BlY3Rvciwg U0lHTkFMKHZpc2libGVDaGFuZ2VkKGJvb2wpKSwgU0xPVChzZXRDaGVja2VkKGJvb2wpKSk7CkBA IC04MTMsMTMgKzgyMCwyMiBAQCB2b2lkIExhdW5jaGVyV2luZG93OjpzZWxlY3RFbGVtZW50cygp CiAKICAgICBpZiAob2sgJiYgIXN0ci5pc0VtcHR5KCkpIHsKICAgICAgICAgUVdlYkVsZW1lbnRD b2xsZWN0aW9uIHJlc3VsdCA9ICBwYWdlKCktPm1haW5GcmFtZSgpLT5maW5kQWxsRWxlbWVudHMo c3RyKTsKLSAgICAgICAgZm9yZWFjaCAoUVdlYkVsZW1lbnQgZSwgcmVzdWx0KQorICAgICAgICBm b3JlYWNoIChRV2ViRWxlbWVudCBlLCByZXN1bHQpIHsKKyAgICAgICAgICAgIEVsZW1lbnRIaWdo bGlnaHQgZWwgPSB7ZSwgZS5zdHlsZVByb3BlcnR5KCJiYWNrZ3JvdW5kLWNvbG9yIiwgUVdlYkVs ZW1lbnQ6OklubGluZVN0eWxlKX07CisgICAgICAgICAgICBtX3ByZXZpb3VzSGlnaGxpZ2h0RWxl bWVudHMuYXBwZW5kKGVsKTsKICAgICAgICAgICAgIGUuc2V0U3R5bGVQcm9wZXJ0eSgiYmFja2dy b3VuZC1jb2xvciIsICJ5ZWxsb3ciKTsKKyAgICAgICAgfQogICAgICAgICBzdGF0dXNCYXIoKS0+ c2hvd01lc3NhZ2UoUVN0cmluZygiJTEgZWxlbWVudChzKSBzZWxlY3RlZCIpLmFyZyhyZXN1bHQu Y291bnQoKSksIDUwMDApOwogICAgIH0KICNlbmRpZgogfQogCit2b2lkIExhdW5jaGVyV2luZG93 OjpjbGVhclNlbGVjdGlvbigpCit7CisgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBtX3ByZXZpb3Vz SGlnaGxpZ2h0RWxlbWVudHMuc2l6ZSgpOyArK2kpCisgICAgICAgIG1fcHJldmlvdXNIaWdobGln aHRFbGVtZW50c1tpXS5tX2VsZW1lbnQuc2V0U3R5bGVQcm9wZXJ0eSgiYmFja2dyb3VuZC1jb2xv ciIsIG1fcHJldmlvdXNIaWdobGlnaHRFbGVtZW50c1tpXS5tX3N0eWxlVmFsdWUpOworfQorCiB2 b2lkIExhdW5jaGVyV2luZG93OjpzZXREaXNrQ2FjaGUoYm9vbCBlbmFibGUpCiB7CiAjaWYgIWRl ZmluZWQoUVRfTk9fTkVUV09SS0RJU0tDQUNIRSkgJiYgIWRlZmluZWQoUVRfTk9fREVTS1RPUFNF UlZJQ0VTKQpkaWZmIC0tZ2l0IGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5o IGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCmluZGV4IGI0ZDQ0ZmUzYjc2 NTZiNjYzNTk5OWMwYzhmNjhmYjQ0NDgzZTY2YmEuLmM1YWExMTkyMGRlNjcwNzNjMjVkZjhkNzA0 NGMzNjNlOTc4Njg4NTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3 aW5kb3cuaAorKysgYi9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgKQEAgLTYw LDYgKzYwLDggQEAgY2xhc3MgUVByb3BlcnR5QW5pbWF0aW9uOwogY2xhc3MgUUxpbmVFZGl0Owog UVRfRU5EX05BTUVTUEFDRQogCitzdHJ1Y3QgRWxlbWVudEhpZ2hsaWdodDsKKwogY2xhc3MgV2lu ZG93T3B0aW9ucyB7CiBwdWJsaWM6CiAgICAgV2luZG93T3B0aW9ucygpCkBAIC0xODEsNiArMTgz LDcgQEAgcHJvdGVjdGVkIFFfU0xPVFM6CiAgICAgdm9pZCBhbmltYXRlZEZsaXAoKTsKICAgICB2 b2lkIGFuaW1hdGVkWUZsaXAoKTsKICAgICB2b2lkIHNlbGVjdEVsZW1lbnRzKCk7CisgICAgdm9p ZCBjbGVhclNlbGVjdGlvbigpOwogICAgIHZvaWQgc2hvd0ZQUyhib29sIGVuYWJsZSk7CiAgICAg dm9pZCBzaG93VXNlckFnZW50RGlhbG9nKCk7CiAKQEAgLTIyNSw2ICsyMjgsNyBAQCBwcml2YXRl OgogICAgIFFOZXR3b3JrUmVwbHkqIG1fcmVwbHk7CiAjZW5kaWYKICAgICBRTGlzdDxRVG91Y2hF dmVudDo6VG91Y2hQb2ludD4gbV90b3VjaFBvaW50czsKKyAgICBRTGlzdDxFbGVtZW50SGlnaGxp Z2h0PiBtX3ByZXZpb3VzSGlnaGxpZ2h0RWxlbWVudHM7CiAgICAgYm9vbCBtX3RvdWNoTW9ja2lu ZzsKIAogICAgIFFTdHJpbmcgbV9pbnB1dFVybDsK 183755 2013-01-21 03:51:55 -0800 2013-01-21 04:08:52 -0800 Patch bug-107437-20130121171946.patch text/plain 4004 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJkMGI4MTZlMjMyNjQ3YjlmMTc1MDhhNzNhZTRkM2Q4 N2VkZDhjOC4uZjNjNTAxZTNiMTg4ZjRiM2E4NjRmMTQ4ZTU4MDc3NzhjOGQxZWJkMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTAxLTIxICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgor CisgICAgICAgIFF0VGVzdEJyb3dzZXIgc2hvdWxkIHByb3ZpZGUgd2F5IHRvIGNsZWFyIHNlbGVj dGVkIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDc0MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQcm92aWRlIGEgd2F5IHRvICJDbGVhciBzZWxlY3Rpb24iIGluIHRoZSAiRGV2ZWxvcCIg bWVudSB0byBjbGVhciB0aGUgcHJldmlvdXMgc2VhcmNoIGhpZ2hsaWdodC4KKyAgICAgICAgSW52 b2tlIHRoZSBjbGVhclNlbGVjdGlvbiBwcmlvciB0byBoaWdobGlnaHRpbmcgbmV3IGVsZW1lbnRz LgorCisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHA6CisgICAgICAg IChFbGVtZW50SGlnaGxpZ2h0KToKKyAgICAgICAgKExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJv bWUpOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OnNlbGVjdEVsZW1lbnRzKToKKyAgICAgICAg KExhdW5jaGVyV2luZG93OjpjbGVhclNlbGVjdGlvbik6CisgICAgICAgICogUXRUZXN0QnJvd3Nl ci9sYXVuY2hlcndpbmRvdy5oOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3cpOgorCiAyMDEzLTAx LTE3ICBGcmFuayBGYXJ6YW4gIDxmcmFua2ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZsYWtp bmVzcyBkYXNoYm9hcmQ6IEFkZCBDaHJvbWl1bUZZSSBtYXN0ZXIKZGlmZiAtLWdpdCBhL1Rvb2xz L1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9s YXVuY2hlcndpbmRvdy5jcHAKaW5kZXggY2EwMDg5MjYyZDM0OTAwMTRmODg5MGM1NTRmZGZkOTM2 MmUwYTk4YS4uNjhiYTU2N2MzYWIxZDU5MzA5MGJkOTVhZDVjYmE4NDkzMDdkZmU1NCAxMDA2NDQK LS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKKysrIGIvVG9vbHMv UXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKQEAgLTczLDYgKzczLDExIEBACiAjaW5j bHVkZSA8UXROZXR3b3JrL1FOZXR3b3JrRGlza0NhY2hlPgogI2VuZGlmCiAKK3N0cnVjdCBFbGVt ZW50SGlnaGxpZ2h0IHsKKyAgICBRV2ViRWxlbWVudCBtX2VsZW1lbnQ7CisgICAgUVN0cmluZyBt X3N0eWxlVmFsdWU7Cit9OworCiBjb25zdCBpbnQgZ0V4aXRDbGlja0FyZWEgPSA4MDsKIFFWZWN0 b3I8aW50PiBMYXVuY2hlcldpbmRvdzo6bV96b29tTGV2ZWxzOwogCkBAIC0zNjIsNiArMzY3LDgg QEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKCkKIAogICAgIHRvb2xzTWVudS0+ YWRkQWN0aW9uKCJTZWxlY3QgRWxlbWVudHMuLi4iLCB0aGlzLCBTTE9UKHNlbGVjdEVsZW1lbnRz KCkpKTsKIAorICAgIHRvb2xzTWVudS0+YWRkQWN0aW9uKCJDbGVhciBzZWxlY3Rpb24iLCB0aGlz LCBTTE9UKGNsZWFyU2VsZWN0aW9uKCkpKTsKKwogICAgIFFBY3Rpb24qIHNob3dJbnNwZWN0b3JB Y3Rpb24gPSB0b29sc01lbnUtPmFkZEFjdGlvbigiU2hvdyBXZWIgSW5zcGVjdG9yIiwgbV9pbnNw ZWN0b3IsIFNMT1Qoc2V0VmlzaWJsZShib29sKSksIFFLZXlTZXF1ZW5jZShRdDo6Q1RSTCB8IFF0 OjpBTFQgfCBRdDo6S2V5X0kpKTsKICAgICBzaG93SW5zcGVjdG9yQWN0aW9uLT5zZXRDaGVja2Fi bGUodHJ1ZSk7CiAgICAgc2hvd0luc3BlY3RvckFjdGlvbi0+Y29ubmVjdChtX2luc3BlY3Rvciwg U0lHTkFMKHZpc2libGVDaGFuZ2VkKGJvb2wpKSwgU0xPVChzZXRDaGVja2VkKGJvb2wpKSk7CkBA IC04MTIsMTQgKzgxOSwyNCBAQCB2b2lkIExhdW5jaGVyV2luZG93OjpzZWxlY3RFbGVtZW50cygp CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUUxpbmVFZGl0OjpOb3Jt YWwsICJhIiwgJm9rKTsKIAogICAgIGlmIChvayAmJiAhc3RyLmlzRW1wdHkoKSkgeworICAgICAg ICBjbGVhclNlbGVjdGlvbigpOwogICAgICAgICBRV2ViRWxlbWVudENvbGxlY3Rpb24gcmVzdWx0 ID0gIHBhZ2UoKS0+bWFpbkZyYW1lKCktPmZpbmRBbGxFbGVtZW50cyhzdHIpOwotICAgICAgICBm b3JlYWNoIChRV2ViRWxlbWVudCBlLCByZXN1bHQpCisgICAgICAgIGZvcmVhY2ggKFFXZWJFbGVt ZW50IGUsIHJlc3VsdCkgeworICAgICAgICAgICAgRWxlbWVudEhpZ2hsaWdodCBlbCA9IHtlLCBl LnN0eWxlUHJvcGVydHkoImJhY2tncm91bmQtY29sb3IiLCBRV2ViRWxlbWVudDo6SW5saW5lU3R5 bGUpfTsKKyAgICAgICAgICAgIG1fcHJldmlvdXNIaWdobGlnaHRFbGVtZW50cy5hcHBlbmQoZWwp OwogICAgICAgICAgICAgZS5zZXRTdHlsZVByb3BlcnR5KCJiYWNrZ3JvdW5kLWNvbG9yIiwgInll bGxvdyIpOworICAgICAgICB9CiAgICAgICAgIHN0YXR1c0JhcigpLT5zaG93TWVzc2FnZShRU3Ry aW5nKCIlMSBlbGVtZW50KHMpIHNlbGVjdGVkIikuYXJnKHJlc3VsdC5jb3VudCgpKSwgNTAwMCk7 CiAgICAgfQogI2VuZGlmCiB9CiAKK3ZvaWQgTGF1bmNoZXJXaW5kb3c6OmNsZWFyU2VsZWN0aW9u KCkKK3sKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IG1fcHJldmlvdXNIaWdobGlnaHRFbGVtZW50 cy5zaXplKCk7ICsraSkKKyAgICAgICAgbV9wcmV2aW91c0hpZ2hsaWdodEVsZW1lbnRzW2ldLm1f ZWxlbWVudC5zZXRTdHlsZVByb3BlcnR5KCJiYWNrZ3JvdW5kLWNvbG9yIiwgbV9wcmV2aW91c0hp Z2hsaWdodEVsZW1lbnRzW2ldLm1fc3R5bGVWYWx1ZSk7Cit9CisKIHZvaWQgTGF1bmNoZXJXaW5k b3c6OnNldERpc2tDYWNoZShib29sIGVuYWJsZSkKIHsKICNpZiAhZGVmaW5lZChRVF9OT19ORVRX T1JLRElTS0NBQ0hFKSAmJiAhZGVmaW5lZChRVF9OT19ERVNLVE9QU0VSVklDRVMpCmRpZmYgLS1n aXQgYS9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmggYi9Ub29scy9RdFRlc3RC cm93c2VyL2xhdW5jaGVyd2luZG93LmgKaW5kZXggYjRkNDRmZTNiNzY1NmI2NjM1OTk5YzBjOGY2 OGZiNDQ0ODNlNjZiYS4uYzVhYTExOTIwZGU2NzA3M2MyNWRmOGQ3MDQ0YzM2M2U5Nzg2ODg1MiAx MDA2NDQKLS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCisrKyBiL1Rv b2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaApAQCAtNjAsNiArNjAsOCBAQCBjbGFz cyBRUHJvcGVydHlBbmltYXRpb247CiBjbGFzcyBRTGluZUVkaXQ7CiBRVF9FTkRfTkFNRVNQQUNF CiAKK3N0cnVjdCBFbGVtZW50SGlnaGxpZ2h0OworCiBjbGFzcyBXaW5kb3dPcHRpb25zIHsKIHB1 YmxpYzoKICAgICBXaW5kb3dPcHRpb25zKCkKQEAgLTE4MSw2ICsxODMsNyBAQCBwcm90ZWN0ZWQg UV9TTE9UUzoKICAgICB2b2lkIGFuaW1hdGVkRmxpcCgpOwogICAgIHZvaWQgYW5pbWF0ZWRZRmxp cCgpOwogICAgIHZvaWQgc2VsZWN0RWxlbWVudHMoKTsKKyAgICB2b2lkIGNsZWFyU2VsZWN0aW9u KCk7CiAgICAgdm9pZCBzaG93RlBTKGJvb2wgZW5hYmxlKTsKICAgICB2b2lkIHNob3dVc2VyQWdl bnREaWFsb2coKTsKIApAQCAtMjI1LDYgKzIyOCw3IEBAIHByaXZhdGU6CiAgICAgUU5ldHdvcmtS ZXBseSogbV9yZXBseTsKICNlbmRpZgogICAgIFFMaXN0PFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50 PiBtX3RvdWNoUG9pbnRzOworICAgIFFMaXN0PEVsZW1lbnRIaWdobGlnaHQ+IG1fcHJldmlvdXNI aWdobGlnaHRFbGVtZW50czsKICAgICBib29sIG1fdG91Y2hNb2NraW5nOwogCiAgICAgUVN0cmlu ZyBtX2lucHV0VXJsOwo= 183758 2013-01-21 04:06:00 -0800 2013-01-21 04:46:51 -0800 Patch bug-107437-20130121173350.patch text/plain 4026 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJkMGI4MTZlMjMyNjQ3YjlmMTc1MDhhNzNhZTRkM2Q4 N2VkZDhjOC4uZjNjNTAxZTNiMTg4ZjRiM2E4NjRmMTQ4ZTU4MDc3NzhjOGQxZWJkMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTAxLTIxICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgor CisgICAgICAgIFF0VGVzdEJyb3dzZXIgc2hvdWxkIHByb3ZpZGUgd2F5IHRvIGNsZWFyIHNlbGVj dGVkIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDc0MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQcm92aWRlIGEgd2F5IHRvICJDbGVhciBzZWxlY3Rpb24iIGluIHRoZSAiRGV2ZWxvcCIg bWVudSB0byBjbGVhciB0aGUgcHJldmlvdXMgc2VhcmNoIGhpZ2hsaWdodC4KKyAgICAgICAgSW52 b2tlIHRoZSBjbGVhclNlbGVjdGlvbiBwcmlvciB0byBoaWdobGlnaHRpbmcgbmV3IGVsZW1lbnRz LgorCisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHA6CisgICAgICAg IChFbGVtZW50SGlnaGxpZ2h0KToKKyAgICAgICAgKExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJv bWUpOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OnNlbGVjdEVsZW1lbnRzKToKKyAgICAgICAg KExhdW5jaGVyV2luZG93OjpjbGVhclNlbGVjdGlvbik6CisgICAgICAgICogUXRUZXN0QnJvd3Nl ci9sYXVuY2hlcndpbmRvdy5oOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3cpOgorCiAyMDEzLTAx LTE3ICBGcmFuayBGYXJ6YW4gIDxmcmFua2ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZsYWtp bmVzcyBkYXNoYm9hcmQ6IEFkZCBDaHJvbWl1bUZZSSBtYXN0ZXIKZGlmZiAtLWdpdCBhL1Rvb2xz L1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9s YXVuY2hlcndpbmRvdy5jcHAKaW5kZXggY2EwMDg5MjYyZDM0OTAwMTRmODg5MGM1NTRmZGZkOTM2 MmUwYTk4YS4uODU1MTkwYjc4MTY4NzU4YTkxODJjMzdjMjlmMmE1YzgwMGIxYmRkNSAxMDA2NDQK LS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKKysrIGIvVG9vbHMv UXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKQEAgLTczLDYgKzczLDExIEBACiAjaW5j bHVkZSA8UXROZXR3b3JrL1FOZXR3b3JrRGlza0NhY2hlPgogI2VuZGlmCiAKK3N0cnVjdCBIaWdo bGlnaHRlZEVsZW1lbnQgeworICAgIFFXZWJFbGVtZW50IG1fZWxlbWVudDsKKyAgICBRU3RyaW5n IG1fcHJldmlvdXNTdHlsZTsKK307CisKIGNvbnN0IGludCBnRXhpdENsaWNrQXJlYSA9IDgwOwog UVZlY3RvcjxpbnQ+IExhdW5jaGVyV2luZG93OjptX3pvb21MZXZlbHM7CiAKQEAgLTM2Miw2ICsz NjcsOCBAQCB2b2lkIExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUoKQogCiAgICAgdG9vbHNN ZW51LT5hZGRBY3Rpb24oIlNlbGVjdCBFbGVtZW50cy4uLiIsIHRoaXMsIFNMT1Qoc2VsZWN0RWxl bWVudHMoKSkpOwogCisgICAgdG9vbHNNZW51LT5hZGRBY3Rpb24oIkNsZWFyIHNlbGVjdGlvbiIs IHRoaXMsIFNMT1QoY2xlYXJTZWxlY3Rpb24oKSkpOworCiAgICAgUUFjdGlvbiogc2hvd0luc3Bl Y3RvckFjdGlvbiA9IHRvb2xzTWVudS0+YWRkQWN0aW9uKCJTaG93IFdlYiBJbnNwZWN0b3IiLCBt X2luc3BlY3RvciwgU0xPVChzZXRWaXNpYmxlKGJvb2wpKSwgUUtleVNlcXVlbmNlKFF0OjpDVFJM IHwgUXQ6OkFMVCB8IFF0OjpLZXlfSSkpOwogICAgIHNob3dJbnNwZWN0b3JBY3Rpb24tPnNldENo ZWNrYWJsZSh0cnVlKTsKICAgICBzaG93SW5zcGVjdG9yQWN0aW9uLT5jb25uZWN0KG1faW5zcGVj dG9yLCBTSUdOQUwodmlzaWJsZUNoYW5nZWQoYm9vbCkpLCBTTE9UKHNldENoZWNrZWQoYm9vbCkp KTsKQEAgLTgxMiwxNCArODE5LDI1IEBAIHZvaWQgTGF1bmNoZXJXaW5kb3c6OnNlbGVjdEVsZW1l bnRzKCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBRTGluZUVkaXQ6 Ok5vcm1hbCwgImEiLCAmb2spOwogCiAgICAgaWYgKG9rICYmICFzdHIuaXNFbXB0eSgpKSB7Cisg ICAgICAgIGNsZWFyU2VsZWN0aW9uKCk7CiAgICAgICAgIFFXZWJFbGVtZW50Q29sbGVjdGlvbiBy ZXN1bHQgPSAgcGFnZSgpLT5tYWluRnJhbWUoKS0+ZmluZEFsbEVsZW1lbnRzKHN0cik7Ci0gICAg ICAgIGZvcmVhY2ggKFFXZWJFbGVtZW50IGUsIHJlc3VsdCkKKyAgICAgICAgZm9yZWFjaCAoUVdl YkVsZW1lbnQgZSwgcmVzdWx0KSB7CisgICAgICAgICAgICBIaWdobGlnaHRlZEVsZW1lbnQgZWwg PSB7IGUsIGUuc3R5bGVQcm9wZXJ0eSgiYmFja2dyb3VuZC1jb2xvciIsIFFXZWJFbGVtZW50OjpJ bmxpbmVTdHlsZSkgfTsKKyAgICAgICAgICAgIG1faGlnaGxpZ2h0ZWRFbGVtZW50cy5hcHBlbmQo ZWwpOwogICAgICAgICAgICAgZS5zZXRTdHlsZVByb3BlcnR5KCJiYWNrZ3JvdW5kLWNvbG9yIiwg InllbGxvdyIpOworICAgICAgICB9CiAgICAgICAgIHN0YXR1c0JhcigpLT5zaG93TWVzc2FnZShR U3RyaW5nKCIlMSBlbGVtZW50KHMpIHNlbGVjdGVkIikuYXJnKHJlc3VsdC5jb3VudCgpKSwgNTAw MCk7CiAgICAgfQogI2VuZGlmCiB9CiAKK3ZvaWQgTGF1bmNoZXJXaW5kb3c6OmNsZWFyU2VsZWN0 aW9uKCkKK3sKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IG1faGlnaGxpZ2h0ZWRFbGVtZW50cy5z aXplKCk7ICsraSkKKyAgICAgICAgbV9oaWdobGlnaHRlZEVsZW1lbnRzW2ldLm1fZWxlbWVudC5z ZXRTdHlsZVByb3BlcnR5KCJiYWNrZ3JvdW5kLWNvbG9yIiwgbV9oaWdobGlnaHRlZEVsZW1lbnRz W2ldLm1fcHJldmlvdXNTdHlsZSk7CisgICAgbV9oaWdobGlnaHRlZEVsZW1lbnRzLmNsZWFyKCk7 Cit9CisKIHZvaWQgTGF1bmNoZXJXaW5kb3c6OnNldERpc2tDYWNoZShib29sIGVuYWJsZSkKIHsK ICNpZiAhZGVmaW5lZChRVF9OT19ORVRXT1JLRElTS0NBQ0hFKSAmJiAhZGVmaW5lZChRVF9OT19E RVNLVE9QU0VSVklDRVMpCmRpZmYgLS1naXQgYS9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVy d2luZG93LmggYi9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgKaW5kZXggYjRk NDRmZTNiNzY1NmI2NjM1OTk5YzBjOGY2OGZiNDQ0ODNlNjZiYS4uZmIzMTM3ZGFjZmZjNzdlODcw NDc4ODFhMmE5N2ViOGMxZTU2ZjRhYiAxMDA2NDQKLS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9s YXVuY2hlcndpbmRvdy5oCisrKyBiL1Rvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cu aApAQCAtNjAsNiArNjAsOCBAQCBjbGFzcyBRUHJvcGVydHlBbmltYXRpb247CiBjbGFzcyBRTGlu ZUVkaXQ7CiBRVF9FTkRfTkFNRVNQQUNFCiAKK3N0cnVjdCBIaWdobGlnaHRlZEVsZW1lbnQ7CisK IGNsYXNzIFdpbmRvd09wdGlvbnMgewogcHVibGljOgogICAgIFdpbmRvd09wdGlvbnMoKQpAQCAt MTgxLDYgKzE4Myw3IEBAIHByb3RlY3RlZCBRX1NMT1RTOgogICAgIHZvaWQgYW5pbWF0ZWRGbGlw KCk7CiAgICAgdm9pZCBhbmltYXRlZFlGbGlwKCk7CiAgICAgdm9pZCBzZWxlY3RFbGVtZW50cygp OworICAgIHZvaWQgY2xlYXJTZWxlY3Rpb24oKTsKICAgICB2b2lkIHNob3dGUFMoYm9vbCBlbmFi bGUpOwogICAgIHZvaWQgc2hvd1VzZXJBZ2VudERpYWxvZygpOwogCkBAIC0yMjUsNiArMjI4LDcg QEAgcHJpdmF0ZToKICAgICBRTmV0d29ya1JlcGx5KiBtX3JlcGx5OwogI2VuZGlmCiAgICAgUUxp c3Q8UVRvdWNoRXZlbnQ6OlRvdWNoUG9pbnQ+IG1fdG91Y2hQb2ludHM7CisgICAgUUxpc3Q8SGln aGxpZ2h0ZWRFbGVtZW50PiBtX2hpZ2hsaWdodGVkRWxlbWVudHM7CiAgICAgYm9vbCBtX3RvdWNo TW9ja2luZzsKIAogICAgIFFTdHJpbmcgbV9pbnB1dFVybDsK