107432 2013-01-21 02:01:04 -0800 [Soup] Use synchronous calls to close completely processed streams 2013-02-19 07:17:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107439 1 svillar svillar danw gustavo mrobinson rakuco s.choi svillar webkit.review.bot oldest_to_newest 811948 0 svillar 2013-01-21 02:01:04 -0800 [Soup] Use synchronous calls to close completely processed streams 811953 1 183739 svillar 2013-01-21 02:10:10 -0800 Created attachment 183739 Patch 812046 2 svillar 2013-01-21 05:09:10 -0800 We might even think about removing the close() completely as streams are automatically closed once their last reference is dropped... 812165 3 183739 mrobinson 2013-01-21 08:09:32 -0800 Comment on attachment 183739 Patch Great! Might be good to get Dan to look at this one too. 812167 4 danw 2013-01-21 08:10:33 -0800 (In reply to comment #2) > We might even think about removing the close() completely as streams are automatically closed once their last reference is dropped... I wouldn't recommend that, because if something was holding a ref on the stream for a while for some reason after we were done reading, that would prevent the connection from being reused for another request. 812191 5 svillar 2013-01-21 08:27:48 -0800 (In reply to comment #3) > (From update of attachment 183739 [details]) > Great! Might be good to get Dan to look at this one too. Cool, I'll wait until we have a clear idea about what triggers the crashes I'm seeing in bug 107439 tough. 812192 6 183739 svillar 2013-01-21 08:28:26 -0800 Comment on attachment 183739 Patch Do not land this automatically, just in case. 836365 7 svillar 2013-02-19 07:17:52 -0800 Committed r143329: <http://trac.webkit.org/changeset/143329> 183739 2013-01-21 02:10:10 -0800 2013-01-21 08:28:25 -0800 Patch bug-107432-20130121110705.patch text/plain 4856 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MxMWM2MTZkYjVmNjU2 NmEwZjkxMTgwOWJmNjY3NjRmYWYyZmJlZC4uNWZjYTE4NmMxYWRmMjY1N2M1NDg4MGE4ZDlkZWNl NzUwM2U2NGYzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTIxICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtTb3VwXSBV c2Ugc3luY2hyb25vdXMgY2FsbHMgdG8gY2xvc2UgY29tcGxldGVseSBwcm9jZXNzZWQgc3RyZWFt cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDMy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUg aXMgbm8gbmVlZCB0byBjbG9zZSBhbHJlYWR5IHByb2Nlc3NlZCBzdHJlYW1zIGluIGFzeW5jaHJv bm91cworICAgICAgICBjYWxscyBzaW5jZSB0aGV5IHdvbid0IGJsb2NrLiBVc2luZyB0aGUgc3lu Y2hyb25vdXMgY2FsbCB3aWxsIHNhdmUKKyAgICAgICAgdXMgc29tZSBjb2RlIGFuZCB1bm5lY2Vz c2FyeSBhc3luY2hyb25vdXMgYnVyZGVuLiBUaGlzIGlzIGtpbmQgb2YKKyAgICAgICAgYSBjb2Rl IHJlZmFjdG9yIHNvIG5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgor ICAgICAgICAoV2ViQ29yZTo6cmVkaXJlY3RTa2lwQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29y ZTo6cmVhZENhbGxiYWNrKToKKwogMjAxMy0wMS0xOSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2Vr QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgYnVpbGQgZml4LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxl U291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VI YW5kbGVTb3VwLmNwcAppbmRleCBhNjRhNDMwOGM3NDI0YzFkNjU5NjA4ODMwZjViZDJjMmMzNWE2 NTM3Li42OGUyZWVlNTE4ZGI0Y2RlZTEwZWNmYWM1MTY1NzVhMmNkYWE5YmU1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3Vw LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VI YW5kbGVTb3VwLmNwcApAQCAtMjI2LDcgKzIyNiw2IEBAIHN0YXRpYyBib29sIGNyZWF0ZVNvdXBS ZXF1ZXN0QW5kTWVzc2FnZUZvckhhbmRsZShSZXNvdXJjZUhhbmRsZSosIGNvbnN0IFJlc291cmNl CiBzdGF0aWMgdm9pZCBjbGVhbnVwU291cFJlcXVlc3RPcGVyYXRpb24oUmVzb3VyY2VIYW5kbGUq LCBib29sIGlzRGVzdHJveWluZyA9IGZhbHNlKTsKIHN0YXRpYyB2b2lkIHNlbmRSZXF1ZXN0Q2Fs bGJhY2soR09iamVjdCosIEdBc3luY1Jlc3VsdCosIGdwb2ludGVyKTsKIHN0YXRpYyB2b2lkIHJl YWRDYWxsYmFjayhHT2JqZWN0KiwgR0FzeW5jUmVzdWx0KiwgZ3BvaW50ZXIpOwotc3RhdGljIHZv aWQgY2xvc2VDYWxsYmFjayhHT2JqZWN0KiwgR0FzeW5jUmVzdWx0KiwgZ3BvaW50ZXIpOwogc3Rh dGljIGdib29sZWFuIHJlcXVlc3RUaW1lb3V0Q2FsbGJhY2sodm9pZCopOwogI2lmIEVOQUJMRShX RUJfVElNSU5HKQogc3RhdGljIGludCAgbWlsaXNlY29uZHNTaW5jZVJlcXVlc3QoZG91YmxlIHJl cXVlc3RUaW1lKTsKQEAgLTQ4NiwyMCArNDg1LDYgQEAgc3RhdGljIHZvaWQgZG9SZWRpcmVjdChS ZXNvdXJjZUhhbmRsZSogaGFuZGxlKQogICAgIGhhbmRsZS0+c2VuZFBlbmRpbmdSZXF1ZXN0KCk7 CiB9CiAKLXN0YXRpYyB2b2lkIHJlZGlyZWN0Q2xvc2VDYWxsYmFjayhHT2JqZWN0KiwgR0FzeW5j UmVzdWx0KiByZXN1bHQsIGdwb2ludGVyIGRhdGEpCi17Ci0gICAgUmVmUHRyPFJlc291cmNlSGFu ZGxlPiBoYW5kbGUgPSBzdGF0aWNfY2FzdDxSZXNvdXJjZUhhbmRsZSo+KGRhdGEpOwotICAgIFJl c291cmNlSGFuZGxlSW50ZXJuYWwqIGQgPSBoYW5kbGUtPmdldEludGVybmFsKCk7Ci0KLSAgICBp ZiAoZC0+bV9jYW5jZWxsZWQgfHwgIWhhbmRsZS0+Y2xpZW50KCkpIHsKLSAgICAgICAgY2xlYW51 cFNvdXBSZXF1ZXN0T3BlcmF0aW9uKGhhbmRsZS5nZXQoKSk7Ci0gICAgICAgIHJldHVybjsKLSAg ICB9Ci0KLSAgICBnX2lucHV0X3N0cmVhbV9jbG9zZV9maW5pc2goZC0+bV9pbnB1dFN0cmVhbS5n ZXQoKSwgcmVzdWx0LCAwKTsKLSAgICBkb1JlZGlyZWN0KGhhbmRsZS5nZXQoKSk7Ci19Ci0KIHN0 YXRpYyB2b2lkIHJlZGlyZWN0U2tpcENhbGxiYWNrKEdPYmplY3QqLCBHQXN5bmNSZXN1bHQqIGFz eW5jUmVzdWx0LCBncG9pbnRlciBkYXRhKQogewogICAgIFJlZlB0cjxSZXNvdXJjZUhhbmRsZT4g aGFuZGxlID0gc3RhdGljX2Nhc3Q8UmVzb3VyY2VIYW5kbGUqPihkYXRhKTsKQEAgLTUyNiw3ICs1 MTEsOCBAQCBzdGF0aWMgdm9pZCByZWRpcmVjdFNraXBDYWxsYmFjayhHT2JqZWN0KiwgR0FzeW5j UmVzdWx0KiBhc3luY1Jlc3VsdCwgZ3BvaW50ZXIgZAogICAgICAgICByZXR1cm47CiAgICAgfQog Ci0gICAgZ19pbnB1dF9zdHJlYW1fY2xvc2VfYXN5bmMoZC0+bV9pbnB1dFN0cmVhbS5nZXQoKSwg R19QUklPUklUWV9ERUZBVUxULCAwLCByZWRpcmVjdENsb3NlQ2FsbGJhY2ssIGhhbmRsZS5nZXQo KSk7CisgICAgZ19pbnB1dF9zdHJlYW1fY2xvc2UoZC0+bV9pbnB1dFN0cmVhbS5nZXQoKSwgMCwg MCk7CisgICAgZG9SZWRpcmVjdChoYW5kbGUuZ2V0KCkpOwogfQogCiBzdGF0aWMgdm9pZCB3cm90 ZUJvZHlEYXRhQ2FsbGJhY2soU291cE1lc3NhZ2UqLCBTb3VwQnVmZmVyKiBidWZmZXIsIGdwb2lu dGVyIGRhdGEpCkBAIC0xMjk4LDIwICsxMjg0LDYgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6bG9h ZFJlc291cmNlU3luY2hyb25vdXNseShOZXR3b3JraW5nQ29udGV4dCogY29udGV4dCwgY29uc3QK ICAgICBzeW5jTG9hZGVyLnJ1bigpOwogfQogCi1zdGF0aWMgdm9pZCBjbG9zZUNhbGxiYWNrKEdP YmplY3QqLCBHQXN5bmNSZXN1bHQqIHJlcywgZ3BvaW50ZXIgZGF0YSkKLXsKLSAgICBSZWZQdHI8 UmVzb3VyY2VIYW5kbGU+IGhhbmRsZSA9IHN0YXRpY19jYXN0PFJlc291cmNlSGFuZGxlKj4oZGF0 YSk7Ci0gICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCogZCA9IGhhbmRsZS0+Z2V0SW50ZXJuYWwo KTsKLQotICAgIGdfaW5wdXRfc3RyZWFtX2Nsb3NlX2ZpbmlzaChkLT5tX2lucHV0U3RyZWFtLmdl dCgpLCByZXMsIDApOwotCi0gICAgUmVzb3VyY2VIYW5kbGVDbGllbnQqIGNsaWVudCA9IGhhbmRs ZS0+Y2xpZW50KCk7Ci0gICAgaWYgKGNsaWVudCAmJiBsb2FkaW5nU3luY2hyb25vdXNSZXF1ZXN0 KQotICAgICAgICBjbGllbnQtPmRpZEZpbmlzaExvYWRpbmcoaGFuZGxlLmdldCgpLCAwKTsKLQot ICAgIGNsZWFudXBTb3VwUmVxdWVzdE9wZXJhdGlvbihoYW5kbGUuZ2V0KCkpOwotfQotCiBzdGF0 aWMgdm9pZCByZWFkQ2FsbGJhY2soR09iamVjdCosIEdBc3luY1Jlc3VsdCogYXN5bmNSZXN1bHQs IGdwb2ludGVyIGRhdGEpCiB7CiAgICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5kbGUgPSBz dGF0aWNfY2FzdDxSZXNvdXJjZUhhbmRsZSo+KGRhdGEpOwpAQCAtMTM0NiwxNiArMTMxOCwxMCBA QCBzdGF0aWMgdm9pZCByZWFkQ2FsbGJhY2soR09iamVjdCosIEdBc3luY1Jlc3VsdCogYXN5bmNS ZXN1bHQsIGdwb2ludGVyIGRhdGEpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAot ICAgICAgICAvLyBXZSBpbmZvcm0gV2ViQ29yZSBvZiBsb2FkIGNvbXBsZXRpb24gbm93IGluc3Rl YWQgb2Ygd2FpdGluZyBmb3IgdGhlIGlucHV0Ci0gICAgICAgIC8vIHN0cmVhbSB0byBjbG9zZSBi ZWNhdXNlIHRoZSBpbnB1dCBzdHJlYW0gaXMgY2xvc2VkIGFzeW5jaHJvbm91c2x5LiBJZiB0aGlz Ci0gICAgICAgIC8vIGlzIGEgc3luY2hyb25vdXMgcmVxdWVzdCwgd2Ugd2FpdCB1bnRpbCB0aGUg Y2xvc2VDYWxsYmFjaywgYmVjYXVzZSB3ZSBkb24ndAotICAgICAgICAvLyB3YW50IHRvIGhhbHQg dGhlIGludGVybmFsIG1haW4gbG9vcCBiZWZvcmUgdGhlIGlucHV0IHN0cmVhbSBjbG9zZXMuCi0g ICAgICAgIGlmIChjbGllbnQgJiYgIWxvYWRpbmdTeW5jaHJvbm91c1JlcXVlc3QpIHsKLSAgICAg ICAgICAgIGNsaWVudC0+ZGlkRmluaXNoTG9hZGluZyhoYW5kbGUuZ2V0KCksIDApOwotICAgICAg ICAgICAgaGFuZGxlLT5zZXRDbGllbnQoMCk7IC8vIFVuc2V0IHRoZSBjbGllbnQgc28gdGhhdCB3 ZSBkbyBub3QgdHJ5IHRvIGFjY2VzcyB0aAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC8vIGNsaWVudCBpbiB0aGUgY2xvc2VDYWxsYmFjay4KLSAgICAgICAgfQotICAgICAgICBn X2lucHV0X3N0cmVhbV9jbG9zZV9hc3luYyhkLT5tX2lucHV0U3RyZWFtLmdldCgpLCBHX1BSSU9S SVRZX0RFRkFVTFQsIDAsIGNsb3NlQ2FsbGJhY2ssIGhhbmRsZS5nZXQoKSk7CisgICAgICAgIGdf aW5wdXRfc3RyZWFtX2Nsb3NlKGQtPm1faW5wdXRTdHJlYW0uZ2V0KCksIDAsIDApOworCisgICAg ICAgIGNsaWVudC0+ZGlkRmluaXNoTG9hZGluZyhoYW5kbGUuZ2V0KCksIDApOworICAgICAgICBj bGVhbnVwU291cFJlcXVlc3RPcGVyYXRpb24oaGFuZGxlLmdldCgpKTsKICAgICAgICAgcmV0dXJu OwogICAgIH0KIAo=