107402 2013-01-20 12:07:42 -0800 Avoid filling a rounded rect when radii are zero 2013-01-20 12:38:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser eric ojan.autocc pdr sam schenney simon.fraser thorton webkit.review.bot oldest_to_newest 811647 0 simon.fraser 2013-01-20 12:07:42 -0800 Avoid filling a rounded rect when radii are zero 811648 1 183679 simon.fraser 2013-01-20 12:09:03 -0800 Created attachment 183679 Patch 811651 2 sam 2013-01-20 12:19:27 -0800 You might want to consider just putting this logic in GraphicsContext::fillRoundedRect. 811654 3 183680 simon.fraser 2013-01-20 12:33:11 -0800 Created attachment 183680 Patch 811656 4 simon.fraser 2013-01-20 12:38:37 -0800 http://trac.webkit.org/changeset/140279 183679 2013-01-20 12:09:03 -0800 2013-01-20 12:33:08 -0800 Patch bug-107402-20130120120600.patch text/plain 1979 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVhYzZmNWNhMjQ5YWY1 NTU5Y2Y1ZjU0YTkwNWNjMWU4NGMzNWU0OS4uYjVkZWE2YzFlOWJmZGQwZjlkNjFkNmVjMzk5OTY3 NWNkM2NlYWEzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGZpbGxp bmcgYSByb3VuZGVkIHJlY3Qgd2hlbiByYWRpaSBhcmUgemVybworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDAyCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8xMjc5MzMxNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJdCdzIG1vcmUgZWZmaWNpZW50IHRvIHBhaW50IGEgc2hhZG93IGFyb3VuZCBhIHJl Y3QgdGhhbiBhIHJvdW5kZWQgcmVjdCwKKyAgICAgICAgc28gaWYgYWRqdXN0aW5nIGZvciBzaGFk b3cgc3ByZWFkICh3aGljaCBtYXkgYmUgbmVnYXRpdmUpIHJlc3VsdHMgaW4KKyAgICAgICAgYSBu b24tcm91bmRlZCByZWN0YW5nbGUsIGp1c3QgdXNlIGZpbGxSZWN0KCkuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyQm94TW9kZWxPYmplY3Q6OnBhaW50Qm94U2hhZG93KToKKwogMjAxMy0wMS0yMCAgUGV0ZXIg UnliaW4gIDxwZXRlci5yeWJpbkBnbWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog TWFrZSBWOCBMaXZlRWRpdCBBUEkgZGlzYWJsZWQgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKaW5kZXggOWU2ZjFjNjZj NjQyNjY2MGVmYWY0OWNmYjNjMTMxZjg0MDVlNDk3Mi4uNmI4OGFhYzhjOWY1ZGQxNWE0Zjc0ODdh YjVhNTA0ODlmMTkzNThiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJveE1vZGVsT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQm94TW9kZWxPYmplY3QuY3BwCkBAIC0yNjE1LDcgKzI2MTUsMTAgQEAgdm9pZCBSZW5kZXJC b3hNb2RlbE9iamVjdDo6cGFpbnRCb3hTaGFkb3coY29uc3QgUGFpbnRJbmZvJiBpbmZvLCBjb25z dCBMYXlvdXRSZWMKICAgICAgICAgICAgICAgICAgICAgZmlsbFJlY3QuZXhwYW5kUmFkaWkoc2hh ZG93U3ByZWFkKTsKICAgICAgICAgICAgICAgICAgICAgaWYgKCFmaWxsUmVjdC5pc1JlbmRlcmFi bGUoKSkKICAgICAgICAgICAgICAgICAgICAgICAgIGZpbGxSZWN0LmFkanVzdFJhZGlpKCk7Ci0g ICAgICAgICAgICAgICAgICAgIGNvbnRleHQtPmZpbGxSb3VuZGVkUmVjdChmaWxsUmVjdCwgQ29s b3I6OmJsYWNrLCBzLT5jb2xvclNwYWNlKCkpOworICAgICAgICAgICAgICAgICAgICBpZiAoZmls bFJlY3QuaXNSb3VuZGVkKCkpCisgICAgICAgICAgICAgICAgICAgICAgICBjb250ZXh0LT5maWxs Um91bmRlZFJlY3QoZmlsbFJlY3QsIENvbG9yOjpibGFjaywgcy0+Y29sb3JTcGFjZSgpKTsKKyAg ICAgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICAgICAgY29udGV4dC0+ ZmlsbFJlY3QoZmlsbFJlY3QucmVjdCgpLCBDb2xvcjo6YmxhY2ssIHMtPmNvbG9yU3BhY2UoKSk7 CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAg ICBJbnRSZWN0IHJlY3RUb0NsaXBPdXQgPSBib3JkZXIucmVjdCgpOwo= 183680 2013-01-20 12:33:11 -0800 2013-01-20 12:35:35 -0800 Patch bug-107402-20130120123007.patch text/plain 2536 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVhYzZmNWNhMjQ5YWY1 NTU5Y2Y1ZjU0YTkwNWNjMWU4NGMzNWU0OS4uZTNhNTJlOWJiYmE2NjBiNDJlZmQyZWZjNmU3YzVi Y2IyMDczYmE0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGZpbGxp bmcgYSByb3VuZGVkIHJlY3Qgd2hlbiByYWRpaSBhcmUgemVybworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NDAyCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8xMjc5MzMxNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJdCdzIG1vcmUgZWZmaWNpZW50IHRvIGNsaXAgYW5kIGZpbGwgcmVjdHMgdGhhbiBy b3VuZGVkIHJlY3RzLAorICAgICAgICBzbyBvcHRpbWl6ZSBmb3IgdGhlIGNhc2Ugd2hlcmUgcm91 bmRlZCByZWN0IHJhZGlpIGFyZSB6ZXJvLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6 Y2xpcFJvdW5kZWRSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Y2xp cE91dFJvdW5kZWRSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Zmls bFJvdW5kZWRSZWN0KToKKwogMjAxMy0wMS0yMCAgUGV0ZXIgUnliaW4gIDxwZXRlci5yeWJpbkBn bWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBWOCBMaXZlRWRpdCBBUEkg ZGlzYWJsZWQgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHAKaW5kZXggNjlhZDRmZGQyOTA1ZWRiZGFjNWFhOWZk ZDdjYmU0Y2U5NzYzMzg5Yy4uMWQ1NzIwNzE3ZGI3MmFkNjJkZjVjODNiOGYxYzI3MGJjODMwZjM4 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQuY3BwCkBAIC02MDIsNiArNjAyLDExIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0Ojpj bGlwUm91bmRlZFJlY3QoY29uc3QgUm91bmRlZFJlY3QmIHJlY3QpCiAgICAgaWYgKHBhaW50aW5n RGlzYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKCFyZWN0LmlzUm91bmRlZCgp KSB7CisgICAgICAgIGNsaXAocmVjdC5yZWN0KCkpOworICAgICAgICByZXR1cm47CisgICAgfQor CiAgICAgUGF0aCBwYXRoOwogICAgIHBhdGguYWRkUm91bmRlZFJlY3QocmVjdCk7CiAgICAgY2xp cChwYXRoKTsKQEAgLTYxMyw2ICs2MTgsMTEgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmNsaXBP dXRSb3VuZGVkUmVjdChjb25zdCBSb3VuZGVkUmVjdCYgcmVjdCkKICAgICBpZiAocGFpbnRpbmdE aXNhYmxlZCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoIXJlY3QuaXNSb3VuZGVkKCkp IHsKKyAgICAgICAgY2xpcE91dChyZWN0LnJlY3QoKSk7CisgICAgICAgIHJldHVybjsKKyAgICB9 CisKICAgICBQYXRoIHBhdGg7CiAgICAgcGF0aC5hZGRSb3VuZGVkUmVjdChyZWN0KTsKICAgICBj bGlwT3V0KHBhdGgpOwpAQCAtNjY2LDcgKzY3NiwxMCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6 ZmlsbFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0LCBjb25zdCBDb2xvciYgY29sb3IsIENvbG9y UwogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFJvdW5kZWRSZWN0KGNvbnN0IFJvdW5kZWRS ZWN0JiByZWN0LCBjb25zdCBDb2xvciYgY29sb3IsIENvbG9yU3BhY2UgY29sb3JTcGFjZSkKIHsK LSAgICBmaWxsUm91bmRlZFJlY3QocmVjdC5yZWN0KCksIHJlY3QucmFkaWkoKS50b3BMZWZ0KCks IHJlY3QucmFkaWkoKS50b3BSaWdodCgpLCByZWN0LnJhZGlpKCkuYm90dG9tTGVmdCgpLCByZWN0 LnJhZGlpKCkuYm90dG9tUmlnaHQoKSwgY29sb3IsIGNvbG9yU3BhY2UpOworICAgIGlmIChyZWN0 LmlzUm91bmRlZCgpKQorICAgICAgICBmaWxsUm91bmRlZFJlY3QocmVjdC5yZWN0KCksIHJlY3Qu cmFkaWkoKS50b3BMZWZ0KCksIHJlY3QucmFkaWkoKS50b3BSaWdodCgpLCByZWN0LnJhZGlpKCku Ym90dG9tTGVmdCgpLCByZWN0LnJhZGlpKCkuYm90dG9tUmlnaHQoKSwgY29sb3IsIGNvbG9yU3Bh Y2UpOworICAgIGVsc2UKKyAgICAgICAgZmlsbFJlY3QocmVjdC5yZWN0KCksIGNvbG9yLCBjb2xv clNwYWNlKTsKIH0KIAogI2lmICFVU0UoQ0cpCg==