107377 2013-01-19 12:19:21 -0800 [GTK][IndexedDB] Crash in WebCore::ScriptExecutionContext::willDestroyActiveDOMObject 2015-09-14 10:40:14 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 107194 1 zan webkit-unassigned alecflett beidson cgarcia commit-queue jsbell lquinn mingwang oldest_to_newest 811443 0 zan 2013-01-19 12:19:21 -0800 At least these tests flakily crash in WebCore::ScriptExecutionContext::willDestroyActiveDOMObject: storage/indexeddb/keypath-basics.html storage/indexeddb/mozilla/create-index-unique.html storage/indexeddb/objectstore-basics.html storage/indexeddb/mozilla/remove-index.html storage/indexeddb/index-get-key-argument-required.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=storage%2Findexeddb%2Fkeypath-basics.html%2Cstorage%2Findexeddb%2Fmozilla%2Fcreate-index-unique.html%2Cstorage%2Findexeddb%2Fobjectstore-basics.html%2Cstorage%2Findexeddb%2Fmozilla%2Fremove-index.html%2Cstorage%2Findexeddb%2Findex-get-key-argument-required.html Here's the trimmed crash log: Crash log for DumpRenderTree (pid 17097): ... [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/DumpR'. Program terminated with signal 11, Segmentation fault. #0 0x00002af9b15d4354 in WebCore::ScriptExecutionContext::willDestroyActiveDOMObject (this=0xd3dea0, object=0xfdcb10) at ../../Source/WebCore/dom/ScriptExecutionContext.cpp:265 265 CRASH(); ...om /lib/x86_64-linux-gnu/libc.so.6 #9 0x0000000000000000 in ?? () Thread 1 (Thread 0x2af9bf70e6a0 (LWP 17097)): #0 0x00002af9b15d4354 in WebCore::ScriptExecutionContext::willDestroyActiveDOMObject (this=0xd3dea0, object=0xfdcb10) at ../../Source/WebCore/dom/ScriptExecutionContext.cpp:265 #1 0x00002af9b14b3877 in WebCore::ActiveDOMObject::~ActiveDOMObject (this=0xfdcb10, __in_chrg=<optimized out>) at ../../Source/WebCore/dom/ActiveDOMObject.cpp:58 #2 0x00002af9b24709e6 in WebCore::IDBRequest::~IDBRequest (this=0xfdcaf0, __in_chrg=<optimized out>) at ../../Source/WebCore/Modules/indexeddb/IDBRequest.cpp:89 #3 0x00002af9b2470a56 in WebCore::IDBRequest::~IDBRequest (this=0xfdcaf0, __in_chrg=<optimized out>) at ../../Source/WebCore/Modules/indexeddb/IDBRequest.cpp:92 #4 0x00002af9b18f7a2a in WTF::RefCounted<WebCore::IDBCallbacks>::deref (this=0xfdcaf8) at ../../Source/WTF/wtf/RefCounted.h:202 #5 0x00002af9b243706a in WTF::derefIfNotNull<WebCore::IDBCallbacks> (ptr=0xfdcaf0) at ../../Source/WTF/wtf/PassRefPtr.h:53 #6 0x00002af9b2436a47 in WTF::RefPtr<WebCore::IDBCallbacks>::~RefPtr (this=0xfdc680, __in_chrg=<optimized out>) at ../../Source/WTF/wtf/RefPtr.h:56 #7 0x00002af9b2446b56 in WebCore::OpenCursorOperation::~OpenCursorOperation (this=0xfdc640, __in_chrg=<optimized out>) at ../../Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:320 #8 0x00002af9b2446bb4 in WebCore::OpenCursorOperation::~OpenCursorOperation (this=0xfdc640, __in_chrg=<optimized out>) at ../../Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:320 #9 0x00002af9b2436f74 in WTF::deleteOwnedPtr<WebCore::IDBTransactionBackendImpl::Operation> (ptr=0xfdc640) at ../../Source/WTF/wtf/OwnPtrCommon.h:65 #10 0x00002af9b24769ed in WTF::OwnPtr<WebCore::IDBTransactionBackendImpl::Operation>::~OwnPtr (this=0xfc18b8, __in_chrg=<optimized out>) at ../../Source/WTF/wtf/OwnPtr.h:63 #11 0x00002af9b24795d4 in WTF::VectorDestructor<true, WTF::OwnPtr<WebCore::IDBTransactionBackendImpl::Operation> >::destruct (begin=0xfc1898, end=0xfc18c0) at ../../Source/WTF/wtf/Vector.h:52 #12 0x00002af9b247884f in WTF::VectorTypeOperations<WTF::OwnPtr<WebCore::IDBTransactionBackendImpl::Operation> >::destruct (begin=0xfc1898, end=0xfc18c0) at ../../Source/WTF/wtf/Vector.h:214 #13 0x00002af9b2477550 in WTF::Deque<WTF::OwnPtr<WebCore::IDBTransactionBackendImpl::Operation>, 0ul>::destroyAll (this=0xfba1c0) at ../../Source/WTF/wtf/Deque.h:315 #14 0x00002af9b247660a in WTF::Deque<WTF::OwnPtr<WebCore::IDBTransactionBackendImpl::Operation>, 0ul>::~Deque (this=0xfba1c0, __in_chrg=<optimized out>) at ../../Source/WTF/wtf/Deque.h:327 #15 0x00002af9b247522f in WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl (this=0xfba160, __in_chrg=<optimized out>) at ../../Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp:67 #16 0x00002af9b247529e in WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl (this=0xfba160, __in_chrg=<optimized out>) at ../../Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp:71 #17 0x00002af9b2437808 in WTF::RefCounted<WebCore::IDBTransactionBackendInterface>::deref (this=0xfba168) at ../../Source/WTF/wtf/RefCounted.h:202 #18 0x00002af9b243740e in WTF::derefIfNotNull<WebCore::IDBTransactionBackendImpl> (ptr=0xfba160) at ../../Source/WTF/wtf/PassRefPtr.h:53 #19 0x00002af9b2436bc9 in WTF::RefPtr<WebCore::IDBTransactionBackendImpl>::~RefPtr (this=0x7fff31d8f420, __in_chrg=<optimized out>) at ../../Source/WTF/wtf/RefPtr.h:56 #20 0x00002af9b24756c6 in WebCore::IDBTransactionBackendImpl::abort (this=0xfba160, error=...) at ../../Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp:141 #21 0x00002af9b24753f5 in WebCore::IDBTransactionBackendImpl::abort (this=0xfba160) at ../../Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp:96 #22 0x00002af9b243b605 in WebCore::IDBDatabaseBackendImpl::abort (this=0xe74620, transactionId=7) at ../../Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:672 #23 0x00002af9b248389f in WebCore::IDBTransaction::abort (this=0xfa7880, ec=@0x7fff31d8f56c: 32767) at ../../Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:229 #24 0x00002af9b2484775 in WebCore::IDBTransaction::stop (this=0xfa7880) at ../../Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:430 #25 0x00002af9b15d40ac in WebCore::ScriptExecutionContext::stopActiveDOMObjects (this=0xd3dea0) at ../../Source/WebCore/dom/ScriptExecutionContext.cpp:235 #26 0x00002af9b14e0f37 in WebCore::Document::detach (this=0xd3de00) at ../../Source/WebCore/dom/Document.cpp:2049 #27 0x00002af9b14e1184 in WebCore::Document::prepareForDestruction (this=0xd3de00) at ../../Source/WebCore/dom/Document.cpp:2119 #28 0x00002af9b1addc20 in WebCore::Frame::setView (this=0x6a6800, view=...) at ../../Source/WebCore/page/Frame.cpp:266 #29 0x00002af9b1ae0329 in WebCore::Frame::createView (this=0x6a6800, viewportSize=..., backgroundColor=..., transparent=false, fixedLayoutSize=..., fixedVisibleContentRect=..., useFixedLayout=false, horizontalScrollbarMode=WebCore::ScrollbarAuto, horizontalLock=false, verticalScrollbarMode=WebCore::ScrollbarAuto, verticalLock=false) at ../../Source/WebCore/page/Frame.cpp:787 #30 0x00002af9b116770b in WebKit::FrameLoaderClient::transitionToCommittedForNewPage (this=0x6a5300) at ../../Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1254 #31 0x00002af9b1a0b169 in WebCore::FrameLoader::transitionToCommitted (this=0x6a6880, cachedPage=...) at ../../Source/WebCore/loader/FrameLoader.cpp:1859 #32 0x00002af9b1a0a5b6 in WebCore::FrameLoader::commitProvisionalLoad (this=0x6a6880) at ../../Source/WebCore/loader/FrameLoader.cpp:1701 #33 0x00002af9b19ecce9 in WebCore::DocumentLoader::commitIfReady (this=0x101c210) at ../../Source/WebCore/loader/DocumentLoader.cpp:277 #34 0x00002af9b19ecd04 in WebCore::DocumentLoader::finishedLoading (this=0x101c210) at ../../Source/WebCore/loader/DocumentLoader.cpp:283 #35 0x00002af9b19ef65f in WebCore::DocumentLoader::maybeLoadEmpty (this=0x101c210) at ../../Source/WebCore/loader/DocumentLoader.cpp:880 #36 0x00002af9b19ef737 in WebCore::DocumentLoader::startLoadingMainResource (this=0x101c210) at ../../Source/WebCore/loader/DocumentLoader.cpp:890 #37 0x00002af9b1a0c6ae in WebCore::FrameLoader::continueLoadAfterWillSubmitForm (this=0x6a6880) at ../../Source/WebCore/loader/FrameLoader.cpp:2221 #38 0x00002af9b1a0f235 in WebCore::FrameLoader::continueLoadAfterNavigationPolicy (this=0x6a6880, formState=..., shouldContinue=true) at ../../Source/WebCore/loader/FrameLoader.cpp:2836 #39 0x00002af9b1a0e947 in WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy (argument=0x6a6880, request=..., formState=..., shouldContinue=true) at ../../Source/WebCore/loader/FrameLoader.cpp:2706 #40 0x00002af9b1a45d73 in WebCore::PolicyCallback::call (this=0x7fff31d8ff90, shouldContinue=true) at ../../Source/WebCore/loader/PolicyCallback.cpp:103 #41 0x00002af9b1a46ce1 in WebCore::PolicyChecker::continueAfterNavigationPolicy (this=0x6a6890, policy=WebCore::PolicyUse) at ../../Source/WebCore/loader/PolicyChecker.cpp:176 #42 0x00002af9b119177a in webkit_web_policy_decision_use (decision=0xd33f80) at ../../Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp:88 #43 0x00002af9b116434e in WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction (this=0x6a5300, policyFunction=(void (WebCore::PolicyChecker::*)(WebCore::PolicyChecker * const, WebCore::PolicyAction)) 0x2af9b1a46a96 <WebCore::PolicyChecker::continueAfterNavigationPolicy(WebCore::PolicyAction)>, action=..., resourceRequest=...) at ../../Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:485 #44 0x00002af9b1a466e7 in WebCore::PolicyChecker::checkNavigationPolicy (this=0x6a6890, request=..., loader=0x101c210, formState=..., function=0x2af9b1a0e8f8 <WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>, argument=0x6a6880) at ../../Source/WebCore/loader/PolicyChecker.cpp:98 #45 0x00002af9b1a08e38 in WebCore::FrameLoader::loadWithDocumentLoader (this=0x6a6880, loader=0x101c210, type=WebCore::FrameLoadTypeStandard, prpFormState=...) at ../../Source/WebCore/loader/FrameLoader.cpp:1400 #46 0x00002af9b1a08870 in WebCore::FrameLoader::load (this=0x6a6880, newDocumentLoader=0x101c210) at ../../Source/WebCore/loader/FrameLoader.cpp:1341 #47 0x00002af9b1a083cf in WebCore::FrameLoader::load (this=0x6a6880, passedRequest=...) at ../../Source/WebCore/loader/FrameLoader.cpp:1291 #48 0x00002af9b118b933 in webkit_web_frame_load_uri (frame=0x6a6060, uri=0x4ff570 "about:blank") at ../../Source/WebKit/gtk/webkit/webkitwebframe.cpp:678 #49 0x00002af9b11a4c8e in webkit_web_view_load_uri (webView=0x6402b0, uri=0x4ff570 "about:blank") at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:4114 #50 0x00002af9b11a4a44 in webkit_web_view_open (webView=0x6402b0, uri=0x4ff570 "about:blank") at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:4074 #51 0x000000000049c182 in runTest (inputLine=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:791 #52 0x000000000049b721 in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:551 #53 0x000000000049ea4f in main (argc=2, argv=0x7fff31d91a38) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1510 928662 1 211511 mingwang 2013-09-12 22:52:40 -0700 Created attachment 211511 patch to review 928911 2 211511 jsbell 2013-09-13 10:47:34 -0700 Comment on attachment 211511 patch to review View in context: https://bugs.webkit.org/attachment.cgi?id=211511&action=review > Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:234 > while (!m_requestList.isEmpty()) { FYI, it looks like we solved this in Blink by simply skipping the request list cleanup if the context is stopped, plus some other transaction/database/request lifetime management tweaks. The Blink patch was https://chromiumcodereview.appspot.com/14236002 - note the commit comment "The unit test turned up a subtle but apparently harmless quirk caused by arbitrary ordering of ActiveDOMObject::stop() calls..." - shortly after this patch in trunk we saw a crash report from beta and realized it wasn't so harmless, and backported the fix to the beta. 930507 3 mingwang 2013-09-17 21:13:27 -0700 I found a similar one http://code.google.com/p/chromium/issues/detail?id=247395, not sure the cause is the same as this one. If the cause is the same, maybe we can do this in webkit also. 1064099 4 cgarcia 2015-01-26 00:33:53 -0800 All these test except storage/indexeddb/objectstore-basics.html pass for me now with the DatabaseProcess. objectstore-basics.html fails but it doesn't crash. It's currently listed in the TestExpectation files as "Blink tests that crash the WebProcess under IDBDatabase::dispatchEvent or IDBRequest::dispatchEvent (possibly all related)" 1097222 5 cgarcia 2015-05-25 01:21:04 -0700 These crashes no longer happen in r184850. 1125611 6 211511 ossy 2015-09-14 10:40:14 -0700 Comment on attachment 211511 patch to review Cleared review? from attachment 211511 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 211511 2013-09-12 22:52:40 -0700 2015-09-14 10:40:14 -0700 patch to review 0001-Don-t-destory-ActiveDOMObject-while-iterating.patch text/plain 4904 mingwang RnJvbSA3ZjcxZjU0OThmNjg1YTlhN2FmZWQyMjE5MWQ0YWFkNTM0ZjQ1ZDYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaW5nZ2FuZyBXYW5nIDxtaW5nd2FuZ0BibGFja2JlcnJ5LmNv bT4KRGF0ZTogRnJpLCAxMyBTZXAgMjAxMyAxMzo0MTowOCArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IERvbid0IGRlc3RvcnkgQWN0aXZlRE9NT2JqZWN0IHdoaWxlIGl0ZXJhdGluZwogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzM3NwoKUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCgpJREJUcmFuc2FjdGlvbjo6c3RvcCBpcyBhIHN5bmNocm9ub3VzIG1ldGhvZC4g V2hlbiBydW5uaW5nIHRoZSBtZXRob2QsCndlIGNvdWxkIHJlbGVhc2UgbGFzdCByZWZlcmVuY2Ug dG8gdGhlIEFjdGl2ZURPTU9iamVjdCwgd2hpY2ggd2lsbApjYXVzZSB0byBjYWxsIFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQ6OndpbGxEZXN0cm95QWN0aXZlRE9NT2JqZWN0LiBUaGlzCndpbGwgaGl0 IGEgY3Jhc2gsIGJlY2F1c2UgdGhlIGV2ZW50IGhhcHBlbnMgZHVyaW5nIGl0ZXJhdGluZy4KClNv LCBzY2hlZHVsZSB0aGUgZGVyZWYgaW4gdGhlIG5leHQgZXZlbnQgbG9vcCBieSBzZXR0aW5nIGEg dGltZXIuCgoqIE1vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9uLmNwcDoKKFdlYkNvcmU6 OklEQlRyYW5zYWN0aW9uOjpJREJUcmFuc2FjdGlvbik6CihXZWJDb3JlOjpJREJUcmFuc2FjdGlv bjo6YWJvcnQpOgooV2ViQ29yZTo6SURCVHJhbnNhY3Rpb246OnNjaGVkdWxlQWJvcnQpOgooV2Vi Q29yZTo6SURCVHJhbnNhY3Rpb246OmRvQWJvcnQpOgooV2ViQ29yZTo6SURCVHJhbnNhY3Rpb246 Ok9wZW5DdXJzb3JOb3RpZmllcjo6T3BlbkN1cnNvck5vdGlmaWVyKToKKiBNb2R1bGVzL2luZGV4 ZWRkYi9JREJUcmFuc2FjdGlvbi5oOgoKQ2hhbmdlLUlkOiBJNjFlZmI4YjNhZWFhN2FiMWQ2NTQw NWRiYmUwNDc5YjQ0NWE1ZTdiZgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAyMiArKysrKysrKysrKysrKysrKysrKwogLi4uL1dlYkNv cmUvTW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rpb24uY3BwICAgfCAgIDE4ICsrKysrKysr KysrKysrLS0KIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9u LmggIHwgICAgNSArKysrKwogMyBmaWxlcyBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlY2ExZDE2Li44NzIzMTVhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTMtMDktMTIgIE1pbmdnYW5nIFdhbmcgIDxtaW5nd2FuZ0BibGFj a2JlcnJ5LmNvbT4KKworICAgICAgICBEb24ndCBkZXN0b3J5IEFjdGl2ZURPTU9iamVjdCB3aGls ZSBpdGVyYXRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNzM3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIElEQlRyYW5zYWN0aW9uOjpzdG9wIGlzIGEgc3luY2hyb25vdXMgbWV0aG9kLiBXaGVuIHJ1 bm5pbmcgdGhlIG1ldGhvZCwKKyAgICAgICAgd2UgY291bGQgcmVsZWFzZSBsYXN0IHJlZmVyZW5j ZSB0byB0aGUgQWN0aXZlRE9NT2JqZWN0LCB3aGljaCB3aWxsCisgICAgICAgIGNhdXNlIHRvIGNh bGwgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6d2lsbERlc3Ryb3lBY3RpdmVET01PYmplY3QuIFRo aXMKKyAgICAgICAgd2lsbCBoaXQgYSBjcmFzaCwgYmVjYXVzZSB0aGUgZXZlbnQgaGFwcGVucyBk dXJpbmcgaXRlcmF0aW5nLgorCisgICAgICAgIFNvLCBzY2hlZHVsZSB0aGUgZGVyZWYgaW4gdGhl IG5leHQgZXZlbnQgbG9vcCBieSBzZXR0aW5nIGEgdGltZXIuCisKKyAgICAgICAgKiBNb2R1bGVz L2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJUcmFu c2FjdGlvbjo6SURCVHJhbnNhY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6SURCVHJhbnNhY3Rp b246OmFib3J0KToKKyAgICAgICAgKFdlYkNvcmU6OklEQlRyYW5zYWN0aW9uOjpzY2hlZHVsZUFi b3J0KToKKyAgICAgICAgKFdlYkNvcmU6OklEQlRyYW5zYWN0aW9uOjpkb0Fib3J0KToKKyAgICAg ICAgKFdlYkNvcmU6OklEQlRyYW5zYWN0aW9uOjpPcGVuQ3Vyc29yTm90aWZpZXI6Ok9wZW5DdXJz b3JOb3RpZmllcik6CisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rpb24u aDoKKwogMjAxMy0wOS0xMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K IAogICAgICAgICBbbWFjXSBDYWNoZSByZW5kZXJlZCBpbWFnZSBpbiBQREZEb2N1bWVudEltYWdl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2Fj dGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlv bi5jcHAKaW5kZXggZjdlOTFkMS4uZTRlZjI4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9uLmNwcApAQCAtMTAxLDYgKzEwMSw3IEBA IElEQlRyYW5zYWN0aW9uOjpJREJUcmFuc2FjdGlvbihTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBj b250ZXh0LCBpbnQ2NF90IGlkLCBjb25zCiAgICAgLCBtX2hhc1BlbmRpbmdBY3Rpdml0eSh0cnVl KQogICAgICwgbV9jb250ZXh0U3RvcHBlZChmYWxzZSkKICAgICAsIG1fcHJldmlvdXNNZXRhZGF0 YShwcmV2aW91c01ldGFkYXRhKQorICAgICwgbV9hYm9ydFRpbWVyKHRoaXMsICZJREJUcmFuc2Fj dGlvbjo6ZG9BYm9ydCkKIHsKICAgICBpZiAobW9kZSA9PSBJbmRleGVkREI6OlRyYW5zYWN0aW9u VmVyc2lvbkNoYW5nZSkgewogICAgICAgICAvLyBOb3QgYWN0aXZlIHVudGlsIHRoZSBjYWxsYmFj ay4KQEAgLTIxNyw2ICsyMTgsMTkgQEAgdm9pZCBJREJUcmFuc2FjdGlvbjo6YWJvcnQoRXhjZXB0 aW9uQ29kZSYgZWMpCiAKICAgICBtX3N0YXRlID0gRmluaXNoaW5nOwogCisgICAgc2NoZWR1bGVB Ym9ydCgpOworfQorCit2b2lkIElEQlRyYW5zYWN0aW9uOjpzY2hlZHVsZUFib3J0KCkKK3sKKyAg ICBpZiAobV9hYm9ydFRpbWVyLmlzQWN0aXZlKCkpCisgICAgICAgIHJldHVybjsKKworICAgIG1f YWJvcnRUaW1lci5zdGFydE9uZVNob3QoMCk7Cit9CisKK3ZvaWQgSURCVHJhbnNhY3Rpb246OmRv QWJvcnQoVGltZXI8SURCVHJhbnNhY3Rpb24+KikKK3sKICAgICB3aGlsZSAoIW1fcmVxdWVzdExp c3QuaXNFbXB0eSgpKSB7CiAgICAgICAgIFJlZlB0cjxJREJSZXF1ZXN0PiByZXF1ZXN0ID0gKm1f cmVxdWVzdExpc3QuYmVnaW4oKTsKICAgICAgICAgbV9yZXF1ZXN0TGlzdC5yZW1vdmUocmVxdWVz dCk7CkBAIC0yMjgsOCArMjQyLDggQEAgdm9pZCBJREJUcmFuc2FjdGlvbjo6YWJvcnQoRXhjZXB0 aW9uQ29kZSYgZWMpCiB9CiAKIElEQlRyYW5zYWN0aW9uOjpPcGVuQ3Vyc29yTm90aWZpZXI6Ok9w ZW5DdXJzb3JOb3RpZmllcihQYXNzUmVmUHRyPElEQlRyYW5zYWN0aW9uPiB0cmFuc2FjdGlvbiwg SURCQ3Vyc29yKiBjdXJzb3IpCi0gICAgOiBtX3RyYW5zYWN0aW9uKHRyYW5zYWN0aW9uKSwKLSAg ICAgIG1fY3Vyc29yKGN1cnNvcikKKyAgICA6IG1fdHJhbnNhY3Rpb24odHJhbnNhY3Rpb24pCisg ICAgLCBtX2N1cnNvcihjdXJzb3IpCiB7CiAgICAgbV90cmFuc2FjdGlvbi0+cmVnaXN0ZXJPcGVu Q3Vyc29yKG1fY3Vyc29yKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9JREJUcmFuc2FjdGlvbi5oCmluZGV4IDZjYTJlYTkuLjkyM2MxOTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9uLmgKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rpb24uaApAQCAtMzcs NiArMzcsNyBAQAogI2luY2x1ZGUgIklEQk1ldGFkYXRhLmgiCiAjaW5jbHVkZSAiSW5kZXhlZERC LmgiCiAjaW5jbHVkZSAiU2NyaXB0V3JhcHBhYmxlLmgiCisjaW5jbHVkZSAiVGltZXIuaCIKICNp bmNsdWRlIDx3dGYvSGFzaFNldC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CiAKQEAg LTEzMSw2ICsxMzIsOSBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBjYW5TdXNwZW5kKCkg Y29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHN0b3AoKSBPVkVSUklERTsKIAorICAg IHZvaWQgc2NoZWR1bGVBYm9ydCgpOworICAgIHZvaWQgZG9BYm9ydChUaW1lcjxJREJUcmFuc2Fj dGlvbj4qID0gMCk7CisKICAgICAvLyBFdmVudFRhcmdldAogICAgIHZpcnR1YWwgdm9pZCByZWZF dmVudFRhcmdldCgpIE9WRVJSSURFIHsgcmVmKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGVyZWZF dmVudFRhcmdldCgpIE9WRVJSSURFIHsgZGVyZWYoKTsgfQpAQCAtMTcwLDYgKzE3NCw3IEBAIHBy aXZhdGU6CiAgICAgSGFzaFNldDxJREJDdXJzb3IqPiBtX29wZW5DdXJzb3JzOwogCiAgICAgRXZl bnRUYXJnZXREYXRhIG1fZXZlbnRUYXJnZXREYXRhOworICAgIFRpbWVyPElEQlRyYW5zYWN0aW9u PiBtX2Fib3J0VGltZXI7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCi0tIAoxLjcuOS41 Cgo=