107374 2013-01-19 10:47:44 -0800 [gstreamer] assertion in g_object_unref from _WebKitWebAudioSourcePrivate destructor 2013-01-20 04:54:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106551 1 cdumez cdumez eric.carlson feature-media-reviews gustavo mrobinson pnormand s.choi webkit.review.bot oldest_to_newest 811423 0 cdumez 2013-01-19 10:47:44 -0800 We get the following assertion when running the webaudio tests in _WebKitWebAudioSourcePrivate destructor: crash log for WebProcess (pid <unknown>): STDOUT: <empty> STDERR: STDERR: (WebProcess:17295): GLib-GObject-CRITICAL **: g_object_unref: assertion `object->ref_count > 0' failed STDERR: 1 0x7f437a569903 STDERR: 2 0x7f437cd134a0 STDERR: 3 0x7f4375ba5d18 g_logv STDERR: 4 0x7f4375ba5e3e g_log STDERR: 5 0x7f4375ba5e7f g_return_if_fail_warning STDERR: 6 0x7f437597e42d g_object_unref STDERR: 7 0x7f4372f58711 STDERR: 8 0x7f437597e65a g_object_unref STDERR: 9 0x7f4372edb16b gst_object_unref STDERR: 10 0x7f437a46ab19 void WTF::derefGPtr<_GstTask>(_GstTask*) STDERR: 11 0x7f437a43ced2 WTF::GRefPtr<_GstTask>::~GRefPtr() STDERR: 12 0x7f437a43ce70 _WebKitWebAudioSourcePrivate::~_WebKitWebAudioSourcePrivate() STDERR: 13 0x7f437a43c18f STDERR: 14 0x7f437597e65a g_object_unref STDERR: 15 0x7f4372edb16b gst_object_unref STDERR: 16 0x7f4372ee218f STDERR: 17 0x7f4372ee23d5 gst_bin_remove STDERR: 18 0x7f4372edfa72 STDERR: 19 0x7f4372f2bc47 STDERR: 20 0x7f437597e566 g_object_unref STDERR: 21 0x7f4372edb16b gst_object_unref STDERR: 22 0x7f437a438f57 WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer() STDERR: 23 0x7f437a438fae WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer() STDERR: 24 0x7f437901ad55 void WTF::deleteOwnedPtr<WebCore::AudioDestination>(WebCore::AudioDestination*) STDERR: 25 0x7f437901ac1f WTF::OwnPtr<WebCore::AudioDestination>::~OwnPtr() STDERR: 26 0x7f437901a86a WebCore::DefaultAudioDestinationNode::~DefaultAudioDestinationNode() STDERR: 27 0x7f437901a8b6 WebCore::DefaultAudioDestinationNode::~DefaultAudioDestinationNode() STDERR: 28 0x7f4378ff9ab1 WebCore::AudioContext::deleteMarkedNodes() STDERR: 29 0x7f4379009480 WebCore::AudioNode::deref(WebCore::AudioNode::RefType) STDERR: 30 0x7f4378ffd250 void WTF::derefIfNotNull<WebCore::AudioDestinationNode>(WebCore::AudioDestinationNode*) STDERR: 31 0x7f4378ffbada WTF::RefPtr<WebCore::AudioDestinationNode>::clear() STDERR: LEAK: 1 WebPage STDERR: LEAK: 1 WebFrame STDERR: LEAK: 3 RenderObject STDERR: LEAK: 1 Page STDERR: LEAK: 1 Frame STDERR: LEAK: 5 CachedResource STDERR: LEAK: 109 WebCoreNode STDERR: LEAK: 1 WebContext 811425 1 183628 cdumez 2013-01-19 10:53:56 -0800 Created attachment 183628 Patch 811588 2 183628 pnormand 2013-01-20 01:51:08 -0800 Comment on attachment 183628 Patch Maybe it'd be simpler to set a NULL GDestroyNotify callback instead? Thanks for taking care of this issue. 811594 3 183662 cdumez 2013-01-20 03:17:10 -0800 Created attachment 183662 Patch Take Philippe's comment into consideration. It is a bit simpler indeed. 811599 4 183662 webkit.review.bot 2013-01-20 03:37:47 -0800 Comment on attachment 183662 Patch Clearing flags on attachment: 183662 Committed r140272: <http://trac.webkit.org/changeset/140272> 811602 5 webkit.review.bot 2013-01-20 03:37:51 -0800 All reviewed patches have been landed. Closing bug. 183628 2013-01-19 10:53:56 -0800 2013-01-20 03:17:10 -0800 Patch 107374_gobject_refcount.patch text/plain 2103 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2YTdjMDI1Li42ZTE2YTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTMtMDEtMTkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbZ3N0cmVhbWVyXSAgYXNzZXJ0aW9uIGluIGdfb2JqZWN0X3VucmVm IGZyb20gX1dlYktpdFdlYkF1ZGlvU291cmNlUHJpdmF0ZSBkZXN0cnVjdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczNzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXRXZWJBdWRpb1NyYyBv YmplY3QgZ2V0cyB1bnJlZmVkIG9uZSB0aW1lIHRvbyBtYW55IGluCisgICAgICAgIF9XZWJLaXRX ZWJBdWRpb1NvdXJjZVByaXZhdGUgZGVzdHJ1Y3RvciwgY2F1c2luZyBhbiBhc3NlcnRpb24KKyAg ICAgICAgaW4gZ19vYmplY3RfdW5yZWYuIFRoaXMgcGF0Y2ggY2FsbHMgZ19vYmplY3RfcmVmKCkg b24gdGhlCisgICAgICAgIFdlYktpdFdlYkF1ZGlvU3JjIG9iamVjdCB3aGVuIHBhc3NpbmcgaXQg YXMgdXNlciBkYXRhIHRvCisgICAgICAgIGdzdF90YXNrX25ldy4gVGhpcyBpcyBuZWVkZWQgYmVj YXVzZSB0aGUgV2ViS2l0V2ViQXVkaW9TcmMKKyAgICAgICAgb2JqZWN0IHdpbGwgZ2V0IHVucmVm ZWQgd2hlbiB0aGUgR3N0VGFzayBvYmplY3QgZ2V0cworICAgICAgICBkZXN0cm95ZWQuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5IGNvdmVyZWQgYnkgd2ViYXVkaW8gdGVzdHMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VH U3RyZWFtZXIuY3BwOgorICAgICAgICAod2Via2l0X3dlYl9hdWRpb19zcmNfaW5pdCk6CisKIDIw MTMtMDEtMTggIEtvbmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29t PgogCiAgICAgICAgIFtFRkxdW1dlYkdMXSBGaXggTWVtb3J5IGxlYWtzIGluIEVHTCBhbmQgR0xY IHN1cmZhY2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3Ry ZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNw cAppbmRleCA3MTk4NTQ4Li4yYmIzNTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRp b1NvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTIwNyw3ICsyMDcsNyBAQCBzdGF0aWMgdm9pZCB3ZWJr aXRfd2ViX2F1ZGlvX3NyY19pbml0KFdlYktpdFdlYkF1ZGlvU3JjKiBzcmMpCiAKICNpZmRlZiBH U1RfQVBJX1ZFUlNJT05fMQogICAgIGdfcmVjX211dGV4X2luaXQoJnByaXYtPm11dGV4KTsKLSAg ICBwcml2LT50YXNrID0gZ3N0X3Rhc2tfbmV3KHJlaW50ZXJwcmV0X2Nhc3Q8R3N0VGFza0Z1bmN0 aW9uPih3ZWJLaXRXZWJBdWRpb1NyY0xvb3ApLCBzcmMsIHJlaW50ZXJwcmV0X2Nhc3Q8R0Rlc3Ry b3lOb3RpZnk+KGdfb2JqZWN0X3VucmVmKSk7CisgICAgcHJpdi0+dGFzayA9IGdzdF90YXNrX25l dyhyZWludGVycHJldF9jYXN0PEdzdFRhc2tGdW5jdGlvbj4od2ViS2l0V2ViQXVkaW9TcmNMb29w KSwgZ19vYmplY3RfcmVmKHNyYyksIHJlaW50ZXJwcmV0X2Nhc3Q8R0Rlc3Ryb3lOb3RpZnk+KGdf b2JqZWN0X3VucmVmKSk7CiAjZWxzZQogICAgIGdfc3RhdGljX3JlY19tdXRleF9pbml0KCZwcml2 LT5tdXRleCk7CiAgICAgcHJpdi0+dGFzayA9IGdzdF90YXNrX2NyZWF0ZShyZWludGVycHJldF9j YXN0PEdzdFRhc2tGdW5jdGlvbj4od2ViS2l0V2ViQXVkaW9TcmNMb29wKSwgc3JjKTsK 183662 2013-01-20 03:17:10 -0800 2013-01-20 03:37:47 -0800 Patch 107374_gobject_refcount.patch text/plain 1961 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2YTdjMDI1Li5lZGZiMGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDEtMTkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbZ3N0cmVhbWVyXSAgYXNzZXJ0aW9uIGluIGdfb2JqZWN0X3VucmVm IGZyb20gX1dlYktpdFdlYkF1ZGlvU291cmNlUHJpdmF0ZSBkZXN0cnVjdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczNzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXRXZWJBdWRpb1NyYyBv YmplY3QgZ2V0cyB1bnJlZmVkIG9uZSB0aW1lIHRvbyBtYW55IGluCisgICAgICAgIF9XZWJLaXRX ZWJBdWRpb1NvdXJjZVByaXZhdGUgZGVzdHJ1Y3RvciwgY2F1c2luZyBhbiBhc3NlcnRpb24KKyAg ICAgICAgaW4gZ19vYmplY3RfdW5yZWYuIFRoaXMgcGF0Y2ggcGFzc2VzIE5VTEwgaW5zdGVhZCBv ZgorICAgICAgICBnX29iamVjdF91bnJlZiB0byBnc3RfdGFza19uZXcoKSBzbyB0aGF0IHRoZSBX ZWJLaXRXZWJBdWRpb1NyYworICAgICAgICBvYmplY3QgZG9lcyBub3QgZ2V0IHVucmVmZWQgd2hl biB0aGUgR3N0VGFzayBpcyBkZXN0cm95ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJl YWR5IGNvdmVyZWQgYnkgd2ViYXVkaW8gdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRp by9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAo d2Via2l0X3dlYl9hdWRpb19zcmNfaW5pdCk6CisKIDIwMTMtMDEtMTggIEtvbmRhcGFsbHkgS2Fs eWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW1dlYkdM XSBGaXggTWVtb3J5IGxlYWtzIGluIEVHTCBhbmQgR0xYIHN1cmZhY2UuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3Vy Y2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVy L1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCA3MTk4NTQ4Li5jZmM1Zjc2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2Vi S2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKQEAg LTIwNyw3ICsyMDcsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2F1ZGlvX3NyY19pbml0KFdl YktpdFdlYkF1ZGlvU3JjKiBzcmMpCiAKICNpZmRlZiBHU1RfQVBJX1ZFUlNJT05fMQogICAgIGdf cmVjX211dGV4X2luaXQoJnByaXYtPm11dGV4KTsKLSAgICBwcml2LT50YXNrID0gZ3N0X3Rhc2tf bmV3KHJlaW50ZXJwcmV0X2Nhc3Q8R3N0VGFza0Z1bmN0aW9uPih3ZWJLaXRXZWJBdWRpb1NyY0xv b3ApLCBzcmMsIHJlaW50ZXJwcmV0X2Nhc3Q8R0Rlc3Ryb3lOb3RpZnk+KGdfb2JqZWN0X3VucmVm KSk7CisgICAgcHJpdi0+dGFzayA9IGdzdF90YXNrX25ldyhyZWludGVycHJldF9jYXN0PEdzdFRh c2tGdW5jdGlvbj4od2ViS2l0V2ViQXVkaW9TcmNMb29wKSwgc3JjLCAwKTsKICNlbHNlCiAgICAg Z19zdGF0aWNfcmVjX211dGV4X2luaXQoJnByaXYtPm11dGV4KTsKICAgICBwcml2LT50YXNrID0g Z3N0X3Rhc2tfY3JlYXRlKHJlaW50ZXJwcmV0X2Nhc3Q8R3N0VGFza0Z1bmN0aW9uPih3ZWJLaXRX ZWJBdWRpb1NyY0xvb3ApLCBzcmMpOwo=