107372 2013-01-19 03:50:10 -0800 CanvasRenderingContext2D::drawTextInternal should create a mask buffer compatible with that of the canvas 2013-01-19 17:02:10 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 811376 0 thorton 2013-01-19 03:50:10 -0800 CanvasRenderingContext2D::drawTextInternal forces use of an accelerated mask buffer if USE(IOSURFACE_CANVAS_BACKING_STORE) is on, but this is wrong, as we can decide (or be forced by a setting) to fall *out* of accelerated mode. We should instead check with the canvas and use GraphicsContext::createCompatibleBuffer. 811377 1 183618 thorton 2013-01-19 03:53:02 -0800 Created attachment 183618 patch 811428 2 183618 simon.fraser 2013-01-19 11:04:20 -0800 Comment on attachment 183618 patch That '1' is pretty mysterious. 811501 3 183618 thorton 2013-01-19 16:58:19 -0800 Comment on attachment 183618 patch View in context: https://bugs.webkit.org/attachment.cgi?id=183618&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2299 > + OwnPtr<ImageBuffer> maskImage = c->createCompatibleBuffer(maskRect.size(), 1); I filed https://bugs.webkit.org/show_bug.cgi?id=107385 about that, but it also defaults to true so I'm gonna remove it from this line while landing. 811503 4 thorton 2013-01-19 17:02:10 -0800 http://trac.webkit.org/changeset/140263 183618 2013-01-19 03:53:02 -0800 2013-01-19 16:58:19 -0800 patch canvas-drawTextInternal-accel.diff text/plain 1948 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYTJmZjFiLi4zOGEyYTYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDEtMTkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpkcmF3VGV4dEludGVybmFsIHNob3Vs ZCBjcmVhdGUgYSBtYXNrIGJ1ZmZlciBjb21wYXRpYmxlIHdpdGggdGhhdCBvZiB0aGUgY2FudmFz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczNzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMsIGp1c3QgbWF0Y2hpbmcgYWNjZWxlcmF0aW9uIG1vZGVzLgorCisgICAgICAgICogaHRt bC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZHJhd1RleHRJbnRlcm5hbCk6IENyZWF0ZSBhIGJ1 ZmZlciB3aXRoIHRoZSBzYW1lIGFjY2VsZXJhdGlvbiBtb2RlIGFzIHRoZSBjYW52YXMKKyAgICAg ICAgaW5zdGVhZCBvZiBmb3JjaW5nIHRoZSB1c2Ugb2YgYW4gYWNjZWxlcmF0ZWQgYnVmZmVyIGlm IHdlIHN1cHBvcnQgYWNjZWxlcmF0aW9uOyB0aGUgY2FudmFzIGNvdWxkIGJlIHVuYWNjZWxlcmF0 ZWQKKyAgICAgICAgZXZlbiBpZiBVU0UoSU9TVVJGQUNFX0NBTlZBU19CQUNLSU5HX1NUT1JFKSBp cyBvbi4KKwogMjAxMy0wMS0xOCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAw Lm5ldD4KIAogICAgICAgICBbTWFjXSBSZW1vdmUgdW51c2VkIHBhZ2VTY2FsZUZhY3RvciBhbmQg cG9zaXRpb25SZWxhdGl2ZVRvQmFzZSBhcmd1bWVudHMgaW4gR3JhcGhpY3NMYXllckNBLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4 dDJELmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRl eHQyRC5jcHAKaW5kZXggMDJhM2MyZS4uOTc2NDMyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCkBAIC0yMjk2 LDExICsyMjk2LDcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmRyYXdUZXh0SW50 ZXJuYWwoY29uc3QgU3RyaW5nJiB0ZXh0LCBmbG9hdCB4LCBmbG8KICAgICBpZiAoZHJhd1N0eWxl LT5jYW52YXNHcmFkaWVudCgpIHx8IGRyYXdTdHlsZS0+Y2FudmFzUGF0dGVybigpKSB7CiAgICAg ICAgIEludFJlY3QgbWFza1JlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KHRleHRSZWN0KTsKIAotI2lm IFVTRShJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUpCi0gICAgICAgIE93blB0cjxJbWFn ZUJ1ZmZlcj4gbWFza0ltYWdlID0gSW1hZ2VCdWZmZXI6OmNyZWF0ZShtYXNrUmVjdC5zaXplKCks IDEsIENvbG9yU3BhY2VEZXZpY2VSR0IsIEFjY2VsZXJhdGVkKTsKLSNlbHNlCi0gICAgICAgIE93 blB0cjxJbWFnZUJ1ZmZlcj4gbWFza0ltYWdlID0gSW1hZ2VCdWZmZXI6OmNyZWF0ZShtYXNrUmVj dC5zaXplKCksIDEpOwotI2VuZGlmCisgICAgICAgIE93blB0cjxJbWFnZUJ1ZmZlcj4gbWFza0lt YWdlID0gYy0+Y3JlYXRlQ29tcGF0aWJsZUJ1ZmZlcihtYXNrUmVjdC5zaXplKCksIDEpOwogCiAg ICAgICAgIEdyYXBoaWNzQ29udGV4dCogbWFza0ltYWdlQ29udGV4dCA9IG1hc2tJbWFnZS0+Y29u dGV4dCgpOwogCg==