107363 2013-01-18 23:52:56 -0800 [EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL 2013-01-21 17:06:08 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis andersca benjamin cdumez gyuyoung.kim kenneth kling laszlo.gombos lucas.de.marchi mitz mjs rakuco sam tmpsantos webkit.review.bot oldest_to_newest 811330 0 naginenis 2013-01-18 23:52:56 -0800 Implement WebInspector::localizedStringsURL() to return the URL of the localizedStrings.js. 811393 1 183623 naginenis 2013-01-19 06:28:18 -0800 Created attachment 183623 patch 811395 2 183623 cdumez 2013-01-19 06:39:33 -0800 Comment on attachment 183623 patch Looks fine but you're not unskipping any test? 811397 3 naginenis 2013-01-19 07:00:27 -0800 (In reply to comment #2) > (From update of attachment 183623 [details]) > Looks fine but you're not unskipping any test? Thanks Chris. Tests were unskipped already. We have 321 Web inspector tests failing on Debug bot now after r140044. http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r140060%20%288198%29/results.html http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/8198/steps/layout-test/logs/stdio 811399 4 cdumez 2013-01-19 07:03:14 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 183623 [details] [details]) > > Looks fine but you're not unskipping any test? > > Thanks Chris. > > Tests were unskipped already. We have 321 Web inspector tests failing on Debug bot now after r140044. > > http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r140060%20%288198%29/results.html > > http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/8198/steps/layout-test/logs/stdio Oh right. All good then :) 811400 5 183623 gyuyoung.kim 2013-01-19 07:04:55 -0800 Comment on attachment 183623 patch View in context: https://bugs.webkit.org/attachment.cgi?id=183623&action=review > Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp:33 > #include <wtf/text/WTFString.h> It looks we don't need to include WTFString.h anymore, isn't it ? 811405 6 183623 naginenis 2013-01-19 07:58:39 -0800 Comment on attachment 183623 patch View in context: https://bugs.webkit.org/attachment.cgi?id=183623&action=review >> Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp:33 >> #include <wtf/text/WTFString.h> > > It looks we don't need to include WTFString.h anymore, isn't it ? I will check and likely remove. 811406 7 183626 naginenis 2013-01-19 08:07:45 -0800 Created attachment 183626 patch 811554 8 183626 gyuyoung.kim 2013-01-19 21:31:34 -0800 Comment on attachment 183626 patch LGTM. 811984 9 cdumez 2013-01-21 03:02:04 -0800 This patch fixes about 300 failures on our build bots. 812135 10 laszlo.gombos 2013-01-21 07:32:17 -0800 (In reply to comment #9) > This patch fixes about 300 failures on our build bots. I was confused by this so just to clarify - these failing tests are not skipped at the moment that's why the patch does not include a change in the Skipped file. This patch will bring back the bot to green. Patch looks good to me. 812140 11 cdumez 2013-01-21 07:45:18 -0800 (In reply to comment #10) > (In reply to comment #9) > > > This patch fixes about 300 failures on our build bots. > > I was confused by this so just to clarify - these failing tests are not skipped at the moment that's why the patch does not include a change in the Skipped file. This patch will bring back the bot to green. > > Patch looks good to me. This is correct. Those tests are not skipped and failing on the WK2 EFL debug build bot. 812141 12 cdumez 2013-01-21 07:46:50 -0800 http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r140330%20(8310)/results.html 812334 13 183626 benjamin 2013-01-21 12:26:00 -0800 Comment on attachment 183626 patch View in context: https://bugs.webkit.org/attachment.cgi?id=183626&action=review > Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp:43 > + StringBuilder builder; > + builder.appendLiteral("file://"); > + builder.append(WebCore::inspectorResourcePath()); > + builder.appendLiteral("/localizedStrings.js"); > + > + return builder.toString(); This should be using the String Operators, not String builder. 812425 14 183841 naginenis 2013-01-21 15:44:25 -0800 Created attachment 183841 Patch Take Benjamin's feedback into consideration. 812465 15 183841 naginenis 2013-01-21 16:48:14 -0800 Comment on attachment 183841 Patch Thanks for review! 812475 16 183841 webkit.review.bot 2013-01-21 17:06:02 -0800 Comment on attachment 183841 Patch Clearing flags on attachment: 183841 Committed r140372: <http://trac.webkit.org/changeset/140372> 812477 17 webkit.review.bot 2013-01-21 17:06:08 -0800 All reviewed patches have been landed. Closing bug. 183623 2013-01-19 06:28:18 -0800 2013-01-19 08:07:45 -0800 patch 107363.patch text/plain 1760 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwYThmOTkyLi5mMjU3MjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDEtMTkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjps b2NhbGl6ZWRTdHJpbmdzVVJMKCkgb24gRUZMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJp bmdzVVJMKCkgbWV0aG9kIHRvIHJldHVybiB0aGUKKyAgICAgICAgZmlsZSBVUkwgb2YgdGhlIGxv Y2FsaXplZFN0cmluZ3MuanMuCisKKyAgICAgICAgVGhpcyBwcmV2ZW50cyBwcmludGluZyB3YXJu aW5ncyBhYm91dCAiTG9jYWxpemVkIHN0cmluZyBub3QgZm91bmQiIGluCisgICAgICAgIHRoZSBj b25zb2xlIGFuZCBmaXhlcyBXZWIgaW5zcGVjdG9yIHJlbGF0ZWQgZmFpbGluZyB0ZXN0cyBvbiB0 aGUgYm90cy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9lZmwvV2ViSW5zcGVjdG9y RWZsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJpbmdz VVJMKToKKwogMjAxMy0wMS0xNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIERvbid0IGluaXRpYWxpemUgQXBwS2l0IGZvciBwcm9jZXNzZXMgdGhhdCBkb24ndCB1c2Ug aXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9lZmwvV2Vi SW5zcGVjdG9yRWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9lZmwv V2ViSW5zcGVjdG9yRWZsLmNwcAppbmRleCA3NTViNDI2Li5hZDkzMzFkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZWZsL1dlYkluc3BlY3RvckVmbC5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2VmbC9XZWJJbnNwZWN0b3JF ZmwuY3BwCkBAIC0yOCwxNSArMjgsMjAgQEAKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAKLSNp bmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9FZmxJ bnNwZWN0b3JVdGlsaXRpZXMuaD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+ CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewog CiBTdHJpbmcgV2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJpbmdzVVJMKCkgY29uc3QKIHsKLSAg ICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBTdHJpbmcoKTsKKyAgICBTdHJpbmdCdWls ZGVyIGJ1aWxkZXI7CisgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJmaWxlOi8vIik7CisgICAg YnVpbGRlci5hcHBlbmQoV2ViQ29yZTo6aW5zcGVjdG9yUmVzb3VyY2VQYXRoKCkpOworICAgIGJ1 aWxkZXIuYXBwZW5kTGl0ZXJhbCgiL2xvY2FsaXplZFN0cmluZ3MuanMiKTsKKworICAgIHJldHVy biBidWlsZGVyLnRvU3RyaW5nKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo= 183626 2013-01-19 08:07:45 -0800 2013-01-21 15:44:25 -0800 patch 107363.patch text/plain 1760 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwYThmOTkyLi5mMjU3MjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDEtMTkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjps b2NhbGl6ZWRTdHJpbmdzVVJMKCkgb24gRUZMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJp bmdzVVJMKCkgbWV0aG9kIHRvIHJldHVybiB0aGUKKyAgICAgICAgZmlsZSBVUkwgb2YgdGhlIGxv Y2FsaXplZFN0cmluZ3MuanMuCisKKyAgICAgICAgVGhpcyBwcmV2ZW50cyBwcmludGluZyB3YXJu aW5ncyBhYm91dCAiTG9jYWxpemVkIHN0cmluZyBub3QgZm91bmQiIGluCisgICAgICAgIHRoZSBj b25zb2xlIGFuZCBmaXhlcyBXZWIgaW5zcGVjdG9yIHJlbGF0ZWQgZmFpbGluZyB0ZXN0cyBvbiB0 aGUgYm90cy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9lZmwvV2ViSW5zcGVjdG9y RWZsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJpbmdz VVJMKToKKwogMjAxMy0wMS0xNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIERvbid0IGluaXRpYWxpemUgQXBwS2l0IGZvciBwcm9jZXNzZXMgdGhhdCBkb24ndCB1c2Ug aXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9lZmwvV2Vi SW5zcGVjdG9yRWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9lZmwv V2ViSW5zcGVjdG9yRWZsLmNwcAppbmRleCA3NTViNDI2Li4yMGUxMmYyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZWZsL1dlYkluc3BlY3RvckVmbC5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2VmbC9XZWJJbnNwZWN0b3JF ZmwuY3BwCkBAIC0yOCwxNSArMjgsMTkgQEAKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAKLSNp bmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+Ci0jaW5jbHVkZSA8d3RmL3RleHQvV1RG U3RyaW5nLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9FZmxJbnNwZWN0b3JVdGlsaXRpZXMuaD4KKyNp bmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewog CiBTdHJpbmcgV2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJpbmdzVVJMKCkgY29uc3QKIHsKLSAg ICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBTdHJpbmcoKTsKKyAgICBTdHJpbmdCdWls ZGVyIGJ1aWxkZXI7CisgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJmaWxlOi8vIik7CisgICAg YnVpbGRlci5hcHBlbmQoV2ViQ29yZTo6aW5zcGVjdG9yUmVzb3VyY2VQYXRoKCkpOworICAgIGJ1 aWxkZXIuYXBwZW5kTGl0ZXJhbCgiL2xvY2FsaXplZFN0cmluZ3MuanMiKTsKKworICAgIHJldHVy biBidWlsZGVyLnRvU3RyaW5nKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo= 183841 2013-01-21 15:44:25 -0800 2013-01-21 17:06:02 -0800 Patch 107363.patch text/plain 1611 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNDc1ZmY5Li4wZDViYzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDEtMjEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjps b2NhbGl6ZWRTdHJpbmdzVVJMKCkgb24gRUZMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJp bmdzVVJMKCkgbWV0aG9kIHRvIHJldHVybiB0aGUKKyAgICAgICAgZmlsZSBVUkwgb2YgdGhlIGxv Y2FsaXplZFN0cmluZ3MuanMuCisKKyAgICAgICAgVGhpcyBwcmV2ZW50cyBwcmludGluZyB3YXJu aW5ncyBhYm91dCAiTG9jYWxpemVkIHN0cmluZyBub3QgZm91bmQiIGluCisgICAgICAgIHRoZSBj b25zb2xlIGFuZCBmaXhlcyBXZWIgaW5zcGVjdG9yIHJlbGF0ZWQgZmFpbGluZyB0ZXN0cyBvbiB0 aGUgYm90cy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9lZmwvV2ViSW5zcGVjdG9y RWZsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJpbmdz VVJMKToKKwogMjAxMy0wMS0yMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIERvbid0IG51bGwgb3V0IHRoZSBJUEMgY29ubmVjdGlvbiBpbiBDaGlsZFBy b2Nlc3M6dGVybWluYXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvZWZsL1dlYkluc3BlY3RvckVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvZWZsL1dlYkluc3BlY3RvckVmbC5jcHAKaW5kZXggNzU1YjQyNi4uMGUwNjRmMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2VmbC9XZWJJbnNw ZWN0b3JFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9lZmwv V2ViSW5zcGVjdG9yRWZsLmNwcApAQCAtMjgsMTUgKzI4LDE0IEBACiAKICNpZiBFTkFCTEUoSU5T UEVDVE9SKQogCi0jaW5jbHVkZSA8V2ViQ29yZS9Ob3RJbXBsZW1lbnRlZC5oPgorI2luY2x1ZGUg PFdlYkNvcmUvRWZsSW5zcGVjdG9yVXRpbGl0aWVzLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RG U3RyaW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBTdHJpbmcgV2ViSW5zcGVjdG9yOjps b2NhbGl6ZWRTdHJpbmdzVVJMKCkgY29uc3QKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAg IHJldHVybiBTdHJpbmcoKTsKKyAgICByZXR1cm4gImZpbGU6Ly8iICsgV2ViQ29yZTo6aW5zcGVj dG9yUmVzb3VyY2VQYXRoKCkgKyAiL2xvY2FsaXplZFN0cmluZ3MuanMiOwogfQogCiB9IC8vIG5h bWVzcGFjZSBXZWJLaXQK