10736 2006-09-04 21:53:21 -0700 XMLHttpRequest.responseXML should be null on error 2006-11-20 12:07:15 -0800 1 1 1 Unclassified WebKit XML 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 54811 0 ap 2006-09-04 21:53:21 -0700 Draft XHR spec says that responseXML must be null if parsing the response fails. But both Firefox and Safari put descriptive error documents there, with our one even being HTML. WinIE initializes responseXML to an empty document, and keeps it empty after an error. So, the spec doesn't seem to match any major browser, but it still makes sense to me. 45954 1 11494 ap 2006-11-12 05:08:33 -0800 Created attachment 11494 proposed patch 45862 2 darin 2006-11-13 10:51:32 -0800 I wonder if this will break any Dashboard widgets. We should test that before landing the change. 44893 3 11494 mjs 2006-11-19 21:50:49 -0800 Comment on attachment 11494 proposed patch r=me 44926 4 ap 2006-11-20 12:07:15 -0800 Committed revision 17860 ( I assume Maciej's r+ meant that this is OK to land). 11494 2006-11-12 05:08:33 -0800 2006-11-19 21:50:49 -0800 proposed patch 10736r1_patch.txt text/plain 6723 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3NzQzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMTEtMTIgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzM2 CisgICAgICAgIFhNTEh0dHBSZXF1ZXN0LnJlc3BvbnNlWE1MIHNob3VsZCBiZSBudWxsIG9uIGVy cm9yCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3plcm8tbGVuZ3RoLXJl c3BvbnNlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L3plcm8tbGVuZ3RoLXJlc3BvbnNlLXN5bmMtZXhwZWN0ZWQudHh0OgorICAgICAgICBVcGRhdGVk IHRoZSByZXN1bHRzIGZvciB0aGUgbmV3IGJlaGF2aW9yLgorCiAyMDA2LTExLTExICBSb2IgQnVp cyAgPGJ1aXNAa2RlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBoeWF0dC4KSW5kZXg6IExh eW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvemVyby1sZW5ndGgtcmVzcG9uc2Ut ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0 cHJlcXVlc3QvemVyby1sZW5ndGgtcmVzcG9uc2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxNzcy NikKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvemVyby1sZW5ndGgt cmVzcG9uc2UtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw2IEBAIG9u cmVhZHlzdGF0ZWNoYW5nZTogTG9hZGVkCiDCoMKgU3RhdHVzOiAyMDAKIMKgwqBTdGF0dXNUZXh0 OiAiT0siCiDCoMKgUmVzcG9uc2VUZXh0OiAiIgotwqDCoFJlc3BvbnNlWE1MOiBbb2JqZWN0IERv Y3VtZW50XQotwqDCoFJlc3BvbnNlWE1MIHNlcmlhbGl6ZWQ6ICI8aHRtbD48Ym9keT48cGFyc2Vy ZXJyb3Igc3R5bGU9IndoaXRlLXNwYWNlOiBwcmU7IGJvcmRlcjogMnB4IHNvbGlkICNjNzc7IHBh ZGRpbmc6IDAgMWVtIDAgMWVtOyBtYXJnaW46IDFlbTsgYmFja2dyb3VuZC1jb2xvcjogI2ZkZDsg Y29sb3I6IGJsYWNrIj48aDM+VGhpcyBwYWdlIGNvbnRhaW5zIHRoZSBmb2xsb3dpbmcgZXJyb3Jz OjwvaDM+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6bW9ub3NwYWNlO2ZvbnQtc2l6ZToxMnB4Ij5l cnJvciBvbiBsaW5lIDEgYXQgY29sdW1uIDE6IEV4dHJhIGNvbnRlbnQgYXQgdGhlIGVuZCBvZiB0 aGUgZG9jdW1lbnQgPC9kaXY+PGgzPkJlbG93IGlzIGEgcmVuZGVyaW5nIG9mIHRoZSBwYWdlIHVw IHRvIHRoZSBmaXJzdCBlcnJvci48L2gzPjwvcGFyc2VyZXJyb3I+PC9ib2R5PjwvaHRtbD4iCivC oMKgUmVzcG9uc2VYTUw6IG51bGwKK8KgwqBSZXNwb25zZVhNTCBzZXJpYWxpemVkOiBuL2EKIApJ bmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC96ZXJvLWxlbmd0aC1y ZXNwb25zZS1zeW5jLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3htbGh0dHByZXF1ZXN0L3plcm8tbGVuZ3RoLXJlc3BvbnNlLXN5bmMtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAxNzcyNikKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJl cXVlc3QvemVyby1sZW5ndGgtcmVzcG9uc2Utc3luYy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTksNiArOSw2IEBAIGFmdGVyIHNlbmQoKTogTG9hZGVkCiDCoMKgU3RhdHVzOiAyMDAK IMKgwqBTdGF0dXNUZXh0OiAiT0siCiDCoMKgUmVzcG9uc2VUZXh0OiAiIgotwqDCoFJlc3BvbnNl WE1MOiBbb2JqZWN0IERvY3VtZW50XQotwqDCoFJlc3BvbnNlWE1MIHNlcmlhbGl6ZWQ6ICI8aHRt bD48Ym9keT48cGFyc2VyZXJyb3Igc3R5bGU9IndoaXRlLXNwYWNlOiBwcmU7IGJvcmRlcjogMnB4 IHNvbGlkICNjNzc7IHBhZGRpbmc6IDAgMWVtIDAgMWVtOyBtYXJnaW46IDFlbTsgYmFja2dyb3Vu ZC1jb2xvcjogI2ZkZDsgY29sb3I6IGJsYWNrIj48aDM+VGhpcyBwYWdlIGNvbnRhaW5zIHRoZSBm b2xsb3dpbmcgZXJyb3JzOjwvaDM+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6bW9ub3NwYWNlO2Zv bnQtc2l6ZToxMnB4Ij5lcnJvciBvbiBsaW5lIDEgYXQgY29sdW1uIDE6IEV4dHJhIGNvbnRlbnQg YXQgdGhlIGVuZCBvZiB0aGUgZG9jdW1lbnQgPC9kaXY+PGgzPkJlbG93IGlzIGEgcmVuZGVyaW5n IG9mIHRoZSBwYWdlIHVwIHRvIHRoZSBmaXJzdCBlcnJvci48L2gzPjwvcGFyc2VyZXJyb3I+PC9i b2R5PjwvaHRtbD4iCivCoMKgUmVzcG9uc2VYTUw6IG51bGwKK8KgwqBSZXNwb25zZVhNTCBzZXJp YWxpemVkOiBuL2EKIApJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzQzKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwyNCBAQAorMjAwNi0xMS0xMiAgQWxleGV5IFByb3NrdXJ5 YWtvdiAgPGFwQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3 MzYKKyAgICAgICAgWE1MSHR0cFJlcXVlc3QucmVzcG9uc2VYTUwgc2hvdWxkIGJlIG51bGwgb24g ZXJyb3IKKworICAgICAgICAqIGRvbS9YTUxUb2tlbml6ZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6WE1MVG9rZW5pemVyOjp3ZWxsRm9ybWVkKToKKyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVy Lmg6CisgICAgICAgIChXZWJDb3JlOjpUb2tlbml6ZXI6OndlbGxGb3JtZWQpOgorICAgICAgICAq IGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6RG9jdW1lbnQp OgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmltcGxpY2l0Q2xvc2UpOgorICAgICAgICAq IGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OndlbGxGb3JtZWQp OgorICAgICAgICBUZWxsIHdoZXRoZXIgWE1MVG9rZW5pemVyIHNhdyBhbiBlcnJvci4gQWx3YXlz IHRydWUgKHN1Y2Nlc3MpIGZvciBIVE1MLgorCisgICAgICAgICogeG1sL3htbGh0dHByZXF1ZXN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpnZXRSZXNwb25zZVhNTCk6 IFNldCB0aGUgZG9jdW1lbnQgdG8gbnVsbCBpZiBpdCdzIG5vdCB3ZWxsLWZvcm1lZC4KKwogMjAw Ni0xMS0xMyAgTWFyayBSb3dlICA8YmRhc2hAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBNaXR6LgpJbmRleDogV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gMTc3MjYpCisrKyBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1Niw2ICsyNTYsNyBAQCBEb2N1bWVu dDo6RG9jdW1lbnQoRE9NSW1wbGVtZW50YXRpb24qIGltCiAgICAgbV9iUGFyc2luZyA9IGZhbHNl OwogICAgIG1fZG9jQ2hhbmdlZCA9IGZhbHNlOwogICAgIG1fdG9rZW5pemVyID0gMDsKKyAgICBt X3dlbGxGb3JtZWQgPSBmYWxzZTsKIAogICAgIHBNb2RlID0gU3RyaWN0OwogICAgIGhNb2RlID0g WEh0bWw7CkBAIC0xMjA2LDYgKzEyMDcsOCBAQCB2b2lkIERvY3VtZW50OjppbXBsaWNpdENsb3Nl KCkKIAogICAgIG1fcHJvY2Vzc2luZ0xvYWRFdmVudCA9IHRydWU7CiAKKyAgICBtX3dlbGxGb3Jt ZWQgPSBtX3Rva2VuaXplciAmJiBtX3Rva2VuaXplci0+d2VsbEZvcm1lZCgpOworCiAgICAgLy8g V2UgaGF2ZSB0byBjbGVhciB0aGUgdG9rZW5pemVyLCBpbiBjYXNlIHNvbWVvbmUgZG9jdW1lbnQu d3JpdGUoKXMgZnJvbSB0aGUKICAgICAvLyBvbkxvYWQgZXZlbnQgaGFuZGxlciwgYXMgaW4gUmFk YXIgMzIwNjUyNC4KICAgICBkZWxldGUgbV90b2tlbml6ZXI7CkluZGV4OiBXZWJDb3JlL2RvbS9E b2N1bWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL0RvY3VtZW50LmgJKHJldmlzaW9u IDE3NzI2KQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzE2 LDYgKzMxNiw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGZpbmlzaFBhcnNpbmcoKTsKICAgICB2b2lk IGNsZWFyKCk7CiAKKyAgICBib29sIHdlbGxGb3JtZWQoKSBjb25zdCB7IHJldHVybiBtX3dlbGxG b3JtZWQ7IH0KKwogICAgIERlcHJlY2F0ZWRTdHJpbmcgVVJMKCkgY29uc3QgeyByZXR1cm4gbV91 cmwuaXNFbXB0eSgpID8gImFib3V0OmJsYW5rIiA6IG1fdXJsOyB9CiAgICAgdm9pZCBzZXRVUkwo Y29uc3QgRGVwcmVjYXRlZFN0cmluZyYgdXJsKTsKIApAQCAtNjAzLDYgKzYwNSw3IEBAIHByb3Rl Y3RlZDoKIAogICAgIERvY0xvYWRlciogbV9kb2NMb2FkZXI7CiAgICAgVG9rZW5pemVyKiBtX3Rv a2VuaXplcjsKKyAgICBib29sIG1fd2VsbEZvcm1lZDsKICAgICBEZXByZWNhdGVkU3RyaW5nIG1f dXJsOwogICAgIERlcHJlY2F0ZWRTdHJpbmcgbV9iYXNlVVJMOwogICAgIFN0cmluZyBtX2Jhc2VU YXJnZXQ7CkluZGV4OiBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvZG9tL1hNTFRva2VuaXplci5jcHAJKHJldmlzaW9uIDE3NzI2KQorKysgV2ViQ29y ZS9kb20vWE1MVG9rZW5pemVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5LDcgKzEwOSw5IEBA IHB1YmxpYzoKICAgICB2b2lkIGludGVybmFsU3Vic2V0KGNvbnN0IHhtbENoYXIgKm5hbWUsIGNv bnN0IHhtbENoYXIgKmV4dGVybmFsSUQsIGNvbnN0IHhtbENoYXIgKnN5c3RlbUlEKTsKIAogICAg IHZvaWQgaGFuZGxlRXJyb3IoRXJyb3JUeXBlIHR5cGUsIGNvbnN0IGNoYXIqIG0sIGludCBsaW5l TnVtYmVyLCBpbnQgY29sdW1uTnVtYmVyKTsKLSAgICAKKworICAgIHZpcnR1YWwgYm9vbCB3ZWxs Rm9ybWVkKCkgY29uc3QgeyByZXR1cm4gIW1fc2F3RXJyb3I7IH0KKwogcHJpdmF0ZToKICAgICB2 b2lkIGluaXRpYWxpemVQYXJzZXJDb250ZXh0KCk7CiAgICAgdm9pZCBzZXRDdXJyZW50Tm9kZShO b2RlKik7CkluZGV4OiBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXIuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXIuaAkocmV2aXNpb24gMTc3MjYpCisrKyBXZWJDb3JlL2Rv bS9YTUxUb2tlbml6ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNjMsNiArNjMsOCBAQCBwdWJsaWM6 CiAgICAgYm9vbCBpblZpZXdTb3VyY2VNb2RlKCkgY29uc3QgeyByZXR1cm4gbV9pblZpZXdTb3Vy Y2VNb2RlOyB9CiAgICAgdm9pZCBzZXRJblZpZXdTb3VyY2VNb2RlKGJvb2wgbW9kZSkgeyBtX2lu Vmlld1NvdXJjZU1vZGUgPSBtb2RlOyB9CiAKKyAgICB2aXJ0dWFsIGJvb2wgd2VsbEZvcm1lZCgp IGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KKwogcHJvdGVjdGVkOgogICAgIC8vIFRoZSB0b2tlbml6 ZXIgaGFzIGJ1ZmZlcnMsIHNvIHBhcnNpbmcgbWF5IGNvbnRpbnVlIGV2ZW4gYWZ0ZXIKICAgICAv LyBpdCBzdG9wcyByZWNlaXZpbmcgZGF0YS4gV2UgdXNlIG1fcGFyc2VyU3RvcHBlZCB0byBzdG9w IHRoZSB0b2tlbml6ZXIKSW5kZXg6IFdlYkNvcmUveG1sL3htbGh0dHByZXF1ZXN0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3htbC94bWxodHRwcmVxdWVzdC5jcHAJKHJldmlzaW9uIDE3NzI2 KQorKysgV2ViQ29yZS94bWwveG1saHR0cHJlcXVlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NjAsNiArMTYwLDkgQEAgRG9jdW1lbnQqIFhNTEh0dHBSZXF1ZXN0OjpnZXRSZXNwb25zZVhNTAog ICAgICAgICAgICAgbV9yZXNwb25zZVhNTC0+d3JpdGUobV9yZXNwb25zZVRleHQpOwogICAgICAg ICAgICAgbV9yZXNwb25zZVhNTC0+ZmluaXNoUGFyc2luZygpOwogICAgICAgICAgICAgbV9yZXNw b25zZVhNTC0+Y2xvc2UoKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKCFtX3Jlc3Bv bnNlWE1MLT53ZWxsRm9ybWVkKCkpCisgICAgICAgICAgICAgICAgbV9yZXNwb25zZVhNTCA9IDA7 CiAgICAgICAgIH0KICAgICAgICAgbV9jcmVhdGVkRG9jdW1lbnQgPSB0cnVlOwogICAgIH0K