107355 2013-01-18 20:45:46 -0800 Remove PLATFORM(TORCHMOBILE) from Assertions.h 2013-01-19 06:24:35 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned abarth benjamin eric ojan.autocc staikos tonikitoo webkit.review.bot oldest_to_newest 811278 0 laszlo.gombos 2013-01-18 20:45:46 -0800 This appears to be the only PLATFORM(TORCHMOBILE) ifdef. I don't believe this ifdef is needed anymore. 811279 1 183598 laszlo.gombos 2013-01-18 20:50:06 -0800 Created attachment 183598 proposed changed Similar cleanup at r111251. 811287 2 183598 eric 2013-01-18 21:10:01 -0800 Comment on attachment 183598 proposed changed LGTM. 811288 3 183598 webkit.review.bot 2013-01-18 21:12:45 -0800 Comment on attachment 183598 proposed changed Rejecting attachment 183598 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15976030 811297 4 183602 laszlo.gombos 2013-01-18 21:37:07 -0800 Created attachment 183602 for cq 811306 5 183602 webkit.review.bot 2013-01-18 22:21:35 -0800 Comment on attachment 183602 for cq Clearing flags on attachment: 183602 Committed r140236: <http://trac.webkit.org/changeset/140236> 811307 6 webkit.review.bot 2013-01-18 22:21:39 -0800 All reviewed patches have been landed. Closing bug. 183598 2013-01-18 20:50:06 -0800 2013-01-18 21:37:07 -0800 proposed changed 107355.patch text/plain 1136 laszlo.gombos SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDAyMzMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTE4ICBMYXN6bG8gR29tYm9zICA8bC5n b21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIFBMQVRGT1JNKFRPUkNITU9CSUxF KSBmcm9tIEFzc2VydGlvbnMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA3MzU1CisKKyAgICAgICAgVGhpcyBhcHBlYXJzIHRvIGJlIHRoZSBvbmx5 IHBsYWNlIHdoZXJlIFBMQVRGT1JNKFRPUkNITU9CSUxFKSBpcworICAgICAgICB1c2VkLiBJIGRv bid0IGJlbGlldmUgdGhpcyBpZmRlZiBpcyBuZWVkZWQgYW55bW9yZS4KKworICAgICAgICAqIHd0 Zi9Bc3NlcnRpb25zLmg6CisKIDIwMTMtMDEtMTggIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBh cHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgaXNQb3dlck9mMigpIGFuZCBhZGQgZ2V0TFNC U2V0KCkKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgJKHJldmlzaW9uIDEzOTkwMykKKysrIFNvdXJjZS9X VEYvd3RmL0Fzc2VydGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMjEzLDcgKzIxMyw3IEBAIFdU Rl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURkluc3RhbGxSZXBvcnQKICAgRXhwcmVzc2lvbnMgaW5z aWRlIHRoZW0gYXJlIGV2YWx1YXRlZCBpbiBkZWJ1ZyBidWlsZHMgb25seS4KICovCiAKLSNpZiBP UyhXSU5DRSkgJiYgIVBMQVRGT1JNKFRPUkNITU9CSUxFKQorI2lmIE9TKFdJTkNFKQogLyogRklY TUU6IFdlIGluY2x1ZGUgdGhpcyBoZXJlIG9ubHkgdG8gYXZvaWQgYSBjb25mbGljdCB3aXRoIHRo ZSBBU1NFUlQgbWFjcm8uICovCiAjaW5jbHVkZSA8d2luZG93cy5oPgogI3VuZGVmIG1pbgo= 183602 2013-01-18 21:37:07 -0800 2013-01-18 22:21:35 -0800 for cq 107355.patch text/plain 1172 laszlo.gombos SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDAyMzMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTE4ICBMYXN6bG8gR29tYm9zICA8bC5n b21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIFBMQVRGT1JNKFRPUkNITU9CSUxF KSBmcm9tIEFzc2VydGlvbnMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA3MzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCisK KyAgICAgICAgVGhpcyBhcHBlYXJzIHRvIGJlIHRoZSBvbmx5IHBsYWNlIHdoZXJlIFBMQVRGT1JN KFRPUkNITU9CSUxFKSBpcworICAgICAgICB1c2VkLiBJIGRvbid0IGJlbGlldmUgdGhpcyBpZmRl ZiBpcyBuZWVkZWQgYW55bW9yZS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisKIDIw MTMtMDEtMTggIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVmYWN0b3IgaXNQb3dlck9mMigpIGFuZCBhZGQgZ2V0TFNCU2V0KCkKSW5kZXg6IFNvdXJjZS9X VEYvd3RmL0Fzc2VydGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRp b25zLmgJKHJldmlzaW9uIDE0MDIzMykKKysrIFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAko d29ya2luZyBjb3B5KQpAQCAtMjEzLDcgKzIxMyw3IEBAIFdURl9FWFBPUlRfUFJJVkFURSB2b2lk IFdURkluc3RhbGxSZXBvcnQKICAgRXhwcmVzc2lvbnMgaW5zaWRlIHRoZW0gYXJlIGV2YWx1YXRl ZCBpbiBkZWJ1ZyBidWlsZHMgb25seS4KICovCiAKLSNpZiBPUyhXSU5DRSkgJiYgIVBMQVRGT1JN KFRPUkNITU9CSUxFKQorI2lmIE9TKFdJTkNFKQogLyogRklYTUU6IFdlIGluY2x1ZGUgdGhpcyBo ZXJlIG9ubHkgdG8gYXZvaWQgYSBjb25mbGljdCB3aXRoIHRoZSBBU1NFUlQgbWFjcm8uICovCiAj aW5jbHVkZSA8d2luZG93cy5oPgogI3VuZGVmIG1pbgo=