10734 2006-09-04 15:39:13 -0700 HTMLOptionElement should not allow setting the text and index attributes 2007-10-29 00:33:26 -0700 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 sam ap ap oldest_to_newest 54798 0 sam 2006-09-04 15:39:13 -0700 According to the DOM spec, both the "text" and "index" attributes of the HTMLOptionElement should be readonly (http://www.w3.org/TR/2003/REC-DOM-Level-2-HTML-20030109/html.html#ID-70901257). We currently allow setting for both, but throw an exception when setting the "index" element. One issue may be that the DOM Level 1 (Version 1.0) spec says that the "index" element shouldn't be readonly, and that fact is noted in the IDL with a FIXME that states, "FIXME: We disallow setting in violation of DOM 1 HTML". 59695 1 16913 ap 2007-10-28 06:28:26 -0700 Created attachment 16913 proposed patch HTMLOptionElement.index is read-only in IE and DOM (both DOM 2 and DOM 1 Second Edition), so if I'm not missing something, Firefox is wrong to raise an exception. HTMLOptionElement.text is settable in both IE and Firefox, so I don't think that we should change this. 59719 2 16913 darin 2007-10-28 14:22:06 -0700 Comment on attachment 16913 proposed patch Why not add a newline at the end of the test file? Shouldn't you also remove HTMLOptionElement::setIndex from HTMLOptionElement.cpp/h? Otherwise, r=me 59780 3 ap 2007-10-29 00:33:26 -0700 (In reply to comment #2) > Why not add a newline at the end of the test file? Done. > Shouldn't you also remove HTMLOptionElement::setIndex from > HTMLOptionElement.cpp/h? Done. > Otherwise, r=me Committed revision 27217. 16913 2007-10-28 06:28:26 -0700 2007-10-28 14:22:06 -0700 proposed patch 10734r1_patch.txt text/plain 4507 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzE4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMTAtMjggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzM0CisgICAgICAgIE1h ZGUgSFRNTE9wdGlvbkVsZW1lbnQuaW5kZXggcmVhZC1vbmx5LCBtYXRjaGluZyBJRSBhbmQgRE9N IHN0YW5kYXJkLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL0hUTUxPcHRpb25FbGVtZW50L3Nl dC1vcHRpb24taW5kZXgtdGV4dC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxPcHRpb25FbGVt ZW50LmlkbDoKKwogMjAwNy0xMC0yOCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgQnVpbGQgZml4IGZvciBub24tU1ZHIGJ1aWxkLCBubyByZXZpZXcuCkluZGV4OiBX ZWJDb3JlL2h0bWwvSFRNTE9wdGlvbkVsZW1lbnQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv aHRtbC9IVE1MT3B0aW9uRWxlbWVudC5pZGwJKHJldmlzaW9uIDI3MTc0KQorKysgV2ViQ29yZS9o dG1sL0hUTUxPcHRpb25FbGVtZW50LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAK IC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDYgQXBwbGUgQ29tcHV0ZXIsIEluYy4KKyAqIENvcHly aWdodCAoQykgMjAwNiwgMjAwNyBBcHBsZSwgSW5jLgogICogQ29weXJpZ2h0IChDKSAyMDA2IFNh bXVlbCBXZWluaWcgPHNhbS53ZWluaWdAZ21haWwuY29tPgogICoKICAqIFRoaXMgbGlicmFyeSBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKQEAgLTI2LDEy ICsyNiwxMCBAQCBtb2R1bGUgaHRtbCB7CiAjaWYgZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBU KQogICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgIFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10g RE9NU3RyaW5nICAgICAgICAgICAgdGV4dAogICAgICAgICAgICAgICAgICAgICAgc2V0dGVyIHJh aXNlcyhET01FeGNlcHRpb24pOwotICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgIGxvbmcgICAg ICAgICAgICAgICAgIGluZGV4Ci0gICAgICAgICAgICAgICAgICAgICBzZXR0ZXIgcmFpc2VzKERP TUV4Y2VwdGlvbik7IC8vIEZJWE1FOiBXZSBkaXNhbGxvdyBzZXR0aW5nIGluIHZpb2xhdGlvbiBv ZiBET00gMSBIVE1MLgogI2Vsc2UKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlICBET01TdHJp bmcgICAgICAgICAgICB0ZXh0OwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgIGxvbmcgICAg ICAgICAgICAgICAgIGluZGV4OwogI2VuZGlmCisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSAg bG9uZyAgICAgICAgICAgICAgICAgaW5kZXg7CiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSAg Ym9vbGVhbiAgICAgICAgICAgICAgZGlzYWJsZWQ7CiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0 ZSAgW0NvbnZlcnROdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcgICAgICAgICAgICBsYWJlbDsK ICAgICAgICAgICAgICAgICAgYXR0cmlidXRlICBib29sZWFuICAgICAgICAgICAgICBzZWxlY3Rl ZDsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MTgwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMTAtMjggIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNzM0CisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MT3B0aW9uRWxlbWVudC9zZXQt b3B0aW9uLWluZGV4LXRleHQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Rv bS9IVE1MT3B0aW9uRWxlbWVudC9zZXQtb3B0aW9uLWluZGV4LXRleHQuaHRtbDogQWRkZWQuCisK IDIwMDctMTAtMjggIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl LWVuYWJsZSBhIGJ1bmNoIG9mIHBhc3NpbmcgdGVzdHMgb24gV2luZG93cwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9kb20vSFRNTE9wdGlvbkVsZW1lbnQvc2V0LW9wdGlvbi1pbmRleC10ZXh0LWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MT3B0aW9u RWxlbWVudC9zZXQtb3B0aW9uLWluZGV4LXRleHQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTE9wdGlvbkVsZW1lbnQvc2V0LW9wdGlvbi1pbmRl eC10ZXh0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACisiT3B0aW9u IDEiIGFuZCAiT3B0aW9uIDIiIHNob3VsZCBiZSBpbiBjb3JyZWN0IG9yZGVyLgorCisgT3B0aW9u IDEKK09wdGlvbiAyCisKClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvZG9t L0hUTUxPcHRpb25FbGVtZW50L3NldC1vcHRpb24taW5kZXgtdGV4dC1leHBlY3RlZC50eHQKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9wbGFpbgpOYW1lOiBzdm46ZW9s LXN0eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTE9wdGlv bkVsZW1lbnQvc2V0LW9wdGlvbi1pbmRleC10ZXh0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9kb20vSFRNTE9wdGlvbkVsZW1lbnQvc2V0LW9wdGlvbi1pbmRleC10ZXh0Lmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MT3B0aW9uRWxlbWVu dC9zZXQtb3B0aW9uLWluZGV4LXRleHQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyNiBA QAorPHA+Ik9wdGlvbiAxIiBhbmQgIk9wdGlvbiAyIiBzaG91bGQgYmUgaW4gY29ycmVjdCBvcmRl ci48L3A+Cis8c2VsZWN0IHNpemU9Mj4KKzxvcHRpb24+RVJST1I8L29wdGlvbj4KKzxvcHRpb24+ T3B0aW9uIDI8L29wdGlvbj4KKzwvc2VsZWN0PgorPHNjcmlwdD4KKyAgaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CisKKyAgdmFyIG9wdGlvbjEgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgib3B0aW9u IilbMF07CisgIHZhciBvcHRpb24yID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoIm9w dGlvbiIpWzFdOworICAKKyAgb3B0aW9uMS50ZXh0ID0gIk9wdGlvbiAxIjsKKyAgdHJ5IHsKKyAg ICBvcHRpb24xLmluZGV4ID0gMTsKKyAgICBpZiAob3B0aW9uMS5pbmRleCAhPSAwKQorICAgICAg ZG9jdW1lbnQud3JpdGUoIjxwPkZBSUw6IEFuIGF0dGVtcHQgdG8gc2V0IEhUTUxPcHRpb25FbGVt ZW50LmluZGV4IHdhcyBub3QgaWdub3JlZC4iKTsKKworICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpIHsKKyAgICAgIGRvY3VtZW50LndyaXRlKGRvY3VtZW50LmdldEVsZW1lbnRz QnlUYWdOYW1lKCJvcHRpb24iKVswXS50ZXh0ICsgIjxicj4iKTsKKyAgICAgIGRvY3VtZW50Lndy aXRlKGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJvcHRpb24iKVsxXS50ZXh0ICsgIjxi cj4iKTsKKyAgICB9CisgIH0gY2F0Y2ggKGV4KSB7CisgICAgZG9jdW1lbnQud3JpdGUoIjxwPkZB SUw6IEV4Y2VwdGlvbiBvbiBzZXR0aW5nIGFuIGluZGV4OiAiICsgZXggKyAiPC9wPiIpOworICB9 Cis8L3NjcmlwdD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCgpQcm9wZXJ0eSBjaGFuZ2Vz IG9uOiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MT3B0aW9uRWxlbWVudC9zZXQtb3B0aW9uLWlu ZGV4LXRleHQuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L2h0 bWwKCg==