107331 2013-01-18 14:54:42 -0800 Change RenderStyle::getRoundedInnerBorderFor to take ints for border widths 2013-01-18 15:23:56 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae eric leviw ojan.autocc webkit.review.bot oldest_to_newest 811070 0 eae 2013-01-18 14:54:42 -0800 Borders are always represented as ints yet RenderStyle::getRoundedInnerBorderFor upcasts from int to LayoutUnit when calling getRoundedInnerBorderFor. 811072 1 183553 eae 2013-01-18 14:55:22 -0800 Created attachment 183553 Patch 811075 2 183553 leviw 2013-01-18 14:59:44 -0800 Comment on attachment 183553 Patch Makes sense. 811093 3 183553 webkit.review.bot 2013-01-18 15:23:53 -0800 Comment on attachment 183553 Patch Clearing flags on attachment: 183553 Committed r140213: <http://trac.webkit.org/changeset/140213> 811094 4 webkit.review.bot 2013-01-18 15:23:56 -0800 All reviewed patches have been landed. Closing bug. 183553 2013-01-18 14:55:22 -0800 2013-01-18 15:23:53 -0800 Patch bug-107331-20130118145221.patch text/plain 3731 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDIxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTE4ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2UgUmVuZGVyU3R5bGU6 OmdldFJvdW5kZWRJbm5lckJvcmRlckZvciB0byB0YWtlIGludHMgZm9yIGJvcmRlciB3aWR0aHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzMzMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg Qm9yZGVycyBhcmUgYWx3YXlzIHJlcHJlc2VudGVkIGFzIGludHMgeWV0IFJlbmRlclN0eWxlOjoK KyAgICAgICAgZ2V0Um91bmRlZElubmVyQm9yZGVyRm9yIHVwY2FzdHMgZnJvbSBpbnQgdG8gTGF5 b3V0VW5pdCB3aGVuCisgICAgICAgIGNhbGxpbmcgZ2V0Um91bmRlZElubmVyQm9yZGVyRm9yLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyU3R5bGU6OmdldFJvdW5kZWRJbm5lckJvcmRlckZvcik6CisgICAgICAgICogcmVu ZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmg6CisgICAgICAgIENoYW5nZSBnZXRSb3VuZGVkSW5u ZXJCb3JkZXJGb3IgdG8gdXNlIGludHMgZm9yIGJvcmRlciB3aWR0aHMuCisKIDIwMTMtMDEtMTgg IFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSdW4gZGVm ZXIgc2NyaXB0cyBpbiB0aGUgdGhyZWFkZWQgSFRNTCBwYXJzZXIKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAkocmV2aXNpb24gMTQwMjA1 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTAwMSwxNiArMTAwMSwxNiBAQCBSb3VuZGVkUmVjdCBSZW5kZXJTdHls ZTo6Z2V0Um91bmRlZElubmVyCiB7CiAgICAgYm9vbCBob3Jpem9udGFsID0gaXNIb3Jpem9udGFs V3JpdGluZ01vZGUoKTsKIAotICAgIExheW91dFVuaXQgbGVmdFdpZHRoID0gKCFob3Jpem9udGFs IHx8IGluY2x1ZGVMb2dpY2FsTGVmdEVkZ2UpID8gYm9yZGVyTGVmdFdpZHRoKCkgOiAwOwotICAg IExheW91dFVuaXQgcmlnaHRXaWR0aCA9ICghaG9yaXpvbnRhbCB8fCBpbmNsdWRlTG9naWNhbFJp Z2h0RWRnZSkgPyBib3JkZXJSaWdodFdpZHRoKCkgOiAwOwotICAgIExheW91dFVuaXQgdG9wV2lk dGggPSAoaG9yaXpvbnRhbCB8fCBpbmNsdWRlTG9naWNhbExlZnRFZGdlKSA/IGJvcmRlclRvcFdp ZHRoKCkgOiAwOwotICAgIExheW91dFVuaXQgYm90dG9tV2lkdGggPSAoaG9yaXpvbnRhbCB8fCBp bmNsdWRlTG9naWNhbFJpZ2h0RWRnZSkgPyBib3JkZXJCb3R0b21XaWR0aCgpIDogMDsKKyAgICBp bnQgbGVmdFdpZHRoID0gKCFob3Jpem9udGFsIHx8IGluY2x1ZGVMb2dpY2FsTGVmdEVkZ2UpID8g Ym9yZGVyTGVmdFdpZHRoKCkgOiAwOworICAgIGludCByaWdodFdpZHRoID0gKCFob3Jpem9udGFs IHx8IGluY2x1ZGVMb2dpY2FsUmlnaHRFZGdlKSA/IGJvcmRlclJpZ2h0V2lkdGgoKSA6IDA7Cisg ICAgaW50IHRvcFdpZHRoID0gKGhvcml6b250YWwgfHwgaW5jbHVkZUxvZ2ljYWxMZWZ0RWRnZSkg PyBib3JkZXJUb3BXaWR0aCgpIDogMDsKKyAgICBpbnQgYm90dG9tV2lkdGggPSAoaG9yaXpvbnRh bCB8fCBpbmNsdWRlTG9naWNhbFJpZ2h0RWRnZSkgPyBib3JkZXJCb3R0b21XaWR0aCgpIDogMDsK IAogICAgIHJldHVybiBnZXRSb3VuZGVkSW5uZXJCb3JkZXJGb3IoYm9yZGVyUmVjdCwgdG9wV2lk dGgsIGJvdHRvbVdpZHRoLCBsZWZ0V2lkdGgsIHJpZ2h0V2lkdGgsIGluY2x1ZGVMb2dpY2FsTGVm dEVkZ2UsIGluY2x1ZGVMb2dpY2FsUmlnaHRFZGdlKTsKIH0KIAogUm91bmRlZFJlY3QgUmVuZGVy U3R5bGU6OmdldFJvdW5kZWRJbm5lckJvcmRlckZvcihjb25zdCBMYXlvdXRSZWN0JiBib3JkZXJS ZWN0LAotICAgIExheW91dFVuaXQgdG9wV2lkdGgsIExheW91dFVuaXQgYm90dG9tV2lkdGgsIExh eW91dFVuaXQgbGVmdFdpZHRoLCBMYXlvdXRVbml0IHJpZ2h0V2lkdGgsIGJvb2wgaW5jbHVkZUxv Z2ljYWxMZWZ0RWRnZSwgYm9vbCBpbmNsdWRlTG9naWNhbFJpZ2h0RWRnZSkgY29uc3QKKyAgICBp bnQgdG9wV2lkdGgsIGludCBib3R0b21XaWR0aCwgaW50IGxlZnRXaWR0aCwgaW50IHJpZ2h0V2lk dGgsIGJvb2wgaW5jbHVkZUxvZ2ljYWxMZWZ0RWRnZSwgYm9vbCBpbmNsdWRlTG9naWNhbFJpZ2h0 RWRnZSkgY29uc3QKIHsKICAgICBMYXlvdXRSZWN0IGlubmVyUmVjdChib3JkZXJSZWN0LngoKSAr IGxlZnRXaWR0aCwgCiAgICAgICAgICAgICAgICBib3JkZXJSZWN0LnkoKSArIHRvcFdpZHRoLCAK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCShy ZXZpc2lvbiAxNDAyMDUpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVy U3R5bGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTA0NSw3ICsxMDQ1LDcgQEAgcHVibGljOgogICAg IFJvdW5kZWRSZWN0IGdldFJvdW5kZWRJbm5lckJvcmRlckZvcihjb25zdCBMYXlvdXRSZWN0JiBi b3JkZXJSZWN0LCBib29sIGluY2x1ZGVMb2dpY2FsTGVmdEVkZ2UgPSB0cnVlLCBib29sIGluY2x1 ZGVMb2dpY2FsUmlnaHRFZGdlID0gdHJ1ZSkgY29uc3Q7CiAKICAgICBSb3VuZGVkUmVjdCBnZXRS b3VuZGVkSW5uZXJCb3JkZXJGb3IoY29uc3QgTGF5b3V0UmVjdCYgYm9yZGVyUmVjdCwKLSAgICAg ICAgTGF5b3V0VW5pdCB0b3BXaWR0aCwgTGF5b3V0VW5pdCBib3R0b21XaWR0aCwgTGF5b3V0VW5p dCBsZWZ0V2lkdGgsIExheW91dFVuaXQgcmlnaHRXaWR0aCwgYm9vbCBpbmNsdWRlTG9naWNhbExl ZnRFZGdlLCBib29sIGluY2x1ZGVMb2dpY2FsUmlnaHRFZGdlKSBjb25zdDsKKyAgICAgICAgaW50 IHRvcFdpZHRoLCBpbnQgYm90dG9tV2lkdGgsIGludCBsZWZ0V2lkdGgsIGludCByaWdodFdpZHRo LCBib29sIGluY2x1ZGVMb2dpY2FsTGVmdEVkZ2UsIGJvb2wgaW5jbHVkZUxvZ2ljYWxSaWdodEVk Z2UpIGNvbnN0OwogCiAgICAgdm9pZCBzZXRCb3JkZXJMZWZ0V2lkdGgodW5zaWduZWQgdikgeyBT RVRfVkFSKHN1cnJvdW5kLCBib3JkZXIubV9sZWZ0Lm1fd2lkdGgsIHYpOyB9CiAgICAgdm9pZCBz ZXRCb3JkZXJMZWZ0U3R5bGUoRUJvcmRlclN0eWxlIHYpIHsgU0VUX1ZBUihzdXJyb3VuZCwgYm9y ZGVyLm1fbGVmdC5tX3N0eWxlLCB2KTsgfQo=