107325 2013-01-18 14:24:59 -0800 [Chromium] Expose didCommitCompositorFrame in WebWidgetClient. 2013-01-22 18:26:37 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leandrogracia leandrogracia abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 811041 0 leandrogracia 2013-01-18 14:24:59 -0800 The didCommit event is currently exposed via the didBecomeReadyForAdditionalInput method, but re-utilizing this for purposes other than input is misleading and can lead to issues in the future if this code changes. To solve this, we should expose didCommit as a separate event. 811044 1 183546 leandrogracia 2013-01-18 14:29:00 -0800 Created attachment 183546 Patch 811048 2 webkit.review.bot 2013-01-18 14:32:00 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 811880 3 183546 fishd 2013-01-20 23:54:30 -0800 Comment on attachment 183546 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183546&action=review > Source/WebKit/chromium/public/WebWidgetClient.h:88 > + virtual void didCommit() { } nit: can you be more specific with the name of this method? based on didCommitAndDrawCompositorFrame, perhaps the name of this method should be didCommitCompositorFrame? there are many things that use the term "commit" in web browsers, and it could be rather confusing to see a didCommit method implemented in a WebWidgetClient subclass, which may be concerned with many things beyond just page rendering. 813500 4 183546 leandrogracia 2013-01-22 15:48:59 -0800 Comment on attachment 183546 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183546&action=review >> Source/WebKit/chromium/public/WebWidgetClient.h:88 >> + virtual void didCommit() { } > > nit: can you be more specific with the name of this method? based on didCommitAndDrawCompositorFrame, perhaps the name of this method should be didCommitCompositorFrame? > > there are many things that use the term "commit" in web browsers, and it could be rather confusing to see a didCommit method implemented in a WebWidgetClient subclass, which may be concerned with many things beyond just page rendering. Good point. I'll be renaming didCommit to didCommitCompositorFrame as suggested. Thanks. 813501 5 184063 leandrogracia 2013-01-22 15:49:17 -0800 Created attachment 184063 Patch 813543 6 184063 jamesr 2013-01-22 16:32:48 -0800 Comment on attachment 184063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184063&action=review Code is good, comments are not. Documentation is important, so I think it's worth going another review round. > Source/WebKit/chromium/ChangeLog:8 > + Expose didCommitCompositorFrame as a separate event to not mix it with didBecomeReadyForAdditionalInput. Please describe what this patch is adding, i.e. "Add a notification on WebWidgetClient called when ...." > Source/WebKit/chromium/public/WebWidgetClient.h:87 > + // Called for compositing mode when a thread commit operation has finished. This notification will be called in single-threaded mode as well, so this comment isn't entirely accurate. 813586 7 184063 leandrogracia 2013-01-22 17:12:30 -0800 Comment on attachment 184063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184063&action=review >> Source/WebKit/chromium/ChangeLog:8 >> + Expose didCommitCompositorFrame as a separate event to not mix it with didBecomeReadyForAdditionalInput. > > Please describe what this patch is adding, i.e. "Add a notification on WebWidgetClient called when ...." Done. >> Source/WebKit/chromium/public/WebWidgetClient.h:87 >> + // Called for compositing mode when a thread commit operation has finished. > > This notification will be called in single-threaded mode as well, so this comment isn't entirely accurate. Done. 813587 8 184087 leandrogracia 2013-01-22 17:12:43 -0800 Created attachment 184087 Patch 813594 9 184087 jamesr 2013-01-22 17:19:36 -0800 Comment on attachment 184087 Patch Eh, ok 813652 10 184087 webkit.review.bot 2013-01-22 18:26:33 -0800 Comment on attachment 184087 Patch Clearing flags on attachment: 184087 Committed r140495: <http://trac.webkit.org/changeset/140495> 813653 11 webkit.review.bot 2013-01-22 18:26:37 -0800 All reviewed patches have been landed. Closing bug. 183546 2013-01-18 14:29:00 -0800 2013-01-22 15:49:13 -0800 Patch bug-107325-20130118222559.patch text/plain 2219 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDA0ZDllZDc3YWIwODg0YjExZGViMDdiNjg1OTQ3ZDRmMTIyNTJkNmYuLmQ4MTA0NjcwZTAwMjkz YmQ2NTdjMWY2ZGJlNWM3NWQxZjAzZTcyOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTMtMDEtMTggIExlYW5kcm8gR3JhY2lhIEdpbCAgPGxlYW5kcm9n cmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRXhwb3NlIGRpZENvbW1p dCBpbiBXZWJXaWRnZXRDbGllbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDczMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFeHBvc2UgZGlkQ29tbWl0IGFzIGEgc2VwYXJhdGUgZXZlbnQgdG8gbm90 IG1peCBpdCB3aXRoIGRpZEJlY29tZVJlYWR5Rm9yQWRkaXRpb25hbElucHV0LgorCisgICAgICAg ICogcHVibGljL1dlYldpZGdldENsaWVudC5oOgorICAgICAgICAoV2ViV2lkZ2V0Q2xpZW50KToK KyAgICAgICAgKFdlYktpdDo6V2ViV2lkZ2V0Q2xpZW50OjpkaWRDb21taXQpOgorICAgICAgICAq IHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpkaWRD b21taXQpOgorCiAyMDEzLTAxLTE1ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbQ2hyb21pdW1dIE1vdmUgU29ja2V0U3RyZWFtSGFuZGxlIGFuZCBTb2Nr ZXRTdHJlYW1IYW5kbGVJbnRlcm5hbCB0byBXZWJDb3JlL3BsYXRmb3JtCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaWRnZXRDbGllbnQuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldENsaWVudC5oCmluZGV4IGRkYzRkOWQ5Njhl NDZmNzU3NTBiMTEyNWMzNjE5ZWM3YjllZTFiNTUuLmQ2Mjk4YTVhZGVmOWVjZGU1OWM5MDRhYmFi OTk4OGVlNDJlNzEwY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYldpZGdldENsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YldpZGdldENsaWVudC5oCkBAIC04NCw2ICs4NCw5IEBAIHB1YmxpYzoKICAgICAvLyBpbnB1dC4K ICAgICB2aXJ0dWFsIHZvaWQgZGlkQmVjb21lUmVhZHlGb3JBZGRpdGlvbmFsSW5wdXQoKSB7IH0K IAorICAgIC8vIENhbGxlZCBmb3IgY29tcG9zaXRpbmcgbW9kZSB3aGVuIGEgdGhyZWFkIGNvbW1p dCBvcGVyYXRpb24gaGFzIGZpbmlzaGVkLgorICAgIHZpcnR1YWwgdm9pZCBkaWRDb21taXQoKSB7 IH0KKwogICAgIC8vIENhbGxlZCBmb3IgY29tcG9zaXRpbmcgbW9kZSB3aGVuIHRoZSBkcmF3IGNv bW1hbmRzIGZvciBhIFdlYktpdC1zaWRlCiAgICAgLy8gZnJhbWUgaGF2ZSBiZWVuIGlzc3VlZC4K ICAgICB2aXJ0dWFsIHZvaWQgZGlkQ29tbWl0QW5kRHJhd0NvbXBvc2l0b3JGcmFtZSgpIHsgfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGRiYjhjODEy NGVmNDhlOTMwY2FjYWI3ZDQyOTE4ZGRlYjlmNzk3OTcuLjE3N2U4MjhjMGVhYTc4ZjAzMGVhYjgy ZWU3YWM4MzYyMmM0Nzc0YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKQEAgLTQxMjMsOCArNDEyMywxMCBAQCB2b2lkIFdlYlZpZXdJbXBsOjp3aWxsQ29t bWl0KCkKIAogdm9pZCBXZWJWaWV3SW1wbDo6ZGlkQ29tbWl0KCkKIHsKLSAgICBpZiAobV9jbGll bnQpCisgICAgaWYgKG1fY2xpZW50KSB7CisgICAgICAgIG1fY2xpZW50LT5kaWRDb21taXQoKTsK ICAgICAgICAgbV9jbGllbnQtPmRpZEJlY29tZVJlYWR5Rm9yQWRkaXRpb25hbElucHV0KCk7Cisg ICAgfQogfQogCiB2b2lkIFdlYlZpZXdJbXBsOjpkaWRDb21taXRBbmREcmF3RnJhbWUoKQo= 184063 2013-01-22 15:49:17 -0800 2013-01-22 17:12:39 -0800 Patch bug-107325-20130122234611.patch text/plain 2296 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDA0ZDllZDc3YWIwODg0YjExZGViMDdiNjg1OTQ3ZDRmMTIyNTJkNmYuLjg2YWRmOWE4NDEyMDg4 ZTUwYmYxYTczMjJiOTBiZWM4MzMyMjIyY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTMtMDEtMjIgIExlYW5kcm8gR3JhY2lhIEdpbCAgPGxlYW5kcm9n cmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRXhwb3NlIGRpZENvbW1p dENvbXBvc2l0b3JGcmFtZSBpbiBXZWJXaWRnZXRDbGllbnQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczMjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2UgZGlkQ29tbWl0Q29tcG9zaXRvckZy YW1lIGFzIGEgc2VwYXJhdGUgZXZlbnQgdG8gbm90IG1peCBpdCB3aXRoIGRpZEJlY29tZVJlYWR5 Rm9yQWRkaXRpb25hbElucHV0LgorCisKKyAgICAgICAgKiBwdWJsaWMvV2ViV2lkZ2V0Q2xpZW50 Lmg6CisgICAgICAgIChXZWJXaWRnZXRDbGllbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJXaWRn ZXRDbGllbnQ6OmRpZENvbW1pdENvbXBvc2l0b3JGcmFtZSk6CisgICAgICAgICogc3JjL1dlYlZp ZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmRpZENvbW1pdCk6CisK IDIwMTMtMDEtMTUgIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFtDaHJvbWl1bV0gTW92ZSBTb2NrZXRTdHJlYW1IYW5kbGUgYW5kIFNvY2tldFN0cmVhbUhh bmRsZUludGVybmFsIHRvIFdlYkNvcmUvcGxhdGZvcm0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldENsaWVudC5oIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViV2lkZ2V0Q2xpZW50LmgKaW5kZXggZGRjNGQ5ZDk2OGU0NmY3NTc1MGIx MTI1YzM2MTllYzdiOWVlMWI1NS4uOGVjOWI2NGNmODkwNDJlZDAxOTdiYjUwYzY0YTY5M2Q2ZDQy ZmExZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0 Q2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0Q2xp ZW50LmgKQEAgLTg0LDYgKzg0LDkgQEAgcHVibGljOgogICAgIC8vIGlucHV0LgogICAgIHZpcnR1 YWwgdm9pZCBkaWRCZWNvbWVSZWFkeUZvckFkZGl0aW9uYWxJbnB1dCgpIHsgfQogCisgICAgLy8g Q2FsbGVkIGZvciBjb21wb3NpdGluZyBtb2RlIHdoZW4gYSB0aHJlYWQgY29tbWl0IG9wZXJhdGlv biBoYXMgZmluaXNoZWQuCisgICAgdmlydHVhbCB2b2lkIGRpZENvbW1pdENvbXBvc2l0b3JGcmFt ZSgpIHsgfQorCiAgICAgLy8gQ2FsbGVkIGZvciBjb21wb3NpdGluZyBtb2RlIHdoZW4gdGhlIGRy YXcgY29tbWFuZHMgZm9yIGEgV2ViS2l0LXNpZGUKICAgICAvLyBmcmFtZSBoYXZlIGJlZW4gaXNz dWVkLgogICAgIHZpcnR1YWwgdm9pZCBkaWRDb21taXRBbmREcmF3Q29tcG9zaXRvckZyYW1lKCkg eyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggZGJi OGM4MTI0ZWY0OGU5MzBjYWNhYjdkNDI5MThkZGViOWY3OTc5Ny4uYTY4MDk3YWNlZmYwODQxNTQ0 OTczZTFlNTVmMGU1OTNjN2NjZjMyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcApAQCAtNDEyMyw4ICs0MTIzLDEwIEBAIHZvaWQgV2ViVmlld0ltcGw6Ondp bGxDb21taXQoKQogCiB2b2lkIFdlYlZpZXdJbXBsOjpkaWRDb21taXQoKQogewotICAgIGlmICht X2NsaWVudCkKKyAgICBpZiAobV9jbGllbnQpIHsKKyAgICAgICAgbV9jbGllbnQtPmRpZENvbW1p dENvbXBvc2l0b3JGcmFtZSgpOwogICAgICAgICBtX2NsaWVudC0+ZGlkQmVjb21lUmVhZHlGb3JB ZGRpdGlvbmFsSW5wdXQoKTsKKyAgICB9CiB9CiAKIHZvaWQgV2ViVmlld0ltcGw6OmRpZENvbW1p dEFuZERyYXdGcmFtZSgpCg== 184087 2013-01-22 17:12:43 -0800 2013-01-22 18:26:33 -0800 Patch bug-107325-20130123010936.patch text/plain 2257 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFmNmYxOTI3MjIxOGY4OTM5OGM0ODc4MmIxYmU3ODc4YzE1YmNmZTYuLjlkZWUwMzBjNjdiZjYw M2M1NmQ5ZDQ2OTZhNGE0YzlkZmEwZDg1ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTMtMDEtMjIgIExlYW5kcm8gR3JhY2lhIEdpbCAgPGxlYW5kcm9n cmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRXhwb3NlIGRpZENvbW1p dENvbXBvc2l0b3JGcmFtZSBpbiBXZWJXaWRnZXRDbGllbnQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczMjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBub3RpZmljYXRpb24gb24gV2ViV2lk Z2V0Q2xpZW50IGNhbGxlZCB3aGVuIHRoZSBjb21wb3NpdG9yIGNvbW1pdHMgYSBmcmFtZS4KKwor ICAgICAgICAqIHB1YmxpYy9XZWJXaWRnZXRDbGllbnQuaDoKKyAgICAgICAgKFdlYldpZGdldENs aWVudCk6CisgICAgICAgIChXZWJLaXQ6OldlYldpZGdldENsaWVudDo6ZGlkQ29tbWl0Q29tcG9z aXRvckZyYW1lKToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJWaWV3SW1wbDo6ZGlkQ29tbWl0KToKKwogMjAxMy0wMS0yMiAgQWxwaGEgTGFtICA8 aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE0MDM5Mik6IEluamVj dElEQktleVRlc3QuVG9wTGV2ZWxQcm9wZXJ0eVN0cmluZ1ZhbHVlIGlzIGNyYXNoaW5nCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaWRnZXRDbGllbnQuaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldENsaWVudC5oCmluZGV4IGRk YzRkOWQ5NjhlNDZmNzU3NTBiMTEyNWMzNjE5ZWM3YjllZTFiNTUuLjQ3MTkxZDc1Nzk5NGUwNjJi ZjRjMjU3NmE5ZjA2YTI1OWUyYTJjY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYldpZGdldENsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYldpZGdldENsaWVudC5oCkBAIC04NCw2ICs4NCw5IEBAIHB1YmxpYzoKICAgICAv LyBpbnB1dC4KICAgICB2aXJ0dWFsIHZvaWQgZGlkQmVjb21lUmVhZHlGb3JBZGRpdGlvbmFsSW5w dXQoKSB7IH0KIAorICAgIC8vIENhbGxlZCBmb3IgY29tcG9zaXRpbmcgbW9kZSB3aGVuIGEgZnJh bWUgY29tbWl0IG9wZXJhdGlvbiBoYXMgZmluaXNoZWQuCisgICAgdmlydHVhbCB2b2lkIGRpZENv bW1pdENvbXBvc2l0b3JGcmFtZSgpIHsgfQorCiAgICAgLy8gQ2FsbGVkIGZvciBjb21wb3NpdGlu ZyBtb2RlIHdoZW4gdGhlIGRyYXcgY29tbWFuZHMgZm9yIGEgV2ViS2l0LXNpZGUKICAgICAvLyBm cmFtZSBoYXZlIGJlZW4gaXNzdWVkLgogICAgIHZpcnR1YWwgdm9pZCBkaWRDb21taXRBbmREcmF3 Q29tcG9zaXRvckZyYW1lKCkgeyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKaW5kZXggZmVkNGY4ZDUxM2RlMzE4NWEzMmQ0M2IzNGFiYzlhMTE4MzllZjQ3Zi4u YWQ4Njg4NWI1N2Y1MGNmOTQ5YTU3MzdkNmVkOTI0OWFiMGYyNTk1NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtNDE2Miw4ICs0MTYyLDEwIEBAIHZv aWQgV2ViVmlld0ltcGw6OndpbGxDb21taXQoKQogCiB2b2lkIFdlYlZpZXdJbXBsOjpkaWRDb21t aXQoKQogewotICAgIGlmIChtX2NsaWVudCkKKyAgICBpZiAobV9jbGllbnQpIHsKKyAgICAgICAg bV9jbGllbnQtPmRpZENvbW1pdENvbXBvc2l0b3JGcmFtZSgpOwogICAgICAgICBtX2NsaWVudC0+ ZGlkQmVjb21lUmVhZHlGb3JBZGRpdGlvbmFsSW5wdXQoKTsKKyAgICB9CiB9CiAKIHZvaWQgV2Vi Vmlld0ltcGw6OmRpZENvbW1pdEFuZERyYXdGcmFtZSgpCg==