107322 2013-01-18 13:51:16 -0800 Update LayoutUnit rounding unit test 2013-01-18 14:02:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae leviw oldest_to_newest 811002 0 eae 2013-01-18 13:51:16 -0800 Update the LayoutUnitRounding test to use fromFloatRound for values that cannot accurately be represented as a LayoutUnit (the default behavior is to floor the value to the nearest LayoutUnit). 811003 1 183539 eae 2013-01-18 13:52:38 -0800 Created attachment 183539 Patch 811007 2 183539 leviw 2013-01-18 13:53:50 -0800 Comment on attachment 183539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183539&action=review > Tools/TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:99 > + ASSERT_EQ(LayoutUnit::fromFloatRound(0.49f).round(), 0); > + ASSERT_EQ(LayoutUnit::fromFloatRound(0.50f).round(), 1); > ASSERT_EQ(LayoutUnit(0.99f).round(), 1); For consistency with above, should you check 0.51f here as well? > Tools/TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:102 > + ASSERT_EQ(LayoutUnit::fromFloatRound(1.49f).round(), 1); > + ASSERT_EQ(LayoutUnit::fromFloatRound(1.5f).round(), 2); Ditto 811008 3 183541 eae 2013-01-18 13:55:07 -0800 Created attachment 183541 Patch 811010 4 183541 leviw 2013-01-18 13:55:50 -0800 Comment on attachment 183541 Patch Who has two thumbs and is equal to r? Me. 811013 5 eae 2013-01-18 13:57:15 -0800 (In reply to comment #4) > (From update of attachment 183541 [details]) > Who has two thumbs and is equal to r? > Me. Thanks Isn't it closer to 1.98 thumbs at the moment though? 811018 6 leviw 2013-01-18 13:58:44 -0800 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 183541 [details] [details]) > > Who has two thumbs and is equal to r? > > Me. > > Thanks > Isn't it closer to 1.98 thumbs at the moment though? 1.98 rounds to 2. Be careful I don't r- and demand that be included! 811022 7 eae 2013-01-18 14:02:31 -0800 Committed r140205: <http://trac.webkit.org/changeset/140205> 183539 2013-01-18 13:52:38 -0800 2013-01-18 13:55:05 -0800 Patch bug-107322-20130118134937.patch text/plain 2785 eae SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0MDIwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDEzLTAxLTE4ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4K KworICAgICAgICBVcGRhdGUgTGF5b3V0VW5pdCByb3VuZGluZyB1bml0IHRlc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzMyMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVXBkYXRlIHRo ZSBMYXlvdXRVbml0Um91bmRpbmcgdGVzdCB0byB1c2UgZnJvbUZsb2F0Um91bmQgZm9yCisgICAg ICAgIHZhbHVlcyB0aGF0IGNhbm5vdCBhY2N1cmF0ZWx5IGJlIHJlcHJlc2VudGVkIGFzIGEgTGF5 b3V0VW5pdAorICAgICAgICAodGhlIGRlZmF1bHQgYmVoYXZpb3IgaXMgdG8gZmxvb3IgdGhlIHZh bHVlIHRvIHRoZSBuZWFyZXN0CisgICAgICAgIExheW91dFVuaXQpLgorCisgICAgICAgICogVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwOgorICAgICAgICAoVGVzdFdl YktpdEFQSTo6VEVTVCk6CisKIDIwMTMtMDEtMTggIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJh cGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAgICAgVkNTVXRpbHMucG06IFN0 b3AgY2FsbGluZyBnaXQgcmVwby1jb25maWcuCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYkNvcmUvTGF5b3V0VW5pdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwCShyZXZpc2lvbiAxNDAxOTcpCisrKyBU b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTGF5b3V0VW5pdC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTgzLDIzICs4MywyMyBAQCBURVNUKFdlYkNvcmVMYXlvdXRVbml0LCBMYXlvdXRV bml0Um91bmRpCiB7CiAgICAgQVNTRVJUX0VRKExheW91dFVuaXQoLTEuOWYpLnJvdW5kKCksIC0y KTsKICAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgtMS42Zikucm91bmQoKSwgLTIpOwotICAgIEFT U0VSVF9FUShMYXlvdXRVbml0KC0xLjUyZikucm91bmQoKSwgLTIpOwotICAgIEFTU0VSVF9FUShM YXlvdXRVbml0KC0xLjVmKS5yb3VuZCgpLCAtMSk7Ci0gICAgQVNTRVJUX0VRKExheW91dFVuaXQo LTEuNDlmKS5yb3VuZCgpLCAtMSk7CisgICAgQVNTRVJUX0VRKExheW91dFVuaXQ6OmZyb21GbG9h dFJvdW5kKC0xLjUxZikucm91bmQoKSwgLTIpOworICAgIEFTU0VSVF9FUShMYXlvdXRVbml0Ojpm cm9tRmxvYXRSb3VuZCgtMS41Zikucm91bmQoKSwgLTEpOworICAgIEFTU0VSVF9FUShMYXlvdXRV bml0Ojpmcm9tRmxvYXRSb3VuZCgtMS40OWYpLnJvdW5kKCksIC0xKTsKICAgICBBU1NFUlRfRVEo TGF5b3V0VW5pdCgtMS4wZikucm91bmQoKSwgLTEpOwotICAgIEFTU0VSVF9FUShMYXlvdXRVbml0 KC0wLjk5Zikucm91bmQoKSwgLTEpOwotICAgIEFTU0VSVF9FUShMYXlvdXRVbml0KC0wLjUxZiku cm91bmQoKSwgMCk7Ci0gICAgQVNTRVJUX0VRKExheW91dFVuaXQoLTAuNTBmKS5yb3VuZCgpLCAw KTsKLSAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgtMC40OWYpLnJvdW5kKCksIDApOworICAgIEFT U0VSVF9FUShMYXlvdXRVbml0Ojpmcm9tRmxvYXRSb3VuZCgtMC45OWYpLnJvdW5kKCksIC0xKTsK KyAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdDo6ZnJvbUZsb2F0Um91bmQoLTAuNTFmKS5yb3VuZCgp LCAtMSk7CisgICAgQVNTRVJUX0VRKExheW91dFVuaXQ6OmZyb21GbG9hdFJvdW5kKC0wLjUwZiku cm91bmQoKSwgMCk7CisgICAgQVNTRVJUX0VRKExheW91dFVuaXQ6OmZyb21GbG9hdFJvdW5kKC0w LjQ5Zikucm91bmQoKSwgMCk7CiAgICAgQVNTRVJUX0VRKExheW91dFVuaXQoLTAuMWYpLnJvdW5k KCksIDApOwogICAgIEFTU0VSVF9FUShMYXlvdXRVbml0KDAuMGYpLnJvdW5kKCksIDApOwogICAg IEFTU0VSVF9FUShMYXlvdXRVbml0KDAuMWYpLnJvdW5kKCksIDApOwotICAgIEFTU0VSVF9FUShM YXlvdXRVbml0KDAuNDlmKS5yb3VuZCgpLCAwKTsKLSAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgw LjUwZikucm91bmQoKSwgMSk7CisgICAgQVNTRVJUX0VRKExheW91dFVuaXQ6OmZyb21GbG9hdFJv dW5kKDAuNDlmKS5yb3VuZCgpLCAwKTsKKyAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdDo6ZnJvbUZs b2F0Um91bmQoMC41MGYpLnJvdW5kKCksIDEpOwogICAgIEFTU0VSVF9FUShMYXlvdXRVbml0KDAu OTlmKS5yb3VuZCgpLCAxKTsKICAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgxLjBmKS5yb3VuZCgp LCAxKTsKLSAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgxLjQ5Zikucm91bmQoKSwgMSk7Ci0gICAg QVNTRVJUX0VRKExheW91dFVuaXQoMS41Zikucm91bmQoKSwgMik7CisgICAgQVNTRVJUX0VRKExh eW91dFVuaXQ6OmZyb21GbG9hdFJvdW5kKDEuNDlmKS5yb3VuZCgpLCAxKTsKKyAgICBBU1NFUlRf RVEoTGF5b3V0VW5pdDo6ZnJvbUZsb2F0Um91bmQoMS41Zikucm91bmQoKSwgMik7CiB9CiAKIFRF U1QoV2ViQ29yZUxheW91dFVuaXQsIExheW91dFVuaXRTbmFwU2l6ZVRvUGl4ZWwpCg== 183541 2013-01-18 13:55:07 -0800 2013-01-18 14:02:53 -0800 Patch bug-107322-20130118135206.patch text/plain 2909 eae SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0MDIwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDEzLTAxLTE4ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4K KworICAgICAgICBVcGRhdGUgTGF5b3V0VW5pdCByb3VuZGluZyB1bml0IHRlc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzMyMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVXBkYXRlIHRo ZSBMYXlvdXRVbml0Um91bmRpbmcgdGVzdCB0byB1c2UgZnJvbUZsb2F0Um91bmQgZm9yCisgICAg ICAgIHZhbHVlcyB0aGF0IGNhbm5vdCBhY2N1cmF0ZWx5IGJlIHJlcHJlc2VudGVkIGFzIGEgTGF5 b3V0VW5pdAorICAgICAgICAodGhlIGRlZmF1bHQgYmVoYXZpb3IgaXMgdG8gZmxvb3IgdGhlIHZh bHVlIHRvIHRoZSBuZWFyZXN0CisgICAgICAgIExheW91dFVuaXQpLgorCisgICAgICAgICogVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwOgorICAgICAgICAoVGVzdFdl YktpdEFQSTo6VEVTVCk6CisKIDIwMTMtMDEtMTggIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJh cGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAgICAgVkNTVXRpbHMucG06IFN0 b3AgY2FsbGluZyBnaXQgcmVwby1jb25maWcuCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYkNvcmUvTGF5b3V0VW5pdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwCShyZXZpc2lvbiAxNDAxOTcpCisrKyBU b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTGF5b3V0VW5pdC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTgzLDIzICs4MywyNSBAQCBURVNUKFdlYkNvcmVMYXlvdXRVbml0LCBMYXlvdXRV bml0Um91bmRpCiB7CiAgICAgQVNTRVJUX0VRKExheW91dFVuaXQoLTEuOWYpLnJvdW5kKCksIC0y KTsKICAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgtMS42Zikucm91bmQoKSwgLTIpOwotICAgIEFT U0VSVF9FUShMYXlvdXRVbml0KC0xLjUyZikucm91bmQoKSwgLTIpOwotICAgIEFTU0VSVF9FUShM YXlvdXRVbml0KC0xLjVmKS5yb3VuZCgpLCAtMSk7Ci0gICAgQVNTRVJUX0VRKExheW91dFVuaXQo LTEuNDlmKS5yb3VuZCgpLCAtMSk7CisgICAgQVNTRVJUX0VRKExheW91dFVuaXQ6OmZyb21GbG9h dFJvdW5kKC0xLjUxZikucm91bmQoKSwgLTIpOworICAgIEFTU0VSVF9FUShMYXlvdXRVbml0Ojpm cm9tRmxvYXRSb3VuZCgtMS41Zikucm91bmQoKSwgLTEpOworICAgIEFTU0VSVF9FUShMYXlvdXRV bml0Ojpmcm9tRmxvYXRSb3VuZCgtMS40OWYpLnJvdW5kKCksIC0xKTsKICAgICBBU1NFUlRfRVEo TGF5b3V0VW5pdCgtMS4wZikucm91bmQoKSwgLTEpOwotICAgIEFTU0VSVF9FUShMYXlvdXRVbml0 KC0wLjk5Zikucm91bmQoKSwgLTEpOwotICAgIEFTU0VSVF9FUShMYXlvdXRVbml0KC0wLjUxZiku cm91bmQoKSwgMCk7Ci0gICAgQVNTRVJUX0VRKExheW91dFVuaXQoLTAuNTBmKS5yb3VuZCgpLCAw KTsKLSAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgtMC40OWYpLnJvdW5kKCksIDApOworICAgIEFT U0VSVF9FUShMYXlvdXRVbml0Ojpmcm9tRmxvYXRSb3VuZCgtMC45OWYpLnJvdW5kKCksIC0xKTsK KyAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdDo6ZnJvbUZsb2F0Um91bmQoLTAuNTFmKS5yb3VuZCgp LCAtMSk7CisgICAgQVNTRVJUX0VRKExheW91dFVuaXQ6OmZyb21GbG9hdFJvdW5kKC0wLjUwZiku cm91bmQoKSwgMCk7CisgICAgQVNTRVJUX0VRKExheW91dFVuaXQ6OmZyb21GbG9hdFJvdW5kKC0w LjQ5Zikucm91bmQoKSwgMCk7CiAgICAgQVNTRVJUX0VRKExheW91dFVuaXQoLTAuMWYpLnJvdW5k KCksIDApOwogICAgIEFTU0VSVF9FUShMYXlvdXRVbml0KDAuMGYpLnJvdW5kKCksIDApOwogICAg IEFTU0VSVF9FUShMYXlvdXRVbml0KDAuMWYpLnJvdW5kKCksIDApOwotICAgIEFTU0VSVF9FUShM YXlvdXRVbml0KDAuNDlmKS5yb3VuZCgpLCAwKTsKLSAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgw LjUwZikucm91bmQoKSwgMSk7CisgICAgQVNTRVJUX0VRKExheW91dFVuaXQ6OmZyb21GbG9hdFJv dW5kKDAuNDlmKS5yb3VuZCgpLCAwKTsKKyAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdDo6ZnJvbUZs b2F0Um91bmQoMC41MGYpLnJvdW5kKCksIDEpOworICAgIEFTU0VSVF9FUShMYXlvdXRVbml0Ojpm cm9tRmxvYXRSb3VuZCgwLjUxZikucm91bmQoKSwgMSk7CiAgICAgQVNTRVJUX0VRKExheW91dFVu aXQoMC45OWYpLnJvdW5kKCksIDEpOwogICAgIEFTU0VSVF9FUShMYXlvdXRVbml0KDEuMGYpLnJv dW5kKCksIDEpOwotICAgIEFTU0VSVF9FUShMYXlvdXRVbml0KDEuNDlmKS5yb3VuZCgpLCAxKTsK LSAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgxLjVmKS5yb3VuZCgpLCAyKTsKKyAgICBBU1NFUlRf RVEoTGF5b3V0VW5pdDo6ZnJvbUZsb2F0Um91bmQoMS40OWYpLnJvdW5kKCksIDEpOworICAgIEFT U0VSVF9FUShMYXlvdXRVbml0Ojpmcm9tRmxvYXRSb3VuZCgxLjVmKS5yb3VuZCgpLCAyKTsKKyAg ICBBU1NFUlRfRVEoTGF5b3V0VW5pdDo6ZnJvbUZsb2F0Um91bmQoMS41MWYpLnJvdW5kKCksIDIp OwogfQogCiBURVNUKFdlYkNvcmVMYXlvdXRVbml0LCBMYXlvdXRVbml0U25hcFNpemVUb1BpeGVs KQo=