107314 2013-01-18 12:44:46 -0800 Remove unused member variable m_useLatchedEventNode from PlatformWheelEvent.h 2013-03-01 22:43:42 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tdanderson tdanderson allan.jensen rjkroege webkit.review.bot oldest_to_newest 810940 0 tdanderson 2013-01-18 12:44:46 -0800 EventHandler::handleGestureScrollCore() was removed in https://bugs.webkit.org/show_bug.cgi?id=103952, and this was the only function that called setUseLatchedEventNode() on a PlatformWheelEvent. We should remove the unused code related to latched wheelevent nodes from EventHandler::handleWheelEvent(). 845558 1 191052 tdanderson 2013-03-01 15:21:00 -0800 Created attachment 191052 Patch 845738 2 191052 webkit.review.bot 2013-03-01 22:43:38 -0800 Comment on attachment 191052 Patch Clearing flags on attachment: 191052 Committed r144531: <http://trac.webkit.org/changeset/144531> 845739 3 webkit.review.bot 2013-03-01 22:43:42 -0800 All reviewed patches have been landed. Closing bug. 191052 2013-03-01 15:21:00 -0800 2013-03-01 22:43:38 -0800 Patch bug-107314-20130301181711.patch text/plain 3551 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWMyODhlOWVjYThhMWM5 NGI0YWY5ZjlmMjQ2ZmE5ZWE0MTdkNjkxYi4uNDUyOWM4ZGNlYTNlYmI5MjllM2UxZGIyYTQ2ODg0 ZDE4Yjg0OTVlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTAxICBUZXJy eSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSB1 bnVzZWQgbWVtYmVyIHZhcmlhYmxlIG1fdXNlTGF0Y2hlZEV2ZW50Tm9kZSBmcm9tIFBsYXRmb3Jt V2hlZWxFdmVudC5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDczMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVTY3JvbGxDb3JlKCkgd2FzIHJlbW92ZWQg aW4gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTQwMTc3LAorICAgICAgICBhbmQg dGhpcyB3YXMgdGhlIG9ubHkgcGxhY2Ugd2hlcmUgdGhlIG1lbWJlciB2YXJpYWJsZSB8bV91c2VM YXRjaGVkRXZlbnROb2RlfCBpbgorICAgICAgICBQbGF0Zm9ybVdoZWVsRXZlbnQgd2FzIG11dGF0 ZWQuIFRoaXMgdmFyaWFibGUgaXMgbm8gbG9uZ2VyIG5lZWRlZCBhbmQgc28gaXQgc2hvdWxkIGJl IHJlbW92ZWQuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLCBzbyBubyBuZXcgdGVz dHMgbmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vUGxhdGZvcm1XaGVlbEV2ZW50Lmg6Cisg ICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybVdoZWVsRXZlbnQ6OlBsYXRmb3JtV2hlZWxFdmVudCk6 CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybVdoZWVsRXZlbnQ6OnVzZUxhdGNoZWRFdmVudE5v ZGUpOgorICAgICAgICAoUGxhdGZvcm1XaGVlbEV2ZW50KToKKwogMjAxMy0wMy0wMSAgVnNldm9s b2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBOYXZpZ2F0b3Igc2hvdWxkIHNob3cgdHJlZSBlbGVtZW50IGZvciBlYWNoIGZvbGRlciBpbiB0 aGUgc291cmNlIHBhdGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0 Zm9ybVdoZWVsRXZlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtV2hlZWxF dmVudC5oCmluZGV4IDhjMDMwMmM1ZWE1ZDViZmU4YTMwYjJjNDU5MTVmMzE4MjQ2OWJmMTkuLjNj ZWYxNGMxNDdjOWZjNWIwMmE1ZmI3YzEzNjY3NjFiM2NhMDMyMTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtV2hlZWxFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1BsYXRmb3JtV2hlZWxFdmVudC5oCkBAIC04Miw3ICs4Miw2IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgICwgbV93aGVlbFRpY2tzWSgwKQogICAgICAgICAg ICAgLCBtX2dyYW51bGFyaXR5KFNjcm9sbEJ5UGl4ZWxXaGVlbEV2ZW50KQogICAgICAgICAgICAg LCBtX2RpcmVjdGlvbkludmVydGVkRnJvbURldmljZShmYWxzZSkKLSAgICAgICAgICAgICwgbV91 c2VMYXRjaGVkRXZlbnROb2RlKGZhbHNlKQogI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0o Q0hST01JVU0pCiAgICAgICAgICAgICAsIG1faGFzUHJlY2lzZVNjcm9sbGluZ0RlbHRhcyhmYWxz ZSkKICNlbmRpZgpAQCAtMTA2LDcgKzEwNSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgICAgICwgbV93aGVlbFRpY2tzWSh3aGVlbFRpY2tzWSkKICAgICAgICAgICAgICwgbV9ncmFu dWxhcml0eShncmFudWxhcml0eSkKICAgICAgICAgICAgICwgbV9kaXJlY3Rpb25JbnZlcnRlZEZy b21EZXZpY2UoZmFsc2UpCi0gICAgICAgICAgICAsIG1fdXNlTGF0Y2hlZEV2ZW50Tm9kZShmYWxz ZSkKICNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKENIUk9NSVVNKQogICAgICAgICAgICAg LCBtX2hhc1ByZWNpc2VTY3JvbGxpbmdEZWx0YXMoZmFsc2UpCiAjZW5kaWYKQEAgLTE0NSw4ICsx NDMsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgYm9vbCBkaXJlY3Rpb25JbnZl cnRlZEZyb21EZXZpY2UoKSBjb25zdCB7IHJldHVybiBtX2RpcmVjdGlvbkludmVydGVkRnJvbURl dmljZTsgfQogCi0gICAgICAgIHZvaWQgc2V0VXNlTGF0Y2hlZEV2ZW50Tm9kZShib29sIGIpIHsg bV91c2VMYXRjaGVkRXZlbnROb2RlID0gYjsgfQotCiAjaWYgUExBVEZPUk0oR1RLKQogICAgICAg ICBleHBsaWNpdCBQbGF0Zm9ybVdoZWVsRXZlbnQoR2RrRXZlbnRTY3JvbGwqKTsKICNlbmRpZgpA QCAtMTY0LDkgKzE2MCw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdW5zaWduZWQg c2Nyb2xsQ291bnQoKSBjb25zdCB7IHJldHVybiBtX3Njcm9sbENvdW50OyB9CiAgICAgICAgIGZs b2F0IHVuYWNjZWxlcmF0ZWRTY3JvbGxpbmdEZWx0YVgoKSBjb25zdCB7IHJldHVybiBtX3VuYWNj ZWxlcmF0ZWRTY3JvbGxpbmdEZWx0YVg7IH0KICAgICAgICAgZmxvYXQgdW5hY2NlbGVyYXRlZFNj cm9sbGluZ0RlbHRhWSgpIGNvbnN0IHsgcmV0dXJuIG1fdW5hY2NlbGVyYXRlZFNjcm9sbGluZ0Rl bHRhWTsgfQotICAgICAgICBib29sIHVzZUxhdGNoZWRFdmVudE5vZGUoKSBjb25zdCB7IHJldHVy biBtX3VzZUxhdGNoZWRFdmVudE5vZGUgfHwgKG1fbW9tZW50dW1QaGFzZSA9PSBQbGF0Zm9ybVdo ZWVsRXZlbnRQaGFzZUJlZ2FuIHx8IG1fbW9tZW50dW1QaGFzZSA9PSBQbGF0Zm9ybVdoZWVsRXZl bnRQaGFzZUNoYW5nZWQpOyB9CisgICAgICAgIGJvb2wgdXNlTGF0Y2hlZEV2ZW50Tm9kZSgpIGNv bnN0IHsgcmV0dXJuIG1fbW9tZW50dW1QaGFzZSA9PSBQbGF0Zm9ybVdoZWVsRXZlbnRQaGFzZUJl Z2FuIHx8IG1fbW9tZW50dW1QaGFzZSA9PSBQbGF0Zm9ybVdoZWVsRXZlbnRQaGFzZUNoYW5nZWQ7 IH0KICNlbHNlCi0gICAgICAgIGJvb2wgdXNlTGF0Y2hlZEV2ZW50Tm9kZSgpIGNvbnN0IHsgcmV0 dXJuIG1fdXNlTGF0Y2hlZEV2ZW50Tm9kZTsgfQorICAgICAgICBib29sIHVzZUxhdGNoZWRFdmVu dE5vZGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogI2VuZGlmCiAKICNpZiBQTEFURk9STShX SU4pCkBAIC0xODcsNyArMTgzLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBmbG9h dCBtX3doZWVsVGlja3NZOwogICAgICAgICBQbGF0Zm9ybVdoZWVsRXZlbnRHcmFudWxhcml0eSBt X2dyYW51bGFyaXR5OwogICAgICAgICBib29sIG1fZGlyZWN0aW9uSW52ZXJ0ZWRGcm9tRGV2aWNl OwotICAgICAgICBib29sIG1fdXNlTGF0Y2hlZEV2ZW50Tm9kZTsKICNpZiBQTEFURk9STShNQUMp IHx8IFBMQVRGT1JNKENIUk9NSVVNKQogICAgICAgICBib29sIG1faGFzUHJlY2lzZVNjcm9sbGlu Z0RlbHRhczsKICNlbmRpZgo=