<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>107313</bug_id>
          
          <creation_ts>2013-01-18 12:41:55 -0800</creation_ts>
          <short_desc>Objective-C API: Update documentation for JSValue and JSContext</short_desc>
          <delta_ts>2013-01-18 12:56:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Hahnenberg">mhahnenberg</reporter>
          <assigned_to name="Mark Hahnenberg">mhahnenberg</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>810939</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Hahnenberg">mhahnenberg</who>
    <bug_when>2013-01-18 12:41:55 -0800</bug_when>
    <thetext>After changing the semantics of object lifetime we need to update the API documentation to reflect the new semantics. This will primarily affect APIJSValue.h and JSContext.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>810947</commentid>
    <comment_count>1</comment_count>
      <attachid>183531</attachid>
    <who name="Mark Hahnenberg">mhahnenberg</who>
    <bug_when>2013-01-18 12:48:46 -0800</bug_when>
    <thetext>Created attachment 183531
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>810949</commentid>
    <comment_count>2</comment_count>
      <attachid>183531</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-01-18 12:50:30 -0800</bug_when>
    <thetext>Comment on attachment 183531
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183531&amp;action=review

&gt; Source/JavaScriptCore/API/JSContext.h:39
&gt; +// will become invalid unless it has been previously retained.

s/will become invalid/will be deallocated/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>810959</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Hahnenberg">mhahnenberg</who>
    <bug_when>2013-01-18 12:56:04 -0800</bug_when>
    <thetext>Committed r140197: &lt;http://trac.webkit.org/changeset/140197&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>183531</attachid>
            <date>2013-01-18 12:48:46 -0800</date>
            <delta_ts>2013-01-18 12:50:29 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-107313-20130118124545.patch</filename>
            <type>text/plain</type>
            <size>3959</size>
            <attacher name="Mark Hahnenberg">mhahnenberg</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwMTk0KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA
CisyMDEzLTAxLTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK
KyAgICAgICAgT2JqZWN0aXZlLUMgQVBJOiBVcGRhdGUgZG9jdW1lbnRhdGlvbiBmb3IgSlNWYWx1
ZSBhbmQgSlNDb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xMDczMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBBZnRlciBjaGFuZ2luZyB0aGUgc2VtYW50aWNzIG9mIG9iamVjdCBsaWZldGltZSB3
ZSBuZWVkIHRvIHVwZGF0ZSB0aGUgQVBJIGRvY3VtZW50YXRpb24gdG8gcmVmbGVjdCB0aGUgbmV3
IHNlbWFudGljcy4KKworICAgICAgICAqIEFQSS9BUElKU1ZhbHVlLmg6CisgICAgICAgICogQVBJ
L0pTQ29udGV4dC5oOgorCiAyMDEzLTAxLTE4ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBs
ZS5jb20+CiAKICAgICAgICAgV2VhayBHQyBtYXBzIHNob3VsZCBiZSBlYXNpZXIgdG8gdXNlCklu
ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0FQSUpTVmFsdWUuaAo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0FQSUpTVmFsdWUuaAkocmV2aXNpb24gMTQwMTYz
KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9BUElKU1ZhbHVlLmgJKHdvcmtpbmcgY29w
eSkKQEAgLTI4LDIxICsyOCwxMiBAQAogQGNsYXNzIEpTQ29udGV4dDsKIAogLy8gQSBKU1ZhbHVl
IGlzIGEgcmVmZXJlbmNlIHRvIGEgdmFsdWUgd2l0aGluIHRoZSBKYXZhU2NyaXB0IG9iamVjdCBz
cGFjZSBvZiBhCi0vLyBKU1ZpcnR1YWxNYWNoaW5lLiBBbGwgaW5zdGFuY2VzIG9mIEpTVmFsdWUg
b3JpZ2luYXRlIGZyb20gYSBKU0NvbnRleHQsIGFuZAotLy8gaG9sZCBhIHN0cm9uZyByZWZlcmVu
Y2UgdG8gdGhpcyBKU0NvbnRleHQuIFdoZXJlIGFuIGluc3RhbmNlIG1ldGhvZCBpcyBpbnZva2Vk
Ci0vLyB1cG9uIGEgSlNWYWx1ZSwgYW5kIHRoaXMgcmV0dXJucyBhbm90aGVyIEpTVmFsdWUsIHRo
ZSByZXR1cm5lZCBKU1ZhbHVlIHdpbGwKLS8vIG9yaWdpbmF0ZSBmcm9tIHRoZSBzYW1lIEpTQ29u
dGV4dCBhcyB0aGUgSlNWYWx1ZSBvbiB3aGljaCB0aGUgbWV0aG9kIHdhcwotLy8gaW52b2tlZC4K
LS8vCi0vLyBUaGUgSlNDb250ZXh0IGlzIHVzZWQgdG8gbWFuYWdlIHRoZSBsaWZlLWN5Y2xlIG9m
IHRoZSByZWZlcmVuY2VkIEphdmFTY3JpcHQKLS8vIHZhbHVlIHdpdGhpbiB0aGUgdmlydHVhbCBt
YWNoaW5lLiBTbyBsb25nIGFzIHRoZSBKU0NvbnRleHQgaXMgYmVpbmcgcmV0YWluZWQKLS8vIHRo
ZSBKU1ZhbHVlIHdpbGwgY29udGludWUgdG8ga2VlcCB0aGUgcmVmZXJlbmNlZCB2YWx1ZSB3aXRo
aW4gdGhlIEphdmFTY3JpcHQKLS8vIHZpcnR1YWwgbWFjaGluZSBhbGl2ZS4gV2hlbiB0aGUgSlND
b250ZXh0IGFzc29jaWF0ZWQgd2l0aCBhIEpTVmFsdWUgaXMKLS8vIGRlYWxsb2NhdGVkIHRoZSB3
ZWFrIGNvbnRleHQgcHJvcGVydHkgb2YgdGhlIEpTVmFsdWUgd2lsbCBiZWNvbWUgbmlsLiBBZnRl
cgotLy8gdGhpcyBvY2N1cnMgdGhlIHZhbHVlIHdpdGhpbiB0aGUgSmF2YVNjcmlwdCB2aXJ0dWFs
IG1hY2hpbmUgaXMgbm8gbG9uZ2VyCi0vLyBiZWluZyBtYWludGFpbmVkIGJ5IHRoaXMgSlNWYWx1
ZSwgYW5kIHRoZSBKU1ZhbHVlIGluc3RhbmNlIG1heSBubyBsb25nZXIgYnkKLS8vIHVzZWQgYXMg
YSByZWZlcmVuY2UgdG8gdGhpcyB2YWx1ZS4gRm9yIGFueSBtZXRob2QgaW52b2tlZCBvbiBpbnN0
YW5jZSBvZgotLy8gSlNWYWx1ZSB3aXRoIGEgbmlsIGNvbnRleHQsIHRoZSBtZXRob2Qgd2lsbCBy
ZXR1cm4gYSBuaWwvemVyby9mYWxzZSByZXN1bHQuCisvLyBKU1ZpcnR1YWxNYWNoaW5lLiBBbGwg
aW5zdGFuY2VzIG9mIEpTVmFsdWUgb3JpZ2luYXRlIGZyb20gYSBKU0NvbnRleHQgYW5kCisvLyBo
b2xkIGEgc3Ryb25nIHJlZmVyZW5jZSB0byB0aGlzIEpTQ29udGV4dC4gQXMgbG9uZyBhcyBhbnkg
dmFsdWUgYXNzb2NpYXRlZCB3aXRoIAorLy8gYSBwYXJ0aWN1bGFyIEpTQ29udGV4dCBpcyByZXRh
aW5lZCwgdGhhdCBKU0NvbnRleHQgd2lsbCByZW1haW4gYWxpdmUuIAorLy8gV2hlcmUgYW4gaW5z
dGFuY2UgbWV0aG9kIGlzIGludm9rZWQgdXBvbiBhIEpTVmFsdWUsIGFuZCB0aGlzIHJldHVybnMg
YW5vdGhlciAKKy8vIEpTVmFsdWUsIHRoZSByZXR1cm5lZCBKU1ZhbHVlIHdpbGwgb3JpZ2luYXRl
IGZyb20gdGhlIHNhbWUgSlNDb250ZXh0IGFzIHRoZSAKKy8vIEpTVmFsdWUgb24gd2hpY2ggdGhl
IG1ldGhvZCB3YXMgaW52b2tlZC4KIC8vCiAvLyBGb3IgYWxsIG1ldGhvZHMgdGFraW5nIGFyZ3Vt
ZW50cyBvZiB0eXBlIGlkLCBhcmd1bWVudHMgd2lsbCBiZSBjb252ZXJ0ZWQKIC8vIGludG8gYSBK
YXZhU2NyaXB0IHZhbHVlIGFjY29yZGluZyB0byB0aGUgY29udmVyc2lvbiBzcGVjaWZpZWQgYmVs
b3cuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4dC5oCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0LmgJKHJldmlzaW9uIDE0
MDE2MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0LmgJKHdvcmtpbmcg
Y29weSkKQEAgLTMzLDExICszMywxMCBAQAogLy8gSmF2YVNjcmlwdCBleGVjdXRpb24gdGFrZXMg
cGxhY2Ugd2l0aGluIGEgY29udGV4dC4KIC8vIEpTQ29udGV4dCBpcyBhbHNvIHVzZWQgdG8gbWFu
YWdlIHRoZSBsaWZlLWN5Y2xlIG9mIG9iamVjdHMgd2l0aGluIHRoZQogLy8gSmF2YVNjcmlwdCB2
aXJ0dWFsIG1hY2hpbmUuIEV2ZXJ5IGluc3RhbmNlIG9mIEpTVmFsdWUgaXMgYXNzb2NpYXRlZCB3
aXRoIGEKLS8vIEpTQ29udGV4dCB2aWEgYSB3ZWFrIHJlZmVyZW5jZS4gVGhlIEpTVmFsdWUgd2ls
bCBrZWVwIHRoZSBKYXZhU2NyaXB0IHZhbHVlIGl0Ci0vLyByZWZlcmVuY2VzIGFsaXZlIHNvIGxv
bmcgYXMgdGhlIEpTQ29udGV4dCBpcyBhbHNvIHJldGFpbmVkLiBXaGVuIGFuIGluc3RhbmNlCi0v
LyBvZiBKU0NvbnRleHQgaXMgZGVhbGxvY2F0ZWQgYW5kIHRoZSB3ZWFrIHJlZmVyZW5jZXMgdG8g
aXQgYXJlIGNsZWFyZWQgdGhlCi0vLyBKU1ZhbHVlcyB0aGF0IGhhZCBiZWVuIGFzc29jaWF0ZWQg
d2l0aCB0aGlzIGNvbnRleHQgd2lsbCBiZSBpbnZhbGlkYXRlZCwgYW5kCi0vLyB3aWxsIGNlYXNl
IHRvIGtlZXAgdGhlIHZhbHVlcyB3aXRoaW4gdGhlIEphdmFTY3JpcHQgZW5naW5lIGFsaXZlLgor
Ly8gSlNDb250ZXh0IHZpYSBhIHN0cm9uZyByZWZlcmVuY2UuIFRoZSBKU1ZhbHVlIHdpbGwga2Vl
cCB0aGUgSlNDb250ZXh0IGl0CisvLyByZWZlcmVuY2VzIGFsaXZlIHNvIGxvbmcgYXMgdGhlIEpT
VmFsdWUgcmVtYWlucyBhbGl2ZS4gV2hlbiBhbGwgb2YgdGhlIEpTVmFsdWVzCisvLyB0aGF0IHJl
ZmVyZW5jZSBhIHBhcnRpY3VsYXIgSlNDb250ZXh0IGhhdmUgYmVlbiBkZWFsbG9jYXRlZCB0aGUg
SlNDb250ZXh0IAorLy8gd2lsbCBiZWNvbWUgaW52YWxpZCB1bmxlc3MgaXQgaGFzIGJlZW4gcHJl
dmlvdXNseSByZXRhaW5lZC4KIAogTlNfQ0xBU1NfQVZBSUxBQkxFKDEwXzksIE5BKQogQGludGVy
ZmFjZSBKU0NvbnRleHQgOiBOU09iamVjdAo=
</data>
<flag name="review"
          id="201934"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>