107293 2013-01-18 09:10:51 -0800 [BlackBerry] fix compile warnings in NetworkJob 2013-01-18 09:53:13 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles webkit.review.bot oldest_to_newest 810686 0 joenotcharles 2013-01-18 09:10:51 -0800 A recent commit introduced some compile warnings. We should compile cleanly. 810691 1 183478 joenotcharles 2013-01-18 09:14:46 -0800 Created attachment 183478 fix 810699 2 183478 yong.li.webkit 2013-01-18 09:17:58 -0800 Comment on attachment 183478 fix View in context: https://bugs.webkit.org/attachment.cgi?id=183478&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:75 > + for (size_t i = 0; i < sizeof(appendableHeaders) /sizeof(char*); i++) Minor: ++i is prefered 810746 3 183478 webkit.review.bot 2013-01-18 09:53:11 -0800 Comment on attachment 183478 fix Clearing flags on attachment: 183478 Committed r140168: <http://trac.webkit.org/changeset/140168> 810747 4 webkit.review.bot 2013-01-18 09:53:13 -0800 All reviewed patches have been landed. Closing bug. 183478 2013-01-18 09:14:46 -0800 2013-01-18 09:53:10 -0800 fix 0001-BlackBerry-fix-compile-warnings-in-NetworkJob.patch text/plain 2262 joenotcharles RnJvbSAzMzAyMjkzOTE5ZGUwYjU2ODJlM2ZkYWZiN2Q3MjRlZmI4N2VmZTFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBGcmks IDE4IEphbiAyMDEzIDEyOjEwOjQ0IC0wNTAwClN1YmplY3Q6IFtQQVRDSCAxLzNdIFtCbGFja0Jl cnJ5XSBmaXggY29tcGlsZSB3YXJuaW5ncyBpbiBOZXR3b3JrSm9iCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MjkzCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KCkludGVybmFsIFBSOiAyODMwOTYKCiogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05l dHdvcmtKb2IuY3BwOgooV2ViQ29yZSk6CihXZWJDb3JlOjppc0FwcGVuZGFibGVIZWFkZXIpOgot LS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxMyArKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdv cmtKb2IuY3BwICAgICB8ICAgIDQgKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5NTk2MDYxLi43ZTQ5ZTIxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDEtMTggIEpvZSBNYXNvbiAgPGptYXNvbkBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBmaXggY29tcGlsZSB3YXJuaW5ncyBpbiBO ZXR3b3JrSm9iCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDcyOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbnRlcm5hbCBQUjogMjgzMDk2CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNv cmU6OmlzQXBwZW5kYWJsZUhlYWRlcik6CisKIDIwMTMtMDEtMTcgIEpvZSBNYXNvbiAgPGptYXNv bkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBPbmx5IGNsZWFyIGNyZWRlbnRpYWxz IHdoZW4gcHVyZ2VDcmVkZW50aWFscyBpcyBjYWxsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCA0 M2IwNzhmLi5mMTBjY2U2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC02Myw3ICs2Myw3IEBAIGlu bGluZSBzdGF0aWMgYm9vbCBpc1VuYXV0aG9yaXplZChpbnQgc3RhdHVzQ29kZSkKICAgICByZXR1 cm4gc3RhdHVzQ29kZSA9PSA0MDE7CiB9CiAKLXN0YXRpYyBjaGFyKiBjb25zdCBhcHBlbmRhYmxl SGVhZGVyc1tdID0geyJhY2Nlc3MtY29udHJvbC1hbGxvdy1vcmlnaW4iLCAiYWxsb3ciLAorc3Rh dGljIGNvbnN0IGNoYXIqIGNvbnN0IGFwcGVuZGFibGVIZWFkZXJzW10gPSB7ImFjY2Vzcy1jb250 cm9sLWFsbG93LW9yaWdpbiIsICJhbGxvdyIsCiAgICAgInNldC1jb29raWUiLCAic2V0LWNvb2tp ZTIiLCAidmFyeSIsICJ2aWEiLCAid2FybmluZyJ9OwogCiBzdGF0aWMgYm9vbCBpc0FwcGVuZGFi bGVIZWFkZXIoY29uc3QgU3RyaW5nJiBrZXkpCkBAIC03Miw3ICs3Miw3IEBAIHN0YXRpYyBib29s IGlzQXBwZW5kYWJsZUhlYWRlcihjb25zdCBTdHJpbmcmIGtleSkKICAgICBpZiAoa2V5LnN0YXJ0 c1dpdGgoIngtIikpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgZm9yIChpbnQgaSA9IDA7 IGkgPCBzaXplb2YoYXBwZW5kYWJsZUhlYWRlcnMpIC9zaXplb2YoY2hhciopOyBpKyspCisgICAg Zm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaXplb2YoYXBwZW5kYWJsZUhlYWRlcnMpIC9zaXplb2Yo Y2hhciopOyBpKyspCiAgICAgICAgIGlmIChrZXkgPT0gYXBwZW5kYWJsZUhlYWRlcnNbaV0pCiAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKIAotLSAKMS43LjUuNAoK