107291 2013-01-18 09:05:00 -0800 Web Inspector: data grid resize is slow 2013-01-21 08:09:23 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 810674 0 caseq 2013-01-18 09:05:00 -0800 0. Open inspector 1. Switch to network panel (or Resources -> Cookies) 2. Quickly drag a resizer in the table 3. Observe update lags considerably 810681 1 183475 caseq 2013-01-18 09:07:20 -0800 Created attachment 183475 Patch 811849 2 183475 pfeldman 2013-01-20 23:22:42 -0800 Comment on attachment 183475 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183475&action=review > Source/WebCore/inspector/front-end/DataGrid.js:688 > + resizer._position = left; Resizers are cached and I don't see where this property is reset. Do you want to split this loop into two loops? First would measure, second would apply. 811915 3 183475 caseq 2013-01-21 00:54:29 -0800 Comment on attachment 183475 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183475&action=review >> Source/WebCore/inspector/front-end/DataGrid.js:688 >> + resizer._position = left; > > Resizers are cached and I don't see where this property is reset. Do you want to split this loop into two loops? First would measure, second would apply. Why would we have to reset this property? It just mirrors resize.style.left, so its life time is meant to match the life time of resizer. 812164 4 caseq 2013-01-21 08:09:23 -0800 Committed r140335: <http://trac.webkit.org/changeset/140335> 183475 2013-01-18 09:07:20 -0800 2013-01-21 01:36:13 -0800 Patch bug-107291-20130118210418.patch text/plain 3101 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRiZTViMDFlNzRiZWFm ZDhkNGIwODRkM2RhZmE4ODNiZTg2ZTQ3Yy4uNWUwYzVmZjFiMDdjZGFkNjcwMDQ3ZTQwMTg0M2Fk OWFlZjZkYzU2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTE4ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogZGF0YSBncmlkIHJlc2l6ZSBpcyBzbG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcyOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAtIGF2b2lkIChtb3N0IG9mKSB1bm5lY2Vzc2FyeSByZWxheW91 dHMgYW5kIHN0eWxlIHJlY2FsY3VsYXRpb24gd2hlbiBkcmFnZ2luZyBkYXRhIGdyaWQgcmVzaXpl ci4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlLl9wb3NpdGlvblJlc2l6ZXJzKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuX3Jlc2l6ZXJEcmFnZ2luZyk6 CisKIDIwMTMtMDEtMTcgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIGNyZWF0ZU9wdGlvbiBtZXRob2QgdG8gV2ViSW5z cGVjdG9yLlN0YXR1c0JhckNvbWJvQm94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9EYXRhR3JpZC5qcwppbmRleCBlNTc0ZDhkYjUyZjc3MzFhOTZiNjU3NzAyYmZkZDlm MWFjZTIxMzk1Li5jOWIzYmYzMjVkZjY1N2I1ZThkZTBhNzdiOTU4ZWQ4ZmM5MzA2ZjIyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanMKQEAgLTY4 NCw3ICs2ODQsMTAgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZSA9IHsKIAogICAg ICAgICAgICAgaWYgKCF0aGlzLl9jb2x1bW5zQXJyYXlbaV0uaGlkZGVuKSB7CiAgICAgICAgICAg ICAgICAgcmVzaXplci5zdHlsZS5yZW1vdmVQcm9wZXJ0eSgiZGlzcGxheSIpOwotICAgICAgICAg ICAgICAgIHJlc2l6ZXIuc3R5bGUubGVmdCA9IGxlZnQgKyAicHgiOworICAgICAgICAgICAgICAg IGlmIChyZXNpemVyLl9wb3NpdGlvbiAhPT0gbGVmdCkgeworICAgICAgICAgICAgICAgICAgICBy ZXNpemVyLl9wb3NpdGlvbiA9IGxlZnQ7CisgICAgICAgICAgICAgICAgICAgIHJlc2l6ZXIuc3R5 bGUubGVmdCA9IGxlZnQgKyAicHgiOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAg ICByZXNpemVyLmxlZnROZWlnaGJvcmluZ0NvbHVtbkluZGV4ID0gaTsKICAgICAgICAgICAgICAg ICBpZiAocHJldmlvdXNSZXNpemVyKQogICAgICAgICAgICAgICAgICAgICBwcmV2aW91c1Jlc2l6 ZXIucmlnaHROZWlnaGJvcmluZ0NvbHVtbkluZGV4ID0gaTsKQEAgLTk3NCw2ICs5NzcsOCBAQCBX ZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlID0gewogICAgICAgICBpZiAoIXJlc2l6ZXIp CiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgdmFyIHRhYmxlV2lkdGggPSB0aGlzLl9k YXRhVGFibGUub2Zmc2V0V2lkdGg7IC8vIENhY2hlIGl0IGVhcmx5LCBiZWZvcmUgd2UgaW52YWxp ZGF0ZSBsYXlvdXQuCisKICAgICAgICAgLy8gQ29uc3RyYWluIHRoZSBkcmFncG9pbnQgdG8gYmUg d2l0aGluIHRoZSBjb250YWluaW5nIGRpdiBvZiB0aGUKICAgICAgICAgLy8gZGF0YWdyaWQuCiAg ICAgICAgIHZhciBkcmFnUG9pbnQgPSBldmVudC5jbGllbnRYIC0gdGhpcy5lbGVtZW50LnRvdGFs T2Zmc2V0TGVmdCgpOwpAQCAtMTAwNCwxMSArMTAwOSwxMSBAQCBXZWJJbnNwZWN0b3IuRGF0YUdy aWQucHJvdG90eXBlID0gewogCiAgICAgICAgIHJlc2l6ZXIuc3R5bGUubGVmdCA9IChkcmFnUG9p bnQgLSB0aGlzLkNlbnRlclJlc2l6ZXJPdmVyQm9yZGVyQWRqdXN0bWVudCkgKyAicHgiOwogCi0g ICAgICAgIHZhciBwZXJjZW50TGVmdENvbHVtbiA9ICgoKGRyYWdQb2ludCAtIGxlZnRFZGdlT2ZQ cmV2aW91c0NvbHVtbikgLyB0aGlzLl9kYXRhVGFibGUub2Zmc2V0V2lkdGgpICogMTAwKSArICIl IjsKKyAgICAgICAgdmFyIHBlcmNlbnRMZWZ0Q29sdW1uID0gKCgoZHJhZ1BvaW50IC0gbGVmdEVk Z2VPZlByZXZpb3VzQ29sdW1uKSAvIHRhYmxlV2lkdGgpICogMTAwKSArICIlIjsKICAgICAgICAg dGhpcy5faGVhZGVyVGFibGVDb2x1bW5Hcm91cC5jaGlsZHJlbltsZWZ0Q2VsbEluZGV4XS5zdHls ZS53aWR0aCA9IHBlcmNlbnRMZWZ0Q29sdW1uOwogICAgICAgICB0aGlzLl9kYXRhVGFibGVDb2x1 bW5Hcm91cC5jaGlsZHJlbltsZWZ0Q2VsbEluZGV4XS5zdHlsZS53aWR0aCA9IHBlcmNlbnRMZWZ0 Q29sdW1uOwogCi0gICAgICAgIHZhciBwZXJjZW50UmlnaHRDb2x1bW4gPSAoKChyaWdodEVkZ2VP Zk5leHRDb2x1bW4gLSBkcmFnUG9pbnQpIC8gdGhpcy5fZGF0YVRhYmxlLm9mZnNldFdpZHRoKSAq IDEwMCkgKyAiJSI7CisgICAgICAgIHZhciBwZXJjZW50UmlnaHRDb2x1bW4gPSAoKChyaWdodEVk Z2VPZk5leHRDb2x1bW4gLSBkcmFnUG9pbnQpIC8gdGFibGVXaWR0aCkgKiAxMDApICsgIiUiOwog ICAgICAgICB0aGlzLl9oZWFkZXJUYWJsZUNvbHVtbkdyb3VwLmNoaWxkcmVuW3JpZ2h0Q2VsbElu ZGV4XS5zdHlsZS53aWR0aCA9ICBwZXJjZW50UmlnaHRDb2x1bW47CiAgICAgICAgIHRoaXMuX2Rh dGFUYWJsZUNvbHVtbkdyb3VwLmNoaWxkcmVuW3JpZ2h0Q2VsbEluZGV4XS5zdHlsZS53aWR0aCA9 IHBlcmNlbnRSaWdodENvbHVtbjsKIAo=