107282 2013-01-18 07:37:09 -0800 Web Inspector: change HeapSnapshotLoader to allow loading native heap snapshots 2013-01-20 23:52:23 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 107254 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 810587 0 yurys 2013-01-18 07:37:09 -0800 HeapSnapshotLoader currently always creates JSHeapSnapshot but the snapshot type can be passed as parameter to support native heap snapshots. 810591 1 183455 yurys 2013-01-18 07:41:21 -0800 Created attachment 183455 Patch 810613 2 183455 loislo 2013-01-18 08:06:09 -0800 Comment on attachment 183455 Patch lgtm 811877 3 183455 webkit.review.bot 2013-01-20 23:52:19 -0800 Comment on attachment 183455 Patch Clearing flags on attachment: 183455 Committed r140306: <http://trac.webkit.org/changeset/140306> 811878 4 webkit.review.bot 2013-01-20 23:52:23 -0800 All reviewed patches have been landed. Closing bug. 183455 2013-01-18 07:41:21 -0800 2013-01-20 23:52:19 -0800 Patch bug-107282-20130118193819.patch text/plain 6932 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTMyMzhiZjk1YjhhY2Uw MDI4YTQ4NWVjYWM3YjBlYjllMTg2YzFlNi4uMTM3ZmU3OWFiNTU3ZTY3ZWU5Yjk0ODM2NmQ3MWEx NmExNGMxMTQ1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTAxLTE4ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGNoYW5nZSBIZWFwU25hcHNob3RMb2FkZXIgdG8gYWxsb3cgbG9hZGluZyBuYXRpdmUgaGVh cCBzbmFwc2hvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNzI4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbmN0ZXRlIGhlYXAgc25hcHNob3QgY29uc3RydWN0b3IgbmFtZSBpcyBwYXNzZWQgYXMg YSBwYXJhbWV0ZXIgdG8gSGVhcFNuYXBzaG90TG9hZGVyUHJveHkgYW5kCisgICAgICAgIHByb3Bh Z2F0ZWQgdG8gSGVhcFNuYXBzaG90TG9hZGVyLmJ1aWxkU25hcHNob3QgdG8gc3VwcG9ydCBkaWZm ZXJlbnQgdHlwZXMgb2YgaGVhcCBzbmFwc2hvdHMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL0hlYXBTbmFwc2hvdExvYWRlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3RMb2FkZXIucHJvdG90eXBlLmJ1aWxkU25hcHNob3QpOgorICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90UHJveHkuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuSGVhcFNuYXBzaG90V29ya2VyLnByb3RvdHlwZS5jcmVhdGVMb2FkZXIpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdExvYWRlclByb3h5KToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5IZWFwU25hcHNob3RMb2FkZXJQcm94eS5wcm90b3R5cGUuY2xvc2UpOgorICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5IZWFwUHJvZmlsZUhlYWRlci5wcm90b3R5cGUuX3NldHVwV29ya2VyKToKKworMjAx My0wMS0xOCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKwogICAgICAg ICBXZWIgSW5zcGVjdG9yOiByZW1vdmUgZGVhZCBjb2RlIGZyb20gaGVhcCBwcm9maWxlciBmcm9u dC1lbmQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NzI2NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hl YXBTbmFwc2hvdExvYWRlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv SGVhcFNuYXBzaG90TG9hZGVyLmpzCmluZGV4IDA1OGM4YTQ2MGE3M2ExZjA3YjgxOGM5MDFjNGQ2 ODc5ZDhlMDFhZTQuLjEyY2Y4ZmU5Njk3MWFjOGNlMmQ2NTIyZjM4ZTAyMDBkMDQ5MTBjNjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90 TG9hZGVyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNu YXBzaG90TG9hZGVyLmpzCkBAIC01Niw5ICs1NiwxMCBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBz aG90TG9hZGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuX3BhcnNlU3RyaW5nc0Fy cmF5KCk7CiAgICAgfSwKIAotICAgIGJ1aWxkU25hcHNob3Q6IGZ1bmN0aW9uKCkKKyAgICBidWls ZFNuYXBzaG90OiBmdW5jdGlvbihjb25zdHJ1Y3Rvck5hbWUpCiAgICAgewotICAgICAgICB2YXIg cmVzdWx0ID0gbmV3IFdlYkluc3BlY3Rvci5KU0hlYXBTbmFwc2hvdCh0aGlzLl9zbmFwc2hvdCk7 CisgICAgICAgIHZhciBjb25zdHJ1Y3RvciA9IFdlYkluc3BlY3Rvcltjb25zdHJ1Y3Rvck5hbWVd OworICAgICAgICB2YXIgcmVzdWx0ID0gbmV3IGNvbnN0cnVjdG9yKHRoaXMuX3NuYXBzaG90KTsK ICAgICAgICAgdGhpcy5fcmVzZXQoKTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9LApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNo b3RQcm94eS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBz aG90UHJveHkuanMKaW5kZXggOTVmMjBjODA0M2UyMjg4OTI5NTQ4YzFlMGU2ZjdlZGY4ODU5ZmJm Mi4uYzhiNDk5YWUxMDQ1NTljOWY4MTVkNDcwZjE0MTI3ZjE4MDE1MTY0NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RQcm94eS5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFByb3h5 LmpzCkBAIC0xODgsMTIgKzE4OCwxMSBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90V29ya2Vy ID0gZnVuY3Rpb24oKQogfQogCiBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90V29ya2VyLnByb3Rv dHlwZSA9IHsKLSAgICBjcmVhdGVPYmplY3Q6IGZ1bmN0aW9uKGNvbnN0cnVjdG9yTmFtZSkKKyAg ICBjcmVhdGVMb2FkZXI6IGZ1bmN0aW9uKHNuYXBzaG90Q29uc3RydWN0b3JOYW1lKQogICAgIHsK LSAgICAgICAgdmFyIHByb3h5Q29uc3RydWN0b3JGdW5jdGlvbiA9IHRoaXMuX2ZpbmRGdW5jdGlv bihjb25zdHJ1Y3Rvck5hbWUgKyAiUHJveHkiKTsKICAgICAgICAgdmFyIG9iamVjdElkID0gdGhp cy5fbmV4dE9iamVjdElkKys7Ci0gICAgICAgIHZhciBwcm94eSA9IG5ldyBwcm94eUNvbnN0cnVj dG9yRnVuY3Rpb24odGhpcywgb2JqZWN0SWQpOwotICAgICAgICB0aGlzLl9wb3N0TWVzc2FnZSh7 Y2FsbElkOiB0aGlzLl9uZXh0Q2FsbElkKyssIGRpc3Bvc2l0aW9uOiAiY3JlYXRlIiwgb2JqZWN0 SWQ6IG9iamVjdElkLCBtZXRob2ROYW1lOiBjb25zdHJ1Y3Rvck5hbWV9KTsKKyAgICAgICAgdmFy IHByb3h5ID0gbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RMb2FkZXJQcm94eSh0aGlzLCBv YmplY3RJZCwgc25hcHNob3RDb25zdHJ1Y3Rvck5hbWUpOworICAgICAgICB0aGlzLl9wb3N0TWVz c2FnZSh7Y2FsbElkOiB0aGlzLl9uZXh0Q2FsbElkKyssIGRpc3Bvc2l0aW9uOiAiY3JlYXRlIiwg b2JqZWN0SWQ6IG9iamVjdElkLCBtZXRob2ROYW1lOiAiV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hv dExvYWRlciJ9KTsKICAgICAgICAgcmV0dXJuIHByb3h5OwogICAgIH0sCiAKQEAgLTM2MCw5ICsz NTksMTAgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFByb3h5T2JqZWN0LnByb3RvdHlwZSA9 IHsKICAqIEBleHRlbmRzIHtXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90UHJveHlPYmplY3R9CiAg KiBAaW1wbGVtZW50cyB7V2ViSW5zcGVjdG9yLk91dHB1dFN0cmVhbX0KICAqLwotV2ViSW5zcGVj dG9yLkhlYXBTbmFwc2hvdExvYWRlclByb3h5ID0gZnVuY3Rpb24od29ya2VyLCBvYmplY3RJZCkK K1dlYkluc3BlY3Rvci5IZWFwU25hcHNob3RMb2FkZXJQcm94eSA9IGZ1bmN0aW9uKHdvcmtlciwg b2JqZWN0SWQsIHNuYXBzaG90Q29uc3RydWN0b3JOYW1lKQogewogICAgIFdlYkluc3BlY3Rvci5I ZWFwU25hcHNob3RQcm94eU9iamVjdC5jYWxsKHRoaXMsIHdvcmtlciwgb2JqZWN0SWQpOworICAg IHRoaXMuX3NuYXBzaG90Q29uc3RydWN0b3JOYW1lID0gc25hcHNob3RDb25zdHJ1Y3Rvck5hbWU7 CiAgICAgdGhpcy5fcGVuZGluZ1NuYXBzaG90Q29uc3VtZXJzID0gW107CiB9CiAKQEAgLTM4OCw3 ICszODgsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90TG9hZGVyUHJveHkucHJvdG90eXBl ID0gewogICAgIHsKICAgICAgICAgZnVuY3Rpb24gYnVpbGRTbmFwc2hvdCgpCiAgICAgICAgIHsK LSAgICAgICAgICAgIHRoaXMuY2FsbEZhY3RvcnlNZXRob2QodXBkYXRlU3RhdGljRGF0YS5iaW5k KHRoaXMpLCAiYnVpbGRTbmFwc2hvdCIsICJXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90UHJveHki KTsKKyAgICAgICAgICAgIHRoaXMuY2FsbEZhY3RvcnlNZXRob2QodXBkYXRlU3RhdGljRGF0YS5i aW5kKHRoaXMpLCAiYnVpbGRTbmFwc2hvdCIsICJXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90UHJv eHkiLCB0aGlzLl9zbmFwc2hvdENvbnN0cnVjdG9yTmFtZSk7CiAgICAgICAgIH0KICAgICAgICAg ZnVuY3Rpb24gdXBkYXRlU3RhdGljRGF0YShzbmFwc2hvdFByb3h5KQogICAgICAgICB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZp ZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZp ZXcuanMKaW5kZXggNmFhYTY0YTlhYWQxZTI1NThmYTFlNGVjMzMzMjMzMmNjMDkxZWVlOS4uN2M3 Mjk1NjM0MGQ2NjE4MzM5Y2Q2MjY4OGE5ZWQ0ZWY5MTYyODIxYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qcwpAQCAt ODczLDcgKzg3Myw3IEBAIFdlYkluc3BlY3Rvci5IZWFwUHJvZmlsZUhlYWRlci5wcm90b3R5cGUg PSB7CiAgICAgICAgIH0KICAgICAgICAgdmFyIHdvcmtlciA9IG5ldyBXZWJJbnNwZWN0b3IuSGVh cFNuYXBzaG90V29ya2VyKCk7CiAgICAgICAgIHdvcmtlci5hZGRFdmVudExpc3RlbmVyKCJ3YWl0 Iiwgc2V0UHJvZmlsZVdhaXQsIHRoaXMpOwotICAgICAgICB2YXIgbG9hZGVyUHJveHkgPSB3b3Jr ZXIuY3JlYXRlT2JqZWN0KCJXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90TG9hZGVyIik7CisgICAg ICAgIHZhciBsb2FkZXJQcm94eSA9IHdvcmtlci5jcmVhdGVMb2FkZXIoIkpTSGVhcFNuYXBzaG90 Iik7CiAgICAgICAgIGxvYWRlclByb3h5LmFkZENvbnN1bWVyKHRoaXMuX3NuYXBzaG90UmVjZWl2 ZWQuYmluZCh0aGlzKSk7CiAgICAgICAgIHRoaXMuX3JlY2VpdmVyID0gbG9hZGVyUHJveHk7CiAg ICAgfSwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCA3MDdkMTE3MWYzMTg3NWY1NDdiMmFiN2FlZGQ0ZDkwNjRiMDdjNmEwLi4x ZTczZjNhZDFhMDNhOGM4MjE2YzhiMDVmNjczZDY3MmJiNmVhZjAxIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTUgQEAKKzIwMTMtMDEtMTggIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY2hhbmdlIEhlYXBTbmFwc2hvdExvYWRlciB0byBh bGxvdyBsb2FkaW5nIG5hdGl2ZSBoZWFwIHNuYXBzaG90cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MjgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29uY3RldGUgaGVhcCBzbmFwc2hvdCBjb25zdHJ1 Y3RvciBuYW1lIGlzIHBhc3NlZCBhcyBhIHBhcmFtZXRlciB0byBIZWFwU25hcHNob3RMb2FkZXJQ cm94eSBhbmQKKyAgICAgICAgcHJvcGFnYXRlZCB0byBIZWFwU25hcHNob3RMb2FkZXIuYnVpbGRT bmFwc2hvdCB0byBzdXBwb3J0IGRpZmZlcmVudCB0eXBlcyBvZiBoZWFwIHNuYXBzaG90cy4KKwor ICAgICAgICAqIGluc3BlY3Rvci9wcm9maWxlci9oZWFwLXNuYXBzaG90LWxvYWRlci5odG1sOgor CiAyMDEzLTAxLTE4ICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRl bC5jb20+CiAKICAgICAgICAgW0VGTF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcHJvZmlsZXIvaGVhcC1zbmFwc2hvdC1sb2FkZXIuaHRt bCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9wcm9maWxlci9oZWFwLXNuYXBzaG90LWxvYWRlci5o dG1sCmluZGV4IDZhZDZiMGRiM2Y3YzI4YzAxYzMwNWFlMTQwYzY2MDgwNjUwYjNlZjUuLjk0MGI2 NGJkMjY4MGYzMmJlNWUzMzllYmFjMjNiYzA1MjQ5ZTc0ZWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2luc3BlY3Rvci9wcm9maWxlci9oZWFwLXNuYXBzaG90LWxvYWRlci5odG1sCisrKyBiL0xh eW91dFRlc3RzL2luc3BlY3Rvci9wcm9maWxlci9oZWFwLXNuYXBzaG90LWxvYWRlci5odG1sCkBA IC01NSw3ICs1NSw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgZm9yICh2YXIgaSA9 IDAsIGwgPSBzb3VyY2VTdHJpbmdpZmllZC5sZW5ndGg7IGkgPCBsOyBpICs9IHBhcnRTaXplKQog ICAgICAgICAgICAgICAgIGxvYWRlci53cml0ZShzb3VyY2VTdHJpbmdpZmllZC5zbGljZShpLCBp ICsgcGFydFNpemUpKTsKICAgICAgICAgICAgIGxvYWRlci5jbG9zZSgpOwotICAgICAgICAgICAg dmFyIHJlc3VsdCA9IGxvYWRlci5idWlsZFNuYXBzaG90KCk7CisgICAgICAgICAgICB2YXIgcmVz dWx0ID0gbG9hZGVyLmJ1aWxkU25hcHNob3QoIkpTSGVhcFNuYXBzaG90Iik7CiAgICAgICAgICAg ICByZXN1bHQuX25vZGVzID0gbmV3IFVpbnQzMkFycmF5KHJlc3VsdC5fbm9kZXMpOwogICAgICAg ICAgICAgcmVzdWx0Ll9jb250YWlubWVudEVkZ2VzID0gbmV3IFVpbnQzMkFycmF5KHJlc3VsdC5f Y29udGFpbm1lbnRFZGdlcyk7CiAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydFNuYXBz aG90RXF1YWxzKG5ldyBXZWJJbnNwZWN0b3IuSlNIZWFwU25hcHNob3QoSW5zcGVjdG9yVGVzdC5j cmVhdGVIZWFwU25hcHNob3RNb2NrKCkpLCByZXN1bHQpOwo=