107273 2013-01-18 05:48:29 -0800 Web Inspector: refactor lineChunks in smth more meaningful in DTE 2013-01-23 07:36:57 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 810511 0 lushnikov 2013-01-18 05:48:29 -0800 Refactor lineChunks in smth more meaningful in DefaultTextEditor because this naming correlates to chunk panel notation in editor. 810515 1 183433 lushnikov 2013-01-18 05:51:41 -0800 Created attachment 183433 Patch 811855 2 183433 pfeldman 2013-01-20 23:32:32 -0800 Comment on attachment 183433 Patch You would need to rebase it to use cq+ for landing. 183433 2013-01-18 05:51:41 -0800 2013-01-23 07:36:57 -0800 Patch bug-107273-20130118174840.patch text/plain 7470 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTM2MGE5YjhkZmMxYTE0 ZDYwYTYyYzcwYjg1OTM2YjZiNjUyYzc2OS4uNWE4MmVjYjI2MmFkNGRjMjk4ZThmNTY3ZDFhZDUz NjJjMGE4MmY4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEzLTAxLTE4ICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5z cGVjdG9yOiByZWZhY3RvciBsaW5lQ2h1bmtzIGluIHNtdGggbW9yZSBtZWFuaW5nZnVsIGluIERU RQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3Mjcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmYWN0 b3IgbGluZUNodW5rcyBpbnRvIGxpbmVOdW1iZXJSYW5nZS4KKworICAgICAgICBObyBuZXcgdGVz dDogbm8gY2hhbmdlIGluIGJlaGF2aW91ci4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvRGVmYXVsdFRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRv ck1haW5QYW5lbC5wcm90b3R5cGUuX3NjaGVkdWxlUGFpbnRMaW5lcyk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUuX3BhaW50U2NoZWR1bGVkTGlu ZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBl Ll9wYWludExpbmVzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVs LnByb3RvdHlwZS5fcGFpbnRMaW5lTnVtYmVyUmFuZ2VzKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZS5fbWVhc3VyZU92ZXJsYXlIaWdobGlnaHQp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlLl9t ZWFzdXJlTGluZU51bWJlclJhbmdlc0ZvclJlZ2V4KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U ZXh0RWRpdG9yTWFpblBhbmVsLkxpbmVOdW1iZXJSYW5nZSk6CisKKzIwMTMtMDEtMTggIEFuZHJl eSBMdXNobmlrb3YgIDxsdXNobmlrb3ZAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IHNwZWVkdXAgaGlnaGxpZ2h0IHJlZ2V4IEFQSSBpbiBEZWZhdWx0VGV4dEVkaXRvcgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MjM4CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRl eHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRU ZXh0RWRpdG9yLmpzCmluZGV4IGNlYTgyZjFkYzUwYzQ5ODU5MmIyMmI0OTBmYjAxMjk0MGJhMWE4 MWYuLmM1Mjc5MjQ3NjAwMjM1ZmYzY2NkY2VjZDlmM2Q5ZmY1MThmYTcxOTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRv ci5qcwpAQCAtMTc5Nyw3ICsxNzk3LDcgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFu ZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmICghdGhp cy5fc2NoZWR1bGVkUGFpbnRMaW5lcykgewotICAgICAgICAgICAgdGhpcy5fc2NoZWR1bGVkUGFp bnRMaW5lcyA9IFt7IHN0YXJ0TGluZTogc3RhcnRMaW5lLCBlbmRMaW5lOiBlbmRMaW5lIH1dOwor ICAgICAgICAgICAgdGhpcy5fc2NoZWR1bGVkUGFpbnRMaW5lcyA9IFtuZXcgV2ViSW5zcGVjdG9y LlRleHRFZGl0b3JNYWluUGFuZWwuTGluZU51bWJlclJhbmdlKHN0YXJ0TGluZSwgZW5kTGluZSld OwogICAgICAgICAgICAgdGhpcy5fcGFpbnRTY2hlZHVsZWRMaW5lc1RpbWVyID0gc2V0VGltZW91 dCh0aGlzLl9wYWludFNjaGVkdWxlZExpbmVzLmJpbmQodGhpcyksIDApOwogICAgICAgICB9IGVs c2UgewogICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLl9zY2hlZHVsZWRQYWlu dExpbmVzLmxlbmd0aDsgKytpKSB7CkBAIC0xODA4LDExICsxODA4LDExIEBAIFdlYkluc3BlY3Rv ci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBpZiAoY2h1bmsuc3Rh cnRMaW5lID4gZW5kTGluZSkgewotICAgICAgICAgICAgICAgICAgICB0aGlzLl9zY2hlZHVsZWRQ YWludExpbmVzLnNwbGljZShpLCAwLCB7IHN0YXJ0TGluZTogc3RhcnRMaW5lLCBlbmRMaW5lOiBl bmRMaW5lIH0pOworICAgICAgICAgICAgICAgICAgICB0aGlzLl9zY2hlZHVsZWRQYWludExpbmVz LnNwbGljZShpLCAwLCBuZXcgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwuTGluZU51 bWJlclJhbmdlKHN0YXJ0TGluZSwgZW5kTGluZSkpOwogICAgICAgICAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQotICAgICAgICAgICAgdGhpcy5f c2NoZWR1bGVkUGFpbnRMaW5lcy5wdXNoKHsgc3RhcnRMaW5lOiBzdGFydExpbmUsIGVuZExpbmU6 IGVuZExpbmUgfSk7CisgICAgICAgICAgICB0aGlzLl9zY2hlZHVsZWRQYWludExpbmVzLnB1c2go bmV3IFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLkxpbmVOdW1iZXJSYW5nZShzdGFy dExpbmUsIGVuZExpbmUpKTsKICAgICAgICAgfQogICAgIH0sCiAKQEAgLTE4MzgsNyArMTgzOCw3 IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAg ICAgZGVsZXRlIHRoaXMuX3NjaGVkdWxlZFBhaW50TGluZXM7CiAKICAgICAgICAgdGhpcy5fcmVz dG9yZVBhaW50TGluZXNPcGVyYXRpb25zQ3JlZGl0KCk7Ci0gICAgICAgIHRoaXMuX3BhaW50TGlu ZUNodW5rcyhzY2hlZHVsZWRQYWludExpbmVzLCAhc2tpcFJlc3RvcmVTZWxlY3Rpb24pOworICAg ICAgICB0aGlzLl9wYWludExpbmVOdW1iZXJSYW5nZXMoc2NoZWR1bGVkUGFpbnRMaW5lcywgIXNr aXBSZXN0b3JlU2VsZWN0aW9uKTsKICAgICAgICAgdGhpcy5fYWRqdXN0UGFpbnRMaW5lc09wZXJh dGlvbnNSZWZyZXNoVmFsdWUoKTsKICAgICB9LAogCkBAIC0xODcwLDE1ICsxODcwLDE1IEBAIFdl Ykluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgKi8KICAg ICBfcGFpbnRMaW5lczogZnVuY3Rpb24oZnJvbUxpbmUsIHRvTGluZSwgcmVzdG9yZVNlbGVjdGlv bikKICAgICB7Ci0gICAgICAgIHRoaXMuX3BhaW50TGluZUNodW5rcyhbeyBzdGFydExpbmU6IGZy b21MaW5lLCBlbmRMaW5lOiB0b0xpbmUgfV0sIHJlc3RvcmVTZWxlY3Rpb24pOworICAgICAgICB0 aGlzLl9wYWludExpbmVOdW1iZXJSYW5nZXMoW25ldyBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1h aW5QYW5lbC5MaW5lTnVtYmVyUmFuZ2UoZnJvbUxpbmUsIHRvTGluZSldLCByZXN0b3JlU2VsZWN0 aW9uKTsKICAgICB9LAogCiAKICAgICAvKioKLSAgICAgKiBAcGFyYW0ge0FycmF5Ljx7c3RhcnRM aW5lOiBudW1iZXIsIGVuZExpbmU6IG51bWJlcn0+fSBsaW5lQ2h1bmtzCisgICAgICogQHBhcmFt IHtBcnJheS48V2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwuTGluZU51bWJlclJhbmdl Pn0gbGluZU51bWJlclJhbmdlcwogICAgICAqIEBwYXJhbSB7Ym9vbGVhbj19IHJlc3RvcmVTZWxl Y3Rpb24KICAgICAgKi8KLSAgICBfcGFpbnRMaW5lQ2h1bmtzOiBmdW5jdGlvbihsaW5lQ2h1bmtz LCByZXN0b3JlU2VsZWN0aW9uKQorICAgIF9wYWludExpbmVOdW1iZXJSYW5nZXM6IGZ1bmN0aW9u KGxpbmVOdW1iZXJSYW5nZXMsIHJlc3RvcmVTZWxlY3Rpb24pCiAgICAgewogICAgICAgICAvLyBG aXJzdCwgcGFpbnQgdmlzaWJsZSBsaW5lcywgc28gdGhhdCBpbiBjYXNlIG9mIGxvbmcgbGluZXMg d2Ugc2hvdWxkIHN0YXJ0IGhpZ2hsaWdodGluZwogICAgICAgICAvLyB0aGUgdmlzaWJsZSBhcmVh IGltbWVkaWF0ZWx5LCBpbnN0ZWFkIG9mIHdhaXRpbmcgZm9yIHRoZSBsaW5lcyBhYm92ZSB0aGUg dmlzaWJsZSBhcmVhLgpAQCAtMTg4OSwxMiArMTg4OSwxMiBAQCBXZWJJbnNwZWN0b3IuVGV4dEVk aXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmIChyZXN0b3JlU2VsZWN0aW9u KQogICAgICAgICAgICAgc2VsZWN0aW9uID0gdGhpcy5zZWxlY3Rpb24oKTsKIAotICAgICAgICB2 YXIgb3ZlcmxheUhpZ2hsaWdodCA9IHRoaXMuX21lYXN1cmVPdmVybGF5SGlnaGxpZ2h0KGxpbmVD aHVua3MpOworICAgICAgICB2YXIgb3ZlcmxheUhpZ2hsaWdodCA9IHRoaXMuX21lYXN1cmVPdmVy bGF5SGlnaGxpZ2h0KGxpbmVOdW1iZXJSYW5nZXMpOwogCiAgICAgICAgIHZhciBjaHVuazsKICAg ICAgICAgdmFyIGludmlzaWJsZUxpbmVSb3dzID0gW107Ci0gICAgICAgIGZvciAodmFyIGkgPSAw OyBpIDwgbGluZUNodW5rcy5sZW5ndGg7ICsraSkgewotICAgICAgICAgICAgdmFyIGxpbmVDaHVu ayA9IGxpbmVDaHVua3NbaV07CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbGluZU51bWJl clJhbmdlcy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgdmFyIGxpbmVDaHVuayA9IGxpbmVO dW1iZXJSYW5nZXNbaV07CiAgICAgICAgICAgICBpZiAodGhpcy5fc2NoZWR1bGVkUGFpbnRMaW5l cykgewogICAgICAgICAgICAgICAgIHRoaXMuX3NjaGVkdWxlUGFpbnRMaW5lcyhsaW5lQ2h1bmsu c3RhcnRMaW5lLCBsaW5lQ2h1bmsuZW5kTGluZSk7CiAgICAgICAgICAgICAgICAgY29udGludWU7 CkBAIC0xOTI2LDMyICsxOTI2LDMyIEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVs LnByb3RvdHlwZSA9IHsKICAgICB9LAogCiAgICAgLyoqCi0gICAgICogQHBhcmFtIHtBcnJheS48 e3N0YXJ0TGluZTogbnVtYmVyLCBlbmRMaW5lOiBudW1iZXJ9Pn0gbGluZUNodW5rcworICAgICAq IEBwYXJhbSB7QXJyYXkuPFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLkxpbmVOdW1i ZXJSYW5nZT59IGxpbmVOdW1iZXJSYW5nZXMKICAgICAgKiBAcmV0dXJuIHtBcnJheS48V2ViSW5z cGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwuUmVnZXhPdmVybGF5SGlnaGxpZ2h0Pn0KICAgICAg Ki8KLSAgICBfbWVhc3VyZU92ZXJsYXlIaWdobGlnaHQ6IGZ1bmN0aW9uKGxpbmVDaHVua3MpCisg ICAgX21lYXN1cmVPdmVybGF5SGlnaGxpZ2h0OiBmdW5jdGlvbihsaW5lTnVtYmVyUmFuZ2VzKQog ICAgIHsKICAgICAgICAgdmFyIG92ZXJsYXlIaWdobGlnaHQgPSBbXTsKICAgICAgICAgZm9yKHZh ciBrZXkgaW4gdGhpcy5faGlnaGxpZ2h0UmVnZXhzKSB7CiAgICAgICAgICAgICB2YXIgdmFsdWUg PSB0aGlzLl9oaWdobGlnaHRSZWdleHNba2V5XTsKLSAgICAgICAgICAgIHZhciBsaW5lQ2h1bmtz UmVnZXhNZXRyaWNzID0gdGhpcy5fbWVhc3VyZUxpbmVDaHVua3NGb3JSZWdleChsaW5lQ2h1bmtz LCB2YWx1ZS5yZWdleCk7CisgICAgICAgICAgICB2YXIgbGluZUNodW5rc1JlZ2V4TWV0cmljcyA9 IHRoaXMuX21lYXN1cmVMaW5lTnVtYmVyUmFuZ2VzRm9yUmVnZXgobGluZU51bWJlclJhbmdlcywg dmFsdWUucmVnZXgpOwogICAgICAgICAgICAgb3ZlcmxheUhpZ2hsaWdodC5wdXNoKG5ldyBXZWJJ bnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5SZWdleE92ZXJsYXlIaWdobGlnaHQobGluZUNo dW5rc1JlZ2V4TWV0cmljcywgdmFsdWUuY3NzQ2xhc3MpKTsKICAgICAgICAgfQogICAgICAgICBy ZXR1cm4gb3ZlcmxheUhpZ2hsaWdodDsKICAgICB9LAogCiAgICAgLyoqCi0gICAgICogQHBhcmFt IHtBcnJheS48e3N0YXJ0TGluZTogbnVtYmVyLCBlbmRMaW5lOiBudW1iZXJ9Pn0gbGluZUNodW5r cworICAgICAqIEBwYXJhbSB7QXJyYXkuPFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVs LkxpbmVOdW1iZXJSYW5nZT59IGxpbmVOdW1iZXJSYW5nZXMKICAgICAgKiBAcGFyYW0ge1JlZ0V4 cH0gcmVnZXgKICAgICAgKiBAcmV0dXJuIHtPYmplY3QuPFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y TWFpblBhbmVsLkxpbmVPdmVybGF5SGlnaGxpZ2h0TWV0cmljcz59CiAgICAgICovCi0gICAgX21l YXN1cmVMaW5lQ2h1bmtzRm9yUmVnZXg6IGZ1bmN0aW9uKGxpbmVDaHVua3MsIHJlZ2V4KQorICAg IF9tZWFzdXJlTGluZU51bWJlclJhbmdlc0ZvclJlZ2V4OiBmdW5jdGlvbihsaW5lTnVtYmVyUmFu Z2VzLCByZWdleCkKICAgICB7CiAgICAgICAgIHZhciBjaHVuazsKICAgICAgICAgdmFyIGxpbmVS b3dzVG9NZWFzdXJlID0gW107CiAgICAgICAgIHRoaXMuYmVnaW5Eb21VcGRhdGVzKCk7Ci0gICAg ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbGluZUNodW5rcy5sZW5ndGg7ICsraSkgewotICAgICAg ICAgICAgdmFyIGxpbmVDaHVuayA9IGxpbmVDaHVua3NbaV07CisgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgbGluZU51bWJlclJhbmdlcy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgdmFy IGxpbmVDaHVuayA9IGxpbmVOdW1iZXJSYW5nZXNbaV07CiAgICAgICAgICAgICBmb3IgKHZhciBs aW5lTnVtYmVyID0gbGluZUNodW5rLnN0YXJ0TGluZTsgbGluZU51bWJlciA8IGxpbmVDaHVuay5l bmRMaW5lOyArK2xpbmVOdW1iZXIpIHsKICAgICAgICAgICAgICAgICBpZiAoIWNodW5rIHx8IGxp bmVOdW1iZXIgPCBjaHVuay5zdGFydExpbmUgfHwgbGluZU51bWJlciA+PSBjaHVuay5zdGFydExp bmUgKyBjaHVuay5saW5lc0NvdW50KQogICAgICAgICAgICAgICAgICAgICBjaHVuayA9IHRoaXMu Y2h1bmtGb3JMaW5lKGxpbmVOdW1iZXIpOwpAQCAtMzA1MCw2ICszMDUwLDE3IEBAIFdlYkluc3Bl Y3Rvci5UZXh0RWRpdG9yTWFpbkNodW5rLnByb3RvdHlwZSA9IHsKIAogLyoqCiAgKiBAY29uc3Ry dWN0b3IKKyAqIEBwYXJhbSB7bnVtYmVyfSBzdGFydExpbmUKKyAqIEBwYXJhbSB7bnVtYmVyfSBl bmRMaW5lCisgKi8KK1dlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLkxpbmVOdW1iZXJS YW5nZSA9IGZ1bmN0aW9uKHN0YXJ0TGluZSwgZW5kTGluZSkKK3sKKyAgICB0aGlzLnN0YXJ0TGlu ZSA9IHN0YXJ0TGluZTsKKyAgICB0aGlzLmVuZExpbmUgPSBlbmRMaW5lOworfQorCisvKioKKyAq IEBjb25zdHJ1Y3RvcgogICogQHBhcmFtIHtFbGVtZW50fSBlbGVtZW50CiAgKi8KIFdlYkluc3Bl Y3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLkVsZW1lbnRNZXRyaWNzID0gZnVuY3Rpb24oZWxlbWVu dCkK