107251 2013-01-18 02:43:40 -0800 [mac] DRT and WKTR should disable NSBeep 2013-09-03 15:09:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 120652 1 thorton thorton darin simon.fraser oldest_to_newest 810413 0 thorton 2013-01-18 02:43:40 -0800 We can't test NSBeep, and we don't, and it's annoying when running layout tests locally, so we should turn it off! 810426 1 183418 thorton 2013-01-18 03:02:26 -0800 Created attachment 183418 meh patch 810661 2 simon.fraser 2013-01-18 08:55:50 -0800 I don't think we're trying to test NSBeep. I think we get NSBeep when some actions are not handled, no? I thought we overrode some NSResponder methods in a few places to avoid beeping. 810726 3 thorton 2013-01-18 09:42:12 -0800 (In reply to comment #2) > I don't think we're trying to test NSBeep. I was joking poorly. > I think we get NSBeep when some actions are not handled, no? I thought we overrode some NSResponder methods in a few places to avoid beeping. But we also call it ourselves in a bunch of places (see WebCore::systemBeep())! Those aren't prevented. 810890 4 thorton 2013-01-18 11:35:36 -0800 http://trac.webkit.org/changeset/140188 811323 5 ap 2013-01-18 23:37:22 -0800 FWIW, we use a different technique to shut up plug-ins when snapshotting, and it doesn't involve SPIs: static void muteAudio(void) { AudioObjectPropertyAddress propertyAddress = { kAudioHardwarePropertyProcessIsAudible, kAudioObjectPropertyScopeGlobal, kAudioObjectPropertyElementMaster }; UInt32 propertyData = 0; OSStatus result = AudioObjectSetPropertyData(kAudioObjectSystemObject, &propertyAddress, 0, 0, sizeof(UInt32), &propertyData); ASSERT_UNUSED(result, result == noErr); } 817460 6 thorton 2013-01-27 18:23:59 -0800 This... didn't work. It covered some cases, but not all of them. Maybe I should do Alexey's thing instead. 888617 7 darin 2013-05-13 18:08:31 -0700 Cleared the review flag so this doesn’t show up as “reviewed but not landed”. 924194 8 ap 2013-09-03 15:09:08 -0700 I didn't realize that this bug was still open, so I fixed the remaining case in bug 120652 (at least some of them, but hopefully all that remained). We probably don't want to disable all audio, as we need to test WebAudio. 183418 2013-01-18 03:02:26 -0800 2013-05-13 18:08:10 -0700 meh patch disable-beep.diff text/plain 2435 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMzg0 MTJiLi5mZGE0YWY2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMTggIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY10gRFJUIGFuZCBXS1RSIHNob3VsZCBk aXNhYmxlIE5TQmVlcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA3MjUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRGlzYWJsZSBOU0JlZXAgaW4gRHVtcFJlbmRlclRyZWUgYW5kIFdlYktpdFRlc3RSdW5u ZXIgdXNpbmcgTlNTb3VuZCBTUEkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVt cFJlbmRlclRyZWUubW06CisgICAgICAgIChkdW1wUmVuZGVyVHJlZSk6CisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9tYWMvSW5qZWN0ZWRCdW5kbGVNYWMubW06Cisg ICAgICAgIChXVFI6OkluamVjdGVkQnVuZGxlOjpwbGF0Zm9ybUluaXRpYWxpemUpOgorCiAyMDEz LTAxLTE3ICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAg ICAgW0JsYWNrQmVycnldIERSVCAtIEFjY2VwdCBodHRwL2ZpbGUgVVJMIHdoZW4gcnVubmluZyBk cnQtbGF1bmNoZXIgZnJvbSBjb21tYW5kIGxpbmUKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbSBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9E dW1wUmVuZGVyVHJlZS5tbQppbmRleCBmMWFiYzEwLi5mYjlkZjJlIDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KKysrIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCkBAIC0xMTAsNiArMTEwLDEwIEBAIHVzaW5n IG5hbWVzcGFjZSBzdGQ7CiArKHZvaWQpc2V0QWxsb3dzQW55SFRUUFNDZXJ0aWZpY2F0ZTooQk9P TClhbGxvdyBmb3JIb3N0OihOU1N0cmluZyAqKWhvc3Q7CiBAZW5kCiAKK0BpbnRlcmZhY2UgTlNT b3VuZCAoRGV0YWlscykKKysgKHZvaWQpX3NldEFsZXJ0VHlwZTooTlNVSW50ZWdlcilhbGVydFR5 cGU7CitAZW5kCisKIHN0YXRpYyB2b2lkIHJ1blRlc3QoY29uc3Qgc3RyaW5nJiB0ZXN0UGF0aE9y VVJMKTsKIAogLy8gRGVjaWRpbmcgd2hlbiBpdCdzIE9LIHRvIGR1bXAgb3V0IHRoZSBzdGF0ZSBp cyBhIGJpdCB0cmlja3kuICBBbGwgdGhlc2UgbXVzdCBiZSB0cnVlOgpAQCAtODczLDYgKzg3Nyw4 IEBAIHZvaWQgZHVtcFJlbmRlclRyZWUoaW50IGFyZ2MsIGNvbnN0IGNoYXIgKmFyZ3ZbXSkKICAg ICBpZiAoZm9yY2VDb21wbGV4VGV4dCkKICAgICAgICAgW1dlYlZpZXcgX3NldEFsd2F5c1VzZXND b21wbGV4VGV4dENvZGVQYXRoOllFU107CiAKKyAgICBbTlNTb3VuZCBfc2V0QWxlcnRUeXBlOjBd OworCiAgICAgV2ViVmlldyAqd2ViVmlldyA9IGNyZWF0ZVdlYlZpZXdBbmRPZmZzY3JlZW5XaW5k b3coKTsKICAgICBtYWluRnJhbWUgPSBbd2ViVmlldyBtYWluRnJhbWVdOwogCmRpZmYgLS1naXQg YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL21hYy9JbmplY3RlZEJ1bmRs ZU1hYy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvbWFjL0luamVj dGVkQnVuZGxlTWFjLm1tCmluZGV4IGI4Y2QwYzMuLjFhZDE5YWUgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvbWFjL0luamVjdGVkQnVuZGxlTWFjLm1t CisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvbWFjL0luamVjdGVk QnVuZGxlTWFjLm1tCkBAIC0zMSw2ICszMSw5IEBACiArKHZvaWQpc2V0QWxsb3dzQW55SFRUUFND ZXJ0aWZpY2F0ZTooQk9PTClhbGxvdyBmb3JIb3N0OihOU1N0cmluZyAqKWhvc3Q7CiBAZW5kCiAK K0BpbnRlcmZhY2UgTlNTb3VuZCAoRGV0YWlscykKKysgKHZvaWQpX3NldEFsZXJ0VHlwZTooTlNV SW50ZWdlcilhbGVydFR5cGU7CitAZW5kCiAKIG5hbWVzcGFjZSBXVFIgewogCkBAIC01Niw2ICs1 OSw4IEBAIHZvaWQgSW5qZWN0ZWRCdW5kbGU6OnBsYXRmb3JtSW5pdGlhbGl6ZShXS1R5cGVSZWYp CiAKICAgICBbTlNVUkxSZXF1ZXN0IHNldEFsbG93c0FueUhUVFBTQ2VydGlmaWNhdGU6WUVTIGZv ckhvc3Q6QCJsb2NhbGhvc3QiXTsKICAgICBbTlNVUkxSZXF1ZXN0IHNldEFsbG93c0FueUhUVFBT Q2VydGlmaWNhdGU6WUVTIGZvckhvc3Q6QCIxMjcuMC4wLjEiXTsKKworICAgIFtOU1NvdW5kIF9z ZXRBbGVydFR5cGU6MF07CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdUUgo=