107245 2013-01-18 02:08:39 -0800 [V8] Remove custom V8ScriptProfileNodeCustom::toV8() 2013-01-18 11:16:04 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth gyuyoung.kim japhet rakuco webkit.review.bot oldest_to_newest 810392 0 haraken 2013-01-18 02:08:39 -0800 V8ScriptProfileNodeCustom::toV8() needs not to be custom. Furthermore, the current custom toV8() is wrong in that it doesn't use a creationContext and it doesn't set a wrapper class id. This is one of steps to avoiding ASSERT()s that will be added in https://bugs.webkit.org/show_bug.cgi?id=107137 . 810393 1 183409 haraken 2013-01-18 02:10:16 -0800 Created attachment 183409 Patch 810860 2 183409 webkit.review.bot 2013-01-18 11:15:59 -0800 Comment on attachment 183409 Patch Clearing flags on attachment: 183409 Committed r140185: <http://trac.webkit.org/changeset/140185> 810861 3 webkit.review.bot 2013-01-18 11:16:04 -0800 All reviewed patches have been landed. Closing bug. 183409 2013-01-18 02:10:16 -0800 2013-01-18 11:15:58 -0800 Patch bug-107245-20130118110715.patch text/plain 5880 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWViYzhkYzY2NGU1ZGYw OTE2OWVkZGM0MTFhZGQzN2QxYjI3NGQzNS4uNDcwYmI1NzZmNjU4MmE0ZjJkMzVjNTk1NjYxMWQ2 YWIyZThhY2ZkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTE4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBj dXN0b20gVjhTY3JpcHRQcm9maWxlTm9kZUN1c3RvbTo6dG9WOCgpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcyNDUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBWOFNjcmlwdFByb2ZpbGVOb2RlQ3VzdG9t Ojp0b1Y4KCkgbmVlZHMgbm90IHRvIGJlIGN1c3RvbS4KKyAgICAgICAgRnVydGhlcm1vcmUsIHRo ZSBjdXJyZW50IGN1c3RvbSB0b1Y4KCkgaXMgd3JvbmcgaW4gdGhhdAorICAgICAgICBpdCBkb2Vz bid0IHVzZSBhIGNyZWF0aW9uQ29udGV4dCBhbmQgaXQgZG9lc24ndCBzZXQgYSB3cmFwcGVyCisg ICAgICAgIGNsYXNzIGlkLiBUaGlzIGlzIG9uZSBvZiBzdGVwcyB0byBhdm9pZGluZyBBU1NFUlQo KXMKKyAgICAgICAgdGhhdCB3aWxsIGJlIGFkZGVkIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDcxMzcgLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2Ug aW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBVc2VWOC5jbWFrZToKKyAgICAgICAgKiBXZWJDb3Jl Lmd5cGk6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4U2NyaXB0UHJvZmlsZU5vZGVD dXN0b20uY3BwOiBSZW1vdmVkLgorICAgICAgICAqIGluc3BlY3Rvci9TY3JpcHRQcm9maWxlTm9k ZS5pZGw6CisKIDIwMTMtMDEtMTggIFZpdmVrIEdhbGF0YWdlICA8dml2ZWsudmdAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2VhcmNoIHNob3J0Y3V0IGNsZWFycyB0aGUg Y3VycmVudCBzZWFyY2ggYm94IGNvbnRlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9V c2VWOC5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1VzZVY4LmNtYWtlCmluZGV4IDY3ZDczZTMxNGRj MTIxYmY4N2U3ODFiM2FmOTg1MGYxMmQ0NTkzYzIuLmJkNmQ4NzU5MTJiM2ZiZmQwNjljMDc1OTUw NWI3MGJmMmEwZWI5NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1VzZVY4LmNtYWtlCisr KyBiL1NvdXJjZS9XZWJDb3JlL1VzZVY4LmNtYWtlCkBAIC0xNzksNyArMTc5LDYgQEAgaWYgKEVO QUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSKQogCiAgICAgICAgIGJpbmRpbmdzL3Y4L2N1c3RvbS9W OEphdmFTY3JpcHRDYWxsRnJhbWVDdXN0b20uY3BwCiAgICAgICAgIGJpbmRpbmdzL3Y4L2N1c3Rv bS9WOFNjcmlwdFByb2ZpbGVDdXN0b20uY3BwCi0gICAgICAgIGJpbmRpbmdzL3Y4L2N1c3RvbS9W OFNjcmlwdFByb2ZpbGVOb2RlQ3VzdG9tLmNwcAogICAgICkKIGVuZGlmICgpCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaSBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUu Z3lwaQppbmRleCBhNzQxYzhkN2YwYTE2MGVmY2I4YTE3MDc1MTkyYTMzYTM3MmExOTAzLi5lNzA5 N2QzZjY3OTc4Yjg5MTE0MjFjZDE3MTA2YzI1ZmQ5ZTFjMmMxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmd5cGkKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCkBA IC0xMzg1LDcgKzEzODUsNiBAQAogICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFNW R0xlbmd0aEN1c3RvbS5jcHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFNW R1BhdGhTZWdDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9jdXN0b20vVjhT Y3JpcHRQcm9maWxlQ3VzdG9tLmNwcCcsCi0gICAgICAgICAgICAnYmluZGluZ3MvdjgvY3VzdG9t L1Y4U2NyaXB0UHJvZmlsZU5vZGVDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92 OC9jdXN0b20vVjhTdG9yYWdlQ3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4U3R5bGVTaGVldEN1c3RvbS5jcHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9tLmNwcCcsCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTY3JpcHRQcm9maWxlTm9kZUN1c3RvbS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTY3JpcHRQcm9maWxlTm9kZUN1 c3RvbS5jcHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDdlODQwNTViNzA0NTY2NTY5 YzFjOGE2NjhlY2EwYjc4ZDI2OWJkZTAuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U2NyaXB0 UHJvZmlsZU5vZGVDdXN0b20uY3BwCisrKyAvZGV2L251bGwKQEAgLTEsNjYgKzAsMCBAQAotLyoK LSAqIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgot ICoKLSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMs IHdpdGggb3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVk IHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQotICogbWV0OgotICoKLSAqICAgICAq IFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29w eXJpZ2h0Ci0gKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93 aW5nIGRpc2NsYWltZXIuCi0gKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0g bXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCi0gKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCi0gKiBpbiB0aGUgZG9j dW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCi0gKiBk aXN0cmlidXRpb24uCi0gKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5v ciB0aGUgbmFtZXMgb2YgaXRzCi0gKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3Jz ZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQotICogdGhpcyBzb2Z0d2FyZSB3aXRo b3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KLSAqCi0gKiBUSElTIFNPRlRX QVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JT Ci0gKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xV RElORywgQlVUIE5PVAotICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBN RVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCi0gKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBB UkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAotICogT1dORVIg T1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lE RU5UQUwsCi0gKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAo SU5DTFVESU5HLCBCVVQgTk9UCi0gKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElU VVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKLSAqIERBVEEsIE9SIFBST0ZJVFM7 IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQotICog VEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElU WSwgT1IgVE9SVAotICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lO RyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElG IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLSNpbmNs dWRlICJjb25maWcuaCIKLSNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKLSNpbmNsdWRl ICJWOFNjcmlwdFByb2ZpbGVOb2RlLmgiCi0KLSNpbmNsdWRlICJTY3JpcHRQcm9maWxlTm9kZS5o IgotI2luY2x1ZGUgIlY4QmluZGluZy5oIgotCi0jaW5jbHVkZSA8djgtcHJvZmlsZXIuaD4KLQot bmFtZXNwYWNlIFdlYkNvcmUgewotCi12ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOChTY3JpcHRQ cm9maWxlTm9kZSogaW1wbCwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBjcmVhdGlvbkNvbnRleHQs IHY4OjpJc29sYXRlKiBpc29sYXRlKQotewotICAgIGlmICghaW1wbCkKLSAgICAgICAgcmV0dXJu IHY4TnVsbFdpdGhDaGVjayhpc29sYXRlKTsKLQotICAgIC8vIEZJWE1FOiBVc2UgdGhlIGNyZWF0 aW9uQ29udGV4dC4KLQotICAgIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+IGZ1bmN0aW9uID0gVjhT Y3JpcHRQcm9maWxlTm9kZTo6R2V0VGVtcGxhdGUoKS0+R2V0RnVuY3Rpb24oKTsKLSAgICBpZiAo ZnVuY3Rpb24uSXNFbXB0eSgpKSB7Ci0gICAgICAgIC8vIFJldHVybiBpZiBhbGxvY2F0aW9uIGZh aWxlZC4KLSAgICAgICAgcmV0dXJuIHY4VW5kZWZpbmVkKCk7Ci0gICAgfQotICAgIHY4OjpMb2Nh bDx2ODo6T2JqZWN0PiBpbnN0YW5jZSA9IFY4T2JqZWN0Q29uc3RydWN0b3I6Om5ld0luc3RhbmNl KGZ1bmN0aW9uKTsKLSAgICBpZiAoaW5zdGFuY2UuSXNFbXB0eSgpKSB7Ci0gICAgICAgIC8vIEF2 b2lkIHNldHRpbmcgdGhlIHdyYXBwZXIgaWYgYWxsb2NhdGlvbiBmYWlsZWQuCi0gICAgICAgIHJl dHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsKLSAgICB9Ci0gICAgaW1wbC0+cmVmKCk7Ci0g ICAgVjhET01XcmFwcGVyOjpzZXROYXRpdmVJbmZvKGluc3RhbmNlLCAmVjhTY3JpcHRQcm9maWxl Tm9kZTo6aW5mbywgaW1wbCk7Ci0gICAgcmV0dXJuIGluc3RhbmNlOwotfQotCi19IC8vIG5hbWVz cGFjZSBXZWJDb3JlCi0KLSNlbmRpZiAvLyBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9TY3JpcHRQcm9maWxlTm9kZS5pZGwg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvU2NyaXB0UHJvZmlsZU5vZGUuaWRsCmluZGV4IGU2 YmUyODdhMDE4YTM0NTBmOGUzZTg1NWE0NDZmMzkzMTMyZmNhZDIuLjc5MWI1YTllNGMyMWFlODgw NjMxZjlkZGY5NGM1NGU3YmEzYjc3MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9TY3JpcHRQcm9maWxlTm9kZS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L1NjcmlwdFByb2ZpbGVOb2RlLmlkbApAQCAtMjYsOSArMjYsNyBAQAogCiBbCiAgICAgQ29uZGl0 aW9uYWw9SkFWQVNDUklQVF9ERUJVR0dFUiwKLSAgICBPbWl0Q29uc3RydWN0b3IsCi0gICAgVjhD dXN0b21Ub0pTT2JqZWN0LAotICAgIFY4Tm9XcmFwcGVyQ2FjaGUKKyAgICBPbWl0Q29uc3RydWN0 b3IKIF0gaW50ZXJmYWNlIFNjcmlwdFByb2ZpbGVOb2RlIHsKICAgICByZWFkb25seSBhdHRyaWJ1 dGUgRE9NU3RyaW5nIGZ1bmN0aW9uTmFtZTsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3Ry aW5nIHVybDsK