107237 2013-01-18 00:32:54 -0800 REGRESSION(r140101): caused debug asserts in fast/forms/associated-element-crash.html and html5lib/run-template.html 2013-05-11 20:30:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 107023 1 webkit.review.bot webkit.review.bot abarth adamk dominicc eric ojan.autocc rafaelw webkit-bug-importer oldest_to_newest 810321 0 webkit.review.bot 2013-01-18 00:32:54 -0800 http://trac.webkit.org/changeset/140101 broke the build: caused debug asserts in fast/forms/associated-element-crash.html and html5lib/run-template.html (Requested by dominicc on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 810323 1 183395 webkit.review.bot 2013-01-18 00:33:24 -0800 Created attachment 183395 ROLLOUT of r140101 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 810328 2 eric 2013-01-18 00:39:05 -0800 Could you document the ASSERTS here, so the author has an easier time fixing? 810329 3 eric 2013-01-18 00:39:22 -0800 Thank you, btw. 810360 4 dominicc 2013-01-18 01:38:20 -0800 I added Chromium debug crash expectations in r140108. Here is the assert; this one from html5lib/run-template.html on Mac 10.7 dbg: STDOUT: <empty> STDERR: ASSERTION FAILED: document() == newChild->document() STDERR: ../../third_party/WebKit/Source/WebCore/dom/ContainerNode.cpp(699) : void WebCore::ContainerNode::parserAppendChild(PassRefPtr<WebCore::Node>) STDERR: 1 0x5fd337a WebCore::ContainerNode::parserAppendChild(WTF::PassRefPtr<WebCore::Node>) STDERR: 2 0x64454ff _ZN7WebCoreL11executeTaskERNS_24HTMLConstructionSiteTaskE STDERR: 3 0x644537b WebCore::HTMLConstructionSite::executeQueuedTasks() STDERR: 4 0x6483a6c WebCore::HTMLTreeBuilder::constructTree(WebCore::AtomicHTMLToken*) STDERR: 5 0x6450bc0 WebCore::HTMLDocumentParser::constructTreeFromHTMLToken(WebCore::HTMLToken&) STDERR: 6 0x64502c1 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) STDERR: 7 0x644fb7f WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) STDERR: 8 0x6450dee WebCore::HTMLDocumentParser::insert(WebCore::SegmentedString const&) STDERR: 9 0x6005152 WebCore::Document::write(WebCore::SegmentedString const&, WebCore::Document*) STDERR: 10 0x6005202 WebCore::Document::write(WTF::String const&, WebCore::Document*) STDERR: 11 0x7a39ec0 WebCore::V8HTMLDocument::writeCallback(v8::Arguments const&) STDERR: 12 0x2e6f06e7 STDERR: Received signal 11 SEGV_MAPERR 0000bbadbeef 810875 5 183516 rafaelw 2013-01-18 11:27:08 -0800 Created attachment 183516 Patch 810879 6 rafaelw 2013-01-18 11:30:07 -0800 Note that 140101 wasn't ever rolled out. This patch fixes the template crash, and removes the TestExpectations for the crashes Also, note that fast/forms/associated-element-crash.html doesn't correctly name a layout test. I assume this was a meant to be fast/forms/form-associated-element-crash.html, but since it isn't crashing on the bots and I couldn't repro locally, and thus the crash was a flake. 813309 7 rafaelw 2013-01-22 12:27:25 -0800 ping. 813550 8 183516 webkit.review.bot 2013-01-22 16:43:35 -0800 Comment on attachment 183516 Patch Rejecting attachment 183516 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: 1 with fuzz 3. patching file Source/WebCore/html/parser/HTMLConstructionSite.cpp patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/TestExpectations Hunk #1 FAILED at 4313. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16035881 814181 9 dominicc 2013-01-23 07:24:11 -0800 Committed r140537. 887891 10 webkit-bug-importer 2013-05-11 20:30:38 -0700 <rdar://problem/13870264> 183395 2013-01-18 00:33:24 -0800 2013-01-18 11:27:06 -0800 ROLLOUT of r140101 bug-107237-20130118083023.patch text/plain 6426 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2YwNTA1ZTI3NzA1MDMw YmYxYWJiNjY4NWIyMWUzMDc4NTFjYTkwMi4uM2Q5MGQ2ODU1M2FhZTcwYmY3Yzg0Zjc5YWViYWY2 NWMwMzBhYjYyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTAxLTE4ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAorICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTQwMTAxLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xNDAxMDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNzIzNworCisgICAgICAgIGNhdXNlZCBkZWJ1ZyBhc3NlcnRzIGluIGZhc3Qv Zm9ybXMvYXNzb2NpYXRlZC1lbGVtZW50LQorICAgICAgICBjcmFzaC5odG1sIGFuZCBodG1sNWxp Yi9ydW4tdGVtcGxhdGUuaHRtbCAoUmVxdWVzdGVkIGJ5CisgICAgICAgIGRvbWluaWNjIG9uICN3 ZWJraXQpLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTENvbnN0cnVjdGlvblNpdGU6Omluc2VydFRleHROb2Rl KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlOjpmb3N0ZXJQYXJlbnQp OgorCisyMDEzLTAxLTE4ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KKwogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQwMDA1LgogICAgICAgICBo dHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNDAwMDUKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzIzNQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCmluZGV4IDQyMmEwYWFi YzgzZmVhODAxNWNhNGQzMTg0NmZkOThkNWI2NTA3YzMuLjU4NmM2MmFmOTI5ZjBhMDBmMWY5ODdj ZGE0YjE5MmU4NTFlYmE5OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2Vy L0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNl ci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKQEAgLTUwMywxMCArNTAzLDYgQEAgdm9pZCBIVE1M Q29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0VGV4dE5vZGUoY29uc3QgU3RyaW5nJiBjaGFyYWN0ZXJz LCBXaGl0ZXNwYWNlTW8KICAgICAgICAgY3VycmVudFBvc2l0aW9uICs9IHRleHROb2RlLT5sZW5n dGgoKTsKICAgICAgICAgQVNTRVJUKGN1cnJlbnRQb3NpdGlvbiA8PSBjaGFyYWN0ZXJzLmxlbmd0 aCgpKTsKICAgICAgICAgdGFzay5jaGlsZCA9IHRleHROb2RlLnJlbGVhc2UoKTsKLQotICAgICAg ICBpZiAodGFzay5wYXJlbnQtPmRvY3VtZW50KCkgIT0gdGFzay5jaGlsZC0+ZG9jdW1lbnQoKSkK LSAgICAgICAgICAgIHRhc2sucGFyZW50LT5kb2N1bWVudCgpLT5hZG9wdE5vZGUodGFzay5jaGls ZCwgQVNTRVJUX05PX0VYQ0VQVElPTik7Ci0KICAgICAgICAgZXhlY3V0ZVRhc2sodGFzayk7CiAg ICAgfQogfQpAQCAtNjQzLDEwICs2MzksNiBAQCB2b2lkIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjpm b3N0ZXJQYXJlbnQoUGFzc1JlZlB0cjxOb2RlPiBub2RlKQogICAgIGZpbmRGb3N0ZXJTaXRlKHRh c2spOwogICAgIHRhc2suY2hpbGQgPSBub2RlOwogICAgIEFTU0VSVCh0YXNrLnBhcmVudCk7Ci0K LSAgICBpZiAodGFzay5wYXJlbnQtPmRvY3VtZW50KCkgIT0gdGFzay5jaGlsZC0+ZG9jdW1lbnQo KSkKLSAgICAgICAgdGFzay5wYXJlbnQtPmRvY3VtZW50KCktPmFkb3B0Tm9kZSh0YXNrLmNoaWxk LCBBU1NFUlRfTk9fRVhDRVBUSU9OKTsKLQogICAgIG1fYXR0YWNobWVudFF1ZXVlLmFwcGVuZCh0 YXNrKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCmluZGV4IDQyMGE3YmEzYWU0ZmQxOWQ0M2M5YWU0ODZiZGFkZDJjMzFmMDFi ODAuLjYwMWQwY2Y0YmQzNjBkNzk4NmFiNTA3YzE4ZWMwODQ4MjE5YzYzMDIgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxMy0wMS0xOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE0MDEwMS4KKyAg ICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTQwMTAxCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcyMzcKKworICAgICAgICBj YXVzZWQgZGVidWcgYXNzZXJ0cyBpbiBmYXN0L2Zvcm1zL2Fzc29jaWF0ZWQtZWxlbWVudC0KKyAg ICAgICAgY3Jhc2guaHRtbCBhbmQgaHRtbDVsaWIvcnVuLXRlbXBsYXRlLmh0bWwgKFJlcXVlc3Rl ZCBieQorICAgICAgICBkb21pbmljYyBvbiAjd2Via2l0KS4KKworICAgICAgICAqIGZhc3QvcGFy c2VyL2Zvc3Rlci1wYXJlbnQtYWRvcHRlZC1leHBlY3RlZC50eHQ6IFJlbW92ZWQuCisgICAgICAg ICogZmFzdC9wYXJzZXIvZm9zdGVyLXBhcmVudC1hZG9wdGVkLmh0bWw6IFJlbW92ZWQuCisgICAg ICAgICogZmFzdC9wYXJzZXIvZm9zdGVyLXBhcmVudC1hZG9wdGVkMi1leHBlY3RlZC50eHQ6IFJl bW92ZWQuCisgICAgICAgICogZmFzdC9wYXJzZXIvZm9zdGVyLXBhcmVudC1hZG9wdGVkMi5odG1s OiBSZW1vdmVkLgorCisyMDEzLTAxLTE4ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQwMDA1Lgog ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNDAwMDUKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzIzNQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvZm9zdGVyLXBhcmVudC1hZG9wdGVkLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2Zvc3Rlci1wYXJlbnQtYWRvcHRlZC1leHBl Y3RlZC50eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDA4MTQ3ODRmYjQ1OTc2MzYx OWVjNDMxMDA3MWZlMzQwMGI5MTZhZGEuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvZm9zdGVyLXBhcmVudC1hZG9w dGVkLWV4cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDMgKzAsMCBAQAotVGhpcyB0ZXN0 cyB0aGF0IHdoZW4gbm9kZXMgYXJlIGZvc3Rlci1wYXJlbnRlZCBhZnRlciBiZWluZyBhZG9wdGVk IGludG8gYW5vdGhlciBkb2N1bWVudCwgdGhleSBhcmUgYWRvcHRlZCBiYWNrIGludG8gdGhlIG93 bmVyRG9jdW1lbnQgb2YgdGhlaXIgZm9zdGVyIHBhcmVudC4KLQotUEFTUy4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2Zvc3Rlci1wYXJlbnQtYWRvcHRlZC5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9wYXJzZXIvZm9zdGVyLXBhcmVudC1hZG9wdGVkLmh0bWwKZGVsZXRlZCBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDljMTJlZTNkMmY5N2EwZTg1OTFmNDM4MDc3MzkzYjdhNDYw ZjMwYjIuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5 b3V0VGVzdHMvZmFzdC9wYXJzZXIvZm9zdGVyLXBhcmVudC1hZG9wdGVkLmh0bWwKKysrIC9kZXYv bnVsbApAQCAtMSwyNSArMCwwIEBACi08IURPQ1RZUEUgaHRtbD4KLTxodG1sPgotICA8Ym9keT4K LSAgICAgIDxwPlRoaXMgdGVzdHMgdGhhdCB3aGVuIG5vZGVzIGFyZSBmb3N0ZXItcGFyZW50ZWQg YWZ0ZXIgYmVpbmcgYWRvcHRlZCBpbnRvIGFub3RoZXIgZG9jdW1lbnQsCi0gICAgICAgICAgdGhl eSBhcmUgYWRvcHRlZCBiYWNrIGludG8gdGhlIG93bmVyRG9jdW1lbnQgb2YgdGhlaXIgZm9zdGVy IHBhcmVudC4gPC9wPgotICAgICAgPHRhYmxlPgotICAgICAgICAgIDx0cj4KLTxzY3JpcHQ+Ci1p ZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Ci0KLXZh ciB0ciA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3RyJyk7Ci12YXIgZG9jID0gZG9jdW1lbnQu aW1wbGVtZW50YXRpb24uY3JlYXRlSFRNTERvY3VtZW50KCk7Ci1kb2MuYWRvcHROb2RlKHRyKTsK LTwvc2NyaXB0PgotICAgICAgICAgICAgICA8ZGl2PjwvZGl2PgotICAgICAgICAgIDwvdHI+Ci0g ICAgICA8L3RhYmxlPgotPHNjcmlwdD4KLXZhciBkaXYgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9y KCdkaXYnKTsKLWlmIChkaXYub3duZXJEb2N1bWVudCA9PT0gZGl2LnBhcmVudE5vZGUub3duZXJE b2N1bWVudCkKLSAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRl eHROb2RlKCdQQVNTLicpKTsKLTwvc2NyaXB0PgotICAgIDwvYm9keT4KLTwvaHRtbD4KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3BhcnNl ci9mb3N0ZXItcGFyZW50LWFkb3B0ZWQyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv cGFyc2VyL2Zvc3Rlci1wYXJlbnQtYWRvcHRlZDItZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwODE0Nzg0ZmI0NTk3NjM2MTllYzQzMTAwNzFmZTM0MDBiOTE2YWRh Li4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRl c3RzL2Zhc3QvcGFyc2VyL2Zvc3Rlci1wYXJlbnQtYWRvcHRlZDItZXhwZWN0ZWQudHh0CisrKyAv ZGV2L251bGwKQEAgLTEsMyArMCwwIEBACi1UaGlzIHRlc3RzIHRoYXQgd2hlbiBub2RlcyBhcmUg Zm9zdGVyLXBhcmVudGVkIGFmdGVyIGJlaW5nIGFkb3B0ZWQgaW50byBhbm90aGVyIGRvY3VtZW50 LCB0aGV5IGFyZSBhZG9wdGVkIGJhY2sgaW50byB0aGUgb3duZXJEb2N1bWVudCBvZiB0aGVpciBm b3N0ZXIgcGFyZW50LgotCi1QQVNTLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9wYXJz ZXIvZm9zdGVyLXBhcmVudC1hZG9wdGVkMi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIv Zm9zdGVyLXBhcmVudC1hZG9wdGVkMi5odG1sCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAzOWM1YzQwNTFmNjQ0ZjA2ZjMyYjE3OWRmY2QyMzVkZDgxZTU2ODg2Li4wMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL2Zhc3QvcGFyc2Vy L2Zvc3Rlci1wYXJlbnQtYWRvcHRlZDIuaHRtbAorKysgL2Rldi9udWxsCkBAIC0xLDI2ICswLDAg QEAKLTwhRE9DVFlQRSBodG1sPgotPGh0bWw+Ci0gIDxib2R5PgotICAgICAgPHA+VGhpcyB0ZXN0 cyB0aGF0IHdoZW4gbm9kZXMgYXJlIGZvc3Rlci1wYXJlbnRlZCBhZnRlciBiZWluZyBhZG9wdGVk IGludG8gYW5vdGhlciBkb2N1bWVudCwKLSAgICAgICAgICB0aGV5IGFyZSBhZG9wdGVkIGJhY2sg aW50byB0aGUgb3duZXJEb2N1bWVudCBvZiB0aGVpciBmb3N0ZXIgcGFyZW50LiA8L3A+Ci0gICAg ICA8dGFibGU+Ci0gICAgICAgICAgPHRyPgotPHNjcmlwdD4KLWlmICh3aW5kb3cudGVzdFJ1bm5l cikKLSAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKLQotdmFyIGRvYyA9IGRvY3VtZW50Lmlt cGxlbWVudGF0aW9uLmNyZWF0ZUhUTUxEb2N1bWVudCgpOwotdmFyIGRpdiA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoJ2RpdicpOwotZG9jLmFkb3B0Tm9kZShkaXYpOwotZGl2LmFwcGVuZENoaWxk KGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3RhYmxlJykpCi08L3NjcmlwdD4KLSAgICAgICAgICAg ICAgPGRpdiBpZD1mb3N0ZXJDaGlsZD48L2Rpdj4KLSAgICAgICAgICA8L3RyPgotICAgICAgPC90 YWJsZT4KLTxzY3JpcHQ+Ci12YXIgZm9zdGVyQ2hpbGQgPSBkaXYucXVlcnlTZWxlY3RvcignI2Zv c3RlckNoaWxkJyk7Ci1pZiAoZm9zdGVyQ2hpbGQub3duZXJEb2N1bWVudCA9PT0gZm9zdGVyQ2hp bGQucGFyZW50Tm9kZS5vd25lckRvY3VtZW50KQotICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoJ1BBU1MuJykpOwotPC9zY3JpcHQ+Ci0gICAgPC9i b2R5PgotPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 183516 2013-01-18 11:27:08 -0800 2013-01-22 16:43:35 -0800 Patch bug-107237-20130118112407.patch text/plain 3616 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU3ZDYzZGFkM2I1MGUz NDQyMzUxZjhjZTljODRiZTAyYTM2MjY4Yi4uN2VlYWI3YmQzMDMyMThmNWNjOTQ0N2FhYmMzMTI0 MGExNGFkN2Q5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTE4ICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TihyMTQwMTAxKTogY2F1c2VkIGRlYnVnIGFzc2VydHMgaW4gZmFzdC9mb3Jtcy9hc3NvY2lhdGVk LWVsZW1lbnQtY3Jhc2guaHRtbCBhbmQgaHRtbDVsaWIvcnVuLXRlbXBsYXRlLmh0bWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzIzNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBu ZWVkZWQuCisKKyAgICAgICAgV2hlbiB0aGUgcGFyc2VyIGZvc3Rlci1wYXJlbnQncyBhIG5vZGUg b3V0IG9mIGEgdGFibGUgY29udGV4dCBhbmQgdGhlIGZvc3RlciBwYXJlbnQgaXMgYSB0ZW1wbGF0 ZSBlbGVtZW50LCBzZXQgdGhlIFRhc2sucGFyZW50CisgICAgICAgIHRvIGJlIHRoZSB0ZW1wbGF0 ZSBlbGVtZW50J3MgY29udGVudCwgcmF0aGVyIHRoYW4gdGhlIGVsZW1lbnQgaXRzZWxmLiBUaGlz IGVuc3VyZXMgdGhlIGZvc3Rlci1wYXJlbnRlZCBub2RlIGlzbid0IGVycm9yZW5vdXNseQorICAg ICAgICByZXBhcmVudGVkLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlv blNpdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENvbnN0cnVjdGlvblNpdGU6OmZpbmRG b3N0ZXJTaXRlKToKKwogMjAxMy0wMS0xOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEluY29ycmVjdCBzY3JvbGxhYmxlIGhlaWdodCBkdXJpbmcgc2ltcGxpZmll ZCBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25z dHJ1Y3Rpb25TaXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1 Y3Rpb25TaXRlLmNwcAppbmRleCA0MjJhMGFhYmM4M2ZlYTgwMTVjYTRkMzE4NDZmZDk4ZDViNjUw N2MzLi5jNzhkNGJmM2IyMTY3ODM5YmNlMjUxNmRiMzBjZDdkMDVkNDc2OGFlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCkBA IC02MDcsOSArNjA3LDEwIEBAIHZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6OmZpbmRGb3N0ZXJT aXRlKEhUTUxDb25zdHJ1Y3Rpb25TaXRlVGFzayYgdGFzaykKICAgICAvLyBXaGVuIGEgbm9kZSBp cyB0byBiZSBmb3N0ZXIgcGFyZW50ZWQsIHRoZSBsYXN0IHRlbXBsYXRlIGVsZW1lbnQgd2l0aCBu byB0YWJsZSBlbGVtZW50IGlzIGJlbG93IGl0IGluIHRoZSBzdGFjayBvZiBvcGVuIGVsZW1lbnRz IGlzIHRoZSBmb3N0ZXIgcGFyZW50IGVsZW1lbnQgKE5PVCB0aGUgdGVtcGxhdGUncyBwYXJlbnQh KQogICAgIEhUTUxFbGVtZW50U3RhY2s6OkVsZW1lbnRSZWNvcmQqIGxhc3RUZW1wbGF0ZUVsZW1l bnQgPSBtX29wZW5FbGVtZW50cy50b3Btb3N0KHRlbXBsYXRlVGFnLmxvY2FsTmFtZSgpKTsKICAg ICBpZiAobGFzdFRlbXBsYXRlRWxlbWVudCAmJiAhbV9vcGVuRWxlbWVudHMuaW5UYWJsZVNjb3Bl KHRhYmxlVGFnKSkgewotICAgICAgICB0YXNrLnBhcmVudCA9IGxhc3RUZW1wbGF0ZUVsZW1lbnQt PmVsZW1lbnQoKTsKKyAgICAgICAgdGFzay5wYXJlbnQgPSB0b0hUTUxUZW1wbGF0ZUVsZW1lbnQo bGFzdFRlbXBsYXRlRWxlbWVudC0+ZWxlbWVudCgpKS0+Y29udGVudCgpOwogICAgICAgICByZXR1 cm47CiAgICAgfQorCiAjZW5kaWYKIAogICAgIEhUTUxFbGVtZW50U3RhY2s6OkVsZW1lbnRSZWNv cmQqIGxhc3RUYWJsZUVsZW1lbnRSZWNvcmQgPSBtX29wZW5FbGVtZW50cy50b3Btb3N0KHRhYmxl VGFnLmxvY2FsTmFtZSgpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0OTlmNDFkYTc5MTRjODFkNTdkZTdiNmZmYWQ2NmFh Mjc5OWNlNzk0Li4wZjgxNjExZDJlODM0ZThkMGUxZmFkNDEwYjhhMjY5ZjVjZDM0ZTI0IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDEtMTggIFJhZmFlbCBXZWluc3RlaW4gIDxyYWZhZWx3 QGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNDAxMDEpOiBjYXVzZWQgZGVi dWcgYXNzZXJ0cyBpbiBmYXN0L2Zvcm1zL2Fzc29jaWF0ZWQtZWxlbWVudC1jcmFzaC5odG1sIGFu ZCBodG1sNWxpYi9ydW4tdGVtcGxhdGUuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDEzLTAxLTE4ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgSW5jb3JyZWN0IHNjcm9sbGFibGUgaGVpZ2h0IGR1cmluZyBzaW1wbGlmaWVkIGxheW91dApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg YjM3N2IwZjIxZjk3MDFhNTBiZTAzNDExMjhiNjQ5YmJiYWUxNDA4Zi4uNTEyNmYyNGU0OTUwNmQx YjgwNWM0MjI1NThmZWJkZWY2ZGY5ZjNjYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCkBAIC00MzEzLDYgKzQzMTMsMyBAQCB3ZWJraXQub3Jn L2IvOTkxMzggWyBEZWJ1ZyBTbm93TGVvcGFyZCBdIHN2Zy9jdXN0b20vZm9yZWlnbi1vYmplY3Qt c2tldy5zdmcgWyBJbQogd2Via2l0Lm9yZy9iLzEwNzIwNCBmYXN0L2V2ZW50cy90b3VjaC9tdWx0 aS10b3VjaC1pbnNpZGUtaWZyYW1lcy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9y Zy9iLzEwNzIwOSBbIERlYnVnIF0gZmFzdC9pbmxpbmUvZml4ZWQtcG9zLW1vdmVzLXdpdGgtYWJz cG9zLXBhcmVudC1yZWxhdGl2ZS1hbmNlc3Rvci5odG1sIFsgQ3Jhc2ggXQotCi13ZWJraXQub3Jn L2IvMTA3MjM3IFsgRGVidWcgXSBmYXN0L2Zvcm1zL2Fzc29jaWF0ZWQtZWxlbWVudC1jcmFzaC5o dG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzEwNzMyNyBbIERlYnVnIF0gaHRtbDVsaWIvcnVu LXRlbXBsYXRlLmh0bWwgWyBDcmFzaCBdCg==