107236 2013-01-18 00:11:51 -0800 display:none iframes should not build rendering trees 2024-03-06 14:26:49 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=17828 https://bugs.webkit.org/show_bug.cgi?id=84684 https://bugs.webkit.org/show_bug.cgi?id=6926 https://bugs.webkit.org/show_bug.cgi?id=136890 https://bugs.webkit.org/show_bug.cgi?id=261741 P2 Normal --- 111200 1 eric eric ap buildbot cdumez dglazkov dholbert esprehn+autocc esprehn kling koivisto laszlo.gombos mkwst ojan.autocc rniwa simon.fraser tonyg webkit.review.bot oldest_to_newest 810304 0 eric 2013-01-18 00:11:51 -0800 display:none iframes should not build rendering trees 810305 1 183391 eric 2013-01-18 00:13:39 -0800 Created attachment 183391 Speculative patch, I"m not sure this is the right code to change. 810307 2 eric 2013-01-18 00:16:03 -0800 I believe this is a regression, but I don't have proof or a timeframe. I just remember that when I wrote the html-parser benchmark 2 years ago it didn't build rendering trees. :) It's possible that the problem is that the HTML parser is using "attach" instead of "lazyAttach" and that lazyAttach would do the right thing as well. 810335 3 eric 2013-01-18 00:45:45 -0800 This may affect whether we issue loads for sub-frames in the display:none iframe. I'm not sure if we have testing coverage for that or not. (I've not yet run the tests with this patch.) 810341 4 183391 buildbot 2013-01-18 01:06:32 -0800 Comment on attachment 183391 Speculative patch, I"m not sure this is the right code to change. Attachment 183391 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/15942428 New failing tests: css2.1/20110323/absolute-replaced-height-007.htm compositing/framesets/composited-frame-alignment.html css2.1/20110323/absolute-replaced-height-025.htm css2.1/20110323/float-replaced-height-005.htm css2.1/20110323/absolute-replaced-height-014.htm css2.1/20110323/block-replaced-height-005.htm css2.1/20110323/block-replaced-height-007.htm css2.1/20110323/absolute-replaced-height-005.htm css2.1/20110323/absolute-replaced-height-011.htm css2.1/20110323/float-replaced-height-007.htm css2.1/20110323/absolute-replaced-height-035.htm css2.1/20110323/absolute-replaced-height-032.htm css2.1/20110323/absolute-replaced-height-018.htm css2.1/20110323/absolute-replaced-height-028.htm css2.1/20110323/float-replaced-height-004.htm css2.1/20110323/absolute-replaced-height-033.htm css2.1/20110323/absolute-replaced-height-012.htm canvas/philip/tests/2d.text.draw.fontface.notinpage.html compositing/iframes/invisible-nested-iframe-show.html css2.1/20110323/absolute-replaced-height-004.htm css2.1/20110323/inline-block-replaced-height-004.htm css2.1/20110323/absolute-replaced-height-019.htm css2.1/20110323/absolute-replaced-height-026.htm css2.1/20110323/absolute-replaced-height-021.htm css2.1/20110323/block-replaced-height-004.htm 810348 5 183391 buildbot 2013-01-18 01:24:18 -0800 Comment on attachment 183391 Speculative patch, I"m not sure this is the right code to change. Attachment 183391 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15946311 New failing tests: css2.1/20110323/absolute-replaced-height-007.htm compositing/framesets/composited-frame-alignment.html css2.1/20110323/absolute-replaced-height-025.htm css2.1/20110323/float-replaced-height-005.htm css2.1/20110323/inline-block-replaced-height-007.htm css2.1/20110323/block-replaced-height-005.htm css2.1/20110323/inline-replaced-height-004.htm css2.1/20110323/block-replaced-height-007.htm css2.1/20110323/absolute-replaced-height-005.htm css2.1/20110323/absolute-replaced-height-011.htm css2.1/20110323/inline-block-replaced-height-005.htm css2.1/20110323/absolute-replaced-height-035.htm css2.1/20110323/inline-replaced-height-005.htm accessibility/loading-iframe-updates-axtree.html css2.1/20110323/absolute-replaced-height-032.htm css2.1/20110323/inline-replaced-height-007.htm css2.1/20110323/absolute-replaced-height-014.htm css2.1/20110323/absolute-replaced-height-018.htm css2.1/20110323/absolute-replaced-height-028.htm css2.1/20110323/float-replaced-height-004.htm css2.1/20110323/absolute-replaced-height-033.htm css2.1/20110323/absolute-replaced-height-012.htm css2.1/20110323/float-replaced-height-007.htm compositing/iframes/invisible-nested-iframe-show.html css2.1/20110323/absolute-replaced-height-004.htm css2.1/20110323/inline-block-replaced-height-004.htm css2.1/20110323/absolute-replaced-height-019.htm css2.1/20110323/absolute-replaced-height-026.htm css2.1/20110323/absolute-replaced-height-021.htm css2.1/20110323/block-replaced-height-004.htm 810352 6 183391 webkit.review.bot 2013-01-18 01:25:53 -0800 Comment on attachment 183391 Speculative patch, I"m not sure this is the right code to change. Attachment 183391 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15949253 New failing tests: css2.1/20110323/absolute-replaced-height-007.htm compositing/framesets/composited-frame-alignment.html css2.1/20110323/absolute-replaced-height-025.htm css2.1/20110323/float-replaced-height-005.htm css2.1/20110323/inline-block-replaced-height-007.htm css2.1/20110323/block-replaced-height-005.htm css2.1/20110323/inline-replaced-height-004.htm css2.1/20110323/block-replaced-height-007.htm css2.1/20110323/absolute-replaced-height-005.htm css2.1/20110323/absolute-replaced-height-011.htm css2.1/20110323/inline-block-replaced-height-005.htm css2.1/20110323/absolute-replaced-height-035.htm css2.1/20110323/inline-replaced-height-005.htm css2.1/20110323/absolute-replaced-height-032.htm css2.1/20110323/inline-replaced-height-007.htm css2.1/20110323/absolute-replaced-height-014.htm css2.1/20110323/absolute-replaced-height-018.htm css2.1/20110323/absolute-replaced-height-028.htm css2.1/20110323/float-replaced-height-004.htm css2.1/20110323/absolute-replaced-height-033.htm css2.1/20110323/absolute-replaced-height-012.htm css2.1/20110323/float-replaced-height-007.htm compositing/iframes/invisible-nested-iframe-show.html css2.1/20110323/absolute-replaced-height-004.htm css2.1/20110323/inline-block-replaced-height-004.htm http/tests/misc/favicon-as-image.html css2.1/20110323/absolute-replaced-height-019.htm css2.1/20110323/absolute-replaced-height-026.htm css2.1/20110323/absolute-replaced-height-021.htm css2.1/20110323/block-replaced-height-004.htm 810805 7 ap 2013-01-18 10:37:10 -0800 See also: bug 17828, bug 84684. 810824 8 183391 abarth 2013-01-18 10:47:54 -0800 Comment on attachment 183391 Speculative patch, I"m not sure this is the right code to change. Looks like this causes many tests to fail. It's still a useful patch for us to work with locally to make it easier to profile the parser, but it will probably need more work to land. 845550 9 191048 eric 2013-03-01 15:12:49 -0800 Created attachment 191048 For the EWS 845590 10 191048 buildbot 2013-03-01 16:12:04 -0800 Comment on attachment 191048 For the EWS Attachment 191048 did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16803334 New failing tests: fast/parser/double-write-from-closed-iframe.html fast/forms/textarea-metrics.html compositing/iframes/invisible-nested-iframe-show.html 845605 11 eric 2013-03-01 16:31:47 -0800 IMO, this is the right behavioral change, but getting it exactly right is tricky. We have to be careful to notify the inner document when the outer iframe changes display. I'm not exactly sure how that's working now. 845709 12 191048 webkit.review.bot 2013-03-01 19:26:44 -0800 Comment on attachment 191048 For the EWS Attachment 191048 did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16844171 New failing tests: fast/parser/double-write-from-closed-iframe.html platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show.html fast/forms/textarea-metrics.html compositing/iframes/invisible-nested-iframe-show.html 845772 13 191048 buildbot 2013-03-02 01:32:04 -0800 Comment on attachment 191048 For the EWS Attachment 191048 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16855312 New failing tests: fast/parser/double-write-from-closed-iframe.html fast/forms/textarea-metrics.html compositing/iframes/invisible-nested-iframe-show.html 1233431 14 ap 2016-09-26 09:26:20 -0700 *** Bug 162560 has been marked as a duplicate of this bug. *** 1233432 15 ap 2016-09-26 09:26:55 -0700 See https://github.com/whatwg/html/issues/1813 183391 2013-01-18 00:13:39 -0800 2013-03-01 15:12:46 -0800 Speculative patch, I"m not sure this is the right code to change. bug-107236-20130118001049.patch text/plain 2158 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzk5OGY4N2I5NWY3NWZm MzljNTYzNjAzN2RjZmFmMTdlMjM0OWE3Zi4uNzc5NDY4ZmRlOTIwNmIwZmYxNGUzYmQzOTRhNWFh OThlNWRkMGE4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTE4ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBkaXNwbGF5Om5vbmUgaWZyYW1l cyBzaG91bGQgbm90IGJ1aWxkIHJlbmRlcmluZyB0cmVlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhleSBkaWRuJ3QgdXNlZCB0byBidWlsZCByZW5k ZXJpbmcgdHJlZXMuICBBdCBzb21lIHBvaW50IHRoaXMKKyAgICAgICAgY2hhbmdlZCwgYW5kIGhh cyBtYWRlIHRoZSBQZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9odG1sLXBhcnNlci5odG1sCisgICAg ICAgIG1pY3JvLWJlbmNobWFyayBtZWFuaW5nbGVzcy4gIEl0J3MgcG9zc2libGUgdGhhdCB3ZSBu ZWVkIHRvIGJ1aWxkCisgICAgICAgIGEgcmVuZGVyaW5nIHRyZWUgZm9yIHNvbWUgcmVhc29uIGFu ZCB0aGlzIGNoYW5nZSB3YXMgaW50ZW50aW9uYWwuCisKKyAgICAgICAgSSdtIG5vdCBzdXJlIHRo YXQgdGhpcyBpcyB0aGUgcmlnaHQgcGxhY2UgdG8gZG8gdGhpcyBjaGVjaworICAgICAgICBidXQg dGhpcyBwYXRjaCB3b3JrcywgYW5kIG1ha2VzIFBhcnNlci9odG1sLXBhcnNlci5odG1sIHJ1bgor ICAgICAgICBpbiAxNHMgdG90YWwgaW5zdGVhZCBvZiA0NXMgdG90YWwuIDopCisKKyAgICAgICAg KiBkb20vTm9kZVJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZVJl bmRlcmluZ0NvbnRleHQ6OnNob3VsZENyZWF0ZVJlbmRlcmVyKToKKwogMjAxMy0wMS0xNyAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgMjAxMy0wMS0x NyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vTm9kZVJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL05vZGVSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCBiYWU1MWE3NGI4YmI3MmIyYzE3 YjYzYWM3MmY2NTkwNTRjZjk1ZDA3Li4xNmE3NmY3NzM5MzZmYzU5ZWJkOWUwNzQwMjZjN2NmODA1 ZmUwYzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJlbmRlcmluZ0NvbnRl eHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmVuZGVyaW5nQ29udGV4dC5jcHAK QEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJFbGVtZW50U2hhZG93LmgiCiAjaW5jbHVkZSAi Rmxvd1RocmVhZENvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJIVE1MQ29udGVudEVsZW1lbnQuaCIK KyNpbmNsdWRlICJIVE1MRnJhbWVPd25lckVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MSW5wdXRF bGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiSFRNTFNoYWRvd0Vs ZW1lbnQuaCIKQEAgLTE3Nyw2ICsxNzgsOSBAQCBib29sIE5vZGVSZW5kZXJpbmdDb250ZXh0Ojpz aG91bGRDcmVhdGVSZW5kZXJlcigpIGNvbnN0CiB7CiAgICAgaWYgKCFtX25vZGUtPmRvY3VtZW50 KCktPnNob3VsZENyZWF0ZVJlbmRlcmVycygpKQogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg Ly8gZGlzcGxheTpub25lIGlmcmFtZXMgZG9uJ3QgbmVlZCByZW5kZXJlcnMuCisgICAgaWYgKG1f bm9kZS0+ZG9jdW1lbnQoKS0+b3duZXJFbGVtZW50KCkgJiYgIW1fbm9kZS0+ZG9jdW1lbnQoKS0+ b3duZXJFbGVtZW50KCktPnJlbmRlcmVyKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBp ZiAoIW1fcmVuZGVyaW5nUGFyZW50KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgUmVuZGVy T2JqZWN0KiBwYXJlbnRSZW5kZXJlciA9IHRoaXMtPnBhcmVudFJlbmRlcmVyKCk7Cg== 191048 2013-03-01 15:12:49 -0800 2013-03-02 01:32:04 -0800 For the EWS bug-107236-20130301150905.patch text/plain 2416 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjM3ZTBjZTJkYTZhOTgz M2UxMWYwNDEyNTUzY2IwYjY5ZWY4MzE5ZS4uZTVjNmQ2MDM4NmQ4MWMyY2FmODI1ZmYzNDdmOGZk NTE3MzhhOTQ4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTAxICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBkaXNwbGF5Om5vbmUgaWZyYW1l cyBzaG91bGQgbm90IGJ1aWxkIHJlbmRlcmluZyB0cmVlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhleSBkaWRuJ3QgdXNlZCB0byBidWlsZCByZW5k ZXJpbmcgdHJlZXMuICBBdCBzb21lIHBvaW50IHRoaXMKKyAgICAgICAgY2hhbmdlZCwgYW5kIGhh cyBtYWRlIHRoZSBQZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9odG1sLXBhcnNlci5odG1sCisgICAg ICAgIG1pY3JvLWJlbmNobWFyayBtZWFuaW5nbGVzcy4gIEl0J3MgcG9zc2libGUgdGhhdCB3ZSBu ZWVkIHRvIGJ1aWxkCisgICAgICAgIGEgcmVuZGVyaW5nIHRyZWUgZm9yIHNvbWUgcmVhc29uIGFu ZCB0aGlzIGNoYW5nZSB3YXMgaW50ZW50aW9uYWwuCisKKyAgICAgICAgSSdtIG5vdCBzdXJlIHRo YXQgdGhpcyBpcyB0aGUgcmlnaHQgcGxhY2UgdG8gZG8gdGhpcyBjaGVjaworICAgICAgICBidXQg dGhpcyBwYXRjaCB3b3JrcywgYW5kIG1ha2VzIFBhcnNlci9odG1sLXBhcnNlci5odG1sIHJ1bgor ICAgICAgICBpbiAxNHMgdG90YWwgaW5zdGVhZCBvZiA0NXMgdG90YWwuIDopCisKKyAgICAgICAg KiBkb20vTm9kZVJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZVJl bmRlcmluZ0NvbnRleHQ6OnNob3VsZENyZWF0ZVJlbmRlcmVyKToKKwogMjAxMy0wMy0wMSAgQW5k eSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjEyNTgw OSk6IENGU3RyaW5ncyBjcmVhdGVkIHZpYSBTdHJpbmdJbXBsOjpjcmVhdGVDRlN0cmluZygpICBt aWdodCByZWZlcmVuY2UgZnJlZWQgbWVtb3J5IHdoZW4gT2JqZWN0aXZlLUMgZ2FyYmFnZSBjb2xs ZWN0aW9uIGlzIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmVu ZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJlbmRlcmluZ0NvbnRl eHQuY3BwCmluZGV4IGU4NGM1ZTQxNTk4YzRkYThjMTE2ZTI2YjFkMWI1ZTczNzRkNjAzODUuLjIx NTExMjhmZTI5NzFiNDIzODc4ZDI0MzkyOThhZDU5MzlmNDk5ODEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Ob2RlUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL05vZGVSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1 ZGUgIkVsZW1lbnRTaGFkb3cuaCIKICNpbmNsdWRlICJGbG93VGhyZWFkQ29udHJvbGxlci5oIgog I2luY2x1ZGUgIkhUTUxDb250ZW50RWxlbWVudC5oIgorI2luY2x1ZGUgIkhUTUxGcmFtZU93bmVy RWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxJbnB1dEVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1M TmFtZXMuaCIKICNpbmNsdWRlICJIVE1MU2hhZG93RWxlbWVudC5oIgpAQCAtMTc3LDYgKzE3OCwx MiBAQCBib29sIE5vZGVSZW5kZXJpbmdDb250ZXh0OjpzaG91bGRDcmVhdGVSZW5kZXJlcigpIGNv bnN0CiB7CiAgICAgaWYgKCFtX25vZGUtPmRvY3VtZW50KCktPnNob3VsZENyZWF0ZVJlbmRlcmVy cygpKQogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgLy8gZGlzcGxheTpub25lIGlmcmFtZXMg ZG9uJ3QgbmVlZCByZW5kZXJlcnMuCisgICAgLy8gSG93ZXZlciwgaWYgb3VyIG93bmVyRWxlbWVu dCBpcyBub3QgeWV0IGF0dGFjaGVkLCB3ZSBjYW4ndCB0cnVzdCBpdHMgcmVuZGVyZXIoKSBiZWlu ZyBudWxsLgorICAgIGlmIChtX25vZGUtPmRvY3VtZW50KCktPm93bmVyRWxlbWVudCgpCisgICAg ICAgICYmIG1fbm9kZS0+ZG9jdW1lbnQoKS0+b3duZXJFbGVtZW50KCktPmF0dGFjaGVkKCkKKyAg ICAgICAgJiYgIW1fbm9kZS0+ZG9jdW1lbnQoKS0+b3duZXJFbGVtZW50KCktPnJlbmRlcmVyKCkp CisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoIW1fcmVuZGVyaW5nUGFyZW50KQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgUmVuZGVyT2JqZWN0KiBwYXJlbnRSZW5kZXJlciA9IHRo aXMtPnBhcmVudFJlbmRlcmVyKCk7Cg==