107201 2013-01-17 16:40:54 -0800 BackgroundHTMLParser should go 18% faster on html-parser-srcdoc benchmark 2013-01-17 18:24:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 abarth abarth eric ojan.autocc tonyg webkit.review.bot oldest_to_newest 809957 0 abarth 2013-01-17 16:40:54 -0800 BackgroundHTMLParser should go 18% faster on html-parser-srcdoc benchmark 809960 1 183315 abarth 2013-01-17 16:44:32 -0800 Created attachment 183315 Patch 809970 2 183315 tonyg 2013-01-17 16:58:41 -0800 Comment on attachment 183315 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183315&action=review > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:50 > +static const size_t pendingTokenLimit = 4000; This constant seems so arbitrary. Did you try running with other values? I'd also recommend a comment explaining how it was chosen (or else a FIXME). 809976 3 abarth 2013-01-17 17:04:41 -0800 (In reply to comment #2) > (From update of attachment 183315 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183315&action=review > > > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:50 > > +static const size_t pendingTokenLimit = 4000; > > This constant seems so arbitrary. Did you try running with other values? I'd also recommend a comment explaining how it was chosen (or else a FIXME). I just grabbed the constant from Eric's patch. I'd be happy to add a FIXME saying that it's arbitrary and needs to be tuned. 809978 4 183323 abarth 2013-01-17 17:06:56 -0800 Created attachment 183323 Patch 810033 5 183323 webkit.review.bot 2013-01-17 18:02:18 -0800 Comment on attachment 183323 Patch Clearing flags on attachment: 183323 Committed r140079: <http://trac.webkit.org/changeset/140079> 810034 6 webkit.review.bot 2013-01-17 18:02:23 -0800 All reviewed patches have been landed. Closing bug. 810064 7 eric 2013-01-17 18:24:18 -0800 Thanks! 183315 2013-01-17 16:44:32 -0800 2013-01-17 17:06:53 -0800 Patch bug-107201-20130117164132.patch text/plain 2985 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM0YzU0ZmQ5MTkzMDYz YjdjNGFmYzBjMTk5YWZmM2JkYTkzOGQzYS4uZjJlNWQxZDE3ZTZlMjc4OWVlMWNkYjQ0OTkyMTRk OTI4OGRkNGY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAxLTE3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQmFja2dyb3VuZEhUTUxQYXJz ZXIgc2hvdWxkIGdvIDE4JSBmYXN0ZXIgb24gaHRtbC1wYXJzZXItc3JjZG9jIGJlbmNobWFyawor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MjAxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJpb3IgdG8g dGhpcyBwYXRjaCwgd2Ugd291bGQgdG9rZW5pemUgYWxsIHRoZSBpbnB1dCBiZWZvcmUgZGVsaXZl cmluZworICAgICAgICBhbnkgdG9rZW5zIHRvIHRoZSBtYWluIHRocmVhZC4gRWZmZWN0aXZlbHks IHRoYXQgcHJldmVudGVkIHRoZQorICAgICAgICBiYWNrZ3JvdW5kIHBhcnNlciBmcm9tIHJ1bm5p bmcgaW4gcGFyYWxsZWwgd2l0aCB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgVGhpcyBwYXRj aCBjYXVzZXMgdXMgdG8gc2VuZCB0b2tlbnMgdG8gdGhlIG1haW4gdGhyZWFkIHBlcmlvZGljYWxs eS4KKyAgICAgICAgVGhlIGNvbnN0YW50IGluIHRoaXMgcGF0Y2ggaXMgc29tZXdoYXQgYXJiaXRy YXJ5LiBXZSdsbCBuZWVkIHRvIHR1bmUgaXQKKyAgICAgICAgbGF0ZXIgd2l0aCBtb3JlIHJlYWxp c3RpYyB3b3JrbG9hZHMuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpbXByb3ZlcyB0aGUgcGVyZm9y bWFuY2Ugb2YgdGhlIGh0bWwtcGFyc2VyLXNyY2RvYyBiZW5jaG1hcmsKKyAgICAgICAgYnkgMTgl LiAoVGhpcyBwYXRjaCBpcyBiYXNlZCBvbiBFcmljJ3Mgd29yayBpbgorICAgICAgICBodHRwczov L2dpdGh1Yi5jb20vdG9ueWdlbnRpbGNvcmUvd2Via2l0L2NvbW1pdC8wNzIzMzExOTQ1MjBjNzc3 MGI1ZTM0YmFlZmJiYmJhOTQ4ODM0OTcxLikKKworICAgICAgICAqIGh0bWwvcGFyc2VyL0JhY2tn cm91bmRIVE1MUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29y ZTo6QmFja2dyb3VuZEhUTUxQYXJzZXI6OnB1bXBUb2tlbml6ZXIpOgorICAgICAgICAoV2ViQ29y ZTo6QmFja2dyb3VuZEhUTUxQYXJzZXI6OnNlbmRUb2tlbnNUb01haW5UaHJlYWQpOgorCiAyMDEz LTAxLTE3ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9yZz4KIAogICAgICAgICBbR1RL XSBJbmRleGVkREI6IEFkZCBMZXZlbERCIGhlYWRlcnMgdG8gaW5jbHVkZSBwYXRoIGlmIEluZGV4 ZWREQiBpcyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9C YWNrZ3JvdW5kSFRNTFBhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9CYWNr Z3JvdW5kSFRNTFBhcnNlci5jcHAKaW5kZXggNDVlOTA3ZDVmZDA2MTIwYjk3ZWNhMDJiYTVmODNm ZWQxZGQ2NWQ4Mi4uOGUyZGY3MjU2ZTM2ZWJiYjAyYTMzMDJmOTExOTg4OWQ0NTM3MmM4NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQmFja2dyb3VuZEhUTUxQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0JhY2tncm91bmRIVE1MUGFyc2Vy LmNwcApAQCAtNDcsNiArNDcsOCBAQCBzdGF0aWMgdm9pZCBjaGVja1RoYXRUb2tlbnNBcmVTYWZl VG9TZW5kVG9Bbm90aGVyVGhyZWFkKGNvbnN0IFZlY3RvcjxDb21wYWN0SFRNTAogCiAjZW5kaWYK IAorc3RhdGljIGNvbnN0IHNpemVfdCBwZW5kaW5nVG9rZW5MaW1pdCA9IDQwMDA7CisKIHR5cGVk ZWYgY29uc3Qgdm9pZCogUGFyc2VySWRlbnRpZmllcjsKIGNsYXNzIEhUTUxEb2N1bWVudFBhcnNl cjsKIApAQCAtMTU3LDExICsxNTksMTAgQEAgdm9pZCBCYWNrZ3JvdW5kSFRNTFBhcnNlcjo6cHVt cFRva2VuaXplcigpCiAgICAgICAgIC8vIEZJWE1FOiBOZWVkIHRvIHNldCBzZXRGb3JjZU51bGxD aGFyYWN0ZXJSZXBsYWNlbWVudCBiYXNlZCBvbiBtX2luRm9yZWlnbkNvbnRlbnQgYXMgd2VsbC4K ICAgICAgICAgbV90b2tlbml6ZXItPnNldFNob3VsZEFsbG93Q0RBVEEobV9pbkZvcmVpZ25Db250 ZW50KTsKICAgICAgICAgbV90b2tlbi5jbGVhcigpOwotICAgIH0KIAotI2lmbmRlZiBOREVCVUcK LSAgICBjaGVja1RoYXRUb2tlbnNBcmVTYWZlVG9TZW5kVG9Bbm90aGVyVGhyZWFkKG1fcGVuZGlu Z1Rva2Vucyk7Ci0jZW5kaWYKKyAgICAgICAgaWYgKG1fcGVuZGluZ1Rva2Vucy5zaXplKCkgPj0g cGVuZGluZ1Rva2VuTGltaXQpCisgICAgICAgICAgICBzZW5kVG9rZW5zVG9NYWluVGhyZWFkKCk7 CisgICAgfQogCiAgICAgc2VuZFRva2Vuc1RvTWFpblRocmVhZCgpOwogfQpAQCAtMTk5LDYgKzIw MCwxNSBAQCBwdWJsaWM6CiAKIHZvaWQgQmFja2dyb3VuZEhUTUxQYXJzZXI6OnNlbmRUb2tlbnNU b01haW5UaHJlYWQoKQogeworICAgIGlmIChtX3BlbmRpbmdUb2tlbnMuaXNFbXB0eSgpKSB7Cisg ICAgICAgIEFTU0VSVCghbV9pc1BhdXNlZFdhaXRpbmdGb3JTY3JpcHRzKTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKworI2lmbmRlZiBOREVCVUcKKyAgICBjaGVja1RoYXRUb2tlbnNBcmVTYWZl VG9TZW5kVG9Bbm90aGVyVGhyZWFkKG1fcGVuZGluZ1Rva2Vucyk7CisjZW5kaWYKKwogICAgIFRv a2VuRGVsaXZlcnkqIGRlbGl2ZXJ5ID0gbmV3IFRva2VuRGVsaXZlcnk7CiAgICAgZGVsaXZlcnkt PmlkZW50aWZpZXIgPSBtX3BhcnNlcklkZW50aWZlcjsKICAgICBkZWxpdmVyeS0+dG9rZW5zLnN3 YXAobV9wZW5kaW5nVG9rZW5zKTsK 183323 2013-01-17 17:06:56 -0800 2013-01-17 18:02:18 -0800 Patch bug-107201-20130117170356.patch text/plain 3080 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM0YzU0ZmQ5MTkzMDYz YjdjNGFmYzBjMTk5YWZmM2JkYTkzOGQzYS4uZjJlNWQxZDE3ZTZlMjc4OWVlMWNkYjQ0OTkyMTRk OTI4OGRkNGY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAxLTE3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQmFja2dyb3VuZEhUTUxQYXJz ZXIgc2hvdWxkIGdvIDE4JSBmYXN0ZXIgb24gaHRtbC1wYXJzZXItc3JjZG9jIGJlbmNobWFyawor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MjAxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJpb3IgdG8g dGhpcyBwYXRjaCwgd2Ugd291bGQgdG9rZW5pemUgYWxsIHRoZSBpbnB1dCBiZWZvcmUgZGVsaXZl cmluZworICAgICAgICBhbnkgdG9rZW5zIHRvIHRoZSBtYWluIHRocmVhZC4gRWZmZWN0aXZlbHks IHRoYXQgcHJldmVudGVkIHRoZQorICAgICAgICBiYWNrZ3JvdW5kIHBhcnNlciBmcm9tIHJ1bm5p bmcgaW4gcGFyYWxsZWwgd2l0aCB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgVGhpcyBwYXRj aCBjYXVzZXMgdXMgdG8gc2VuZCB0b2tlbnMgdG8gdGhlIG1haW4gdGhyZWFkIHBlcmlvZGljYWxs eS4KKyAgICAgICAgVGhlIGNvbnN0YW50IGluIHRoaXMgcGF0Y2ggaXMgc29tZXdoYXQgYXJiaXRy YXJ5LiBXZSdsbCBuZWVkIHRvIHR1bmUgaXQKKyAgICAgICAgbGF0ZXIgd2l0aCBtb3JlIHJlYWxp c3RpYyB3b3JrbG9hZHMuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpbXByb3ZlcyB0aGUgcGVyZm9y bWFuY2Ugb2YgdGhlIGh0bWwtcGFyc2VyLXNyY2RvYyBiZW5jaG1hcmsKKyAgICAgICAgYnkgMTgl LiAoVGhpcyBwYXRjaCBpcyBiYXNlZCBvbiBFcmljJ3Mgd29yayBpbgorICAgICAgICBodHRwczov L2dpdGh1Yi5jb20vdG9ueWdlbnRpbGNvcmUvd2Via2l0L2NvbW1pdC8wNzIzMzExOTQ1MjBjNzc3 MGI1ZTM0YmFlZmJiYmJhOTQ4ODM0OTcxLikKKworICAgICAgICAqIGh0bWwvcGFyc2VyL0JhY2tn cm91bmRIVE1MUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29y ZTo6QmFja2dyb3VuZEhUTUxQYXJzZXI6OnB1bXBUb2tlbml6ZXIpOgorICAgICAgICAoV2ViQ29y ZTo6QmFja2dyb3VuZEhUTUxQYXJzZXI6OnNlbmRUb2tlbnNUb01haW5UaHJlYWQpOgorCiAyMDEz LTAxLTE3ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9yZz4KIAogICAgICAgICBbR1RL XSBJbmRleGVkREI6IEFkZCBMZXZlbERCIGhlYWRlcnMgdG8gaW5jbHVkZSBwYXRoIGlmIEluZGV4 ZWREQiBpcyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9C YWNrZ3JvdW5kSFRNTFBhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9CYWNr Z3JvdW5kSFRNTFBhcnNlci5jcHAKaW5kZXggNDVlOTA3ZDVmZDA2MTIwYjk3ZWNhMDJiYTVmODNm ZWQxZGQ2NWQ4Mi4uM2NkMGY4NWU4MjM2MGY0ZWNkZmMxNTk4NzRmOTBkYTI4NjMzNGI3MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQmFja2dyb3VuZEhUTUxQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0JhY2tncm91bmRIVE1MUGFyc2Vy LmNwcApAQCAtNDcsNiArNDcsOSBAQCBzdGF0aWMgdm9pZCBjaGVja1RoYXRUb2tlbnNBcmVTYWZl VG9TZW5kVG9Bbm90aGVyVGhyZWFkKGNvbnN0IFZlY3RvcjxDb21wYWN0SFRNTAogCiAjZW5kaWYK IAorLy8gRklYTUU6IFR1bmUgdGhpcyBjb25zdGFudCBiYXNlZCBvbiBhIGJlbmNobWFyay4gVGhl IGN1cnJlbnQgdmFsdWUgd2FzIGNob29zZW4gYXJiaXRyYXJpbHkuCitzdGF0aWMgY29uc3Qgc2l6 ZV90IHBlbmRpbmdUb2tlbkxpbWl0ID0gNDAwMDsKKwogdHlwZWRlZiBjb25zdCB2b2lkKiBQYXJz ZXJJZGVudGlmaWVyOwogY2xhc3MgSFRNTERvY3VtZW50UGFyc2VyOwogCkBAIC0xNTcsMTEgKzE2 MCwxMCBAQCB2b2lkIEJhY2tncm91bmRIVE1MUGFyc2VyOjpwdW1wVG9rZW5pemVyKCkKICAgICAg ICAgLy8gRklYTUU6IE5lZWQgdG8gc2V0IHNldEZvcmNlTnVsbENoYXJhY3RlclJlcGxhY2VtZW50 IGJhc2VkIG9uIG1faW5Gb3JlaWduQ29udGVudCBhcyB3ZWxsLgogICAgICAgICBtX3Rva2VuaXpl ci0+c2V0U2hvdWxkQWxsb3dDREFUQShtX2luRm9yZWlnbkNvbnRlbnQpOwogICAgICAgICBtX3Rv a2VuLmNsZWFyKCk7Ci0gICAgfQogCi0jaWZuZGVmIE5ERUJVRwotICAgIGNoZWNrVGhhdFRva2Vu c0FyZVNhZmVUb1NlbmRUb0Fub3RoZXJUaHJlYWQobV9wZW5kaW5nVG9rZW5zKTsKLSNlbmRpZgor ICAgICAgICBpZiAobV9wZW5kaW5nVG9rZW5zLnNpemUoKSA+PSBwZW5kaW5nVG9rZW5MaW1pdCkK KyAgICAgICAgICAgIHNlbmRUb2tlbnNUb01haW5UaHJlYWQoKTsKKyAgICB9CiAKICAgICBzZW5k VG9rZW5zVG9NYWluVGhyZWFkKCk7CiB9CkBAIC0xOTksNiArMjAxLDE1IEBAIHB1YmxpYzoKIAog dm9pZCBCYWNrZ3JvdW5kSFRNTFBhcnNlcjo6c2VuZFRva2Vuc1RvTWFpblRocmVhZCgpCiB7Cisg ICAgaWYgKG1fcGVuZGluZ1Rva2Vucy5pc0VtcHR5KCkpIHsKKyAgICAgICAgQVNTRVJUKCFtX2lz UGF1c2VkV2FpdGluZ0ZvclNjcmlwdHMpOworICAgICAgICByZXR1cm47CisgICAgfQorCisjaWZu ZGVmIE5ERUJVRworICAgIGNoZWNrVGhhdFRva2Vuc0FyZVNhZmVUb1NlbmRUb0Fub3RoZXJUaHJl YWQobV9wZW5kaW5nVG9rZW5zKTsKKyNlbmRpZgorCiAgICAgVG9rZW5EZWxpdmVyeSogZGVsaXZl cnkgPSBuZXcgVG9rZW5EZWxpdmVyeTsKICAgICBkZWxpdmVyeS0+aWRlbnRpZmllciA9IG1fcGFy c2VySWRlbnRpZmVyOwogICAgIGRlbGl2ZXJ5LT50b2tlbnMuc3dhcChtX3BlbmRpbmdUb2tlbnMp Owo=