107196 2013-01-17 16:09:00 -0800 Coordinated Graphics: CoordinatedTile::updateBackBuffer() returns dirty rects. 2013-01-18 03:30:48 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105787 1 dongseong.hwang dongseong.hwang kenneth noam webkit.review.bot zeno oldest_to_newest 809915 0 dongseong.hwang 2013-01-17 16:09:00 -0800 Currently, CoordinatedTile::updateBackBuffer() always returns an empty vector. This patch makes CoordinatedTile::updateBackBuffer() return correct dirty rects. 809916 1 183304 dongseong.hwang 2013-01-17 16:10:12 -0800 Created attachment 183304 Patch 810367 2 183304 kenneth 2013-01-18 01:45:41 -0800 Comment on attachment 183304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:103 > + Vector<IntRect> updatedRects; > + updatedRects.append(m_dirtyRect); > m_dirtyRect = IntRect(); > - return Vector<IntRect>(); > + return updatedRects; Why are we returning a vector? isnt m_dirtyRect not just one rect? 810374 3 183304 dongseong.hwang 2013-01-18 01:53:05 -0800 Comment on attachment 183304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:103 >> + return updatedRects; > > Why are we returning a vector? isnt m_dirtyRect not just one rect? CoordinatedTile::updateBackBuffer() overrides Tile::updateBackBuffer(), and Tile::updateBackBuffer() returns vector. We can refactor it later :) 810396 4 183304 kenneth 2013-01-18 02:14:07 -0800 Comment on attachment 183304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review > Source/WebKit2/ChangeLog:9 > + This patch makes CoordinatedTile::updateBackBuffer() return correct dirty rects. rect* - you could refrase 810404 5 183412 dongseong.hwang 2013-01-18 02:26:45 -0800 Created attachment 183412 Patch for land 810434 6 183412 webkit.review.bot 2013-01-18 03:30:44 -0800 Comment on attachment 183412 Patch for land Clearing flags on attachment: 183412 Committed r140118: <http://trac.webkit.org/changeset/140118> 810435 7 webkit.review.bot 2013-01-18 03:30:48 -0800 All reviewed patches have been landed. Closing bug. 183304 2013-01-17 16:10:12 -0800 2013-01-18 02:27:15 -0800 Patch bug-107196-20130118090705.patch text/plain 1723 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5OTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTI4NDBiODhmNTYyNzI2 YzkzNGM4YWJiZjUzNDQ3ODMxMjE5ZGVlNC4uMDFhOGIxNzcwYzEwOTg3MzZkYTcyNWI5ZTczZWZm ODFlZjQxYmIzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTE3ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBDb29yZGluYXRlZFRpbGU6OnVwZGF0ZUJhY2tCdWZmZXIoKSByZXR1cm5z IGRpcnR5IHJlY3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA3MTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ3VycmVudGx5LCBDb29yZGluYXRlZFRpbGU6OnVwZGF0ZUJhY2tCdWZmZXIoKSBhbHdh eXMgcmV0dXJucyBhbiBlbXB0eSB2ZWN0b3IuCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgQ29v cmRpbmF0ZWRUaWxlOjp1cGRhdGVCYWNrQnVmZmVyKCkgcmV0dXJuIGNvcnJlY3QgZGlydHkgcmVj dHMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZFRpbGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZFRpbGU6OnVw ZGF0ZUJhY2tCdWZmZXIpOgorCiAyMDEzLTAxLTE2ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxh QGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFtUZXhtYXBdIFJlZmFjdG9yIGNvZGUgcmVsYXRl ZCB0byBkZWJ1ZyBib3JkZXIgYW5kIHJlcGFpbnQgY291bnQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRl ZFRpbGUuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVk R3JhcGhpY3MvQ29vcmRpbmF0ZWRUaWxlLmNwcAppbmRleCA3OThkMmI3NWYyNTBkYTY3MjlmZjli Y2U1MGU4OGMyOTEyOTQwYjhlLi5hYzBiNTY2MjZlODFmMTBiMTg3NjJiOThmMzY1ODA0ZjhlMzI2 MTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRp bmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZFRpbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkVGlsZS5jcHAK QEAgLTk3LDggKzk3LDEwIEBAIFZlY3RvcjxJbnRSZWN0PiBDb29yZGluYXRlZFRpbGU6OnVwZGF0 ZUJhY2tCdWZmZXIoKQogICAgIH0gZWxzZQogICAgICAgICBtX2NsaWVudC0+dXBkYXRlVGlsZSht X0lELCB1cGRhdGVJbmZvLCBtX3JlY3QpOwogCisgICAgVmVjdG9yPEludFJlY3Q+IHVwZGF0ZWRS ZWN0czsKKyAgICB1cGRhdGVkUmVjdHMuYXBwZW5kKG1fZGlydHlSZWN0KTsKICAgICBtX2RpcnR5 UmVjdCA9IEludFJlY3QoKTsKLSAgICByZXR1cm4gVmVjdG9yPEludFJlY3Q+KCk7CisgICAgcmV0 dXJuIHVwZGF0ZWRSZWN0czsKIH0KIAogdm9pZCBDb29yZGluYXRlZFRpbGU6OnN3YXBCYWNrQnVm ZmVyVG9Gcm9udCgpCg== 183412 2013-01-18 02:26:45 -0800 2013-01-18 03:30:44 -0800 Patch for land bug-107196-20130118192337.patch text/plain 1749 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGI2MWU2NTdkNjc5YzAz MGExYTRiZjMxZTJhYWVkNzNjNzI1YjQ4ZS4uMDRlNzg4YjgyNGRlMzBhMjZlNmFiNWE1YjEyMmMw N2ZkNGUyOWFhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTE3ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBDb29yZGluYXRlZFRpbGU6OnVwZGF0ZUJhY2tCdWZmZXIoKSByZXR1cm5z IGEgZGlydHkgcmVjdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNzE5NgorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuLgorCisgICAgICAgIEN1cnJlbnRseSwgQ29vcmRpbmF0ZWRUaWxlOjp1cGRhdGVCYWNr QnVmZmVyKCkgYWx3YXlzIHJldHVybnMgYW4gZW1wdHkgdmVjdG9yLgorICAgICAgICBUaGlzIHBh dGNoIG1ha2VzIENvb3JkaW5hdGVkVGlsZTo6dXBkYXRlQmFja0J1ZmZlcigpIHJldHVybiBhIGNv cnJlY3QgZGlydHkgcmVjdC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkVGlsZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNvb3Jk aW5hdGVkVGlsZTo6dXBkYXRlQmFja0J1ZmZlcik6CisKIDIwMTMtMDEtMTcgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjEzOTUxNik6 IE5ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXI6OnJlY2VpdmVkUmVkaXJlY3QgaXMgbm90IGNh bGxlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29y ZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkVGlsZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZFRpbGUuY3BwCmlu ZGV4IDc5OGQyYjc1ZjI1MGRhNjcyOWZmOWJjZTUwZTg4YzI5MTI5NDBiOGUuLmFjMGI1NjYyNmU4 MWYxMGIxODc2MmI5OGYzNjU4MDRmOGUzMjYxNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkVGlsZS5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvQ29vcmRpbmF0ZWRUaWxlLmNwcApAQCAtOTcsOCArOTcsMTAgQEAgVmVjdG9yPEludFJl Y3Q+IENvb3JkaW5hdGVkVGlsZTo6dXBkYXRlQmFja0J1ZmZlcigpCiAgICAgfSBlbHNlCiAgICAg ICAgIG1fY2xpZW50LT51cGRhdGVUaWxlKG1fSUQsIHVwZGF0ZUluZm8sIG1fcmVjdCk7CiAKKyAg ICBWZWN0b3I8SW50UmVjdD4gdXBkYXRlZFJlY3RzOworICAgIHVwZGF0ZWRSZWN0cy5hcHBlbmQo bV9kaXJ0eVJlY3QpOwogICAgIG1fZGlydHlSZWN0ID0gSW50UmVjdCgpOwotICAgIHJldHVybiBW ZWN0b3I8SW50UmVjdD4oKTsKKyAgICByZXR1cm4gdXBkYXRlZFJlY3RzOwogfQogCiB2b2lkIENv b3JkaW5hdGVkVGlsZTo6c3dhcEJhY2tCdWZmZXJUb0Zyb250KCkK