107188 2013-01-17 15:11:29 -0800 Reorganize webkitdirs.pm into modular pieces 2013-01-26 00:30:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All ASSIGNED P3 Enhancement --- 1 dfarler dfarler ddkilzer oldest_to_newest 809857 0 dfarler 2013-01-17 15:11:29 -0800 webkitdirs.pm is currently too state-oriented and overloaded in functionality to easily extend. I propose the following: - Separate ports and extend a common interface - Separate the concerns of command line options, utility functions, etc. - Recommend rewrite in something like Python - Automatically generate usage help using something like argparse - Reduce reliance on state - *Do not* mutate ARGV For command line options: - dynamically add argument sub-parsers depending on the tool and port For utility functions: - separate the various ports to ease merging and preventing interference All of this might entail refactoring a lot of the tools but I think the long-term benefit would be worth it. Being able to centralize library behavior so that all ports can extend or utilize modules without interfering with each other would be a good thing.