107164 2013-01-17 13:04:34 -0800 Fix a logic error in AuthenticationChallengeMac 2013-01-17 13:52:21 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap beidson sam oldest_to_newest 809673 0 ap 2013-01-17 13:04:34 -0800 AuthenticationChallenge::setAuthenticationClient creates a dummy m_nsChallenge if there was none. We do not want incorrect fields like this, as they may be picked up by callers. I don't think that this causes any observable badness yet, even though this code path is hit in NetworkProcess authentication delegates. 809689 1 183255 ap 2013-01-17 13:16:46 -0800 Created attachment 183255 proposed patch 809738 2 ap 2013-01-17 13:52:21 -0800 Committed <http://trac.webkit.org/changeset/140037>. 183255 2013-01-17 13:16:46 -0800 2013-01-17 13:22:24 -0800 proposed patch AuthenticationChallenge.txt text/plain 3727 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDAzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTE3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBhIGxvZ2ljIGVycm9y IGluIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlTWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcxNjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFzIHRoaXMgaXMgbm90IGN1cnJl bnRseSBvYnNlcnZhYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9BdXRoZW50 aWNhdGlvbkNGLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUNGKTogQWRkZCBhIEZJWE1F IGFib3V0IG1ha2luZyB0aGlzIG1vcmUgbGlrZSBNYWMgY291bnRlcnBhcnQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL2NmL0F1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlLmg6CisgICAgICAg IChBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSk6IENvcnJlY3RlZCBhbiBzbGlnaHRseSBtaXNsZWFk aW5nIGV4cGxhbmF0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9tYWMvQXV0aGVu dGljYXRpb25NYWMubW06CisgICAgICAgIChXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5n ZTo6c2V0QXV0aGVudGljYXRpb25DbGllbnQpOiBEb24ndCBjcmVhdGUgYSBkdW1teQorICAgICAg ICBtX25zQ2hhbGxlbmdlIG9iamVjdCBpbiBwbGFjZSBvZiBhIG5pbCBvbmUuCisKIDIwMTMtMDEt MTcgIFBvdWwgU3lzb2x5YXRpbiAgPHBzeXRvbnhAZ21haWwuY29tPgogCiAgICAgICAgIDMyLWJp dCBidWlsZCBmb3IgUXQ1IG9uIE1hYyBPUyBmYWlscy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY2YvQXV0aGVudGljYXRpb25DRi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9BdXRoZW50aWNhdGlvbkNGLmNwcAkocmV2 aXNpb24gMTM5OTkxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9BdXRo ZW50aWNhdGlvbkNGLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTQsNyArOTQsOSBAQCBib29sIEF1 dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOjpwbGF0Zm9ybUNvCiB9CiAKIENGVVJMQXV0aENoYWxsZW5n ZVJlZiBjcmVhdGVDRihjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYgY29yZUNoYWxsZW5n ZSkKLXsgIAoreworICAgIC8vIEZJWE1FOiBXaHkgbm90IGNhY2hlIENGVVJMQXV0aENoYWxsZW5n ZVJlZiBpbiBtX2NmQ2hhbGxlbmdlPyBGb3VuZGF0aW9uIGNvdW50ZXJwYXJ0IGRvZXMgdGhhdC4K KwogICAgIENGVVJMUHJvdGVjdGlvblNwYWNlUmVmIHByb3RlY3Rpb25TcGFjZSA9IGNyZWF0ZUNG KGNvcmVDaGFsbGVuZ2UucHJvdGVjdGlvblNwYWNlKCkpOwogICAgIENGVVJMQ3JlZGVudGlhbFJl ZiBjcmVkZW50aWFsID0gY3JlYXRlQ0YoY29yZUNoYWxsZW5nZS5wcm9wb3NlZENyZWRlbnRpYWwo KSk7CiAgICAgCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0F1dGhl bnRpY2F0aW9uQ2hhbGxlbmdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jZi9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZS5oCShyZXZpc2lvbiAxMzk5OTEp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0F1dGhlbnRpY2F0aW9uQ2hh bGxlbmdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTcxLDExICs3MSwxMiBAQCBwcml2YXRlOgogICAg IGZyaWVuZCBjbGFzcyBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZUJhc2U7CiAgICAgc3RhdGljIGJv b2wgcGxhdGZvcm1Db21wYXJlKGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJiBhLCBjb25z dCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYgYik7CiAKKyAgICAvLyBQbGF0Zm9ybSBjaGFsbGVu Z2UgbWF5IGJlIG51bGwuIElmIGl0J3Mgbm9uLW51bGwsIGl0J3MgYWx3YXlzIHVwIHRvIGRhdGUg d2l0aCBvdGhlciBmaWVsZHMuCiAjaWYgVVNFKENGTkVUV09SSykKICAgICBSZWZQdHI8QXV0aGVu dGljYXRpb25DbGllbnQ+IG1fYXV0aGVudGljYXRpb25DbGllbnQ7CiAgICAgUmV0YWluUHRyPENG VVJMQXV0aENoYWxsZW5nZVJlZj4gbV9jZkNoYWxsZW5nZTsKICNlbHNlCi0gICAgUmV0YWluUHRy PGlkPiBtX3NlbmRlcjsgLy8gQWx3YXlzIHRoZSBzYW1lIGFzIFttX21hY0NoYWxsZW5nZS5nZXQo KSBzZW5kZXJdLCBjYWNoZWQgaGVyZSBmb3IgcGVyZm9ybWFuY2UuCisgICAgUmV0YWluUHRyPGlk PiBtX3NlbmRlcjsKICAgICBSZXRhaW5QdHI8TlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSAq PiBtX25zQ2hhbGxlbmdlOwogI2VuZGlmCiB9OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9tYWMvQXV0aGVudGljYXRpb25NYWMubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvQXV0aGVudGljYXRpb25NYWMubW0JKHJldmlz aW9uIDEzOTk5MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL0F1dGhl bnRpY2F0aW9uTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMDcsNyArMjA3LDggQEAgdm9pZCBB dXRoZW50aWNhdGlvbkNoYWxsZW5nZTo6c2V0QXV0aGVudAogewogICAgIGlmIChjbGllbnQpIHsK ICAgICAgICAgbV9zZW5kZXIuYWRvcHROUyhbW1dlYkNvcmVBdXRoZW50aWNhdGlvbkNsaWVudEFz Q2hhbGxlbmdlU2VuZGVyIGFsbG9jXSBpbml0V2l0aEF1dGhlbnRpY2F0aW9uQ2xpZW50OmNsaWVu dF0pOwotICAgICAgICBtX25zQ2hhbGxlbmdlLmFkb3B0TlMoW1tOU1VSTEF1dGhlbnRpY2F0aW9u Q2hhbGxlbmdlIGFsbG9jXSBpbml0V2l0aEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOm1fbnNDaGFs bGVuZ2UuZ2V0KCkgc2VuZGVyOm1fc2VuZGVyLmdldCgpXSk7CisgICAgICAgIGlmIChtX25zQ2hh bGxlbmdlKQorICAgICAgICAgICAgbV9uc0NoYWxsZW5nZS5hZG9wdE5TKFtbTlNVUkxBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZSBhbGxvY10gaW5pdFdpdGhBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTpt X25zQ2hhbGxlbmdlLmdldCgpIHNlbmRlcjptX3NlbmRlci5nZXQoKV0pOwogICAgIH0gZWxzZSB7 CiAgICAgICAgIGlmIChbbV9zZW5kZXIuZ2V0KCkgaXNNZW1iZXJPZkNsYXNzOltXZWJDb3JlQXV0 aGVudGljYXRpb25DbGllbnRBc0NoYWxsZW5nZVNlbmRlciBjbGFzc11dKQogICAgICAgICAgICAg WyhXZWJDb3JlQXV0aGVudGljYXRpb25DbGllbnRBc0NoYWxsZW5nZVNlbmRlciAqKW1fc2VuZGVy LmdldCgpIGRldGFjaENsaWVudF07Cg==