107128 2013-01-17 07:58:38 -0800 MediaStream API: Move all ExtraDataContainers into anonymous namespaces 2013-01-17 11:49:44 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw eric.carlson feature-media-reviews haraken webkit.review.bot oldest_to_newest 809331 0 tommyw 2013-01-17 07:58:38 -0800 Since there are more than one with the same name they need to be moved into anonymous namespaces. 809336 1 183186 tommyw 2013-01-17 08:05:19 -0800 Created attachment 183186 Patch 809355 2 183186 haraken 2013-01-17 08:33:39 -0800 Comment on attachment 183186 Patch Looks OK 809574 3 183186 webkit.review.bot 2013-01-17 11:49:41 -0800 Comment on attachment 183186 Patch Clearing flags on attachment: 183186 Committed r140017: <http://trac.webkit.org/changeset/140017> 809575 4 webkit.review.bot 2013-01-17 11:49:44 -0800 All reviewed patches have been landed. Closing bug. 183186 2013-01-17 08:05:19 -0800 2013-01-17 11:49:40 -0800 Patch bug-107128-20130117170219.patch text/plain 7520 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5OTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRiZTViMDFlNzRiZWFm ZDhkNGIwODRkM2RhZmE4ODNiZTg2ZTQ3Yy4uYTdkMWM5ZmIzZGY2MzYxNmI0ZTU0MzMwM2I3MzRh MjZjZWMwMWM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTE3ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogTW92ZSBhbGwgRXh0cmFEYXRhQ29udGFpbmVycyBpbnRvIGFub255bW91cyBuYW1lc3Bh Y2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcx MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 cyBub3QgbmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJN ZWRpYVN0cmVhbURlc2NyaXB0b3IuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3N1 cHBvcnQvV2ViTWVkaWFTdHJlYW1Tb3VyY2UuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL3N1cHBvcnQvV2ViUlRDU2Vzc2lvbkRlc2NyaXB0aW9uUmVxdWVzdC5jcHA6CisgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJSVENWb2lkUmVxdWVzdC5jcHA6CisKIDIw MTMtMDEtMTcgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogYWRkIGNyZWF0ZU9wdGlvbiBtZXRob2QgdG8gV2ViSW5zcGVjdG9y LlN0YXR1c0JhckNvbWJvQm94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9zdXBwb3J0L1dlYk1lZGlhU3RyZWFtRGVzY3JpcHRvci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYk1lZGlhU3RyZWFtRGVzY3JpcHRvci5j cHAKaW5kZXggNDEwNzQ0ZGIwYjQyYzMyNGUxYmMwZjc4NmRhMDY0MzQ1M2VkNGUxZi4uZjdhMzEy ZmM1N2E4NzhhYmZkMGYwMWI4Yjk0NzU4MjM2YzM5OTdkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJNZWRpYVN0cmVhbURlc2NyaXB0b3Iu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvV2ViTWVk aWFTdHJlYW1EZXNjcmlwdG9yLmNwcApAQCAtNDgsNiArNDgsMjAgQEAgdXNpbmcgbmFtZXNwYWNl IFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCituYW1lc3BhY2UgeworCitjbGFzcyBF eHRyYURhdGFDb250YWluZXIgOiBwdWJsaWMgTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjpFeHRyYURh dGEgeworcHVibGljOgorICAgIEV4dHJhRGF0YUNvbnRhaW5lcihXZWJNZWRpYVN0cmVhbURlc2Ny aXB0b3I6OkV4dHJhRGF0YSogZXh0cmFEYXRhKSA6IG1fZXh0cmFEYXRhKGFkb3B0UHRyKGV4dHJh RGF0YSkpIHsgfQorCisgICAgV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjpFeHRyYURhdGEqIGV4 dHJhRGF0YSgpIHsgcmV0dXJuIG1fZXh0cmFEYXRhLmdldCgpOyB9CisKK3ByaXZhdGU6CisgICAg T3duUHRyPFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcjo6RXh0cmFEYXRhPiBtX2V4dHJhRGF0YTsK K307CisKK30gLy8gbmFtZXNwYWNlCisKIFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcjo6V2ViTWVk aWFTdHJlYW1EZXNjcmlwdG9yKGNvbnN0IFBhc3NSZWZQdHI8V2ViQ29yZTo6TWVkaWFTdHJlYW1E ZXNjcmlwdG9yPiYgbWVkaWFTdHJlYW1EZXNjcmlwdG9yKQogICAgIDogbV9wcml2YXRlKG1lZGlh U3RyZWFtRGVzY3JpcHRvcikKIHsKQEAgLTczLDE2ICs4Nyw2IEBAIFdlYlN0cmluZyBXZWJNZWRp YVN0cmVhbURlc2NyaXB0b3I6OmlkKCkgY29uc3QKICAgICByZXR1cm4gbV9wcml2YXRlLT5pZCgp OwogfQogCi1jbGFzcyBFeHRyYURhdGFDb250YWluZXIgOiBwdWJsaWMgV2ViQ29yZTo6TWVkaWFT dHJlYW1EZXNjcmlwdG9yOjpFeHRyYURhdGEgewotcHVibGljOgotICAgIEV4dHJhRGF0YUNvbnRh aW5lcihXZWJNZWRpYVN0cmVhbURlc2NyaXB0b3I6OkV4dHJhRGF0YSogZXh0cmFEYXRhKSA6IG1f ZXh0cmFEYXRhKFdURjo6YWRvcHRQdHIoZXh0cmFEYXRhKSkgeyB9Ci0KLSAgICBXZWJNZWRpYVN0 cmVhbURlc2NyaXB0b3I6OkV4dHJhRGF0YSogZXh0cmFEYXRhKCkgeyByZXR1cm4gbV9leHRyYURh dGEuZ2V0KCk7IH0KLQotcHJpdmF0ZToKLSAgICBPd25QdHI8V2ViTWVkaWFTdHJlYW1EZXNjcmlw dG9yOjpFeHRyYURhdGE+IG1fZXh0cmFEYXRhOwotfTsKLQogV2ViTWVkaWFTdHJlYW1EZXNjcmlw dG9yOjpFeHRyYURhdGEqIFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcjo6ZXh0cmFEYXRhKCkgY29u c3QKIHsKICAgICBSZWZQdHI8TWVkaWFTdHJlYW1EZXNjcmlwdG9yOjpFeHRyYURhdGE+IGRhdGEg PSBtX3ByaXZhdGUtPmV4dHJhRGF0YSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJNZWRpYVN0cmVhbVNvdXJjZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYk1lZGlhU3RyZWFtU291cmNlLmNw cAppbmRleCA2NWEzOWRmOTNjOWNlNjU2MzZlNWFhZGRkZTc1ZDczYmJmYTQ4Mjc5Li4xNWE3M2I5 MzRhM2I4MWI0ZjNiM2I0MWNiYWEyZmYxMmNhOWMyNzdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYk1lZGlhU3RyZWFtU291cmNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYk1lZGlhU3Ry ZWFtU291cmNlLmNwcApAQCAtNDYsNiArNDYsMjAgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7 CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCituYW1lc3BhY2UgeworCitjbGFzcyBFeHRyYURhdGFD b250YWluZXIgOiBwdWJsaWMgTWVkaWFTdHJlYW1Tb3VyY2U6OkV4dHJhRGF0YSB7CitwdWJsaWM6 CisgICAgRXh0cmFEYXRhQ29udGFpbmVyKFdlYk1lZGlhU3RyZWFtU291cmNlOjpFeHRyYURhdGEq IGV4dHJhRGF0YSkgOiBtX2V4dHJhRGF0YShhZG9wdFB0cihleHRyYURhdGEpKSB7IH0KKworICAg IFdlYk1lZGlhU3RyZWFtU291cmNlOjpFeHRyYURhdGEqIGV4dHJhRGF0YSgpIHsgcmV0dXJuIG1f ZXh0cmFEYXRhLmdldCgpOyB9CisKK3ByaXZhdGU6CisgICAgT3duUHRyPFdlYk1lZGlhU3RyZWFt U291cmNlOjpFeHRyYURhdGE+IG1fZXh0cmFEYXRhOworfTsKKworfSAvLyBuYW1lc3BhY2UKKwog V2ViTWVkaWFTdHJlYW1Tb3VyY2U6OldlYk1lZGlhU3RyZWFtU291cmNlKGNvbnN0IFBhc3NSZWZQ dHI8TWVkaWFTdHJlYW1Tb3VyY2U+JiBtZWRpYVN0cmVhbVNvdXJjZSkKICAgICA6IG1fcHJpdmF0 ZShtZWRpYVN0cmVhbVNvdXJjZSkKIHsKQEAgLTExMiwxNiArMTI2LDYgQEAgV2ViTWVkaWFTdHJl YW1Tb3VyY2U6OlJlYWR5U3RhdGUgV2ViTWVkaWFTdHJlYW1Tb3VyY2U6OnJlYWR5U3RhdGUoKSBj b25zdAogICAgIHJldHVybiBzdGF0aWNfY2FzdDxSZWFkeVN0YXRlPihtX3ByaXZhdGUtPnJlYWR5 U3RhdGUoKSk7CiB9CiAKLWNsYXNzIEV4dHJhRGF0YUNvbnRhaW5lciA6IHB1YmxpYyBXZWJDb3Jl OjpNZWRpYVN0cmVhbVNvdXJjZTo6RXh0cmFEYXRhIHsKLXB1YmxpYzoKLSAgICBFeHRyYURhdGFD b250YWluZXIoV2ViTWVkaWFTdHJlYW1Tb3VyY2U6OkV4dHJhRGF0YSogZXh0cmFEYXRhKSA6IG1f ZXh0cmFEYXRhKFdURjo6YWRvcHRQdHIoZXh0cmFEYXRhKSkgeyB9Ci0KLSAgICBXZWJNZWRpYVN0 cmVhbVNvdXJjZTo6RXh0cmFEYXRhKiBleHRyYURhdGEoKSB7IHJldHVybiBtX2V4dHJhRGF0YS5n ZXQoKTsgfQotCi1wcml2YXRlOgotICAgIE93blB0cjxXZWJNZWRpYVN0cmVhbVNvdXJjZTo6RXh0 cmFEYXRhPiBtX2V4dHJhRGF0YTsKLX07Ci0KIFdlYk1lZGlhU3RyZWFtU291cmNlOjpFeHRyYURh dGEqIFdlYk1lZGlhU3RyZWFtU291cmNlOjpleHRyYURhdGEoKSBjb25zdAogewogICAgIEFTU0VS VCghbV9wcml2YXRlLmlzTnVsbCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL3N1cHBvcnQvV2ViUlRDU2Vzc2lvbkRlc2NyaXB0aW9uUmVxdWVzdC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYlJUQ1Nlc3Npb25E ZXNjcmlwdGlvblJlcXVlc3QuY3BwCmluZGV4IDAwZDdlNmI4NjMzZmY2YjBiYjM3YTQ0ODEyYTE0 NWNjYzEzY2UwYTAuLmEzY2I4NDkzMzViYjE2YjhiNzdkZTIwMzAyZWRhMTc0YTIwMWYwMzcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvV2ViUlRD U2Vzc2lvbkRlc2NyaXB0aW9uUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vc3VwcG9ydC9XZWJSVENTZXNzaW9uRGVzY3JpcHRpb25SZXF1ZXN0LmNwcApA QCAtNDMsNiArNDMsMjAgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBX ZWJLaXQgewogCituYW1lc3BhY2UgeworCitjbGFzcyBFeHRyYURhdGFDb250YWluZXIgOiBwdWJs aWMgUlRDU2Vzc2lvbkRlc2NyaXB0aW9uUmVxdWVzdDo6RXh0cmFEYXRhIHsKK3B1YmxpYzoKKyAg ICBFeHRyYURhdGFDb250YWluZXIoV2ViUlRDU2Vzc2lvbkRlc2NyaXB0aW9uUmVxdWVzdDo6RXh0 cmFEYXRhKiBleHRyYURhdGEpIDogbV9leHRyYURhdGEoYWRvcHRQdHIoZXh0cmFEYXRhKSkgeyB9 CisKKyAgICBXZWJSVENTZXNzaW9uRGVzY3JpcHRpb25SZXF1ZXN0OjpFeHRyYURhdGEqIGV4dHJh RGF0YSgpIHsgcmV0dXJuIG1fZXh0cmFEYXRhLmdldCgpOyB9CisKK3ByaXZhdGU6CisgICAgT3du UHRyPFdlYlJUQ1Nlc3Npb25EZXNjcmlwdGlvblJlcXVlc3Q6OkV4dHJhRGF0YT4gbV9leHRyYURh dGE7Cit9OworCit9IC8vIG5hbWVzcGFjZQorCiBXZWJSVENTZXNzaW9uRGVzY3JpcHRpb25SZXF1 ZXN0OjpXZWJSVENTZXNzaW9uRGVzY3JpcHRpb25SZXF1ZXN0KGNvbnN0IFBhc3NSZWZQdHI8UlRD U2Vzc2lvbkRlc2NyaXB0aW9uUmVxdWVzdD4mIGNvbnN0cmFpbnRzKQogICAgIDogbV9wcml2YXRl KGNvbnN0cmFpbnRzKQogewpAQCAtNzAsMTYgKzg0LDYgQEAgdm9pZCBXZWJSVENTZXNzaW9uRGVz Y3JpcHRpb25SZXF1ZXN0OjpyZXF1ZXN0RmFpbGVkKGNvbnN0IFdlYlN0cmluZyYgZXJyb3IpIGNv bnMKICAgICBtX3ByaXZhdGUtPnJlcXVlc3RGYWlsZWQoZXJyb3IpOwogfQogCi1jbGFzcyBFeHRy YURhdGFDb250YWluZXIgOiBwdWJsaWMgV2ViQ29yZTo6UlRDU2Vzc2lvbkRlc2NyaXB0aW9uUmVx dWVzdDo6RXh0cmFEYXRhIHsKLXB1YmxpYzoKLSAgICBFeHRyYURhdGFDb250YWluZXIoV2ViUlRD U2Vzc2lvbkRlc2NyaXB0aW9uUmVxdWVzdDo6RXh0cmFEYXRhKiBleHRyYURhdGEpIDogbV9leHRy YURhdGEoV1RGOjphZG9wdFB0cihleHRyYURhdGEpKSB7IH0KLQotICAgIFdlYlJUQ1Nlc3Npb25E ZXNjcmlwdGlvblJlcXVlc3Q6OkV4dHJhRGF0YSogZXh0cmFEYXRhKCkgeyByZXR1cm4gbV9leHRy YURhdGEuZ2V0KCk7IH0KLQotcHJpdmF0ZToKLSAgICBPd25QdHI8V2ViUlRDU2Vzc2lvbkRlc2Ny aXB0aW9uUmVxdWVzdDo6RXh0cmFEYXRhPiBtX2V4dHJhRGF0YTsKLX07Ci0KIFdlYlJUQ1Nlc3Np b25EZXNjcmlwdGlvblJlcXVlc3Q6OkV4dHJhRGF0YSogV2ViUlRDU2Vzc2lvbkRlc2NyaXB0aW9u UmVxdWVzdDo6ZXh0cmFEYXRhKCkgY29uc3QKIHsKICAgICBSZWZQdHI8UlRDU2Vzc2lvbkRlc2Ny aXB0aW9uUmVxdWVzdDo6RXh0cmFEYXRhPiBkYXRhID0gbV9wcml2YXRlLT5leHRyYURhdGEoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvV2Vi UlRDVm9pZFJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3Vw cG9ydC9XZWJSVENWb2lkUmVxdWVzdC5jcHAKaW5kZXggMmUyNDIxOTNiYWRlZmVlNTJmNDg1YWQz ODZlOGE4MDk0ZmMwNWUyZi4uZGJhM2YyODFiZmRhN2FlODU0ZGE2ZDVhMWM3YmRjZTE1MjJjNTdj OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9X ZWJSVENWb2lkUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vc3VwcG9ydC9XZWJSVENWb2lkUmVxdWVzdC5jcHAKQEAgLTQxLDYgKzQxLDIwIEBAIHVzaW5n IG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorbmFtZXNwYWNlIHsK KworY2xhc3MgRXh0cmFEYXRhQ29udGFpbmVyIDogcHVibGljIFJUQ1ZvaWRSZXF1ZXN0OjpFeHRy YURhdGEgeworcHVibGljOgorICAgIEV4dHJhRGF0YUNvbnRhaW5lcihXZWJSVENWb2lkUmVxdWVz dDo6RXh0cmFEYXRhKiBleHRyYURhdGEpIDogbV9leHRyYURhdGEoYWRvcHRQdHIoZXh0cmFEYXRh KSkgeyB9CisKKyAgICBXZWJSVENWb2lkUmVxdWVzdDo6RXh0cmFEYXRhKiBleHRyYURhdGEoKSB7 IHJldHVybiBtX2V4dHJhRGF0YS5nZXQoKTsgfQorCitwcml2YXRlOgorICAgIE93blB0cjxXZWJS VENWb2lkUmVxdWVzdDo6RXh0cmFEYXRhPiBtX2V4dHJhRGF0YTsKK307CisKK30gLy8gbmFtZXNw YWNlCisKIFdlYlJUQ1ZvaWRSZXF1ZXN0OjpXZWJSVENWb2lkUmVxdWVzdChjb25zdCBQYXNzUmVm UHRyPFJUQ1ZvaWRSZXF1ZXN0PiYgY29uc3RyYWludHMpCiAgICAgOiBtX3ByaXZhdGUoY29uc3Ry YWludHMpCiB7CkBAIC02OCwxNiArODIsNiBAQCB2b2lkIFdlYlJUQ1ZvaWRSZXF1ZXN0OjpyZXF1 ZXN0RmFpbGVkKGNvbnN0IFdlYlN0cmluZyYgZXJyb3IpIGNvbnN0CiAgICAgbV9wcml2YXRlLT5y ZXF1ZXN0RmFpbGVkKGVycm9yKTsKIH0KIAotY2xhc3MgRXh0cmFEYXRhQ29udGFpbmVyIDogcHVi bGljIFdlYkNvcmU6OlJUQ1ZvaWRSZXF1ZXN0OjpFeHRyYURhdGEgewotcHVibGljOgotICAgIEV4 dHJhRGF0YUNvbnRhaW5lcihXZWJSVENWb2lkUmVxdWVzdDo6RXh0cmFEYXRhKiBleHRyYURhdGEp IDogbV9leHRyYURhdGEoV1RGOjphZG9wdFB0cihleHRyYURhdGEpKSB7IH0KLQotICAgIFdlYlJU Q1ZvaWRSZXF1ZXN0OjpFeHRyYURhdGEqIGV4dHJhRGF0YSgpIHsgcmV0dXJuIG1fZXh0cmFEYXRh LmdldCgpOyB9Ci0KLXByaXZhdGU6Ci0gICAgT3duUHRyPFdlYlJUQ1ZvaWRSZXF1ZXN0OjpFeHRy YURhdGE+IG1fZXh0cmFEYXRhOwotfTsKLQogV2ViUlRDVm9pZFJlcXVlc3Q6OkV4dHJhRGF0YSog V2ViUlRDVm9pZFJlcXVlc3Q6OmV4dHJhRGF0YSgpIGNvbnN0CiB7CiAgICAgUmVmUHRyPFJUQ1Zv aWRSZXF1ZXN0OjpFeHRyYURhdGE+IGRhdGEgPSBtX3ByaXZhdGUtPmV4dHJhRGF0YSgpOwo=