107127 2013-01-17 07:44:27 -0800 Web Inspector: InstrumentingAgents should be registered in InspectorInstrumentation only when there is a front-end 2013-01-17 11:43:46 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 809328 0 yurys 2013-01-17 07:44:27 -0800 Currently InspectorInstrumentation::registerInstrumentingAgents is called in InspectorController constructor which is suboptimal as it is enough to register corresponding InstrumentingAgents only while front-end is attached to the InspectorController. 809329 1 183184 yurys 2013-01-17 07:46:17 -0800 Created attachment 183184 Patch 809565 2 183184 webkit.review.bot 2013-01-17 11:43:42 -0800 Comment on attachment 183184 Patch Clearing flags on attachment: 183184 Committed r140015: <http://trac.webkit.org/changeset/140015> 809567 3 webkit.review.bot 2013-01-17 11:43:46 -0800 All reviewed patches have been landed. Closing bug. 183184 2013-01-17 07:46:17 -0800 2013-01-17 11:43:42 -0800 Patch bug-107127-20130117194317.patch text/plain 2949 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5OTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRiZTViMDFlNzRiZWFm ZDhkNGIwODRkM2RhZmE4ODNiZTg2ZTQ3Yy4uNzlhOGIyOGQ4NDE1ODMwNGM2YzRmYmY4NjY1YmMz YzEyMzBlYTNmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTE3ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEluc3RydW1lbnRpbmdBZ2VudHMgc2hvdWxkIGJlIHJlZ2lzdGVyZWQgaW4gSW5zcGVjdG9y SW5zdHJ1bWVudGF0aW9uIG9ubHkgd2hlbiB0aGVyZSBpcyBhIGZyb250LWVuZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MTI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zcGVjdG9ySW5zdHJ1bWVu dGF0aW9uOjpyZWdpc3Rlckluc3RydW1lbnRpbmdBZ2VudHMgaXMgY2FsbGVkIHdoZW4gZnJvbnQt ZW5kCisgICAgICAgIGlzIGNvbm5lY3RlZCB0byBjb3JyZXNwb25kaW5nIEluc3BlY3RvckNvbnRy b2xsZXIuIFdoZW4gdGhlIGZyb250LWVuZCBkaXNjb25uZWN0cworICAgICAgICBJbnNwZWN0b3JJ bnN0cnVtZW50YXRpb246OnVucmVnaXN0ZXJJbnN0cnVtZW50aW5nQWdlbnRzIGlzIGNhbGxlZC4K KworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6Okluc3BlY3RvckNvbnRyb2xsZXIpOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6aW5zcGVjdGVkUGFnZURlc3Ryb3ll ZCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpjb25uZWN0RnJvbnRl bmQpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzY29ubmVjdEZy b250ZW5kKToKKwogMjAxMy0wMS0xNyAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgY3JlYXRlT3B0aW9uIG1ldGhvZCB0 byBXZWJJbnNwZWN0b3IuU3RhdHVzQmFyQ29tYm9Cb3gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCBkYzJiNWNkMmFlMTA3YTBhMzZl YzBlZWI0Y2Q2NjFlMWM0MjMwYTI1Li5kMWRhZjFkODc0OGIyZTMyYzUzNmViZmNkODZhNjYzY2Uw ZWU0NDYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRy b2xsZXIuY3BwCkBAIC0xNzUsOCArMTc1LDYgQEAgSW5zcGVjdG9yQ29udHJvbGxlcjo6SW5zcGVj dG9yQ29udHJvbGxlcihQYWdlKiBwYWdlLCBJbnNwZWN0b3JDbGllbnQqIGluc3BlY3RvckMKICNp ZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKICAgICBydW50aW1lQWdlbnQtPnNldFNjcmlw dERlYnVnU2VydmVyKCZtX2RlYnVnZ2VyQWdlbnQtPnNjcmlwdERlYnVnU2VydmVyKCkpOwogI2Vu ZGlmCi0KLSAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OnJlZ2lzdGVySW5zdHJ1bWVudGlu Z0FnZW50cyhtX2luc3RydW1lbnRpbmdBZ2VudHMuZ2V0KCkpOwogfQogCiBJbnNwZWN0b3JDb250 cm9sbGVyOjp+SW5zcGVjdG9yQ29udHJvbGxlcigpCkBAIC0xOTMsNyArMTkxLDYgQEAgUGFzc093 blB0cjxJbnNwZWN0b3JDb250cm9sbGVyPiBJbnNwZWN0b3JDb250cm9sbGVyOjpjcmVhdGUoUGFn ZSogcGFnZSwgSW5zcGVjdG8KIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6aW5zcGVjdGVkUGFn ZURlc3Ryb3llZCgpCiB7CiAgICAgZGlzY29ubmVjdEZyb250ZW5kKCk7Ci0gICAgSW5zcGVjdG9y SW5zdHJ1bWVudGF0aW9uOjp1bnJlZ2lzdGVySW5zdHJ1bWVudGluZ0FnZW50cyhtX2luc3RydW1l bnRpbmdBZ2VudHMuZ2V0KCkpOwogICAgIG1faW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLT5kaXNjb25u ZWN0KCk7CiAgICAgbV9pbnNwZWN0b3JDbGllbnQtPmluc3BlY3RvckRlc3Ryb3llZCgpOwogICAg IG1faW5zcGVjdG9yQ2xpZW50ID0gMDsKQEAgLTIzMSw2ICsyMjgsNyBAQCB2b2lkIEluc3BlY3Rv ckNvbnRyb2xsZXI6OmNvbm5lY3RGcm9udGVuZChJbnNwZWN0b3JGcm9udGVuZENoYW5uZWwqIGZy b250ZW5kQ2hhbgogCiAgICAgbV9hZ2VudHMuc2V0RnJvbnRlbmQobV9pbnNwZWN0b3JGcm9udGVu ZC5nZXQoKSk7CiAKKyAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OnJlZ2lzdGVySW5zdHJ1 bWVudGluZ0FnZW50cyhtX2luc3RydW1lbnRpbmdBZ2VudHMuZ2V0KCkpOwogICAgIEluc3BlY3Rv ckluc3RydW1lbnRhdGlvbjo6ZnJvbnRlbmRDcmVhdGVkKCk7CiAKICAgICBBU1NFUlQobV9pbnNw ZWN0b3JDbGllbnQpOwpAQCAtMjU3LDYgKzI1NSw3IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxl cjo6ZGlzY29ubmVjdEZyb250ZW5kKCkKICAgICAvLyByZWxlc2Ugb3ZlcmxheSBwYWdlIHJlc291 cmNlcwogICAgIG1fb3ZlcmxheS0+ZnJlZVBhZ2UoKTsKICAgICBJbnNwZWN0b3JJbnN0cnVtZW50 YXRpb246OmZyb250ZW5kRGVsZXRlZCgpOworICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6 dW5yZWdpc3Rlckluc3RydW1lbnRpbmdBZ2VudHMobV9pbnN0cnVtZW50aW5nQWdlbnRzLmdldCgp KTsKIH0KIAogdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpzaG93KCkK