107119 2013-01-17 05:15:24 -0800 [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init() 2013-01-17 11:07:47 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 809283 0 naginenis 2013-01-17 05:15:24 -0800 Noticed a crash on release build while running the WebKit2 API test (test_webkit2_api_UserMessage). The reason for this crash is that Ecore_Evas is not initialized on released builds since we are using ASSERT on ecore_evas_init(). CRI: ecore_evas.c:864 ecore_evas_new() eina_log_print() unknown domain -1, original message format 'using engine '%s', extra_options=%s' ERR<15581>:ecore ecore.c:558 _ecore_magic_fail() *** ECORE ERROR: Ecore Magic Check Failed!!! *** IN FUNCTION: ecore_evas_show() ERR<15581>:ecore ecore.c:560 _ecore_magic_fail() Input handle pointer is NULL! ERR<15581>:ecore ecore.c:571 _ecore_magic_fail() *** NAUGHTY PROGRAMMER!!! *** SPANK SPANK SPANK!!! *** Now go fix your code. Tut tut tut! ERR<15581>:ecore ecore.c:558 _ecore_magic_fail() *** ECORE ERROR: Ecore Magic Check Failed!!! *** IN FUNCTION: ecore_evas_get() ERR<15581>:ecore ecore.c:560 _ecore_magic_fail() Input handle pointer is NULL! ERR<15581>:ecore ecore.c:571 _ecore_magic_fail() *** NAUGHTY PROGRAMMER!!! *** SPANK SPANK SPANK!!! *** Now go fix your code. Tut tut tut! ERR<15581>: WebKit/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:509 createEwkView() safety check failed: canvas == NULL CRI<15581>: WebKit/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:669 ewk_view_theme_set() null is not a ewk_view CRI<15581>: WebKit/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:669 ewk_view_theme_set() no smart data for object (nil) ((null)) 1 0x413e98 2 0x7f43ec95dcb0 3 0x7f43ece7b9a9 EwkViewImpl::fromEvasObject(_Evas_Object const*) 4 0x7f43ece7b0d9 WKViewGetPage 5 0x4113da TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp() 6 0x7f43ed14ce83 testing::Test::Run() 7 0x7f43ed14cfe8 testing::internal::TestInfoImpl::Run() 8 0x7f43ed14d0a5 testing::TestCase::Run() 9 0x7f43ed14d3de testing::internal::UnitTestImpl::RunAllTests() 10 0x413862 TestWebKitAPI::TestsController::run(int, char**) 11 0x412fd9 main 12 0x7f43eb67c76d __libc_start_main 13 0x410a79 809286 1 183170 naginenis 2013-01-17 05:33:20 -0800 Created attachment 183170 Patch 809358 2 183170 laszlo.gombos 2013-01-17 08:35:53 -0800 Comment on attachment 183170 Patch r=me. 809508 3 183170 webkit.review.bot 2013-01-17 11:07:42 -0800 Comment on attachment 183170 Patch Clearing flags on attachment: 183170 Committed r140004: <http://trac.webkit.org/changeset/140004> 809509 4 webkit.review.bot 2013-01-17 11:07:47 -0800 All reviewed patches have been landed. Closing bug. 183170 2013-01-17 05:33:20 -0800 2013-01-17 11:07:41 -0800 Patch 107119.patch text/plain 1954 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMWI4 ZTM5Li45Y2RkZjU4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMTcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBGaXgg bWlzdXNlIG9mIEFTU0VSVCBvbiBlY29yZV9ldmFzX2luaXQoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MTE5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IHVzZSBBU1NFUlQgb24gZWNvcmVf ZXZhc19pbml0KCksIHNpbmNlIHRoZSBleHByZXNzaW9uIGluc2lkZQorICAgICAgICB0aGUgbWFj cm8gY29tcGlsZXMgb3V0IG9mIHJlbGVhc2UgYnVpbGRzLgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9QbGF0Zm9ybUVmbC5jbWFrZTogRW5hYmxlIEFQSSB0ZXN0IFVzZXJNZXNzYWdlLgorICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvZWZsL1BsYXRmb3JtV2ViVmlldy5jcHA6CisgICAgICAgIChU ZXN0V2ViS2l0QVBJOjppbml0RWNvcmVFdmFzKTogUmVtb3ZlIEFTU0VSVCBvbiBlY29yZV9ldmFz X2luaXQoKS4KKwogMjAxMy0wMS0xNyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS11bRUZMXSBOV1JUIHNob3VsZCBjaGVjayB0aGF0IFh2ZmIgaXMg aW5zdGFsbGVkCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtRWZsLmNt YWtlIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybUVmbC5jbWFrZQppbmRleCAzY2E3MTFj Li41YTQ1YmJmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtRWZsLmNt YWtlCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1FZmwuY21ha2UKQEAgLTc3LDYg Kzc3LDcgQEAgc2V0KHRlc3Rfd2Via2l0Ml9hcGlfQklOQVJJRVMKICAgICBQcmV2ZW50RW1wdHlV c2VyQWdlbnQKICAgICBQcml2YXRlQnJvd3NpbmdQdXNoU3RhdGVOb0hpc3RvcnlDYWxsYmFjawog ICAgIFNob3VsZEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtCisgICAgVXNlck1lc3NhZ2UKICAgICBX S0Nvbm5lY3Rpb24KICAgICBXS1ByZWZlcmVuY2VzCiAgICAgV0tTdHJpbmcKQEAgLTk5LDcgKzEw MCwzIEBAIGFkZF9kZWZpbml0aW9ucygtRFRIRU1FX0RJUj0iJHtUSEVNRV9CSU5BUllfRElSfSIp CiAjCiAjICAgUmVzcG9uc2l2ZW5lc3NUaW1lckRvZXNudEZpcmVFYXJseQogIyAgIFNwYWNlYmFy U2Nyb2xsaW5nCi0jCi0jIEZsYWt5IHRlc3QsIGZhaWxzIG9uIFJlbGVhc2UgYnV0IHBhc3NlcyBv biBEZWJ1ZzoKLSMKLSMgICBVc2VyTWVzc2FnZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9lZmwvUGxhdGZvcm1XZWJWaWV3LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZWZsL1Bs YXRmb3JtV2ViVmlldy5jcHAKaW5kZXggMDg0MDdjNi4uZDU0NDllYiAxMDA2NDQKLS0tIGEvVG9v bHMvVGVzdFdlYktpdEFQSS9lZmwvUGxhdGZvcm1XZWJWaWV3LmNwcAorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL2VmbC9QbGF0Zm9ybVdlYlZpZXcuY3BwCkBAIC0zOSw3ICszOSw4IEBAIG5hbWVz cGFjZSBUZXN0V2ViS2l0QVBJIHsKIAogc3RhdGljIEVjb3JlX0V2YXMqIGluaXRFY29yZUV2YXMo KQogewotICAgIEFTU0VSVChlY29yZV9ldmFzX2luaXQoKSk7CisgICAgaWYgKCFlY29yZV9ldmFz X2luaXQoKSkKKyAgICAgICAgcmV0dXJuIDA7CiAKICAgICBjb25zdCBjaGFyKiBlbmdpbmUgPSAw OwogI2lmIGRlZmluZWQoV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORykgJiYgZGVmaW5l ZChIQVZFX0VDT1JFX1gpCg==