107117 2013-01-17 05:03:20 -0800 PDFPlugin: Build PDFPlugin everywhere, enable at runtime 2013-01-22 00:41:25 -0800 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton ap sam simon.fraser oldest_to_newest 809279 0 thorton 2013-01-17 05:03:20 -0800 Since PDFLayerController SPI is all forward-declared, this should build anywhere, and can be enabled/disabled at runtime. 809280 1 183168 thorton 2013-01-17 05:05:29 -0800 Created attachment 183168 patch 809368 2 183168 ap 2013-01-17 08:48:26 -0800 Comment on attachment 183168 patch r=me on the assumption that there is enough runtime detection in place already to not break PDFs in nightlies. 812705 3 thorton 2013-01-22 00:30:32 -0800 (In reply to comment #2) > (From update of attachment 183168 [details]) > r=me on the assumption that there is enough runtime detection in place already to not break PDFs in nightlies. Not... exactly. It's an off-by-default setting. So there's no runtime detection; things will break if you flip the setting, but that's your own fault :D It won't break the nightlies. I'm going to land this and file another bug about making the setting's default value depend on the existence of PDFLayerController. 812719 4 thorton 2013-01-22 00:40:04 -0800 http://trac.webkit.org/changeset/140394 812721 5 thorton 2013-01-22 00:41:25 -0800 (In reply to comment #3) > I'm going to land this and file another bug about making the setting's default value depend on the existence of PDFLayerController. --> https://bugs.webkit.org/show_bug.cgi?id=107514 183168 2013-01-17 05:05:29 -0800 2013-01-17 08:48:26 -0800 patch build-everywhere.diff text/plain 6608 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUzNTQ5NDAuLjE4MDQ1ZjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTE3ICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFBERlBsdWdpbjogQnVpbGQgUERG UGx1Z2luIGV2ZXJ5d2hlcmUsIGVuYWJsZSBhdCBydW50aW1lCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcxMTcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBQREZMYXllckNvbnRyb2xsZXIgU1BJ IGlzIGFsbCBmb3J3YXJkLWRlY2xhcmVkLCB0aGUgcGx1Z2luIHNob3VsZCBidWlsZAorICAgICAg ICBvbiBhbGwgTWFjIHBsYXRmb3JtcywgYW5kIGNhbiBiZSBlbmFibGVkIGF0IHJ1bnRpbWUuCisK KyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZzoKKwogMjAx My0wMS0xNiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIERGRyAz Ml82NCBiYWNrZW5kIGRvZXNuJ3QgY2hlY2sgZm9yIGhhc0FycmF5U3RvcmFnZSgpIGluIE5ld0Fy cmF5V2l0aFNpemUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0 aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25m aWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwppbmRleCAxNWU3MDU1Li5jMjM5YTNl IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvRmVhdHVy ZURlZmluZXMueGNjb25maWcKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRp b25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCkBAIC0xMjMsMTEgKzEyMyw3IEBAIEVOQUJMRV9O T1RJRklDQVRJT05TX21hY29zeF8xMDcwID0gOwogRU5BQkxFX05PVElGSUNBVElPTlNfbWFjb3N4 XzEwODAgPSBFTkFCTEVfTk9USUZJQ0FUSU9OUzsKIEVOQUJMRV9OT1RJRklDQVRJT05TX21hY29z eF8xMDkwID0gRU5BQkxFX05PVElGSUNBVElPTlM7CiBFTkFCTEVfUEFHRV9WSVNJQklMSVRZX0FQ SSA9IDsKLUVOQUJMRV9QREZLSVRfUExVR0lOID0gJChFTkFCTEVfUERGS0lUX1BMVUdJTl8kKFBM QVRGT1JNX05BTUUpKTsKLUVOQUJMRV9QREZLSVRfUExVR0lOX21hY29zeCA9ICQoRU5BQkxFX1BE RktJVF9QTFVHSU5fbWFjb3N4XyQoVEFSR0VUX01BQ19PU19YX1ZFUlNJT05fTUFKT1IpKTsKLUVO QUJMRV9QREZLSVRfUExVR0lOX21hY29zeF8xMDcwID0gOwotRU5BQkxFX1BERktJVF9QTFVHSU5f bWFjb3N4XzEwODAgPSA7Ci1FTkFCTEVfUERGS0lUX1BMVUdJTl9tYWNvc3hfMTA5MCA9IEVOQUJM RV9QREZLSVRfUExVR0lOOworRU5BQkxFX1BERktJVF9QTFVHSU4gPSBFTkFCTEVfUERGS0lUX1BM VUdJTjsKIEVOQUJMRV9QUk9HUkVTU19FTEVNRU5UID0gRU5BQkxFX1BST0dSRVNTX0VMRU1FTlQ7 CiBFTkFCTEVfUFJPWElNSVRZX0VWRU5UUyA9IDsKIEVOQUJMRV9RVU9UQSA9IDsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBjMGQyMjU1Li44NThhZTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMt MDEtMTcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAg UERGUGx1Z2luOiBCdWlsZCBQREZQbHVnaW4gZXZlcnl3aGVyZSwgZW5hYmxlIGF0IHJ1bnRpbWUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzExNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIFBE RkxheWVyQ29udHJvbGxlciBTUEkgaXMgYWxsIGZvcndhcmQtZGVjbGFyZWQsIHRoZSBwbHVnaW4g c2hvdWxkIGJ1aWxkCisgICAgICAgIG9uIGFsbCBNYWMgcGxhdGZvcm1zLCBhbmQgY2FuIGJlIGVu YWJsZWQgYXQgcnVudGltZS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZp bmVzLnhjY29uZmlnOgorCiAyMDEzLTAxLTE2ICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAZ29v Z2xlLmNvbT4KIAogICAgICAgICBOb0V2ZW50RGlzcGF0Y2hBc3NlcnRpb24gaW4gQ29udGFpbmVy Tm9kZTo6cmVtb3ZlQ2hpbGRyZW4gaXMgdG9vIHN0cmljdApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcgYi9Tb3VyY2UvV2Vi Q29yZS9Db25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwppbmRleCA0NjhhZmJk Li5lMGYyNjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9GZWF0 dXJlRGVmaW5lcy54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9G ZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwpAQCAtMTIzLDExICsxMjMsNyBAQCBFTkFCTEVfTk9USUZJ Q0FUSU9OU19tYWNvc3hfMTA3MCA9IDsKIEVOQUJMRV9OT1RJRklDQVRJT05TX21hY29zeF8xMDgw ID0gRU5BQkxFX05PVElGSUNBVElPTlM7CiBFTkFCTEVfTk9USUZJQ0FUSU9OU19tYWNvc3hfMTA5 MCA9IEVOQUJMRV9OT1RJRklDQVRJT05TOwogRU5BQkxFX1BBR0VfVklTSUJJTElUWV9BUEkgPSA7 Ci1FTkFCTEVfUERGS0lUX1BMVUdJTiA9ICQoRU5BQkxFX1BERktJVF9QTFVHSU5fJChQTEFURk9S TV9OQU1FKSk7Ci1FTkFCTEVfUERGS0lUX1BMVUdJTl9tYWNvc3ggPSAkKEVOQUJMRV9QREZLSVRf UExVR0lOX21hY29zeF8kKFRBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9SKSk7Ci1FTkFCTEVf UERGS0lUX1BMVUdJTl9tYWNvc3hfMTA3MCA9IDsKLUVOQUJMRV9QREZLSVRfUExVR0lOX21hY29z eF8xMDgwID0gOwotRU5BQkxFX1BERktJVF9QTFVHSU5fbWFjb3N4XzEwOTAgPSBFTkFCTEVfUERG S0lUX1BMVUdJTjsKK0VOQUJMRV9QREZLSVRfUExVR0lOID0gRU5BQkxFX1BERktJVF9QTFVHSU47 CiBFTkFCTEVfUFJPR1JFU1NfRUxFTUVOVCA9IEVOQUJMRV9QUk9HUkVTU19FTEVNRU5UOwogRU5B QkxFX1BST1hJTUlUWV9FVkVOVFMgPSA7CiBFTkFCTEVfUVVPVEEgPSA7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggYzQyYzQ4Mi4uZjMwMzU4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTAxLTE3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisg ICAgICAgIFBERlBsdWdpbjogQnVpbGQgUERGUGx1Z2luIGV2ZXJ5d2hlcmUsIGVuYWJsZSBhdCBy dW50aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDcxMTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT aW5jZSBQREZMYXllckNvbnRyb2xsZXIgU1BJIGlzIGFsbCBmb3J3YXJkLWRlY2xhcmVkLCB0aGUg cGx1Z2luIHNob3VsZCBidWlsZAorICAgICAgICBvbiBhbGwgTWFjIHBsYXRmb3JtcywgYW5kIGNh biBiZSBlbmFibGVkIGF0IHJ1bnRpbWUuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9GZWF0 dXJlRGVmaW5lcy54Y2NvbmZpZzoKKwogMjAxMy0wMS0xNSAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBTZXR0aW5nIHRvIGRpc2FibGUgUVRLaXQgbWVk aWEgZW5naW5lLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMv RmVhdHVyZURlZmluZXMueGNjb25maWcgYi9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1cmF0aW9u cy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwppbmRleCBmZmQ4MmEwLi4xMGMyNDc2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2Nv bmZpZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5l cy54Y2NvbmZpZwpAQCAtMTIzLDExICsxMjMsNyBAQCBFTkFCTEVfTk9USUZJQ0FUSU9OU19tYWNv c3hfMTA3MCA9IDsKIEVOQUJMRV9OT1RJRklDQVRJT05TX21hY29zeF8xMDgwID0gRU5BQkxFX05P VElGSUNBVElPTlM7CiBFTkFCTEVfTk9USUZJQ0FUSU9OU19tYWNvc3hfMTA5MCA9IEVOQUJMRV9O T1RJRklDQVRJT05TOwogRU5BQkxFX1BBR0VfVklTSUJJTElUWV9BUEkgPSA7Ci1FTkFCTEVfUERG S0lUX1BMVUdJTiA9ICQoRU5BQkxFX1BERktJVF9QTFVHSU5fJChQTEFURk9STV9OQU1FKSk7Ci1F TkFCTEVfUERGS0lUX1BMVUdJTl9tYWNvc3ggPSAkKEVOQUJMRV9QREZLSVRfUExVR0lOX21hY29z eF8kKFRBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9SKSk7Ci1FTkFCTEVfUERGS0lUX1BMVUdJ Tl9tYWNvc3hfMTA3MCA9IDsKLUVOQUJMRV9QREZLSVRfUExVR0lOX21hY29zeF8xMDgwID0gOwot RU5BQkxFX1BERktJVF9QTFVHSU5fbWFjb3N4XzEwOTAgPSBFTkFCTEVfUERGS0lUX1BMVUdJTjsK K0VOQUJMRV9QREZLSVRfUExVR0lOID0gRU5BQkxFX1BERktJVF9QTFVHSU47CiBFTkFCTEVfUFJP R1JFU1NfRUxFTUVOVCA9IEVOQUJMRV9QUk9HUkVTU19FTEVNRU5UOwogRU5BQkxFX1BST1hJTUlU WV9FVkVOVFMgPSA7CiBFTkFCTEVfUVVPVEEgPSA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzdlOTI3MC4uNmVm NDYzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTE3ICBUaW0gSG9ydG9u ICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFBERlBsdWdpbjogQnVpbGQg UERGUGx1Z2luIGV2ZXJ5d2hlcmUsIGVuYWJsZSBhdCBydW50aW1lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcxMTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBQREZMYXllckNvbnRyb2xsZXIg U1BJIGlzIGFsbCBmb3J3YXJkLWRlY2xhcmVkLCB0aGUgcGx1Z2luIHNob3VsZCBidWlsZAorICAg ICAgICBvbiBhbGwgTWFjIHBsYXRmb3JtcywgYW5kIGNhbiBiZSBlbmFibGVkIGF0IHJ1bnRpbWUu CisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZzoKKwog MjAxMy0wMS0xNiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2Ug ZGVidWctc2FmYXJpIC0tdGFyZ2V0LXdlYi1wcm9jZXNzIHdvcmsgYWdhaW4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnIGIv U291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcKaW5k ZXggZmZkODJhMC4uMTBjMjQ3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ29uZmlndXJh dGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcKKysrIGIvU291cmNlL1dlYktpdDIvQ29uZmln dXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcKQEAgLTEyMywxMSArMTIzLDcgQEAgRU5B QkxFX05PVElGSUNBVElPTlNfbWFjb3N4XzEwNzAgPSA7CiBFTkFCTEVfTk9USUZJQ0FUSU9OU19t YWNvc3hfMTA4MCA9IEVOQUJMRV9OT1RJRklDQVRJT05TOwogRU5BQkxFX05PVElGSUNBVElPTlNf bWFjb3N4XzEwOTAgPSBFTkFCTEVfTk9USUZJQ0FUSU9OUzsKIEVOQUJMRV9QQUdFX1ZJU0lCSUxJ VFlfQVBJID0gOwotRU5BQkxFX1BERktJVF9QTFVHSU4gPSAkKEVOQUJMRV9QREZLSVRfUExVR0lO XyQoUExBVEZPUk1fTkFNRSkpOwotRU5BQkxFX1BERktJVF9QTFVHSU5fbWFjb3N4ID0gJChFTkFC TEVfUERGS0lUX1BMVUdJTl9tYWNvc3hfJChUQVJHRVRfTUFDX09TX1hfVkVSU0lPTl9NQUpPUikp OwotRU5BQkxFX1BERktJVF9QTFVHSU5fbWFjb3N4XzEwNzAgPSA7Ci1FTkFCTEVfUERGS0lUX1BM VUdJTl9tYWNvc3hfMTA4MCA9IDsKLUVOQUJMRV9QREZLSVRfUExVR0lOX21hY29zeF8xMDkwID0g RU5BQkxFX1BERktJVF9QTFVHSU47CitFTkFCTEVfUERGS0lUX1BMVUdJTiA9IEVOQUJMRV9QREZL SVRfUExVR0lOOwogRU5BQkxFX1BST0dSRVNTX0VMRU1FTlQgPSBFTkFCTEVfUFJPR1JFU1NfRUxF TUVOVDsKIEVOQUJMRV9QUk9YSU1JVFlfRVZFTlRTID0gOwogRU5BQkxFX1FVT1RBID0gOwo=