107112 2013-01-17 03:53:00 -0800 [Gtk] [Cairo] Memory leak when is WebView destroy. 2013-01-21 05:35:42 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All Linux RESOLVED FIXED Cairo, Gtk P2 Normal --- 0 oleg_smirnov webkit-unassigned alexey.verlinger oleg_smirnov pnormand webkit.review.bot oldest_to_newest 809240 0 oleg_smirnov 2013-01-17 03:53:00 -0800 Steps to reproduce: 1) Create one WebkitWebView, screen resolution 1280*720 2) Load any page 3) desrtoy WebkitWebView 4) Repeat steps 1-3 several times. Actual Results: Memory will be increase on ~7 mb after destroying. Expected Results: No memory growing here. Build Date & Platform: Build 2013-01-17 on Ubuntu 12.04. 809271 1 183165 oleg_smirnov 2013-01-17 04:45:21 -0800 Created attachment 183165 Patch 809276 2 webkit.review.bot 2013-01-17 04:49:26 -0800 Attachment 183165 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 810283 3 183386 oleg_smirnov 2013-01-17 23:19:05 -0800 Created attachment 183386 Patch 810620 4 183386 pnormand 2013-01-18 08:15:35 -0800 Comment on attachment 183386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183386&action=review > Source/WebCore/ChangeLog:11 > + No new tests, there is platform memory leak. > + > + Created cairo surface never then deleted, cause of factory method > + createSurfaceForBackingStore for GTK backend returns incorrect refered PassRefPtr value. "No new test" usually goes after the change description, which could use some rewording, I think. Something like "Make createSurfaceForBackingStore return a smart pointer in all supported build configurations to avoid a memory leak" 811445 5 183630 oleg_smirnov 2013-01-19 12:26:32 -0800 Created attachment 183630 Patch 811488 6 183630 mrobinson 2013-01-19 16:04:46 -0800 Comment on attachment 183630 Patch Thanks! 812055 7 183630 webkit.review.bot 2013-01-21 05:35:39 -0800 Comment on attachment 183630 Patch Clearing flags on attachment: 183630 Committed r140325: <http://trac.webkit.org/changeset/140325> 812056 8 webkit.review.bot 2013-01-21 05:35:42 -0800 All reviewed patches have been landed. Closing bug. 183165 2013-01-17 04:45:21 -0800 2013-01-17 23:18:53 -0800 Patch bug-107112-20130117164024.patch text/plain 1998 oleg_smirnov U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5OTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRiZTViMDFlNzRiZWFm ZDhkNGIwODRkM2RhZmE4ODNiZTg2ZTQ3Yy4uM2VlM2M3MjRkNmJhNGIzYWUxZTI0MTNlNDQwZTcx YWE4OTEzMDU0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTE3ICBPbGVn IFNtaXJub3YgIDxvbGVnLnNtaXJub3ZAbGdlLmNvbT4KKworICAgICAgICBbR1RLXSBbY2Fpcm9d IE1lbW9yeSBsZWFrIHdoZW4gaXMgV2ViVmlldyBkZXN0cm95LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MTEyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGVyZSBpcyBwbGF0 Zm9ybSBtZW1vcnkgbGVhay4KKworICAgICAgICBDcmVhdGVkIGNhaXJvIHN1cmZhY2UgbmV2ZXIg dGhlbiBkZWxldGVkLCBjYXVzZSBvZiBmYWN0b3J5IG1ldGhvZCBjcmVhdGVTdXJmYWNlRm9yQmFj a2luZ1N0b3JlCisgICAgICAgIGZvciBHVEsgYmFja2VuZCByZXR1cm5zIGluY29ycmVjdCByZWZl cmVkIFBhc3NSZWZQdHIgdmFsdWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jYWlyby9XaWRnZXRC YWNraW5nU3RvcmVDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVTdXJmYWNlRm9y QmFja2luZ1N0b3JlKToKKwogMjAxMy0wMS0xNyAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgY3JlYXRlT3B0aW9uIG1l dGhvZCB0byBXZWJJbnNwZWN0b3IuU3RhdHVzQmFyQ29tYm9Cb3gKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2NhaXJvL1dpZGdldEJhY2tpbmdTdG9yZUNhaXJvLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NhaXJvL1dpZGdldEJhY2tpbmdTdG9yZUNhaXJvLmNwcApp bmRleCA2OWI3OWVmY2ExYWQ1ZTcwZWMzYjAxYzNhZjJjYjUzMjUzMTMwZDQ3Li43MDg4NjZkYjU5 OTU5NzkyNzk3MmE0MmM1MDRiZjJiYTYwNWQ3YjgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmVDYWlyby5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uY3BwCkBAIC0z Myw5ICszMyw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHN0YXRpYyBQYXNzUmVmUHRyPGNhaXJv X3N1cmZhY2VfdD4gY3JlYXRlU3VyZmFjZUZvckJhY2tpbmdTdG9yZShQbGF0Zm9ybVdpZGdldCB3 aWRnZXQsIGNvbnN0IEludFNpemUmIHNpemUpCiB7CiAjaWYgUExBVEZPUk0oR1RLKQotICAgIHJl dHVybiBnZGtfd2luZG93X2NyZWF0ZV9zaW1pbGFyX3N1cmZhY2UoZ3RrX3dpZGdldF9nZXRfd2lu ZG93KHdpZGdldCksCisgICAgcmV0dXJuIGFkb3B0UmVmKGdka193aW5kb3dfY3JlYXRlX3NpbWls YXJfc3VyZmFjZShndGtfd2lkZ2V0X2dldF93aW5kb3cod2lkZ2V0KSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENBSVJPX0NPTlRFTlRfQ09MT1JfQUxQSEEs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaXplLndpZHRo KCksIHNpemUuaGVpZ2h0KCkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKSk7CiAjZWxzZQogICAgIFVOVVNF RF9QQVJBTSh3aWRnZXQpOwogICAgIHJldHVybiBhZG9wdFJlZihjYWlyb19pbWFnZV9zdXJmYWNl X2NyZWF0ZShDQUlST19GT1JNQVRfQVJHQjMyLCBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCkp KTsK 183386 2013-01-17 23:19:05 -0800 2013-01-19 12:26:27 -0800 Patch bug-107112-20130118111410.patch text/plain 1978 oleg_smirnov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWNlZWMwMmY5NjFiYzEx OGQ3YTY0YTAxNTM4OTU3MmQzMWVlZTFhOS4uNTM5NzBkODMzZTMwZTFlYjRhNTQ0MjYxM2EyOTM0 ZjFiMmRiNDY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTE3ICBPbGVn IFNtaXJub3YgIDxvbGVnLnNtaXJub3ZAbGdlLmNvbT4KKworICAgICAgICBbR3RrXSBbQ2Fpcm9d IE1lbW9yeSBsZWFrIHdoZW4gaXMgV2ViVmlldyBkZXN0cm95LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MTEyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGVyZSBpcyBwbGF0 Zm9ybSBtZW1vcnkgbGVhay4KKworICAgICAgICBDcmVhdGVkIGNhaXJvIHN1cmZhY2UgbmV2ZXIg dGhlbiBkZWxldGVkLCBjYXVzZSBvZiBmYWN0b3J5IG1ldGhvZAorICAgICAgICBjcmVhdGVTdXJm YWNlRm9yQmFja2luZ1N0b3JlIGZvciBHVEsgYmFja2VuZCByZXR1cm5zIGluY29ycmVjdCByZWZl cmVkIFBhc3NSZWZQdHIgdmFsdWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jYWlyby9XaWRnZXRC YWNraW5nU3RvcmVDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVTdXJmYWNlRm9y QmFja2luZ1N0b3JlKToKKwogMjAxMy0wMS0xNyAgU2Fua2VlcnRoIFYgUyAgPHNhbmtlZXJ0aC52 c0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBTZWFyY2ggZm9yIGEgc2VsZWN0ZWQgd29yZCBzaG91 bGQgdHJpZ2dlciBfcGVyZm9ybVNlYXJjaCB0byBwb3B1bGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uY3BwCmlu ZGV4IDY5Yjc5ZWZjYTFhZDVlNzBlYzNiMDFjM2FmMmNiNTMyNTMxMzBkNDcuLmEzNmZmYmQ4MzE1 MGE3MTkwNzJiZDIzZTA4N2ExNDUzZTk1NzdkZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2NhaXJvL1dpZGdldEJhY2tpbmdTdG9yZUNhaXJvLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmVDYWlyby5jcHAKQEAgLTMz LDkgKzMzLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogc3RhdGljIFBhc3NSZWZQdHI8Y2Fpcm9f c3VyZmFjZV90PiBjcmVhdGVTdXJmYWNlRm9yQmFja2luZ1N0b3JlKFBsYXRmb3JtV2lkZ2V0IHdp ZGdldCwgY29uc3QgSW50U2l6ZSYgc2l6ZSkKIHsKICNpZiBQTEFURk9STShHVEspCi0gICAgcmV0 dXJuIGdka193aW5kb3dfY3JlYXRlX3NpbWlsYXJfc3VyZmFjZShndGtfd2lkZ2V0X2dldF93aW5k b3cod2lkZ2V0KSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IENBSVJPX0NPTlRFTlRfQ09MT1JfQUxQSEEsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCkpOworICAgIHJldHVy biBhZG9wdFJlZihnZGtfd2luZG93X2NyZWF0ZV9zaW1pbGFyX3N1cmZhY2UoZ3RrX3dpZGdldF9n ZXRfd2luZG93KHdpZGdldCksIENBSVJPX0NPTlRFTlRfQ09MT1JfQUxQSEEsIHNpemUud2lkdGgo KSwgc2l6ZS5oZWlnaHQoKSkpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0od2lkZ2V0KTsKICAg ICByZXR1cm4gYWRvcHRSZWYoY2Fpcm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGUoQ0FJUk9fRk9STUFU X0FSR0IzMiwgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKSk7Cg== 183630 2013-01-19 12:26:32 -0800 2013-01-21 05:35:38 -0800 Patch bug-107112-20130120002329.patch text/plain 1963 oleg_smirnov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjk3ZTc0NmVkZGU1OWZk ZWQxMjBmNGQ1YTdjYWZlN2QxNzhkZjljZi4uOGIzYjM2MWRhZjY4YzQ2OWE4MTRiNDNkMGI0ZmVh MzVkZWZkZTgzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTE5ICBPbGVn IFNtaXJub3YgIDxvbGVnLnNtaXJub3ZAbGdlLmNvbT4KKworICAgICAgICBbR3RrXSBbQ2Fpcm9d IE1lbW9yeSBsZWFrIHdoZW4gaXMgV2ViVmlldyBkZXN0cm95LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MTEyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBjcmVhdGVTdXJmYWNlRm9yQmFja2lu Z1N0b3JlIHJldHVybiBhIHNtYXJ0IHBvaW50ZXIgaW4gYWxsIHN1cHBvcnRlZAorICAgICAgICBi dWlsZCBjb25maWd1cmF0aW9ucyB0byBhdm9pZCBhIG1lbW9yeSBsZWFrLgorICAgICAgICAKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiBUaGVyZSBpcyBtZW1vcnkgbGVhayBvbmx5LgorCisgICAgICAg ICogcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uY3BwOgorICAgICAgICAo V2ViQ29yZTo6Y3JlYXRlU3VyZmFjZUZvckJhY2tpbmdTdG9yZSk6CisKIDIwMTMtMDEtMTkgIEtv bmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29tPgogCiAgICAgICAg IFtFRkxdW1dlYkdMXSBSZWdyZXNzaW9uOiBXZWJHTCBDb250ZW50IGlzIG5vdCBkcmF3biBhZnRl ciByZXNpemluZyB0aGUgY2FudmFzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uY3BwCmluZGV4IDY5Yjc5ZWZjYTFh ZDVlNzBlYzNiMDFjM2FmMmNiNTMyNTMxMzBkNDcuLmEzNmZmYmQ4MzE1MGE3MTkwNzJiZDIzZTA4 N2ExNDUzZTk1NzdkZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NhaXJv L1dpZGdldEJhY2tpbmdTdG9yZUNhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmVDYWlyby5jcHAKQEAgLTMzLDkgKzMzLDcgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogc3RhdGljIFBhc3NSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBjcmVh dGVTdXJmYWNlRm9yQmFja2luZ1N0b3JlKFBsYXRmb3JtV2lkZ2V0IHdpZGdldCwgY29uc3QgSW50 U2l6ZSYgc2l6ZSkKIHsKICNpZiBQTEFURk9STShHVEspCi0gICAgcmV0dXJuIGdka193aW5kb3df Y3JlYXRlX3NpbWlsYXJfc3VyZmFjZShndGtfd2lkZ2V0X2dldF93aW5kb3cod2lkZ2V0KSwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENBSVJPX0NPTlRFTlRf Q09MT1JfQUxQSEEsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCkpOworICAgIHJldHVybiBhZG9wdFJlZihnZGtf d2luZG93X2NyZWF0ZV9zaW1pbGFyX3N1cmZhY2UoZ3RrX3dpZGdldF9nZXRfd2luZG93KHdpZGdl dCksIENBSVJPX0NPTlRFTlRfQ09MT1JfQUxQSEEsIHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQo KSkpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0od2lkZ2V0KTsKICAgICByZXR1cm4gYWRvcHRS ZWYoY2Fpcm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGUoQ0FJUk9fRk9STUFUX0FSR0IzMiwgc2l6ZS53 aWR0aCgpLCBzaXplLmhlaWdodCgpKSk7Cg==