107109 2013-01-17 02:54:58 -0800 Web Inspector: Search shortcut clears the current search box contents 2013-01-18 01:30:55 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov vivek.vg apavlov keishi loislo pfeldman pmuellr vivek.vg vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 809224 0 apavlov 2013-01-17 02:54:58 -0800 Steps to reproduce (on Mac): 1. Open a source in the Sources panel (e.g. JavaScript) 2. Hit Cmd-F and type a substring that is found in the open resource, press Enter. A match is highlighted. 3. Hit Cmd-F once again. This should be a no-op, but instead, the search box contents are cleared and replaced by the "Find" placeholder 810180 1 183361 vivek.vg 2013-01-17 20:52:59 -0800 Created attachment 183361 Patch 810194 2 183361 pfeldman 2013-01-17 21:11:28 -0800 Comment on attachment 183361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183361&action=review > Source/WebCore/inspector/front-end/SearchController.js:253 > + if (selection.rangeCount) { I think you should first check for WebInspector.currentFocusElement() !== this._searchInputElemen and only if that is true, grap the window.getSelection(). 810207 3 183361 vivekg 2013-01-17 21:22:31 -0800 Comment on attachment 183361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183361&action=review >> Source/WebCore/inspector/front-end/SearchController.js:253 >> + if (selection.rangeCount) { > > I think you should first check for WebInspector.currentFocusElement() !== this._searchInputElemen and only if that is true, grap the window.getSelection(). oh yeah sure. Will upload a new patch. Thank you! 810209 4 183369 vivek.vg 2013-01-17 21:24:32 -0800 Created attachment 183369 Patch 810340 5 183369 vivek.vg 2013-01-18 01:01:20 -0800 Comment on attachment 183369 Patch Thank you! 810354 6 183369 webkit.review.bot 2013-01-18 01:30:51 -0800 Comment on attachment 183369 Patch Clearing flags on attachment: 183369 Committed r140109: <http://trac.webkit.org/changeset/140109> 810355 7 webkit.review.bot 2013-01-18 01:30:55 -0800 All reviewed patches have been landed. Closing bug. 183361 2013-01-17 20:52:59 -0800 2013-01-17 21:24:27 -0800 Patch bug-107109-20130118102053.patch text/plain 1806 vivek.vg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDEwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTE3ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFNlYXJjaCBzaG9ydGN1dCBjbGVhcnMgdGhlIGN1cnJlbnQgc2VhcmNoIGJveCBjb250ZW50cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MTA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNlYXJj aCBib3ggY29udGVudHMgc2hvdWxkIGJlIGNoYW5nZWQgb25seSB3aGVuIHRoZSBjdXJyZW50IGZv Y3VzIGVsZW1lbnQgaXMgCisgICAgICAgIGRpZmZlcmVudCB0aGFuIHRoZSBfc2VhcmNoSW5wdXRF bGVtZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBVSSBjaGFuZ2UuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NlYXJjaENvbnRyb2xsZXIuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU2VhcmNoQ29udHJvbGxlci5wcm90b3R5cGUuc2hvd1NlYXJjaEZpZWxkKToKKwog MjAxMy0wMS0xNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAg ICAgICAgMjAxMy0wMS0xNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+ CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NlYXJjaENvbnRyb2xs ZXIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T ZWFyY2hDb250cm9sbGVyLmpzCShyZXZpc2lvbiAxMzk5NjUpCisrKyBTb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NlYXJjaENvbnRyb2xsZXIuanMJKHdvcmtpbmcgY29weSkKQEAg LTI1MCw4ICsyNTAsMTAgQEAgV2ViSW5zcGVjdG9yLlNlYXJjaENvbnRyb2xsZXIucHJvdG90eXBl CiAgICAgICAgIHRoaXMuX3VwZGF0ZVJlcGxhY2VWaXNpYmlsaXR5KCk7CiAgICAgICAgIHRoaXMu X3VwZGF0ZUZpbHRlclZpc2liaWxpdHkoKTsKICAgICAgICAgdmFyIHNlbGVjdGlvbiA9IHdpbmRv dy5nZXRTZWxlY3Rpb24oKTsKLSAgICAgICAgaWYgKHNlbGVjdGlvbi5yYW5nZUNvdW50KQotICAg ICAgICAgICAgdGhpcy5fc2VhcmNoSW5wdXRFbGVtZW50LnZhbHVlID0gc2VsZWN0aW9uLnRvU3Ry aW5nKCkucmVwbGFjZSgvXHI/XG4uKi8sICIiKTsKKyAgICAgICAgaWYgKHNlbGVjdGlvbi5yYW5n ZUNvdW50KSB7CisgICAgICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLmN1cnJlbnRGb2N1c0VsZW1l bnQoKSAhPT0gdGhpcy5fc2VhcmNoSW5wdXRFbGVtZW50KQorICAgICAgICAgICAgICAgIHRoaXMu X3NlYXJjaElucHV0RWxlbWVudC52YWx1ZSA9IHNlbGVjdGlvbi50b1N0cmluZygpLnJlcGxhY2Uo L1xyP1xuLiovLCAiIik7CisgICAgICAgIH0KICAgICAgICAgdGhpcy5fc2VhcmNoSW5wdXRFbGVt ZW50LmZvY3VzKCk7CiAgICAgICAgIHRoaXMuX3NlYXJjaElucHV0RWxlbWVudC5zZWxlY3QoKTsK ICAgICAgICAgdGhpcy5fc2VhcmNoSXNWaXNpYmxlID0gdHJ1ZTsK 183369 2013-01-17 21:24:32 -0800 2013-01-18 01:30:51 -0800 Patch bug-107109-20130118105226.patch text/plain 1943 vivek.vg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDEwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTE3ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFNlYXJjaCBzaG9ydGN1dCBjbGVhcnMgdGhlIGN1cnJlbnQgc2VhcmNoIGJveCBjb250ZW50cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MTA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNlYXJj aCBib3ggY29udGVudHMgc2hvdWxkIGJlIGNoYW5nZWQgb25seSB3aGVuIHRoZSBjdXJyZW50IGZv Y3VzIGVsZW1lbnQgaXMKKyAgICAgICAgZGlmZmVyZW50IHRoYW4gdGhlIF9zZWFyY2hJbnB1dEVs ZW1lbnQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NlYXJjaENvbnRyb2xsZXIu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2VhcmNoQ29udHJvbGxlci5wcm90b3R5cGUuc2hv d1NlYXJjaEZpZWxkKToKKwogMjAxMy0wMS0xNyAgU2Fua2VlcnRoIFYgUyAgPHNhbmtlZXJ0aC52 c0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBTZWFyY2ggZm9yIGEgc2VsZWN0ZWQgd29yZCBzaG91 bGQgdHJpZ2dlciBfcGVyZm9ybVNlYXJjaCB0byBwb3B1bGF0ZQpJbmRleDogU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZWFyY2hDb250cm9sbGVyLmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2VhcmNoQ29udHJvbGxlci5qcwko cmV2aXNpb24gMTQwMTAyKQorKysgU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T ZWFyY2hDb250cm9sbGVyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNDksOSArMjQ5LDExIEBAIFdl Ykluc3BlY3Rvci5TZWFyY2hDb250cm9sbGVyLnByb3RvdHlwZQogICAgICAgICBXZWJJbnNwZWN0 b3IuaW5zcGVjdG9yVmlldy5zZXRGb290ZXJFbGVtZW50KHRoaXMuX2VsZW1lbnQpOwogICAgICAg ICB0aGlzLl91cGRhdGVSZXBsYWNlVmlzaWJpbGl0eSgpOwogICAgICAgICB0aGlzLl91cGRhdGVG aWx0ZXJWaXNpYmlsaXR5KCk7Ci0gICAgICAgIHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2Vs ZWN0aW9uKCk7Ci0gICAgICAgIGlmIChzZWxlY3Rpb24ucmFuZ2VDb3VudCkKLSAgICAgICAgICAg IHRoaXMuX3NlYXJjaElucHV0RWxlbWVudC52YWx1ZSA9IHNlbGVjdGlvbi50b1N0cmluZygpLnJl cGxhY2UoL1xyP1xuLiovLCAiIik7CisgICAgICAgIGlmIChXZWJJbnNwZWN0b3IuY3VycmVudEZv Y3VzRWxlbWVudCgpICE9PSB0aGlzLl9zZWFyY2hJbnB1dEVsZW1lbnQpIHsKKyAgICAgICAgICAg IHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CisgICAgICAgICAgICBpZiAo c2VsZWN0aW9uLnJhbmdlQ291bnQpCisgICAgICAgICAgICAgICAgdGhpcy5fc2VhcmNoSW5wdXRF bGVtZW50LnZhbHVlID0gc2VsZWN0aW9uLnRvU3RyaW5nKCkucmVwbGFjZSgvXHI/XG4uKi8sICIi KTsKKyAgICAgICAgfQogICAgICAgICB0aGlzLl9wZXJmb3JtU2VhcmNoKHRoaXMuX3NlYXJjaElu cHV0RWxlbWVudC52YWx1ZSwgdHJ1ZSwgZmFsc2UpOwogICAgICAgICB0aGlzLl9zZWFyY2hJbnB1 dEVsZW1lbnQuZm9jdXMoKTsKICAgICAgICAgdGhpcy5fc2VhcmNoSW5wdXRFbGVtZW50LnNlbGVj dCgpOwo=