107108 2013-01-17 02:24:13 -0800 [WK2] TiledCoreAnimationDrawingArea should unparent its layer tree when requested 2013-01-17 13:10:07 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca barraclough benjamin ggaren sam simon.fraser slewis oldest_to_newest 809212 0 thorton 2013-01-17 02:24:13 -0800 Currently, TiledCoreAnimationDrawingArea returns early if asked to unparent its layer tree, to prevent flashing when switching tabs. We have new plans to alleviate the flashing, but first, we should reinstate unparenting the root layer. <rdar://problem/12549879> 809217 1 183155 thorton 2013-01-17 02:28:01 -0800 Created attachment 183155 patch 809499 2 thorton 2013-01-17 11:02:54 -0800 Thanks, Darin! http://trac.webkit.org/changeset/140002 809666 3 benjamin 2013-01-17 12:59:58 -0800 There are 20 failed assertion on the debug bot: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r140002%20(5931)/results.html This may be the cause. 809679 4 thorton 2013-01-17 13:10:07 -0800 (In reply to comment #3) > There are 20 failed assertion on the debug bot: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r140002%20(5931)/results.html > > This may be the cause. Whoops. Fixed in http://trac.webkit.org/changeset/140033 183155 2013-01-17 02:28:01 -0800 2013-01-17 07:36:40 -0800 patch 107108.diff text/plain 2616 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhY2VmMTJhLi5lNjNiMDdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDEtMTcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW1dLMl0gVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEgc2hvdWxkIHVucGFy ZW50IGl0cyBsYXllciB0cmVlIHdoZW4gcmVxdWVzdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcxMDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzEyNTQ5ODc5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEN1cnJlbnRseSwgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEgcmV0dXJucyBlYXJs eSBpZiBhc2tlZCB0byB1bnBhcmVudAorICAgICAgICBpdHMgbGF5ZXIgdHJlZSwgdG8gcHJldmVu dCBmbGFzaGluZyB3aGVuIHN3aXRjaGluZyB0YWJzLiBXZSBoYXZlIG5ldyBwbGFucworICAgICAg ICB0byBhbGxldmlhdGUgdGhlIGZsYXNoaW5nLCBidXQgZmlyc3QsIHdlIHNob3VsZCByZWluc3Rh dGUgdW5wYXJlbnRpbmcgdGhlIHJvb3QgbGF5ZXIsCisgICAgICAgIHRvIGFsbG93IHVuZGVybHlp bmcgbGlicmFyaWVzIHRvIGJldHRlciBtYW5hZ2UgdGhlIG1lbW9yeSBiYWNraW5nIGFsbCBjb21w b3NpdGluZyBsYXllcnMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVk Q29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tOgorICAgICAgICAoV2ViS2l0OjpUaWxlZENvcmVB bmltYXRpb25EcmF3aW5nQXJlYTo6c2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIpOgorCiAyMDEzLTAx LTE2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0 ZSBzYW5kYm94IHJ1bGVzIGFmdGVyIHIxMjgwMDMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0g Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlv bkRyYXdpbmdBcmVhLm1tCmluZGV4IDgwZTgwNWQuLjQyMTllY2MgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2lu Z0FyZWEubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxl ZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQpAQCAtMTEzLDEzICsxMTMsNiBAQCB2b2lkIFRp bGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpzZXRSb290Q29tcG9zaXRpbmdMYXllcihHcmFw aGljc0xheWVyKiBncmFwaAogewogICAgIENBTGF5ZXIgKnJvb3RDb21wb3NpdGluZ0xheWVyID0g Z3JhcGhpY3NMYXllciA/IGdyYXBoaWNzTGF5ZXItPnBsYXRmb3JtTGF5ZXIoKSA6IG5pbDsKIAot ICAgIC8vIFNpbmNlIHdlJ2xsIGFsd2F5cyBiZSBpbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBt b2RlLCB0aGUgb25seSB0aW1lIHRoYXQgbGF5ZXIgd2lsbCBiZSBuaWwKLSAgICAvLyBpcyB3aGVu IHRoZSBXS1ZpZXcgaXMgcmVtb3ZlZCBmcm9tIGl0cyBjb250YWluaW5nIHdpbmRvdy4gSW4gdGhh dCBjYXNlLCB0aGUgbGF5ZXIgd2lsbCBhbHJlYWR5IGJlCi0gICAgLy8gcmVtb3ZlZCBmcm9tIHRo ZSBsYXllciB0cmVlIGhpZXJhcmNoeSBvdmVyIGluIHRoZSBVSSBwcm9jZXNzLCBzbyB0aGVyZSdz IG5vIHJlYXNvbiB0byByZW1vdmUgaXQgbG9jYWxseS4KLSAgICAvLyBJbiBhZGRpdGlvbiwgcmVt b3ZpbmcgdGhlIGxheWVyIGhlcmUgd2lsbCBjYXVzZSBmbGFzaGVzIHdoZW4gc3dpdGNoaW5nIGJl dHdlZW4gdGFicy4KLSAgICBpZiAoIXJvb3RDb21wb3NpdGluZ0xheWVyKQotICAgICAgICByZXR1 cm47Ci0KICAgICBpZiAobV9sYXllclRyZWVTdGF0ZUlzRnJvemVuKSB7CiAgICAgICAgIG1fcGVu ZGluZ1Jvb3RDb21wb3NpdGluZ0xheWVyID0gcm9vdENvbXBvc2l0aW5nTGF5ZXI7CiAgICAgICAg IHJldHVybjsKQEAgLTQ1OCw3ICs0NTEsNyBAQCB2b2lkIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdp bmdBcmVhOjpzZXRSb290Q29tcG9zaXRpbmdMYXllcihDQUxheWVyICpsYXllcikKICAgICBbQ0FU cmFuc2FjdGlvbiBiZWdpbl07CiAgICAgW0NBVHJhbnNhY3Rpb24gc2V0RGlzYWJsZUFjdGlvbnM6 WUVTXTsKIAotICAgIG1fcm9vdExheWVyLmdldCgpLnN1YmxheWVycyA9IFtOU0FycmF5IGFycmF5 V2l0aE9iamVjdDpsYXllcl07CisgICAgbV9yb290TGF5ZXIuZ2V0KCkuc3VibGF5ZXJzID0gbGF5 ZXIgPyBbTlNBcnJheSBhcnJheVdpdGhPYmplY3Q6bGF5ZXJdIDogW05TQXJyYXkgYXJyYXldOwog CiAgICAgaWYgKG1fcGFnZU92ZXJsYXlMYXllcikKICAgICAgICAgW21fcm9vdExheWVyLmdldCgp IGFkZFN1YmxheWVyOm1fcGFnZU92ZXJsYXlMYXllci0+cGxhdGZvcm1MYXllcigpXTsK