107107 2013-01-17 01:56:49 -0800 [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line 2013-01-17 20:43:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 xiaobwang webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 809198 0 xiaobwang 2013-01-17 01:56:49 -0800 Currently we only accept DRT test file (relative to webkit/LayoutTests). Developers have an requirement to dump render tree from command line for http:// URL, as well as relative/absolute file path. 809206 1 183152 xiaobwang 2013-01-17 02:06:03 -0800 Created attachment 183152 patch 809504 2 183152 rwlbuis 2013-01-17 11:06:58 -0800 Comment on attachment 183152 patch View in context: https://bugs.webkit.org/attachment.cgi?id=183152&action=review > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:176 > +} I am not sure if we need this complexity for two string comparisons? Or are you expecting more entries in the Vector? 810030 3 183152 xiaobwang 2013-01-17 18:01:54 -0800 Comment on attachment 183152 patch View in context: https://bugs.webkit.org/attachment.cgi?id=183152&action=review >> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:176 >> +} > > I am not sure if we need this complexity for two string comparisons? Or are you expecting more entries in the Vector? Yes, I'm expecting more protocols to be added, such as https://. If we only consider these two, I can update the patch to make it simple. 810060 4 183152 rwlbuis 2013-01-17 18:21:07 -0800 Comment on attachment 183152 patch Ok. 810175 5 183152 webkit.review.bot 2013-01-17 20:43:03 -0800 Comment on attachment 183152 patch Clearing flags on attachment: 183152 Committed r140100: <http://trac.webkit.org/changeset/140100> 810176 6 webkit.review.bot 2013-01-17 20:43:06 -0800 All reviewed patches have been landed. Closing bug. 183152 2013-01-17 02:06:03 -0800 2013-01-17 20:43:01 -0800 patch 0001-BlackBerry-DRT-Accept-http-file-URL-when-running-drt.patch text/plain 2997 xiaobwang RnJvbSA4MWFhOTdlMjJjYjA1NWY5YWY4NTkyZGJhODc0ZTFmZTc3ODEzZmUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaWFvYm8gV2FuZyA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KRGF0ZTogVGh1LCAxNyBKYW4gMjAxMyAxNzo1ODowOCArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IFtCbGFja0JlcnJ5XSBEUlQgLSBBY2NlcHQgaHR0cC9maWxlIFVSTCB3aGVuIHJ1bm5pbmcKIGRy dC1sYXVuY2hlciBmcm9tIGNvbW1hbmQgbGluZQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNzEwNyBQUiAyODIxOTIKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKVGhlIERSVCBhcHBsaWNhdGlvbiB3aWxsIGNvbnZlcnQgcmVsYXRpdmUvYWJzb2x1dGUgZmls ZSBwYXRoIHRvCmZpbGU6Ly88cmVhbC1maWxlLXBhdGg+IGZvcm1hdCwgc28gd2Ugb25seSBjaGVj ayBmb3IgaHR0cC9maWxlIHByZWZpeC4KCiogRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9EdW1w UmVuZGVyVHJlZS5jcHA6CihCbGFja0JlcnJ5OjpXZWJLaXQ6OmlzRnVsbFVybCk6CihXZWJLaXQp OgooQmxhY2tCZXJyeTo6V2ViS2l0OjpEdW1wUmVuZGVyVHJlZTo6cnVuQ3VycmVudFRlc3QpOgot LS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxNiArKysrKysrKysrKysrKysrCiBUb29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1 bXBSZW5kZXJUcmVlLmNwcCB8ICAgMTkgKysrKysrKysrKysrKysrKysrLQogMiBmaWxlcyBjaGFu Z2VkLCAzNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmY2ZhYmQ1Li40ODMzNDk3IDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTkgQEAKKzIwMTMtMDEtMTcgIFhpYW9ibyBXYW5nICA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRFJUIC0gQWNjZXB0IGh0dHAvZmlsZSBVUkwgd2hl biBydW5uaW5nIGRydC1sYXVuY2hlciBmcm9tIGNvbW1hbmQgbGluZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MTA3CisgICAgICAgIFBSIDI4MjE5 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBE UlQgYXBwbGljYXRpb24gd2lsbCBjb252ZXJ0IHJlbGF0aXZlL2Fic29sdXRlIGZpbGUgcGF0aCB0 bworICAgICAgICBmaWxlOi8vPHJlYWwtZmlsZS1wYXRoPiBmb3JtYXQsIHNvIHdlIG9ubHkgY2hl Y2sgZm9yIGh0dHAvZmlsZSBwcmVmaXguCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ibGFj a2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 aXNGdWxsVXJsKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OkR1bXBSZW5kZXJUcmVlOjpydW5DdXJyZW50VGVzdCk6CisKIDIwMTMtMDEtMTYgIEFsYW4g Q3V0dGVyICA8YWxhbmN1dHRlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgc2hlcmlmZmJvdCBj YW4ndCB0ZWxsIG1lIHdobyAia292IiBpcwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9i bGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCAzYTg1Y2I1Li5lNGJmZTM4IDEwMDY0 NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNw cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNw cApAQCAtMTYwLDYgKzE2MCwyMSBAQCBzdGF0aWMgdm9pZCBjcmVhdGVGaWxlKGNvbnN0IFN0cmlu ZyYgZmlsZU5hbWUpCiAgICAgICAgIGZjbG9zZShmZCk7CiB9CiAKK3N0YXRpYyBib29sIGlzRnVs bFVybChjb25zdCBTdHJpbmcmIHVybCkKK3sKKyAgICBzdGF0aWMgVmVjdG9yPFN0cmluZz4gKnBy ZWZpeGVzID0gMDsKKyAgICBpZiAoIXByZWZpeGVzKSAgeworICAgICAgICBwcmVmaXhlcyA9IG5l dyBWZWN0b3I8U3RyaW5nPigpOworICAgICAgICBwcmVmaXhlcy0+YXBwZW5kKCJodHRwOi8vIik7 CisgICAgICAgIHByZWZpeGVzLT5hcHBlbmQoImZpbGU6Ly8iKTsKKyAgICB9CisgICAgZm9yICh1 bnNpZ25lZCBpID0gMDsgaSA8IHByZWZpeGVzLT5zaXplKCk7ICsraSkgeworICAgICAgICBpZiAo dXJsLnN0YXJ0c1dpdGgocHJlZml4ZXMtPmF0KGkpLCBmYWxzZSkpCisgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorCiBEdW1wUmVuZGVyVHJlZTo6 RHVtcFJlbmRlclRyZWUoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlKiBwYWdlKQogICAgIDog bV9nY0NvbnRyb2xsZXIoMCkKICAgICAsIG1fYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIoMCkKQEAg LTIzNCw3ICsyNDksOSBAQCB2b2lkIER1bXBSZW5kZXJUcmVlOjpydW5DdXJyZW50VGVzdCgpCiAg ICAgICAgIG1fY3VycmVudEh0dHBUZXN0ID0gbV9jdXJyZW50VGVzdC0+dXRmOCgpLmRhdGEoKTsK ICAgICAgICAgbV9jdXJyZW50SHR0cFRlc3QucmVtb3ZlKDAsIHN0cmxlbihodHRwVGVzdFN5bnRh eCkpOwogICAgICAgICBydW5UZXN0KGh0dHBQcmVmaXhVUkwgKyBtX2N1cnJlbnRIdHRwVGVzdCwg aW1hZ2VIYXNoKTsKLSAgICB9IGVsc2UKKyAgICB9IGVsc2UgaWYgKGlzRnVsbFVybCgqbV9jdXJy ZW50VGVzdCkpCisgICAgICAgIHJ1blRlc3QoKm1fY3VycmVudFRlc3QsIGltYWdlSGFzaCk7Cisg ICAgZWxzZQogICAgICAgICBydW5UZXN0KGtTRENMYXlvdXRUZXN0c1VSSSArICptX2N1cnJlbnRU ZXN0LCBpbWFnZUhhc2gpOwogfQogCi0tIAoxLjcuNgoK