107085 2013-01-16 19:17:02 -0800 [BlackBerry] Need to adjust the scale and scroll position after leaving fullscreen mode if there's device rotation in fullscreen mode 2013-01-16 19:54:21 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei jkjiang staikos webkit.review.bot oldest_to_newest 808984 0 charles.wei 2013-01-16 19:17:02 -0800 We saved the scale and scroll position before entering full screen mode, so that we can restore them after leaving fullscreen mode, because entering fullscreen mode automatically changes the scale to make the video to fit to the viewport. But if there's device rotation during the fullscreen, the scale and scroll position saved before may or may not apply anymore, we need to adjust the scale and/or scroll position if needed to make sure no over-scale or over-scroll in the new orientation. 808992 1 183100 charles.wei 2013-01-16 19:27:15 -0800 Created attachment 183100 Patch 808993 2 183100 charles.wei 2013-01-16 19:28:49 -0800 Comment on attachment 183100 Patch Already reviewed by George Staikos. Commit it. 809004 3 183100 webkit.review.bot 2013-01-16 19:54:18 -0800 Comment on attachment 183100 Patch Clearing flags on attachment: 183100 Committed r139955: <http://trac.webkit.org/changeset/139955> 809005 4 webkit.review.bot 2013-01-16 19:54:21 -0800 All reviewed patches have been landed. Closing bug. 183100 2013-01-16 19:27:15 -0800 2013-01-16 19:54:18 -0800 Patch bug-107085-20130117112415.patch text/plain 5577 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5OTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4MDlmNmIwZjliMzMyMTYzOTg3NTg3ZGQyZThkNTZlMGI0YzExNTc0Li43NGRhOGYyYjE4 ODlkYTgyNWQwNzE5NWRmYjg1ZTYwMzlhMmFiYWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMy0wMS0xNiAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIE5lZWQgdG8g YWRqdXN0IHRoZSBzY2FsZSBhbmQgc2Nyb2xsIHBvc2l0aW9uIGFmdGVyIGxlYXZpbmcgZnVsbHNj cmVlbiBtb2RlIGlmIHRoZXJlJ3MKKyAgICAgICAgZGV2aWNlIHJvdGF0aW9uIGluIGZ1bGxzY3Jl ZW4gbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA3MDg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR2VvcmdlIFNUYWlrb3MuCisgICAgICAgIEFs c28gaW50ZXJuYWxseSByZXZpZXdlZCBieSBKYWNreSBKaWFuZy4KKworICAgICAgICBXZSBzYXZl ZCB0aGUgc2NhbGUgYW5kIHNjcm9sbCBwb3NpdGlvbiBiZWZvcmUgZW50ZXJpbmcgZnVsbCBzY3Jl ZW4gbW9kZSwgc28gdGhhdCB3ZSBjYW4gcmVzdG9yZQorICAgICAgICB0aGVtIGFmdGVyIGxlYXZp bmcgZnVsbHNjcmVlbiBtb2RlLCBiZWNhdXNlIGVudGVyaW5nIGZ1bGxzY3JlZW4gbW9kZSBhdXRv bWF0aWNhbGx5IGNoYW5nZXMgdGhlIAorICAgICAgIHNjYWxlIHRvIG1ha2UgdGhlIHZpZGVvIHRv IGZpdCB0byB0aGUgdmlld3BvcnQuIEJ1dCBpZiB0aGVyZSdzIGRldmljZSByb3RhdGlvbiBkdXJp bmcgdGhlIGZ1bGxzY3JlZW4sCisgICAgICAgdGhlIHNjYWxlIGFuZCBzY3JvbGwgcG9zaXRpb24g c2F2ZWQgYmVmb3JlIG1heSBvciBtYXkgbm90IGFwcGx5IGFueW1vcmUsIHdlIG5lZWQgdG8gYWRq dXN0IHRoZQorICAgICAgIHNjYWxlIGFuZC9vciBzY3JvbGwgcG9zaXRpb24gaWYgbmVlZGVkIHRv IG1ha2Ugc3VyZSBubyBvdmVyLXNjYWxlIG9yIG92ZXItc2Nyb2xsIGluIHRoZSBuZXcgb3JpZW50 YXRpb24uCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5 OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpzZXRWaWV3cG9ydFNpemUpOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6ZW50ZXJGdWxsU2NyZWVuRm9yRWxlbWVu dCk6CisgICAgICAgICogQXBpL1dlYlBhZ2VfcC5oOgorICAgICAgICAoV2ViUGFnZVByaXZhdGUp OgorCiAyMDEzLTAxLTE2ICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNvbT4KIAogICAgICAgICBb QmxhY2tCZXJyeV0gUmVtb3ZlIGJvZ3VzIGFzc2VydCBpbiBHZW9sb2NhdGlvbkNsaWVudEJsYWNr QmVycnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDdlZTlj OWM5NDA3MGJmN2IxMTVjNzlmMTA4ZDAyNmQ3YTVhZDZjOWYuLjg1ZmYwODFlNzFhODFiNDY4NTEy OThhMzFjNTYwNDc0M2NiYzlmYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmNwcApAQCAtMzgxOSwxNCArMzgxOSwzMiBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjpzZXRW aWV3cG9ydFNpemUoY29uc3QgSW50U2l6ZSYgdHJhbnNmb3JtZWRBY3R1YWxWaXNpYmxlU2l6ZQog ICAgIH0KIAogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkgJiYgRU5BQkxFKFZJREVPKQotICAg IC8vIFdoZW4gbGVhdmluZyBmdWxsc2NyZWVuIG1vZGUsIHJlc3RvcmUgdGhlIHNjYWxlIGFuZCBz Y3JvbGwgcG9zaXRpb24KLSAgICAvLyBpZiBuZWVkZWQuCi0gICAgLy8gRklYTUU6IFRoZSBjYWNo ZWQgdmFsdWVzIG1pZ2h0IGdldCBpbXByZWNpc2UgaWYgdXNlciBoYXZlIHJvdGF0ZWQgdGhlCi0g ICAgLy8gZGV2aWNlIHdoaWxlIGluIGZ1bGxzY3JlZW4uCisgICAgLy8gV2hlbiBsZWF2aW5nIGZ1 bGxzY3JlZW4gbW9kZSwgcmVzdG9yZSB0aGUgc2NhbGUgYW5kIHNjcm9sbCBwb3NpdGlvbiBpZiBu ZWVkZWQuCisgICAgLy8gV2UgYWxzbyBuZWVkIHRvIG1ha2Ugc3VyZSB0aGUgc2NhbGUgYW5kIHNj cm9sbCBwb3NpdGlvbiB3b24ndCBjYXVzZSBvdmVyIHNjYWxlIG9yIG92ZXIgc2Nyb2xsLgogICAg IGlmIChtX3NjYWxlQmVmb3JlRnVsbFNjcmVlbiA+IDAgJiYgIW1fZnVsbHNjcmVlblZpZGVvTm9k ZSkgewogICAgICAgICAvLyBSZXN0b3JlIHRoZSBzY2FsZSB3aGVuIGxlYXZpbmcgZnVsbHNjcmVl bi4gV2UgY2FuJ3QgdXNlIFRyYW5zZm9ybWF0aW9uTWF0cml4OjpzY2FsZShkb3VibGUpIGhlcmUs CiAgICAgICAgIC8vIGFzIGl0IHdpbGwgbXVsdGlwbHkgdGhlIHNjYWxlIHJhdGhlciB0aGFuIHNl dCB0aGUgc2NhbGUuCiAgICAgICAgIC8vIEZJWE1FOiBXZSBjYW4gcmVmYWN0b3IgdGhpcyBpbnRv IHNldEN1cnJlbnRTY2FsZShkb3VibGUpIGlmIGl0IGlzIHVzZWZ1bCBpbiB0aGUgZnV0dXJlLgor ICAgICAgICBpZiAobV9vcmllbnRhdGlvbkJlZm9yZUZ1bGxTY3JlZW4gJSAxODAgIT0gb3JpZW50 YXRpb24oKSAlIDE4MCkgeyAvLyBPcmllbnRhdGlvbiBjaGFuZ2VkCisgICAgICAgICAgICBpZiAo bV9hY3R1YWxWaXNpYmxlV2lkdGggPiBjb250ZW50c1NpemUoKS53aWR0aCgpICogbV9zY2FsZUJl Zm9yZUZ1bGxTY3JlZW4pIHsKKyAgICAgICAgICAgICAgICAvLyBDYWNoZWQgc2NhbGUgbmVlZCB0 byBiZSBhZGp1c3RlZCBhZnRlciByb3RhdGlvbi4KKyAgICAgICAgICAgICAgICBtX3NjYWxlQmVm b3JlRnVsbFNjcmVlbiA9IGRvdWJsZShtX2FjdHVhbFZpc2libGVXaWR0aCkgLyBjb250ZW50c1Np emUoKS53aWR0aCgpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKG1fc2NhbGVCZWZv cmVGdWxsU2NyZWVuICogY29udGVudHNTaXplKCkuaGVpZ2h0KCkgPCBtX2FjdHVhbFZpc2libGVI ZWlnaHQpIHsKKyAgICAgICAgICAgICAgICAvLyBVc2Ugem9vbSB0byBmaXQgaGVpZ2h0IHNjYWxl IGluIG9yZGVyIHRvIGNvdmVyIHRoZSBzY3JlZW4gaGVpZ2h0LgorICAgICAgICAgICAgICAgIG1f c2NhbGVCZWZvcmVGdWxsU2NyZWVuID0gZG91YmxlKG1fYWN0dWFsVmlzaWJsZUhlaWdodCkgLyBj b250ZW50c1NpemUoKS5oZWlnaHQoKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgaWYg KG1fYWN0dWFsVmlzaWJsZVdpZHRoID4gbV9zY2FsZUJlZm9yZUZ1bGxTY3JlZW4gKiAoY29udGVu dHNTaXplKCkud2lkdGgoKSAtIG1fc2Nyb2xsUG9zaXRpb25CZWZvcmVGdWxsU2NyZWVuLngoKSkp IHsKKyAgICAgICAgICAgICAgICAvLyBDYWNoZWQgc2Nyb2xsIHBvc2l0aW9uIG92ZXIgc2Nyb2xs cyBob3Jpem9udGFsbHkgYWZ0ZXIgcm90YXRpb24uCisgICAgICAgICAgICAgICAgbV9zY3JvbGxQ b3NpdGlvbkJlZm9yZUZ1bGxTY3JlZW4uc2V0WChjb250ZW50c1NpemUoKS53aWR0aCgpIC0gbV9h Y3R1YWxWaXNpYmxlV2lkdGggLyBtX3NjYWxlQmVmb3JlRnVsbFNjcmVlbik7CisgICAgICAgICAg ICB9CisgICAgICAgICAgICBpZiAobV9hY3R1YWxWaXNpYmxlSGVpZ2h0ID4gbV9zY2FsZUJlZm9y ZUZ1bGxTY3JlZW4gKiAoY29udGVudHNTaXplKCkuaGVpZ2h0KCkgLSBtX3Njcm9sbFBvc2l0aW9u QmVmb3JlRnVsbFNjcmVlbi55KCkpKSB7CisgICAgICAgICAgICAgICAgLy8gQ2FjaGVkIHNjcm9s bCBwb3NpdGlvbiBvdmVyIHNjcm9sbHMgdmVydGljYWxseSBhZnRlciByb3RhdGlvbi4KKyAgICAg ICAgICAgICAgICBtX3Njcm9sbFBvc2l0aW9uQmVmb3JlRnVsbFNjcmVlbi5zZXRZKGNvbnRlbnRz U2l6ZSgpLmhlaWdodCgpIC0gbV9hY3R1YWxWaXNpYmxlSGVpZ2h0IC8gbV9zY2FsZUJlZm9yZUZ1 bGxTY3JlZW4pOworICAgICAgICAgICAgfQorICAgICAgICB9CisKICAgICAgICAgbV90cmFuc2Zv cm1hdGlvbk1hdHJpeC0+c2V0TTExKG1fc2NhbGVCZWZvcmVGdWxsU2NyZWVuKTsKICAgICAgICAg bV90cmFuc2Zvcm1hdGlvbk1hdHJpeC0+c2V0TTIyKG1fc2NhbGVCZWZvcmVGdWxsU2NyZWVuKTsK ICAgICAgICAgbV9zY2FsZUJlZm9yZUZ1bGxTY3JlZW4gPSAtMS4wOwpAQCAtNTgwOCw2ICs1ODI2 LDExIEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OmVudGVyRnVsbFNjcmVlbkZvckVsZW1lbnQoRWxl bWVudCogZWxlbWVudCkKICAgICAgICAgICAgIC8vIHBvc2l0aW9uIG1pZ2h0IGNoYW5nZS4gU28g d2Uga2VlcCB0cmFjayBvZiBpdCBoZXJlLCBpbiBvcmRlciB0byByZXN0b3JlIGl0CiAgICAgICAg ICAgICAvLyBvbmNlIGVsZW1lbnQgbGVhdmVzIGZ1bGxzY3JlZW4uCiAgICAgICAgICAgICBtX3Nj cm9sbFBvc2l0aW9uQmVmb3JlRnVsbFNjcmVlbiA9IG1fbWFpbkZyYW1lLT52aWV3KCktPnNjcm9s bFBvc2l0aW9uKCk7CisKKyAgICAgICAgICAgIC8vIFdlIG5lZWQgdG8gcmVtZW1iZXIgdGhlIG9y aWVudGF0aW9uIGJlZm9yZSBlbnRlcmluZyBmdWxsc2NyZWVuLCBzbyB0aGF0IHdlIGNhbiBhZGp1 c3QKKyAgICAgICAgICAgIC8vIHRoZSBzY2FsZSBhbmQgc2Nyb2xsIHBvc2l0aW9uIHdoZW4gZXhp dGluZyBmdWxsc2NyZWVuIGlmIG5lZWRlZCwgYmVjYXVzZSB0aGUgc2NhbGUgYW5kCisgICAgICAg ICAgICAvLyBzY3JvbGwgcG9zaXRpb24gIG1heSBub3QgYXBwbHkgKG92ZXJzY2FsZSBhbmQvb3Ig b3ZlcnNjcm9sbCkgaW4gdGhlIG90aGVyIG9yaWVudGF0aW9uLgorICAgICAgICAgICAgbV9vcmll bnRhdGlvbkJlZm9yZUZ1bGxTY3JlZW4gPSBvcmllbnRhdGlvbigpOwogICAgICAgICB9CiAKICAg ICAgICAgLy8gTm8gZnVsbHNjcmVlbiB2aWRlbyB3aWRnZXQgaGFzIGJlZW4gbWFkZSBhdmFpbGFi bGUgYnkgdGhlIEJyb3dzZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvV2ViUGFnZV9wLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5o CmluZGV4IDg1YzI3ZTc3MDI0ZGQ0ZGNkMTE3MjQ1ZDgzZjdlOTZkMDAyMDk4NDguLmIyMDZlODNm NzkyYzczY2RiMTY2ZWMwNzU5OWY5ZTE5Y2E5MmQ3YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlX3AuaApAQCAtNTI4LDYgKzUyOCw3IEBAIHB1YmxpYzoKICNpZiBFTkFC TEUoVklERU8pCiAgICAgZG91YmxlIG1fc2NhbGVCZWZvcmVGdWxsU2NyZWVuOwogICAgIFdlYkNv cmU6OkludFBvaW50IG1fc2Nyb2xsUG9zaXRpb25CZWZvcmVGdWxsU2NyZWVuOworICAgIGludCBt X29yaWVudGF0aW9uQmVmb3JlRnVsbFNjcmVlbjsKICNlbmRpZgogI2VuZGlmCiAK