<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>107072</bug_id>
          
          <creation_ts>2013-01-16 17:43:56 -0800</creation_ts>
          <short_desc>Fix build break for Android webview</short_desc>
          <delta_ts>2013-01-16 21:17:56 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Android</rep_platform>
          <op_sys>Android</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kristian Monsen">kristianm</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benm</cc>
    
    <cc>cjhopman</cc>
    
    <cc>steveblock</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>808895</commentid>
    <comment_count>0</comment_count>
    <who name="Kristian Monsen">kristianm</who>
    <bug_when>2013-01-16 17:43:56 -0800</bug_when>
    <thetext>Add additional guards when checking for OS==&quot;Android&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>808946</commentid>
    <comment_count>1</comment_count>
      <attachid>183087</attachid>
    <who name="Kristian Monsen">kristianm</who>
    <bug_when>2013-01-16 18:26:51 -0800</bug_when>
    <thetext>Created attachment 183087
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>808978</commentid>
    <comment_count>2</comment_count>
    <who name="Ben Murdoch">benm</who>
    <bug_when>2013-01-16 19:05:59 -0800</bug_when>
    <thetext>The patch LGTM to fix our build.

I&apos;m not a reviewer however, and you need to mark the patch r?.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>809014</commentid>
    <comment_count>3</comment_count>
      <attachid>183087</attachid>
    <who name="Steve Block">steveblock</who>
    <bug_when>2013-01-16 20:15:37 -0800</bug_when>
    <thetext>Comment on attachment 183087
Proposed patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>809054</commentid>
    <comment_count>4</comment_count>
      <attachid>183087</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-16 21:17:53 -0800</bug_when>
    <thetext>Comment on attachment 183087
Proposed patch

Clearing flags on attachment: 183087

Committed r139963: &lt;http://trac.webkit.org/changeset/139963&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>809055</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-16 21:17:56 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>183087</attachid>
            <date>2013-01-16 18:26:51 -0800</date>
            <delta_ts>2013-01-16 21:17:53 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>1406</size>
            <attacher name="Kristian Monsen">kristianm</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzk5NDYpCisrKyBTb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1
IEBACisyMDEzLTAxLTE2ICBLcmlzdGlhbiBNb25zZW4gIDxrcmlzdGlhbm1AZ29vZ2xlLmNvbT4K
KworICAgICAgICBGaXggYnVpbGQgYnJlYWsgZm9yIEFuZHJvaWQgd2Vidmlldy4KKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzA3MgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBleHRyYSBndWFyZHMg
d2hlbiBjaGVja2luZyBmb3IgT1M9PSJBbmRyb2lkIiB0byBtYWtlIHN1cmUgaXQgaXMgbm90IGlu
Y2x1ZGVkCisgICAgICAgIGZvciB3ZWJ2aWV3LgorCisgICAgICAgICogV2ViS2l0VW5pdFRlc3Rz
Lmd5cDoKKwogMjAxMy0wMS0xNiAgVy4gSmFtZXMgTWFjTGVhbiAgPHdqbWFjbGVhbkBjaHJvbWl1
bS5vcmc+CiAKICAgICAgICAgTGlua0hpZ2hsaWdodCBzaG91bGQgdXNlIHRvdWNoIGFkanVzdG1l
bnQgdG8gbWF0Y2ggYWN0aXZlIHN0YXRlIG9uIEdlc3R1cmVUYXBEb3duLgpJbmRleDogU291cmNl
L1dlYktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5pdFRlc3RzLmd5cAkocmV2aXNpb24gMTM5OTQyKQor
KysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCSh3b3JraW5nIGNv
cHkpCkBAIC0xMzgsNyArMTM4LDcgQEAKICAgICAgICAgICAgICAgICAnY2ZsYWdzX2NjJzogWyct
V25vLWMrKzB4LWNvbXBhdCddLAogICAgICAgICAgICAgfSwKICAgICAgICAgfV0sCi0gICAgICAg
IFsnT1M9PSJhbmRyb2lkIiBhbmQgZ3Rlc3RfdGFyZ2V0X3R5cGUgPT0gInNoYXJlZF9saWJyYXJ5
IicsIHsKKyAgICAgICAgWydPUz09ImFuZHJvaWQiIGFuZCBhbmRyb2lkX2J1aWxkX3R5cGU9PTAg
YW5kIGd0ZXN0X3RhcmdldF90eXBlID09ICJzaGFyZWRfbGlicmFyeSInLCB7CiAgICAgICAgICAg
ICAjIFdyYXAgbGlid2Via2l0X3VuaXRfdGVzdHMuc28gaW50byBhbiBhbmRyb2lkIGFwayBmb3Ig
ZXhlY3V0aW9uLgogICAgICAgICAgICAgJ3RhcmdldHMnOiBbewogICAgICAgICAgICAgICAgICd0
YXJnZXRfbmFtZSc6ICd3ZWJraXRfdW5pdF90ZXN0c19hcGsnLAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>