107061 2013-01-16 16:05:30 -0800 [WK2] Don't use NSApplication run loop in NetworkProcess 2013-01-17 16:19:37 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca beidson cmuppala sam oldest_to_newest 808814 0 ap 2013-01-16 16:05:30 -0800 Entering the NSApplication run loop initializes a number of subsystems that we don't need, and thus needs a less strict sandbox than necessary. 808816 1 183053 ap 2013-01-16 16:09:48 -0800 Created attachment 183053 proposed patch 809417 2 183053 andersca 2013-01-17 10:03:20 -0800 Comment on attachment 183053 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=183053&action=review > Source/WebCore/platform/mac/RunLoopMac.mm:36 > +void RunLoop::setUseApplicationRunLoopOnMainRunLoop() > +{ > + s_useApplicationRunLoopOnMainRunLoop = true; > +} Can we assert that the main run loop has not yet been created here? 809434 3 ap 2013-01-17 10:12:00 -0800 Committed <http://trac.webkit.org/changeset/139985>. > Can we assert that the main run loop has not yet been created here? Sadly not without some major refactoring, the main run loop is created very early, before we know what kind of process it is. 183053 2013-01-16 16:09:48 -0800 2013-01-17 10:03:18 -0800 proposed patch RunLoop.txt text/plain 6022 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTkzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAxLTE2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IHVzZSBOU0FwcGxp Y2F0aW9uIHJ1biBsb29wIGluIE5ldHdvcmtQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCBhIHdheSB0byB0ZWxsIFJ1bkxvb3Agd2hldGhlciBpdCBzaG91bGQgdXNlIE5TQXBw bGljYXRpb24gcnVuIGxvb3AKKyAgICAgICAgKGRlZmF1bHRpbmcgdG8gbm90IHVzaW5nIGl0LCBh cyB0aGlzIHNob3VsZCBiZSBhbiBleGNlcHRpb24gZm9yIGNoaWxkIHByb2Nlc3NlcykuCisKKyAg ICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBwbGF0Zm9ybS9SdW5Mb29wLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJ1bkxvb3A6OnNldFVzZUFwcGxpY2F0aW9uUnVuTG9vcE9uTWFp blJ1bkxvb3ApOgorICAgICAgICAqIHBsYXRmb3JtL1J1bkxvb3AuaDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMvUnVuTG9vcE1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJ1bkxvb3A6OnNldFVz ZUFwcGxpY2F0aW9uUnVuTG9vcE9uTWFpblJ1bkxvb3ApOgorICAgICAgICAoV2ViQ29yZTo6UnVu TG9vcDo6cnVuKToKKyAgICAgICAgKFdlYkNvcmU6OlJ1bkxvb3A6OnN0b3ApOgorCiAyMDEzLTAx LTE2ICBWaWN0b3IgQ2FyYnVuZSAgPHZjYXJidW5lQGNocm9taXVtLm9yZz4KIAogICAgICAgICBD dWVzIG5vdCByZW5kZXJlZCB3aGVuIHRoZXkgc2hvdWxkIGJlCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLmV4cC5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4 cC5pbgkocmV2aXNpb24gMTM5Nzc4KQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4J KHdvcmtpbmcgY29weSkKQEAgLTkwMSw2ICs5MDEsNyBAQCBfX1pON1dlYkNvcmU3SW50U2l6ZUMx RVJLNkNHU2l6ZQogX19aTjdXZWJDb3JlN1J1bkxvb3AxNHJ1bkZvckR1cmF0aW9uRWQKIF9fWk43 V2ViQ29yZTdSdW5Mb29wMjFpbml0aWFsaXplTWFpblJ1bkxvb3BFdgogX19aTjdXZWJDb3JlN1J1 bkxvb3AzcnVuRXYKK19fWk43V2ViQ29yZTdSdW5Mb29wMzdzZXRVc2VBcHBsaWNhdGlvblJ1bkxv b3BPbk1haW5SdW5Mb29wRXYKIF9fWk43V2ViQ29yZTdSdW5Mb29wNG1haW5FdgogX19aTjdXZWJD b3JlN1J1bkxvb3A0c3RvcEV2CiBfX1pON1dlYkNvcmU3UnVuTG9vcDZ3YWtlVXBFdgpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9vcC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9vcC5jcHAJKHJldmlzaW9uIDEzOTc3OCkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1J1bkxvb3AuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Myw2ICs1 MywxMCBAQCBSdW5Mb29wKiBSdW5Mb29wOjptYWluKCkKICAgICByZXR1cm4gc19tYWluUnVuTG9v cDsKIH0KIAordm9pZCBSdW5Mb29wOjpzZXRVc2VBcHBsaWNhdGlvblJ1bkxvb3BPbk1haW5SdW5M b29wKCkKK3sKK30KKwogI2VuZGlmCiAKIHZvaWQgUnVuTG9vcDo6cGVyZm9ybVdvcmsoKQpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9vcC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1J1bkxvb3AuaAkocmV2aXNpb24gMTM5Nzc4KQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9vcC5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw2ICs1MSw5 IEBAIHB1YmxpYzoKICAgICAvLyBjYW4gYmUgY2FsbGVkIGZyb20gYW55IHRocmVhZCkuCiAgICAg c3RhdGljIHZvaWQgaW5pdGlhbGl6ZU1haW5SdW5Mb29wKCk7CiAKKyAgICAvLyBNdXN0IGJlIGNh bGxlZCBiZWZvcmUgZW50ZXJpbmcgbWFpbiBydW4gbG9vcC4gSWYgY2FsbGVkLCBhcHBsaWNhdGlv biBzdHlsZSBydW4gbG9vcCB3aWxsIGJlIHVzZWQsIGhhbmRsaW5nIGV2ZW50cy4KKyAgICBzdGF0 aWMgdm9pZCBzZXRVc2VBcHBsaWNhdGlvblJ1bkxvb3BPbk1haW5SdW5Mb29wKCk7CisKICAgICBz dGF0aWMgUnVuTG9vcCogY3VycmVudCgpOwogICAgIHN0YXRpYyBSdW5Mb29wKiBtYWluKCk7CiAK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9SdW5Mb29wTWFjLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9SdW5Mb29wTWFjLm1tCShyZXZpc2lv biAxMzk3NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUnVuTG9vcE1hYy5tbQko d29ya2luZyBjb3B5KQpAQCAtMjgsMTAgKzI4LDE3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAorc3RhdGljIGJvb2wgc191c2VBcHBsaWNhdGlvblJ1bkxvb3BPbk1haW5SdW5Mb29wOworCit2 b2lkIFJ1bkxvb3A6OnNldFVzZUFwcGxpY2F0aW9uUnVuTG9vcE9uTWFpblJ1bkxvb3AoKQorewor ICAgIHNfdXNlQXBwbGljYXRpb25SdW5Mb29wT25NYWluUnVuTG9vcCA9IHRydWU7Cit9CisKIHZv aWQgUnVuTG9vcDo6cnVuKCkKIHsKICAgICBjdXJyZW50KCktPm1fbmVzdGluZ0xldmVsKys7Ci0g ICAgaWYgKGN1cnJlbnQoKSA9PSBtYWluKCkgJiYgY3VycmVudCgpLT5tX25lc3RpbmdMZXZlbCA9 PSAxKSB7CisgICAgaWYgKGN1cnJlbnQoKSA9PSBtYWluKCkgJiYgY3VycmVudCgpLT5tX25lc3Rp bmdMZXZlbCA9PSAxICYmIHNfdXNlQXBwbGljYXRpb25SdW5Mb29wT25NYWluUnVuTG9vcCkgewog ICAgICAgICAvLyBVc2UgLVtOU0FwcGxpY2F0aW9uIHJ1bl0gZm9yIHRoZSBtYWluIHJ1biBsb29w LgogICAgICAgICBbTlNBcHAgcnVuXTsKICAgICB9IGVsc2UgewpAQCAtNDYsNyArNTMsNyBAQCB2 b2lkIFJ1bkxvb3A6OnN0b3AoKQogewogICAgIEFTU0VSVChtX3J1bkxvb3AgPT0gQ0ZSdW5Mb29w R2V0Q3VycmVudCgpKTsKICAgICAKLSAgICBpZiAobV9ydW5Mb29wID09IG1haW4oKS0+bV9ydW5M b29wICYmIG1fbmVzdGluZ0xldmVsID09IDEpIHsKKyAgICBpZiAobV9ydW5Mb29wID09IG1haW4o KS0+bV9ydW5Mb29wICYmIG1fbmVzdGluZ0xldmVsID09IDEgJiYgc191c2VBcHBsaWNhdGlvblJ1 bkxvb3BPbk1haW5SdW5Mb29wKSB7CiAgICAgICAgIFtbTlNBcHBsaWNhdGlvbiBzaGFyZWRBcHBs aWNhdGlvbl0gc3RvcDpuaWxdOwogICAgICAgICBOU0V2ZW50ICpldmVudCA9IFtOU0V2ZW50IG90 aGVyRXZlbnRXaXRoVHlwZTpOU0FwcGxpY2F0aW9uRGVmaW5lZAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBsb2NhdGlvbjpOU01ha2VQb2ludCgwLCAwKQpJbmRl eDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwkocmV2aXNpb24gMTM5OTMyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMTYgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgdXNlIE5TQXBwbGljYXRp b24gcnVuIGxvb3AgaW4gTmV0d29ya1Byb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzA2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgV2ViUHJvY2VzcyBhbmQgUGx1Z2luUHJvY2VzcyBz aG91bGQgdXNlIENvY29hIEFQSXMgdGhhdCByZXF1aXJlIHRoZSBydW4gbG9vcC4KKworICAgICAg ICAqIFBsdWdpblByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NNYWMubW06CisgICAgICAgIChXZWJL aXQ6OlBsdWdpblByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVBsdWdpblByb2Nlc3MpOgorICAg ICAgICAqIFdlYlByb2Nlc3MvbWFjL1dlYlByb2Nlc3NNYWMubW06CisgICAgICAgIChXZWJLaXQ6 OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3MpOgorCiAyMDEzLTAxLTE2ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYlByb2Nlc3Mg c2hvdWxkIG5vdCBhY2Nlc3Mgfi9MaWJyYXJ5L0NhY2hlcy9jb20uYXBwbGUuV2ViUHJvY2VzcwpJ bmRleDogU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Q cm9jZXNzTWFjLm1tCShyZXZpc2lvbiAxMzk3NzgpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Q cm9jZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0 Miw4IEBACiAKICNpbXBvcnQgIk5ldHNjYXBlU2FuZGJveEZ1bmN0aW9ucy5oIgogCit1c2luZyBu YW1lc3BhY2UgV2ViQ29yZTsKKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIEZ1bGxzY3Jl ZW5XaW5kb3dUcmFja2VyIHsKQEAgLTMzOCw2ICszNDAsOCBAQCBzdGF0aWMgdm9pZCBtdXRlQXVk aW8odm9pZCkKIAogdm9pZCBQbHVnaW5Qcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQbHVnaW5Q cm9jZXNzKGNvbnN0IFBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRlcnMp CiB7CisgICAgUnVuTG9vcDo6c2V0VXNlQXBwbGljYXRpb25SdW5Mb29wT25NYWluUnVuTG9vcCgp OworCiAgICAgbV9jb21wb3NpdGluZ1JlbmRlclNlcnZlclBvcnQgPSBwYXJhbWV0ZXJzLmFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdQb3J0LnBvcnQoKTsKIAogICAgIE5TU3RyaW5nICphcHBsaWNhdGlv bk5hbWUgPSBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpXRUJfVUlfU1RSSU5HKCIlQCAoJUAg SW50ZXJuZXQgcGx1Zy1pbikiLApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9tYWMv V2ViUHJvY2Vzc01hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L21hYy9XZWJQcm9jZXNzTWFjLm1tCShyZXZpc2lvbiAxMzk5MzEpCisrKyBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMDUs NiArMzA1LDggQEAgdm9pZCBXZWJQcm9jZXNzOjppbml0aWFsaXplUHJvY2Vzc05hbWUoYwogCiB2 b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3MoY29uc3QgQ2hpbGRQcm9j ZXNzSW5pdGlhbGl6YXRpb25QYXJhbWV0ZXJzJikKIHsKKyAgICBSdW5Mb29wOjpzZXRVc2VBcHBs aWNhdGlvblJ1bkxvb3BPbk1haW5SdW5Mb29wKCk7CisKICAgICBXS0FYUmVnaXN0ZXJSZW1vdGVB cHAoKTsKIAogI2lmIFVTRShTRUNVUklUWV9GUkFNRVdPUkspCg==