107052 2013-01-16 14:49:16 -0800 Buildmaster shouldn't restart after all webkitpy change 2015-09-24 07:32:04 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 ossy webkit-unassigned lforschler ossy wsiegrist oldest_to_newest 808736 0 ossy 2013-01-16 14:49:16 -0800 It seems build.webkit.org restarts itself after all webkitpy change. Today it was restarted twice in a short period because of these changes: - http://build.webkit.org/changes/20528 (http://trac.webkit.org/changeset/139913) - http://build.webkit.org/changes/20539 (http://trac.webkit.org/changeset/139924) Do we really need restarting master after all webkitpy change? I think only master.cfg changes should trigger master restart. 1128486 1 lforschler 2015-09-24 07:29:30 -0700 Buildbot is restarted via post commit hook from the svn sever. The post commit hook reads as follows: # # update build.webkit.org # UPDATE_BUILDBOT=$(/usr/bin/svnlook changed $REPOS -r $REV | /bin/grep -cE '(webkitpy|BuildSlaveSupport)') if [ $UPDATE_BUILDBOT -gt 0 ]; then /usr/bin/ssh -t buildbot@build.webkit.org "/usr/bin/sudo -n /usr/local/bin/buildbot-update-restart --force" >> /tmp/post-commit.log 2>&1 & fi 1128487 2 lforschler 2015-09-24 07:32:04 -0700 However, looking in the buildbot-update-restart code, it seems we filter out on config.json or master.cfg changes RESTART=$(/usr/bin/svn log -r $OLDREV:HEAD -vq | grep -cE '(config.json|master.cfg)');