107043 2013-01-16 12:39:28 -0800 [BlackBerry] Fix selection handle appearance for RTL text. 2013-01-17 14:33:11 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton webkit.review.bot oldest_to_newest 808613 0 mifenton 2013-01-16 12:39:28 -0800 SSIA. 809296 1 183176 mifenton 2013-01-17 06:01:22 -0800 Created attachment 183176 Patch 809319 2 183176 rwlbuis 2013-01-17 07:17:27 -0800 Comment on attachment 183176 Patch LGTM. 809791 3 183176 webkit.review.bot 2013-01-17 14:33:08 -0800 Comment on attachment 183176 Patch Clearing flags on attachment: 183176 Committed r140043: <http://trac.webkit.org/changeset/140043> 809792 4 webkit.review.bot 2013-01-17 14:33:11 -0800 All reviewed patches have been landed. Closing bug. 183176 2013-01-17 06:01:22 -0800 2013-01-17 14:33:08 -0800 Patch 0001-2013-01-16-Mike-Fenton-mifenton-rim.com.patch text/plain 3549 mifenton RnJvbSA3ZDNiZTI2NWM1M2I4OTUzY2ZiYjYzNDU1YWMwY2U4ODEyZjdlNzg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog V2VkLCAxNiBKYW4gMjAxMyAxNDowMDozNiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTMtMDEt MTYgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMjYzNTg1LgoK ICAgICAgICBJbnZlcnQgdGhlIHJlcG9ydGVkIHNlbGVjdGlvbiBoYW5kbGUgcG9zaXRpb24gaWYg dG8gbWF0Y2gKICAgICAgICB0aGUgdmlzdWFsIG9yZGVyIGluc3RlYWQgb2YgdGhlIGxvZ2ljYWwg b3JkZXIgdG8gY3JlYXRlIHRoZQogICAgICAgIGRlc2lyZWQgYXBwZWFyYW5jZSBmb3IgUlRMIHRl eHQgYW5kIGRpcmVjdGlvbmFsIHNlbGVjdGlvbnMuCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgoKICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6 CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0aW9u UG9zaXRpb25DaGFuZ2VkKToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICB8ICAgMTggKysrKysrKysrKysrKysrKysrCiAuLi4vYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwICB8ICAgMTAgKysrKysrKystLQog MiBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDc0ZGE4ZjIuLjcyNzMyNDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTE3ICBNaWtlIEZl bnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEZpeCBzZWxl Y3Rpb24gaGFuZGxlIGFwcGVhcmFuY2UgZm9yIFJUTCB0ZXh0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3MDQzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUFIgMjYzNTg1LgorCisgICAgICAgIEludmVy dCB0aGUgcmVwb3J0ZWQgc2VsZWN0aW9uIGhhbmRsZSBwb3NpdGlvbiBpZiB0byBtYXRjaAorICAg ICAgICB0aGUgdmlzdWFsIG9yZGVyIGluc3RlYWQgb2YgdGhlIGxvZ2ljYWwgb3JkZXIgdG8gY3Jl YXRlIHRoZQorICAgICAgICBkZXNpcmVkIGFwcGVhcmFuY2UgZm9yIFJUTCB0ZXh0IGFuZCBkaXJl Y3Rpb25hbCBzZWxlY3Rpb25zLgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkgYnkgR2Vu IE1hayBhbmQgTmltYSBHaGFuYXZhdGlhbi4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2Vs ZWN0aW9uSGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlv bkhhbmRsZXI6OnNlbGVjdGlvblBvc2l0aW9uQ2hhbmdlZCk6CisKIDIwMTMtMDEtMTYgIENoYXJs ZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFj a0JlcnJ5XSBOZWVkIHRvIGFkanVzdCB0aGUgc2NhbGUgYW5kIHNjcm9sbCBwb3NpdGlvbiBhZnRl ciBsZWF2aW5nIGZ1bGxzY3JlZW4gbW9kZSBpZiB0aGVyZSdzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3Bw CmluZGV4IDU3ODVhMzkuLjYxMWRmZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCkBAIC05NTQs MTQgKzk1NCwxMyBAQCB2b2lkIFNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdGlvblBvc2l0aW9uQ2hh bmdlZChib29sIGZvcmNlVXBkYXRlV2l0aG91dENoYW5nZSkKICAgICAgICAgcmV0dXJuOwogCiAg ICAgbV9sYXN0U2VsZWN0aW9uUmVnaW9uID0gdW5jbGlwcGVkUmVnaW9uOworICAgIGJvb2wgaXNS VEwgPSBkaXJlY3Rpb25PZkVuY2xvc2luZ0Jsb2NrKGZyYW1lLT5zZWxlY3Rpb24oKSkgPT0gUlRM OwogCiAgICAgSW50UmVjdFJlZ2lvbiB2aXNpYmxlU2VsZWN0aW9uUmVnaW9uOwogICAgIGlmICgh dW5jbGlwcGVkUmVnaW9uLmlzRW1wdHkoKSkgewogICAgICAgICBXZWJDb3JlOjpJbnRSZWN0IHVu Y2xpcHBlZFN0YXJ0Q2FyZXQ7CiAgICAgICAgIFdlYkNvcmU6OkludFJlY3QgdW5jbGlwcGVkRW5k Q2FyZXQ7CiAKLSAgICAgICAgYm9vbCBpc1JUTCA9IGRpcmVjdGlvbk9mRW5jbG9zaW5nQmxvY2so ZnJhbWUtPnNlbGVjdGlvbigpKSA9PSBSVEw7Ci0KICAgICAgICAgV2ViQ29yZTo6SW50UG9pbnQg c3RhcnRDYXJldFJlZmVyZW5jZVBvaW50ID0gcmVmZXJlbmNlUG9pbnQoZnJhbWUtPnNlbGVjdGlv bigpLT5zZWxlY3Rpb24oKS52aXNpYmxlU3RhcnQoKSwgdW5jbGlwcGVkUmVnaW9uLmV4dGVudHMo KSwgZnJhbWVQb3MsIHRydWUgLyogaXNTdGFydENhcmV0ICovLCBpc1JUTCk7CiAgICAgICAgIFdl YkNvcmU6OkludFBvaW50IGVuZENhcmV0UmVmZXJlbmNlUG9pbnQgPSByZWZlcmVuY2VQb2ludChm cmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLnZpc2libGVFbmQoKSwgdW5jbGlwcGVkUmVn aW9uLmV4dGVudHMoKSwgZnJhbWVQb3MsIGZhbHNlIC8qIGlzU3RhcnRDYXJldCAqLywgaXNSVEwp OwogCkBAIC05OTksNiArOTk4LDEzIEBAIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0aW9u UG9zaXRpb25DaGFuZ2VkKGJvb2wgZm9yY2VVcGRhdGVXaXRob3V0Q2hhbmdlKQogICAgICAgICB9 CiAgICAgfQogCisgICAgaWYgKCFmcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLmlzQmFz ZUZpcnN0KCkgfHwgaXNSVEwgKSB7CisgICAgICAgIC8vIEVuZCBoYW5kbGUgY29tZXMgYmVmb3Jl IHN0YXJ0LCBpbnZlcnQgdGhlIGNhcmV0IHJlZmVyZW5jZSBwb2ludHMuCisgICAgICAgIFdlYkNv cmU6OkludFJlY3QgdG1wQ2FyZXQoc3RhcnRDYXJldCk7CisgICAgICAgIHN0YXJ0Q2FyZXQgPSBl bmRDYXJldDsKKyAgICAgICAgZW5kQ2FyZXQgPSB0bXBDYXJldDsKKyAgICB9CisKICAgICBTZWxl Y3Rpb25Mb2coUGxhdGZvcm06OkxvZ0xldmVsSW5mbywKICAgICAgICAgIlNlbGVjdGlvbkhhbmRs ZXI6OnNlbGVjdGlvblBvc2l0aW9uQ2hhbmdlZCBTdGFydCBSZWN0PSVzIEVuZCBSZWN0PSVzIiwK ICAgICAgICAgUGxhdGZvcm06OkludFJlY3Qoc3RhcnRDYXJldCkudG9TdHJpbmcoKS5jX3N0cigp LAotLSAKMS43LjkuNQoK