107039 2013-01-16 12:06:05 -0800 Web Inspector: Crash at Console.cpp:216 (use of RefPtr after release to PassRefPtr) 2013-01-16 18:59:09 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 808590 0 timothy 2013-01-16 12:06:05 -0800 The arguments RefPtr is being released and later used. I have some other tweaks in this function too. 808595 1 183017 timothy 2013-01-16 12:09:28 -0800 Created attachment 183017 Proposed Change 808599 2 183017 joepeck 2013-01-16 12:12:45 -0800 Comment on attachment 183017 Proposed Change r=me Although it might be nice to make a test for this. I'm surprised that it wasn't covered by existing tests. 808742 3 183017 webkit.review.bot 2013-01-16 14:54:10 -0800 Comment on attachment 183017 Proposed Change Clearing flags on attachment: 183017 Committed r139927: <http://trac.webkit.org/changeset/139927> 808743 4 webkit.review.bot 2013-01-16 14:54:13 -0800 All reviewed patches have been landed. Closing bug. 808972 5 183017 darin 2013-01-16 18:59:09 -0800 Comment on attachment 183017 Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=183017&action=review > Source/WebCore/page/Console.cpp:218 > + String argAsString = arguments->argumentAt(i).toString(arguments->globalState()); > + printf(" %s", argAsString.utf8().data()); Could all be one line now without a local variable. 183017 2013-01-16 12:09:28 -0800 2013-01-16 18:59:09 -0800 Proposed Change 0001-Fix-a-crash-when-printing-console-messages-to-STDOUT.patch text/plain 3061 timothy RnJvbSAzYTZmYjE3YTBjMTBmMzRjNmEyZmExOGQwZDk4ODExODRhMGQ4OWU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBXZWQsIDE2IEphbiAyMDEzIDE1OjA1OjQ5IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGEgY3Jhc2ggd2hlbiBwcmludGluZyBjb25zb2xlIG1lc3NhZ2VzIHRvIFNURE9VVC4KCmh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcwMzkKClJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKKiBwYWdlL0NvbnNvbGUuY3BwOgooV2ViQ29yZTo6aW50ZXJuYWxBZGRN ZXNzYWdlKTogRG9uJ3QgcmVsZWFzZSB0aGUgUmVmUHRyIGVhcmx5LiBBbHNvIGxvZyB0aGUgbGlu ZSBudW1iZXIKYW5kIGNvbnZlcnQgbm9uLXN0cmluZyBhcmd1bWVudHMgdG8gc3RyaW5ncyB3aGVu IHByaW50aW5nIHRoZW0uCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICB8ICAg MTIgKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwIHwgICAxMCAr KysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDY3ZjliYmMuLmEzMDZlY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAxMy0wMS0xNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+ CisKKyAgICAgICAgRml4IGEgY3Jhc2ggd2hlbiBwcmludGluZyBjb25zb2xlIG1lc3NhZ2VzIHRv IFNURE9VVC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA3MDM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwYWdlL0NvbnNvbGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aW50ZXJuYWxBZGRNZXNz YWdlKTogRG9uJ3QgcmVsZWFzZSB0aGUgUmVmUHRyIGVhcmx5LiBBbHNvIGxvZyB0aGUgbGluZSBu dW1iZXIKKyAgICAgICAgYW5kIGNvbnZlcnQgbm9uLXN0cmluZyBhcmd1bWVudHMgdG8gc3RyaW5n cyB3aGVuIHByaW50aW5nIHRoZW0uCisKIDIwMTMtMDEtMTQgIEtlbnRhcm8gSGFyYSAgPGhhcmFr ZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gTWFrZSBhbiBJc29sYXRlIHBhcmFtZXRl ciBtYW5kYXRvcnkgaW4gYXNzb2NpYXRlT2JqZWN0V2l0aFdyYXBwZXIoKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9Db25zb2xlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29u c29sZS5jcHAKaW5kZXggZDRlMzQ4MS4uMDk3NzEwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9Db25zb2xlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3Bw CkBAIC0yMDEsNyArMjAxLDcgQEAgc3RhdGljIHZvaWQgaW50ZXJuYWxBZGRNZXNzYWdlKFBhZ2Uq IHBhZ2UsIE1lc3NhZ2VUeXBlIHR5cGUsIE1lc3NhZ2VMZXZlbCBsZXZlbCwKIAogICAgIFN0cmlu ZyBtZXNzYWdlOwogICAgIGJvb2wgZ290TWVzc2FnZSA9IGFyZ3VtZW50cy0+Z2V0Rmlyc3RBcmd1 bWVudEFzU3RyaW5nKG1lc3NhZ2UpOwotICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6YWRk TWVzc2FnZVRvQ29uc29sZShwYWdlLCBDb25zb2xlQVBJTWVzc2FnZVNvdXJjZSwgdHlwZSwgbGV2 ZWwsIG1lc3NhZ2UsIHN0YXRlLCBhcmd1bWVudHMucmVsZWFzZSgpKTsKKyAgICBJbnNwZWN0b3JJ bnN0cnVtZW50YXRpb246OmFkZE1lc3NhZ2VUb0NvbnNvbGUocGFnZSwgQ29uc29sZUFQSU1lc3Nh Z2VTb3VyY2UsIHR5cGUsIGxldmVsLCBtZXNzYWdlLCBzdGF0ZSwgYXJndW1lbnRzKTsKIAogICAg IGlmICghcGFnZS0+c2V0dGluZ3MoKSB8fCBwYWdlLT5zZXR0aW5ncygpLT5wcml2YXRlQnJvd3Np bmdFbmFibGVkKCkpCiAgICAgICAgIHJldHVybjsKQEAgLTIxMCwxNCArMjEwLDE0IEBAIHN0YXRp YyB2b2lkIGludGVybmFsQWRkTWVzc2FnZShQYWdlKiBwYWdlLCBNZXNzYWdlVHlwZSB0eXBlLCBN ZXNzYWdlTGV2ZWwgbGV2ZWwsCiAgICAgICAgIHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+YWRk TWVzc2FnZVRvQ29uc29sZShDb25zb2xlQVBJTWVzc2FnZVNvdXJjZSwgdHlwZSwgbGV2ZWwsIG1l c3NhZ2UsIGxhc3RDYWxsZXIubGluZU51bWJlcigpLCBsYXN0Q2FsbGVyLnNvdXJjZVVSTCgpKTsK IAogICAgIGlmIChwcmludEV4Y2VwdGlvbnMpIHsKLSAgICAgICAgcHJpbnRTb3VyY2VVUkxBbmRM aW5lKGxhc3RDYWxsZXIuc291cmNlVVJMKCksIDApOworICAgICAgICBwcmludFNvdXJjZVVSTEFu ZExpbmUobGFzdENhbGxlci5zb3VyY2VVUkwoKSwgbGFzdENhbGxlci5saW5lTnVtYmVyKCkpOwog ICAgICAgICBwcmludE1lc3NhZ2VTb3VyY2VBbmRMZXZlbFByZWZpeChDb25zb2xlQVBJTWVzc2Fn ZVNvdXJjZSwgbGV2ZWwpOwogCiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBhcmd1 bWVudHMtPmFyZ3VtZW50Q291bnQoKTsgKytpKSB7Ci0gICAgICAgICAgICBTdHJpbmcgYXJnQXNT dHJpbmc7Ci0gICAgICAgICAgICBpZiAoYXJndW1lbnRzLT5hcmd1bWVudEF0KGkpLmdldFN0cmlu Zyhhcmd1bWVudHMtPmdsb2JhbFN0YXRlKCksIGFyZ0FzU3RyaW5nKSkKLSAgICAgICAgICAgICAg ICBwcmludGYoIiAlcyIsIGFyZ0FzU3RyaW5nLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICAgICAg U3RyaW5nIGFyZ0FzU3RyaW5nID0gYXJndW1lbnRzLT5hcmd1bWVudEF0KGkpLnRvU3RyaW5nKGFy Z3VtZW50cy0+Z2xvYmFsU3RhdGUoKSk7CisgICAgICAgICAgICBwcmludGYoIiAlcyIsIGFyZ0Fz U3RyaW5nLnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICB9CisKICAgICAgICAgcHJpbnRmKCJcbiIp OwogICAgIH0KIAotLSAKMS43LjEwLjIgKEFwcGxlIEdpdC0zMykKCg==