107035 2013-01-16 11:05:31 -0800 [WK2] Expose WebGLErrorsToConsole settings in WebKit2 2013-01-17 19:48:52 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 104138 1 a.renevier a.renevier benjamin dino gman gyuyoung.kim kbr laszlo.gombos ostap73 sam simon.fraser oldest_to_newest 808535 0 a.renevier 2013-01-16 11:05:31 -0800 Hi, it would be nice to be able to set/get WebGLErrorsToConsole flag in WebKit2 808547 1 183011 a.renevier 2013-01-16 11:11:42 -0800 Created attachment 183011 patch proposal 808692 2 benjamin 2013-01-16 13:56:36 -0800 Curious: Why not just enable it by default? Is it too verbose or something? 808695 3 ostap73 2013-01-16 13:59:43 -0800 (In reply to comment #2) > Curious: Why not just enable it by default? Is it too verbose or something? IMHO, could be enable by default for debug builds. 808727 4 a.renevier 2013-01-16 14:33:32 -0800 (In reply to comment #3) > (In reply to comment #2) > > Curious: Why not just enable it by default? Is it too verbose or something? > > IMHO, could be enable by default for debug builds. This feature is useful for web developers. So, even we if we enable it for debug builds, I think still need to enable it (either by default, or behind a flag) in "regular" builds. 808730 5 benjamin 2013-01-16 14:37:07 -0800 > This feature is useful for web developers. So, even we if we enable it for debug builds, I think still need to enable it (either by default, or behind a flag) in "regular" builds. Agreed. Please answer my question :) 808764 6 a.renevier 2013-01-16 15:17:57 -0800 I don't known why this was chosen in the first place. Ccing people having worked on bug #77696 808871 7 kbr 2013-01-16 17:20:50 -0800 The patch looks reasonable to me but someone who works on WebKit2 should review it. 808879 8 sam 2013-01-16 17:25:59 -0800 I also don't understand what this switch is for. What console do the errors go to? The Web Inspector console? 808880 9 a.renevier 2013-01-16 17:28:53 -0800 (In reply to comment #8) > I also don't understand what this switch is for. What console do the errors go to? The Web Inspector console? yes. 808881 10 kbr 2013-01-16 17:29:59 -0800 Also, answering the earlier question, I don't remember why this was made a page setting rather than enabled by default, but it can be too verbose for poorly written WebGL applications. For this reason WebGLRenderingContext contains a throttle which turns it off after a certain number of errors. 809009 11 183011 sam 2013-01-16 20:04:39 -0800 Comment on attachment 183011 patch proposal This doesn't seem like a useful switch to have. 809465 12 kbr 2013-01-17 10:41:39 -0800 Thinking back, I am pretty sure this switch was added so that TestRunner/DumpRenderTree could turn off the logging of errors to the console. Some tests generate more than one kind of error. While a test can be written to check only for the one it wants, it can't prevent the WebGL implementation from logging all of the errors to the console, and those might vary between OpenGL implementations, leading to platform-specific text differences in the output. 809731 13 sam 2013-01-17 13:46:42 -0800 (In reply to comment #12) > Thinking back, I am pretty sure this switch was added so that TestRunner/DumpRenderTree could turn off the logging of errors to the console. Some tests generate more than one kind of error. While a test can be written to check only for the one it wants, it can't prevent the WebGL implementation from logging all of the errors to the console, and those might vary between OpenGL implementations, leading to platform-specific text differences in the output. In that case, the switch should be switchable from window.internals.settings, and new API should not be necessary. 810142 14 kbr 2013-01-17 19:48:52 -0800 (In reply to comment #13) > (In reply to comment #12) > > Thinking back, I am pretty sure this switch was added so that TestRunner/DumpRenderTree could turn off the logging of errors to the console. Some tests generate more than one kind of error. While a test can be written to check only for the one it wants, it can't prevent the WebGL implementation from logging all of the errors to the console, and those might vary between OpenGL implementations, leading to platform-specific text differences in the output. > > In that case, the switch should be switchable from window.internals.settings, and new API should not be necessary. Thanks for the suggestion. Bug 107218 filed about doing this. 183011 2013-01-16 11:11:42 -0800 2013-01-16 20:04:39 -0800 patch proposal bug-107035-20130116110835.patch text/plain 4934 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzk1NmM0ZTAxNzhmY2Fm YWU4ZGJmN2UxMjljZmI1YjdjNWRiMzg4Ny4uMDI0Yjk1MDYzYmJlMzM0MjZiYjBmMzMxMWE5ZmUx YzFmNWFhYjUwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTE2ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dL Ml0gRXhwb3NlIFdlYkdMRXJyb3JzVG9Db25zb2xlIHNldHRpbmdzIGluIFdlYktpdDIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzAzNQorCisgICAg ICAgIEFkZCBzZXR0aW5nIEFQSXMgZm9yIFdlYkdMIGVycm9ycyB0byBjb25zb2xlIGluIFdlYktp dDIuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oOgorICAgICAgICAo V2ViS2l0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHA6Cisg ICAgICAgIChXS1ByZWZlcmVuY2VzU2V0V2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVkKToKKyAg ICAgICAgKFdLUHJlZmVyZW5jZXNHZXRXZWJHTEVycm9yc1RvQ29uc29sZUVuYWJsZWQpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZTo6dXBkYXRlUHJlZmVyZW5jZXMpOgorCiAyMDEyLTEyLTIwICBBcm5hdWQgUmVuZXZpZXIgIDxh LnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQg Zm9yIGNvbG9yIGlucHV0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJl ZmVyZW5jZXNTdG9yZS5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzU3Rv cmUuaAppbmRleCBhYWIzY2NiOTY5OThhNzhjZWRhZDQwNjg4NDA4N2JlOGYyMjFkN2I0Li44NzM4 ZGJkNjQ2YTRjZTBkMDNjODNmMjc0ZmE3MDBmYjdkZWFmYjRjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmgKQEAgLTgyLDYgKzgyLDcgQEAgbmFtZXNwYWNl IFdlYktpdCB7CiAgICAgbWFjcm8oVGlsZWRTY3JvbGxpbmdJbmRpY2F0b3JWaXNpYmxlLCB0aWxl ZFNjcm9sbGluZ0luZGljYXRvclZpc2libGUsIEJvb2wsIGJvb2wsIGZhbHNlKSBcCiAgICAgbWFj cm8oQ1NTQ3VzdG9tRmlsdGVyRW5hYmxlZCwgY3NzQ3VzdG9tRmlsdGVyRW5hYmxlZCwgQm9vbCwg Ym9vbCwgdHJ1ZSkgXAogICAgIG1hY3JvKFdlYkdMRW5hYmxlZCwgd2ViR0xFbmFibGVkLCBCb29s LCBib29sLCBmYWxzZSkgXAorICAgIG1hY3JvKFdlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZCwg d2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVkLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAgIG1h Y3JvKEFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkLCBhY2NlbGVyYXRlZDJkQ2FudmFzRW5hYmxl ZCwgQm9vbCwgYm9vbCwgZmFsc2UpIFwKICAgICBtYWNybyhDU1NSZWdpb25zRW5hYmxlZCwgY3Nz UmVnaW9uc0VuYWJsZWQsIEJvb2wsIGJvb2wsIHRydWUpIFwKICAgICBtYWNybyhDU1NHcmlkTGF5 b3V0RW5hYmxlZCwgY3NzR3JpZExheW91dEVuYWJsZWQsIEJvb2wsIGJvb2wsIGZhbHNlKSBcCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHAKaW5k ZXggMDM0YmM5ZTA3ZWU0ZWQ5MmUyMDAxZWU0ZWY5MGU3NzYyM2Y4MDZhNy4uMjg3YmMxOTRkOWM0 ZjE0MGIwZjY2YTIyNjI4ODc1MzBiZTljMjVmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcApAQCAtNDY4LDYgKzQ2OCwxNiBAQCBib29s IFdLUHJlZmVyZW5jZXNHZXRXZWJHTEVuYWJsZWQoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNl c1JlZikKICAgICByZXR1cm4gdG9JbXBsKHByZWZlcmVuY2VzUmVmKS0+d2ViR0xFbmFibGVkKCk7 CiB9CiAKK3ZvaWQgV0tQcmVmZXJlbmNlc1NldFdlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZChX S1ByZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVmLCBib29sIGZsYWcpCit7CisgICAgdG9JbXBs KHByZWZlcmVuY2VzUmVmKS0+c2V0V2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVkKGZsYWcpOwor fQorCitib29sIFdLUHJlZmVyZW5jZXNHZXRXZWJHTEVycm9yc1RvQ29uc29sZUVuYWJsZWQoV0tQ cmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlc1JlZikKK3sKKyAgICByZXR1cm4gdG9JbXBsKHByZWZl cmVuY2VzUmVmKS0+d2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVkKCk7Cit9CisKIHZvaWQgV0tQ cmVmZXJlbmNlc1NldEFjY2VsZXJhdGVkMkRDYW52YXNFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYg cHJlZmVyZW5jZXNSZWYsIGJvb2wgZmxhZykKIHsKICAgICB0b0ltcGwocHJlZmVyZW5jZXNSZWYp LT5zZXRBY2NlbGVyYXRlZDJkQ2FudmFzRW5hYmxlZChmbGFnKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKaW5kZXggOTAy YWE0MDBkNTU5Yjc3MTg2YjJjYjczNjA1ZmI5NGMyNmJjYzVlZi4uMGVlYzcxMDY5N2QwNzI1ZDEy MzQ2OTE3NzRiYjY1MDViYTk4MGU2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKQEAgLTk2LDYgKzk2LDEwIEBAIFdL X0VYUE9SVCB2b2lkIFdLUHJlZmVyZW5jZXNTZXRXZWJHTEVuYWJsZWQoV0tQcmVmZXJlbmNlc1Jl ZiwgYm9vbCk7CiBXS19FWFBPUlQgYm9vbCBXS1ByZWZlcmVuY2VzR2V0V2ViR0xFbmFibGVkKFdL UHJlZmVyZW5jZXNSZWYpOwogCiAvLyBEZWZhdWx0cyB0byBmYWxzZS4KK1dLX0VYUE9SVCB2b2lk IFdLUHJlZmVyZW5jZXNTZXRXZWJHTEVycm9yc1RvQ29uc29sZUVuYWJsZWQoV0tQcmVmZXJlbmNl c1JlZiwgYm9vbCk7CitXS19FWFBPUlQgYm9vbCBXS1ByZWZlcmVuY2VzR2V0V2ViR0xFcnJvcnNU b0NvbnNvbGVFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYpOworCisvLyBEZWZhdWx0cyB0byBmYWxz ZS4KIFdLX0VYUE9SVCB2b2lkIFdLUHJlZmVyZW5jZXNTZXRBY2NlbGVyYXRlZDJEQ2FudmFzRW5h YmxlZChXS1ByZWZlcmVuY2VzUmVmLCBib29sKTsKIFdLX0VYUE9SVCBib29sIFdLUHJlZmVyZW5j ZXNHZXRBY2NlbGVyYXRlZDJEQ2FudmFzRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmKTsKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IGE1MjJh OWUzNmIwZGM5YTE2MzdkN2JlNGMyOWVkMzc2NmQzOTY4YWYuLjk1YmZlYzZiMWY2NWQ1N2ZmM2Mz MzljNDBlNzA5NjIwYWFhYTBmMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTIzNDMsNiArMjM0Myw3IEBAIHZvaWQgV2ViUGFnZTo6dXBk YXRlUHJlZmVyZW5jZXMoY29uc3QgV2ViUHJlZmVyZW5jZXNTdG9yZSYgc3RvcmUpCiAgICAgc2V0 dGluZ3MtPnNldENTU0dyaWRMYXlvdXRFbmFibGVkKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShX ZWJQcmVmZXJlbmNlc0tleTo6Y3NzR3JpZExheW91dEVuYWJsZWRLZXkoKSkpOwogICAgIHNldHRp bmdzLT5zZXRSZWdpb25CYXNlZENvbHVtbnNFbmFibGVkKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktl eShXZWJQcmVmZXJlbmNlc0tleTo6cmVnaW9uQmFzZWRDb2x1bW5zRW5hYmxlZEtleSgpKSk7CiAg ICAgc2V0dGluZ3MtPnNldFdlYkdMRW5hYmxlZChzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2Vi UHJlZmVyZW5jZXNLZXk6OndlYkdMRW5hYmxlZEtleSgpKSk7CisgICAgc2V0dGluZ3MtPnNldFdl YkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZChzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJl ZmVyZW5jZXNLZXk6OndlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZEtleSgpKSk7CiAgICAgc2V0 dGluZ3MtPnNldEFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkKHN0b3JlLmdldEJvb2xWYWx1ZUZv cktleShXZWJQcmVmZXJlbmNlc0tleTo6YWNjZWxlcmF0ZWQyZENhbnZhc0VuYWJsZWRLZXkoKSkp OwogICAgIHNldHRpbmdzLT5zZXRNZWRpYVBsYXliYWNrUmVxdWlyZXNVc2VyR2VzdHVyZShzdG9y ZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6Om1lZGlhUGxheWJhY2tSZXF1 aXJlc1VzZXJHZXN0dXJlS2V5KCkpKTsKICAgICBzZXR0aW5ncy0+c2V0TWVkaWFQbGF5YmFja0Fs bG93c0lubGluZShzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6Om1l ZGlhUGxheWJhY2tBbGxvd3NJbmxpbmVLZXkoKSkpOwo=