107010 2013-01-16 06:56:29 -0800 [CMake] Report actual values for feature configuration (instead of the default) 2013-01-16 13:25:05 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hugo.lima hugo.lima gyuyoung.kim laszlo.gombos rakuco webkit.review.bot oldest_to_newest 808346 0 hugo.lima 2013-01-16 06:56:29 -0800 The features summary is printing the initial value instead of the value chosen by the user, so if you pass --no-svg to webkit-build script it's now showing ENABLE_SVG ON instead of ENABLE_SVG OFF. 808352 1 182978 hugo.lima 2013-01-16 07:03:24 -0800 Created attachment 182978 Patch 808462 2 laszlo.gombos 2013-01-16 09:58:08 -0800 *** Bug 104738 has been marked as a duplicate of this bug. *** 808596 3 182978 laszlo.gombos 2013-01-16 12:09:38 -0800 Comment on attachment 182978 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182978&action=review > Source/cmake/WebKitFeatures.cmake:172 > - set(_MESSAGE "${_MESSAGE} ${_WEBKIT_AVAILABLE_OPTIONS_INITALVALUE_${_name}}") > + set(_MESSAGE "${_MESSAGE} ${${_name}}") Looks good. > ChangeLog:3 > + [cmake] Print the choose value on features summary instead of the initial value [cmake] -> [CMake] (to be consistent) choose --> chosen Perhaps - "[CMake] Report actual values for feature configuration (instead of the default)" 808619 4 hugo.lima 2013-01-16 12:43:00 -0800 (In reply to comment #3) > (From update of attachment 182978 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182978&action=review > > > Source/cmake/WebKitFeatures.cmake:172 > > - set(_MESSAGE "${_MESSAGE} ${_WEBKIT_AVAILABLE_OPTIONS_INITALVALUE_${_name}}") > > + set(_MESSAGE "${_MESSAGE} ${${_name}}") > > Looks good. > > > ChangeLog:3 > > + [cmake] Print the choose value on features summary instead of the initial value > > [cmake] -> [CMake] (to be consistent) > choose --> chosen > > Perhaps - "[CMake] Report actual values for feature configuration (instead of the default)" Yes, I noticed the typos after upload the patch, I'll re-upload it. 808621 5 183019 hugo.lima 2013-01-16 12:44:56 -0800 Created attachment 183019 Patch 808635 6 183019 laszlo.gombos 2013-01-16 12:57:28 -0800 Comment on attachment 183019 Patch r=me. 808652 7 183019 webkit.review.bot 2013-01-16 13:25:00 -0800 Comment on attachment 183019 Patch Clearing flags on attachment: 183019 Committed r139916: <http://trac.webkit.org/changeset/139916> 808653 8 webkit.review.bot 2013-01-16 13:25:05 -0800 All reviewed patches have been landed. Closing bug. 182978 2013-01-16 07:03:24 -0800 2013-01-16 12:44:49 -0800 Patch bug-107010-20130116115911.patch text/plain 1260 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMTAxZTQwYzFlYjQwYzE3NGM1MGJkNmRiZmE5YzcyNTM5NDQ2ZjIyMS4uOGViNDA2NDYzY2E1 YTU2OWQ2ZjcyNWY1YjhiNjMzNzQ5NDRkZTUyZiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTY5LDcgKzE2OSw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fRU5EKQogICAgICAgICAg ICAgc2V0KEZFQVRVUkVfREVGSU5FU19XSVRIX1NQQUNFX1NFUEFSQVRPUiAiJHtGRUFUVVJFX0RF RklORVNfV0lUSF9TUEFDRV9TRVBBUkFUT1J9ICR7X25hbWV9IikKICAgICAgICAgZW5kaWYgKCkK IAotICAgICAgICBzZXQoX01FU1NBR0UgIiR7X01FU1NBR0V9ICR7X1dFQktJVF9BVkFJTEFCTEVf T1BUSU9OU19JTklUQUxWQUxVRV8ke19uYW1lfX0iKQorICAgICAgICBzZXQoX01FU1NBR0UgIiR7 X01FU1NBR0V9ICR7JHtfbmFtZX19IikKICAgICAgICAgbWVzc2FnZShTVEFUVVMgIiR7X01FU1NB R0V9IikKICAgICBlbmRmb3JlYWNoICgpCiBlbmRtYWNybygpCmRpZmYgLS1naXQgYS9DaGFuZ2VM b2cgYi9DaGFuZ2VMb2cKaW5kZXggMWQyZDM3NGQ0NWQ4ZGJlYTEwY2E1ZWE2NjIwMzBkMTNmYWZk MWIyOC4uOWMyOTIyZmRmNWUwOTZlZTkzZjA1OGM3YzhiYzk5NjY5NjQyZTY3MCAxMDA2NDQKLS0t IGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAxLTE2 ICBIdWdvIFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAg IFtjbWFrZV0gUHJpbnQgdGhlIGNob29zZSB2YWx1ZSBvbiBmZWF0dXJlcyBzdW1tYXJ5IGluc3Rl YWQgb2YgdGhlIGluaXRpYWwgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNzAxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOgorCiAy MDEzLTAxLTE2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW0VGTF0gTW92ZSAnRGVmYXVsdFRoZW1lJyBmb2xkZXIgdG8gV2ViQ29yZS9wbGF0Zm9y bS9lZmwK 183019 2013-01-16 12:44:56 -0800 2013-01-16 13:24:59 -0800 Patch bug-107010-20130116174044.patch text/plain 1260 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMTAxZTQwYzFlYjQwYzE3NGM1MGJkNmRiZmE5YzcyNTM5NDQ2ZjIyMS4uOGViNDA2NDYzY2E1 YTU2OWQ2ZjcyNWY1YjhiNjMzNzQ5NDRkZTUyZiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTY5LDcgKzE2OSw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fRU5EKQogICAgICAgICAg ICAgc2V0KEZFQVRVUkVfREVGSU5FU19XSVRIX1NQQUNFX1NFUEFSQVRPUiAiJHtGRUFUVVJFX0RF RklORVNfV0lUSF9TUEFDRV9TRVBBUkFUT1J9ICR7X25hbWV9IikKICAgICAgICAgZW5kaWYgKCkK IAotICAgICAgICBzZXQoX01FU1NBR0UgIiR7X01FU1NBR0V9ICR7X1dFQktJVF9BVkFJTEFCTEVf T1BUSU9OU19JTklUQUxWQUxVRV8ke19uYW1lfX0iKQorICAgICAgICBzZXQoX01FU1NBR0UgIiR7 X01FU1NBR0V9ICR7JHtfbmFtZX19IikKICAgICAgICAgbWVzc2FnZShTVEFUVVMgIiR7X01FU1NB R0V9IikKICAgICBlbmRmb3JlYWNoICgpCiBlbmRtYWNybygpCmRpZmYgLS1naXQgYS9DaGFuZ2VM b2cgYi9DaGFuZ2VMb2cKaW5kZXggMWQyZDM3NGQ0NWQ4ZGJlYTEwY2E1ZWE2NjIwMzBkMTNmYWZk MWIyOC4uMmNkNjI5OWIwOWIyZjU2ZDRkYzE3YjJmNDdmY2IzNTEwZGNlMjlkMSAxMDA2NDQKLS0t IGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAxLTE2 ICBIdWdvIFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAg IFtDTWFrZV0gUmVwb3J0IGFjdHVhbCB2YWx1ZXMgZm9yIGZlYXR1cmUgY29uZmlndXJhdGlvbiAo aW5zdGVhZCBvZiB0aGUgZGVmYXVsdCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNzAxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOgorCiAy MDEzLTAxLTE2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW0VGTF0gTW92ZSAnRGVmYXVsdFRoZW1lJyBmb2xkZXIgdG8gV2ViQ29yZS9wbGF0Zm9y bS9lZmwK