107004 2013-01-16 05:12:05 -0800 Monitor usage of unprefixed and prefixed DOM events for CSS Transitions. 2019-02-06 09:19:04 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard abarth ojan.autocc webkit.review.bot oldest_to_newest 808290 0 menard 2013-01-16 05:12:05 -0800 Monitor usage of unprefixed and prefixed DOM event for CSS Transitions. 808298 1 182964 menard 2013-01-16 05:17:01 -0800 Created attachment 182964 Patch 808299 2 182965 menard 2013-01-16 05:19:10 -0800 Created attachment 182965 Patch 808432 3 182965 abarth 2013-01-16 09:37:28 -0800 Comment on attachment 182965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182965&action=review > Source/WebCore/dom/EventTarget.cpp:174 > + if (document->domWindow()) { > + if (event->type() == eventNames().transitionendEvent) > + FeatureObserver::observe(document->domWindow(), FeatureObserver::UnprefixedTransitionEndEvent); > + if (event->type() == eventNames().webkitTransitionEndEvent) > + FeatureObserver::observe(document->domWindow(), FeatureObserver::PrefixedTransitionEndEvent); > + } This is fine, but you won't be able to correlate the two. You might want to also observe when both are registered. 808434 4 182965 abarth 2013-01-16 09:38:48 -0800 Comment on attachment 182965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182965&action=review > Source/WebCore/dom/EventTarget.cpp:164 > +static void observeEvent(const Event* event, const EventTarget* target) Isn't the common case that event isn't for transitions? If so, we might want to check for whether the event is transitionendEvent or webkitTransitionEndEvent early in this function. 808437 5 menard 2013-01-16 09:41:16 -0800 (In reply to comment #4) > (From update of attachment 182965 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182965&action=review > > > Source/WebCore/dom/EventTarget.cpp:164 > > +static void observeEvent(const Event* event, const EventTarget* target) > > Isn't the common case that event isn't for transitions? If so, we might want to check for whether the event is transitionendEvent or webkitTransitionEndEvent early in this function. Well in that function later I'll put the animation DOM events :). 808440 6 182965 menard 2013-01-16 09:43:08 -0800 Comment on attachment 182965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182965&action=review >>> Source/WebCore/dom/EventTarget.cpp:164 >>> +static void observeEvent(const Event* event, const EventTarget* target) >> >> Isn't the common case that event isn't for transitions? If so, we might want to check for whether the event is transitionendEvent or webkitTransitionEndEvent early in this function. > > Well in that function later I'll put the animation DOM events :). Well in fact before observeEvent is called I check (!prefixedTypeName.isEmpty()) which already filter regular events. You'll be in that function only if the event had a prefixed version. >> Source/WebCore/dom/EventTarget.cpp:174 >> + } > > This is fine, but you won't be able to correlate the two. You might want to also observe when both are registered. I'm not sure to understand here. 808524 7 abarth 2013-01-16 10:46:23 -0800 > >> Source/WebCore/dom/EventTarget.cpp:174 > >> + } > > > > This is fine, but you won't be able to correlate the two. You might want to also observe when both are registered. > > I'm not sure to understand here. My understanding is that you're interested in knowing how often web pages are listening for both the prefixed and unprefixed versions of the same event. The way you've written this patch, you'll learn how often they listening for each type of event, but you won't be able to figure out how often they're listening for *both* at the same time. 808632 8 183021 menard 2013-01-16 12:50:16 -0800 Created attachment 183021 Patch 808654 9 183026 menard 2013-01-16 13:30:13 -0800 Created attachment 183026 Patch 808696 10 183026 webkit.review.bot 2013-01-16 14:00:10 -0800 Comment on attachment 183026 Patch Clearing flags on attachment: 183026 Committed r139922: <http://trac.webkit.org/changeset/139922> 808697 11 webkit.review.bot 2013-01-16 14:00:14 -0800 All reviewed patches have been landed. Closing bug. 1503308 12 lforschler 2019-02-06 09:19:04 -0800 Mass move bugs into the DOM component. 182964 2013-01-16 05:17:01 -0800 2013-01-16 05:19:04 -0800 Patch bug-107004-20130116101401.patch text/plain 3597 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM5YWE4NGZhMWE0NWY0 Mzg3MmNiYTU2NTk3ZmZlN2UxNGZlOWM1Ny4uM2NlOTZjNmMyZDhmOWU3YmJhNTI4MTA4ZWU2Mzcy M2MyMjE1YWNjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTE2ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW9uaXRvciB1c2FnZSBv ZiB1bnByZWZpeGVkIGFuZCBwcmVmaXhlZCBET00gZXZlbnQgZm9yIENTUyBUcmFuc2l0aW9ucy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzAwNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vbml0b3Ig dGhlIHVzYWdlIG9mIHRyYW5zaXRpb25FbmQgZXZlbnRzIGFzIHdlbGwgYXMKKyAgICAgICAgd2Vi a2l0VHJhbnNpdGlvbkVuZCBldmVudHMgc28gd2UgY2FuIGtub3cgaW4gdGhlIGZ1dHVyZSBob3cg bXVjaCB0aGUKKyAgICAgICAgcHJlZml4ZWQgdmVyc2lvbiBpcyB1c2VkIHRvIHJlbW92ZSBpdCBi ZWNvbWVzIGlycmVsZXZhbnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogbm8gYmVoYXZpb3Ig Y2hhbmdlcywgd2UncmUganVzdCBhZGRpbmcgbW9uaXRvcmluZy4KKworICAgICAgICAqIGRvbS9F dmVudFRhcmdldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpvYnNlcnZlRXZlbnQpOgorICAgICAg ICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudFRhcmdldDo6ZmlyZUV2ZW50TGlz dGVuZXJzKToKKyAgICAgICAgKiBwYWdlL0ZlYXR1cmVPYnNlcnZlci5oOgorCiAyMDEzLTAxLTE1 ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IFN0b3JlIHByb2plY3QgVUlTb3VyY2VDb2RlcyBpbiBhIG1hcCB3aXRoIHVyaSBh cyBhIGtleSBmb3IgZmFzdGVyIGxvb2t1cC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FdmVudFRhcmdldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXQuY3BwCmlu ZGV4IGU1NTQ4ZDdkNGQwOWE5OTQ4YTgxYjA4ZmMzNTliZDIyNzVhYWNjMGMuLjIxMTdiOGQwMjky YWU1NWMzNDU1YzQxMjExNGYwZjQxMTk0NTUxOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9FdmVudFRhcmdldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0 LmNwcApAQCAtMTYxLDYgKzE2MSwyMCBAQCB2b2lkIEV2ZW50VGFyZ2V0Ojp1bmNhdWdodEV4Y2Vw dGlvbkluRXZlbnRIYW5kbGVyKCkKIHsKIH0KIAorc3RhdGljIHZvaWQgb2JzZXJ2ZUV2ZW50KGNv bnN0IEV2ZW50KiBldmVudCwgY29uc3QgRXZlbnRUYXJnZXQqIHRhcmdldCkKK3sKKyAgICBTY3Jp cHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0ID0gdGFyZ2V0LT5zY3JpcHRFeGVjdXRpb25Db250 ZXh0KCk7CisgICAgaWYgKGNvbnRleHQgJiYgY29udGV4dC0+aXNEb2N1bWVudCgpKSB7CisgICAg ICAgIERvY3VtZW50KiBkb2N1bWVudCA9IHN0YXRpY19jYXN0PERvY3VtZW50Kj4oY29udGV4dCk7 CisgICAgICAgIGlmIChkb2N1bWVudC0+ZG9tV2luZG93KCkpIHsKKyAgICAgICAgICAgIGlmIChl dmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS50cmFuc2l0aW9uZW5kRXZlbnQpCisgICAgICAg ICAgICAgICAgRmVhdHVyZU9ic2VydmVyOjpvYnNlcnZlKGRvY3VtZW50LT5kb21XaW5kb3coKSwg RmVhdHVyZU9ic2VydmVyOjpVbnByZWZpeGVkVHJhbnNpdGlvbkVuZEV2ZW50KTsKKyAgICAgICAg ICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS53ZWJraXRUcmFuc2l0aW9uRW5k RXZlbnQpCisgICAgICAgICAgICAgICAgRmVhdHVyZU9ic2VydmVyOjpvYnNlcnZlKGRvY3VtZW50 LT5kb21XaW5kb3coKSwgRmVhdHVyZU9ic2VydmVyOjpQcmVmaXhlZFRyYW5zaXRpb25FbmRFdmVu dCk7CisgICAgICAgIH0KKyAgICB9Cit9CisKIHN0YXRpYyBQYXNzUmVmUHRyPEV2ZW50PiBjcmVh dGVNYXRjaGluZ1ByZWZpeGVkRXZlbnQoY29uc3QgRXZlbnQqIGV2ZW50KQogewogICAgIGlmIChl dmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS50cmFuc2l0aW9uZW5kRXZlbnQpIHsKQEAgLTE5 OSwxMCArMjEzLDE1IEBAIGJvb2wgRXZlbnRUYXJnZXQ6OmZpcmVFdmVudExpc3RlbmVycyhFdmVu dCogZXZlbnQpCiAKICAgICBFdmVudExpc3RlbmVyVmVjdG9yKiBsaXN0ZW5lclVucHJlZml4ZWRW ZWN0b3IgPSBkLT5ldmVudExpc3RlbmVyTWFwLmZpbmQoZXZlbnQtPnR5cGUoKSk7CiAKLSAgICBp ZiAobGlzdGVuZXJVbnByZWZpeGVkVmVjdG9yKQorICAgIGlmIChsaXN0ZW5lclVucHJlZml4ZWRW ZWN0b3IpIHsKKyAgICAgICAgaWYgKCFwcmVmaXhlZFR5cGVOYW1lLmlzRW1wdHkoKSkKKyAgICAg ICAgICAgIG9ic2VydmVFdmVudChldmVudCwgdGhpcyk7CiAgICAgICAgIGZpcmVFdmVudExpc3Rl bmVycyhldmVudCwgZCwgKmxpc3RlbmVyVW5wcmVmaXhlZFZlY3Rvcik7Ci0gICAgZWxzZSBpZiAo bGlzdGVuZXJQcmVmaXhlZFZlY3RvcikKKyAgICB9IGVsc2UgaWYgKGxpc3RlbmVyUHJlZml4ZWRW ZWN0b3IpIHsKKyAgICAgICAgaWYgKCFwcmVmaXhlZFR5cGVOYW1lLmlzRW1wdHkoKSkKKyAgICAg ICAgICAgIG9ic2VydmVFdmVudChldmVudCwgdGhpcyk7CiAgICAgICAgIGZpcmVFdmVudExpc3Rl bmVycyhjcmVhdGVNYXRjaGluZ1ByZWZpeGVkRXZlbnQoZXZlbnQpLmdldCgpLCBkLCAqbGlzdGVu ZXJQcmVmaXhlZFZlY3Rvcik7CisgICAgfQogICAgIAogICAgIHJldHVybiAhZXZlbnQtPmRlZmF1 bHRQcmV2ZW50ZWQoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVy ZU9ic2VydmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCmluZGV4 IDUzMWY0NmYzOGQyMWVlNGViZGFhNzA5YjYyNWEyN2Y0NmMzMTk3ZGMuLmE2MzQwNTIxOWI3NzMz MTM0Y2Q2YTM0ZjAyODI2ZjVkZmRhMmM1YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRmVhdHVyZU9ic2VydmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2Jz ZXJ2ZXIuaApAQCAtNTcsNiArNTcsOCBAQCBwdWJsaWM6CiAgICAgICAgIENvbnRlbnRTZWN1cml0 eVBvbGljeSwKICAgICAgICAgQ29udGVudFNlY3VyaXR5UG9saWN5UmVwb3J0T25seSwKICAgICAg ICAgUHJlZml4ZWRDb250ZW50U2VjdXJpdHlQb2xpY3lSZXBvcnRPbmx5LAorICAgICAgICBQcmVm aXhlZFRyYW5zaXRpb25FbmRFdmVudCwKKyAgICAgICAgVW5wcmVmaXhlZFRyYW5zaXRpb25FbmRF dmVudCwKICAgICAgICAgLy8gQWRkIG5ldyBmZWF0dXJlcyBhYm92ZSB0aGlzIGxpbmUuCiAgICAg ICAgIE51bWJlck9mRmVhdHVyZXMsIC8vIFRoaXMgZW51bSB2YWx1ZSBtdXN0IGJlIGxhc3QuCiAg ICAgfTsK 182965 2013-01-16 05:19:10 -0800 2013-01-16 12:50:10 -0800 Patch bug-107004-20130116101610.patch text/plain 3598 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM5YWE4NGZhMWE0NWY0 Mzg3MmNiYTU2NTk3ZmZlN2UxNGZlOWM1Ny4uY2Y1ZmI3Zjk2YmNjOWNiZjU0YzQzZGQ1NmM4ZWRk NDA2NDI2MzgzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTE2ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW9uaXRvciB1c2FnZSBv ZiB1bnByZWZpeGVkIGFuZCBwcmVmaXhlZCBET00gZXZlbnRzIGZvciBDU1MgVHJhbnNpdGlvbnMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcwMDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb25pdG9y IHRoZSB1c2FnZSBvZiB0cmFuc2l0aW9uRW5kIGV2ZW50cyBhcyB3ZWxsIGFzCisgICAgICAgIHdl YmtpdFRyYW5zaXRpb25FbmQgZXZlbnRzIHNvIHdlIGNhbiBrbm93IGluIHRoZSBmdXR1cmUgaG93 IG11Y2ggdGhlCisgICAgICAgIHByZWZpeGVkIHZlcnNpb24gaXMgdXNlZCB0byByZW1vdmUgaXQg YmVjb21lcyBpcnJlbGV2YW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyA6IG5vIGJlaGF2aW9y IGNoYW5nZXMsIHdlJ3JlIGp1c3QgYWRkaW5nIG1vbml0b3JpbmcuCisKKyAgICAgICAgKiBkb20v RXZlbnRUYXJnZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6b2JzZXJ2ZUV2ZW50KToKKyAgICAg ICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRUYXJnZXQ6OmZpcmVFdmVudExp c3RlbmVycyk6CisgICAgICAgICogcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaDoKKwogMjAxMy0wMS0x NSAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBTdG9yZSBwcm9qZWN0IFVJU291cmNlQ29kZXMgaW4gYSBtYXAgd2l0aCB1cmkg YXMgYSBrZXkgZm9yIGZhc3RlciBsb29rdXAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vRXZlbnRUYXJnZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0LmNwcApp bmRleCBlNTU0OGQ3ZDRkMDlhOTk0OGE4MWIwOGZjMzU5YmQyMjc1YWFjYzBjLi4yMTE3YjhkMDI5 MmFlNTVjMzQ1NWM0MTIxMTRmMGY0MTE5NDU1MTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRXZlbnRUYXJnZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRhcmdl dC5jcHAKQEAgLTE2MSw2ICsxNjEsMjAgQEAgdm9pZCBFdmVudFRhcmdldDo6dW5jYXVnaHRFeGNl cHRpb25JbkV2ZW50SGFuZGxlcigpCiB7CiB9CiAKK3N0YXRpYyB2b2lkIG9ic2VydmVFdmVudChj b25zdCBFdmVudCogZXZlbnQsIGNvbnN0IEV2ZW50VGFyZ2V0KiB0YXJnZXQpCit7CisgICAgU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCA9IHRhcmdldC0+c2NyaXB0RXhlY3V0aW9uQ29u dGV4dCgpOworICAgIGlmIChjb250ZXh0ICYmIGNvbnRleHQtPmlzRG9jdW1lbnQoKSkgeworICAg ICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBzdGF0aWNfY2FzdDxEb2N1bWVudCo+KGNvbnRleHQp OworICAgICAgICBpZiAoZG9jdW1lbnQtPmRvbVdpbmRvdygpKSB7CisgICAgICAgICAgICBpZiAo ZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkudHJhbnNpdGlvbmVuZEV2ZW50KQorICAgICAg ICAgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVudC0+ZG9tV2luZG93KCks IEZlYXR1cmVPYnNlcnZlcjo6VW5wcmVmaXhlZFRyYW5zaXRpb25FbmRFdmVudCk7CisgICAgICAg ICAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkud2Via2l0VHJhbnNpdGlvbkVu ZEV2ZW50KQorICAgICAgICAgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVu dC0+ZG9tV2luZG93KCksIEZlYXR1cmVPYnNlcnZlcjo6UHJlZml4ZWRUcmFuc2l0aW9uRW5kRXZl bnQpOworICAgICAgICB9CisgICAgfQorfQorCiBzdGF0aWMgUGFzc1JlZlB0cjxFdmVudD4gY3Jl YXRlTWF0Y2hpbmdQcmVmaXhlZEV2ZW50KGNvbnN0IEV2ZW50KiBldmVudCkKIHsKICAgICBpZiAo ZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkudHJhbnNpdGlvbmVuZEV2ZW50KSB7CkBAIC0x OTksMTAgKzIxMywxNSBAQCBib29sIEV2ZW50VGFyZ2V0OjpmaXJlRXZlbnRMaXN0ZW5lcnMoRXZl bnQqIGV2ZW50KQogCiAgICAgRXZlbnRMaXN0ZW5lclZlY3RvciogbGlzdGVuZXJVbnByZWZpeGVk VmVjdG9yID0gZC0+ZXZlbnRMaXN0ZW5lck1hcC5maW5kKGV2ZW50LT50eXBlKCkpOwogCi0gICAg aWYgKGxpc3RlbmVyVW5wcmVmaXhlZFZlY3RvcikKKyAgICBpZiAobGlzdGVuZXJVbnByZWZpeGVk VmVjdG9yKSB7CisgICAgICAgIGlmICghcHJlZml4ZWRUeXBlTmFtZS5pc0VtcHR5KCkpCisgICAg ICAgICAgICBvYnNlcnZlRXZlbnQoZXZlbnQsIHRoaXMpOwogICAgICAgICBmaXJlRXZlbnRMaXN0 ZW5lcnMoZXZlbnQsIGQsICpsaXN0ZW5lclVucHJlZml4ZWRWZWN0b3IpOwotICAgIGVsc2UgaWYg KGxpc3RlbmVyUHJlZml4ZWRWZWN0b3IpCisgICAgfSBlbHNlIGlmIChsaXN0ZW5lclByZWZpeGVk VmVjdG9yKSB7CisgICAgICAgIGlmICghcHJlZml4ZWRUeXBlTmFtZS5pc0VtcHR5KCkpCisgICAg ICAgICAgICBvYnNlcnZlRXZlbnQoZXZlbnQsIHRoaXMpOwogICAgICAgICBmaXJlRXZlbnRMaXN0 ZW5lcnMoY3JlYXRlTWF0Y2hpbmdQcmVmaXhlZEV2ZW50KGV2ZW50KS5nZXQoKSwgZCwgKmxpc3Rl bmVyUHJlZml4ZWRWZWN0b3IpOworICAgIH0KICAgICAKICAgICByZXR1cm4gIWV2ZW50LT5kZWZh dWx0UHJldmVudGVkKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1 cmVPYnNlcnZlci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaAppbmRl eCA1MzFmNDZmMzhkMjFlZTRlYmRhYTcwOWI2MjVhMjdmNDZjMzE5N2RjLi5hNjM0MDUyMTliNzcz MzEzNGNkNmEzNGYwMjgyNmY1ZGZkYTJjNWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL0ZlYXR1cmVPYnNlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9i c2VydmVyLmgKQEAgLTU3LDYgKzU3LDggQEAgcHVibGljOgogICAgICAgICBDb250ZW50U2VjdXJp dHlQb2xpY3ksCiAgICAgICAgIENvbnRlbnRTZWN1cml0eVBvbGljeVJlcG9ydE9ubHksCiAgICAg ICAgIFByZWZpeGVkQ29udGVudFNlY3VyaXR5UG9saWN5UmVwb3J0T25seSwKKyAgICAgICAgUHJl Zml4ZWRUcmFuc2l0aW9uRW5kRXZlbnQsCisgICAgICAgIFVucHJlZml4ZWRUcmFuc2l0aW9uRW5k RXZlbnQsCiAgICAgICAgIC8vIEFkZCBuZXcgZmVhdHVyZXMgYWJvdmUgdGhpcyBsaW5lLgogICAg ICAgICBOdW1iZXJPZkZlYXR1cmVzLCAvLyBUaGlzIGVudW0gdmFsdWUgbXVzdCBiZSBsYXN0Lgog ICAgIH07Cg== 183021 2013-01-16 12:50:16 -0800 2013-01-16 13:30:06 -0800 Patch bug-107004-20130116174717.patch text/plain 3234 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM5YWE4NGZhMWE0NWY0 Mzg3MmNiYTU2NTk3ZmZlN2UxNGZlOWM1Ny4uYWIxOTIzMzY1ZDRkMzUzYjMxYmYwODJmNjNiN2Q1 YTFkYjI2MWUxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTE2ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW9uaXRvciB1c2FnZSBv ZiB1bnByZWZpeGVkIGFuZCBwcmVmaXhlZCBET00gZXZlbnRzIGZvciBDU1MgVHJhbnNpdGlvbnMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcwMDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb25pdG9y IHRoZSB1c2FnZSBvZiB0cmFuc2l0aW9uRW5kIGV2ZW50cyBhcyB3ZWxsIGFzCisgICAgICAgIHdl YmtpdFRyYW5zaXRpb25FbmQgZXZlbnRzIHNvIHdlIGNhbiBrbm93IGluIHRoZSBmdXR1cmUgaG93 IG11Y2ggdGhlCisgICAgICAgIHByZWZpeGVkIHZlcnNpb24gaXMgdXNlZCB0byByZW1vdmUgaXQg YmVjb21lcyBpcnJlbGV2YW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyA6IG5vIGJlaGF2aW9y IGNoYW5nZXMsIHdlJ3JlIGp1c3QgYWRkaW5nIG1vbml0b3JpbmcuCisKKyAgICAgICAgKiBkb20v RXZlbnRUYXJnZXQuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpF dmVudFRhcmdldDo6ZmlyZUV2ZW50TGlzdGVuZXJzKToKKyAgICAgICAgKiBwYWdlL0ZlYXR1cmVP YnNlcnZlci5oOgorCiAyMDEzLTAxLTE1ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0b3JlIHByb2plY3QgVUlTb3VyY2VD b2RlcyBpbiBhIG1hcCB3aXRoIHVyaSBhcyBhIGtleSBmb3IgZmFzdGVyIGxvb2t1cC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRhcmdldC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRXZlbnRUYXJnZXQuY3BwCmluZGV4IGU1NTQ4ZDdkNGQwOWE5OTQ4YTgxYjA4ZmMzNTli ZDIyNzVhYWNjMGMuLjZhNmVmM2Y5ODBmMTg3NDFkMTFjODhhMGE0ZmE0NTY3Mjc3YTA4ZjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRhcmdldC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0LmNwcApAQCAtMjAzLDcgKzIwMywyMiBAQCBib29sIEV2 ZW50VGFyZ2V0OjpmaXJlRXZlbnRMaXN0ZW5lcnMoRXZlbnQqIGV2ZW50KQogICAgICAgICBmaXJl RXZlbnRMaXN0ZW5lcnMoZXZlbnQsIGQsICpsaXN0ZW5lclVucHJlZml4ZWRWZWN0b3IpOwogICAg IGVsc2UgaWYgKGxpc3RlbmVyUHJlZml4ZWRWZWN0b3IpCiAgICAgICAgIGZpcmVFdmVudExpc3Rl bmVycyhjcmVhdGVNYXRjaGluZ1ByZWZpeGVkRXZlbnQoZXZlbnQpLmdldCgpLCBkLCAqbGlzdGVu ZXJQcmVmaXhlZFZlY3Rvcik7Ci0gICAgCisKKyAgICBpZiAoIXByZWZpeGVkVHlwZU5hbWUuaXNF bXB0eSgpKSB7CisgICAgICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQgPSBzY3Jp cHRFeGVjdXRpb25Db250ZXh0KCk7CisgICAgICAgIGlmIChjb250ZXh0ICYmIGNvbnRleHQtPmlz RG9jdW1lbnQoKSkgeworICAgICAgICAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gc3RhdGljX2Nh c3Q8RG9jdW1lbnQqPihjb250ZXh0KTsKKyAgICAgICAgICAgIGlmIChkb2N1bWVudC0+ZG9tV2lu ZG93KCkpIHsKKyAgICAgICAgICAgICAgICBpZiAobGlzdGVuZXJVbnByZWZpeGVkVmVjdG9yICYm IGxpc3RlbmVyUHJlZml4ZWRWZWN0b3IpCisgICAgICAgICAgICAgICAgICAgIEZlYXR1cmVPYnNl cnZlcjo6b2JzZXJ2ZShkb2N1bWVudC0+ZG9tV2luZG93KCksIEZlYXR1cmVPYnNlcnZlcjo6UHJl Zml4ZWRBbmRVbnByZWZpeGVkVHJhbnNpdGlvbkVuZEV2ZW50KTsKKyAgICAgICAgICAgICAgICBl bHNlIGlmICghbGlzdGVuZXJVbnByZWZpeGVkVmVjdG9yICYmIGxpc3RlbmVyUHJlZml4ZWRWZWN0 b3IpCisgICAgICAgICAgICAgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVu dC0+ZG9tV2luZG93KCksIEZlYXR1cmVPYnNlcnZlcjo6UHJlZml4ZWRUcmFuc2l0aW9uRW5kRXZl bnQpOworICAgICAgICAgICAgICAgIGVsc2UgaWYgKGxpc3RlbmVyVW5wcmVmaXhlZFZlY3RvciAm JiAhbGlzdGVuZXJQcmVmaXhlZFZlY3RvcikKKyAgICAgICAgICAgICAgICAgICAgRmVhdHVyZU9i c2VydmVyOjpvYnNlcnZlKGRvY3VtZW50LT5kb21XaW5kb3coKSwgRmVhdHVyZU9ic2VydmVyOjpV bnByZWZpeGVkVHJhbnNpdGlvbkVuZEV2ZW50KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQor ICAgIH0KKwogICAgIHJldHVybiAhZXZlbnQtPmRlZmF1bHRQcmV2ZW50ZWQoKTsKIH0KICAgICAg ICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oIGIv U291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaAppbmRleCA1MzFmNDZmMzhkMjFl ZTRlYmRhYTcwOWI2MjVhMjdmNDZjMzE5N2RjLi41ZTVjZGE3NGI4NzJlMjM4YzAyMzI5MzRlNjc1 YWNlZjBjYzQwZjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNl cnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVyLmgKQEAgLTU3 LDYgKzU3LDkgQEAgcHVibGljOgogICAgICAgICBDb250ZW50U2VjdXJpdHlQb2xpY3ksCiAgICAg ICAgIENvbnRlbnRTZWN1cml0eVBvbGljeVJlcG9ydE9ubHksCiAgICAgICAgIFByZWZpeGVkQ29u dGVudFNlY3VyaXR5UG9saWN5UmVwb3J0T25seSwKKyAgICAgICAgUHJlZml4ZWRUcmFuc2l0aW9u RW5kRXZlbnQsCisgICAgICAgIFVucHJlZml4ZWRUcmFuc2l0aW9uRW5kRXZlbnQsCisgICAgICAg IFByZWZpeGVkQW5kVW5wcmVmaXhlZFRyYW5zaXRpb25FbmRFdmVudCwKICAgICAgICAgLy8gQWRk IG5ldyBmZWF0dXJlcyBhYm92ZSB0aGlzIGxpbmUuCiAgICAgICAgIE51bWJlck9mRmVhdHVyZXMs IC8vIFRoaXMgZW51bSB2YWx1ZSBtdXN0IGJlIGxhc3QuCiAgICAgfTsK 183026 2013-01-16 13:30:13 -0800 2013-01-16 14:00:10 -0800 Patch bug-107004-20130116182713.patch text/plain 3185 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM5YWE4NGZhMWE0NWY0 Mzg3MmNiYTU2NTk3ZmZlN2UxNGZlOWM1Ny4uYWIxOTIzMzY1ZDRkMzUzYjMxYmYwODJmNjNiN2Q1 YTFkYjI2MWUxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTE2ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW9uaXRvciB1c2FnZSBv ZiB1bnByZWZpeGVkIGFuZCBwcmVmaXhlZCBET00gZXZlbnRzIGZvciBDU1MgVHJhbnNpdGlvbnMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcwMDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb25pdG9y IHRoZSB1c2FnZSBvZiB0cmFuc2l0aW9uRW5kIGV2ZW50cyBhcyB3ZWxsIGFzCisgICAgICAgIHdl YmtpdFRyYW5zaXRpb25FbmQgZXZlbnRzIHNvIHdlIGNhbiBrbm93IGluIHRoZSBmdXR1cmUgaG93 IG11Y2ggdGhlCisgICAgICAgIHByZWZpeGVkIHZlcnNpb24gaXMgdXNlZCB0byByZW1vdmUgaXQg YmVjb21lcyBpcnJlbGV2YW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyA6IG5vIGJlaGF2aW9y IGNoYW5nZXMsIHdlJ3JlIGp1c3QgYWRkaW5nIG1vbml0b3JpbmcuCisKKyAgICAgICAgKiBkb20v RXZlbnRUYXJnZXQuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpF dmVudFRhcmdldDo6ZmlyZUV2ZW50TGlzdGVuZXJzKToKKyAgICAgICAgKiBwYWdlL0ZlYXR1cmVP YnNlcnZlci5oOgorCiAyMDEzLTAxLTE1ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0b3JlIHByb2plY3QgVUlTb3VyY2VD b2RlcyBpbiBhIG1hcCB3aXRoIHVyaSBhcyBhIGtleSBmb3IgZmFzdGVyIGxvb2t1cC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRhcmdldC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRXZlbnRUYXJnZXQuY3BwCmluZGV4IGU1NTQ4ZDdkNGQwOWE5OTQ4YTgxYjA4ZmMzNTli ZDIyNzVhYWNjMGMuLjkyNGEzMmNiMzIzMTU0ZWYyMDQ1MTc0Y2M4Mjc0M2Q1YWVkM2VmNDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRhcmdldC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0LmNwcApAQCAtMjAzLDcgKzIwMywyMyBAQCBib29sIEV2 ZW50VGFyZ2V0OjpmaXJlRXZlbnRMaXN0ZW5lcnMoRXZlbnQqIGV2ZW50KQogICAgICAgICBmaXJl RXZlbnRMaXN0ZW5lcnMoZXZlbnQsIGQsICpsaXN0ZW5lclVucHJlZml4ZWRWZWN0b3IpOwogICAg IGVsc2UgaWYgKGxpc3RlbmVyUHJlZml4ZWRWZWN0b3IpCiAgICAgICAgIGZpcmVFdmVudExpc3Rl bmVycyhjcmVhdGVNYXRjaGluZ1ByZWZpeGVkRXZlbnQoZXZlbnQpLmdldCgpLCBkLCAqbGlzdGVu ZXJQcmVmaXhlZFZlY3Rvcik7Ci0gICAgCisKKyAgICBpZiAoIXByZWZpeGVkVHlwZU5hbWUuaXNF bXB0eSgpKSB7CisgICAgICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQgPSBzY3Jp cHRFeGVjdXRpb25Db250ZXh0KCk7CisgICAgICAgIGlmIChjb250ZXh0ICYmIGNvbnRleHQtPmlz RG9jdW1lbnQoKSkgeworICAgICAgICAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gc3RhdGljX2Nh c3Q8RG9jdW1lbnQqPihjb250ZXh0KTsKKyAgICAgICAgICAgIGlmIChkb2N1bWVudC0+ZG9tV2lu ZG93KCkpIHsKKyAgICAgICAgICAgICAgICBpZiAobGlzdGVuZXJQcmVmaXhlZFZlY3RvcikKKyAg ICAgICAgICAgICAgICAgICAgaWYgKGxpc3RlbmVyVW5wcmVmaXhlZFZlY3RvcikKKyAgICAgICAg ICAgICAgICAgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShkb2N1bWVudC0+ZG9tV2lu ZG93KCksIEZlYXR1cmVPYnNlcnZlcjo6UHJlZml4ZWRBbmRVbnByZWZpeGVkVHJhbnNpdGlvbkVu ZEV2ZW50KTsKKyAgICAgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICAg ICAgRmVhdHVyZU9ic2VydmVyOjpvYnNlcnZlKGRvY3VtZW50LT5kb21XaW5kb3coKSwgRmVhdHVy ZU9ic2VydmVyOjpQcmVmaXhlZFRyYW5zaXRpb25FbmRFdmVudCk7CisgICAgICAgICAgICAgICAg ZWxzZSBpZiAobGlzdGVuZXJVbnByZWZpeGVkVmVjdG9yKQorICAgICAgICAgICAgICAgICAgICBG ZWF0dXJlT2JzZXJ2ZXI6Om9ic2VydmUoZG9jdW1lbnQtPmRvbVdpbmRvdygpLCBGZWF0dXJlT2Jz ZXJ2ZXI6OlVucHJlZml4ZWRUcmFuc2l0aW9uRW5kRXZlbnQpOworICAgICAgICAgICAgfQorICAg ICAgICB9CisgICAgfQorCiAgICAgcmV0dXJuICFldmVudC0+ZGVmYXVsdFByZXZlbnRlZCgpOwog fQogICAgICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2Vy dmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCmluZGV4IDUzMWY0 NmYzOGQyMWVlNGViZGFhNzA5YjYyNWEyN2Y0NmMzMTk3ZGMuLjVlNWNkYTc0Yjg3MmUyMzhjMDIz MjkzNGU2NzVhY2VmMGNjNDBmNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVh dHVyZU9ic2VydmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIu aApAQCAtNTcsNiArNTcsOSBAQCBwdWJsaWM6CiAgICAgICAgIENvbnRlbnRTZWN1cml0eVBvbGlj eSwKICAgICAgICAgQ29udGVudFNlY3VyaXR5UG9saWN5UmVwb3J0T25seSwKICAgICAgICAgUHJl Zml4ZWRDb250ZW50U2VjdXJpdHlQb2xpY3lSZXBvcnRPbmx5LAorICAgICAgICBQcmVmaXhlZFRy YW5zaXRpb25FbmRFdmVudCwKKyAgICAgICAgVW5wcmVmaXhlZFRyYW5zaXRpb25FbmRFdmVudCwK KyAgICAgICAgUHJlZml4ZWRBbmRVbnByZWZpeGVkVHJhbnNpdGlvbkVuZEV2ZW50LAogICAgICAg ICAvLyBBZGQgbmV3IGZlYXR1cmVzIGFib3ZlIHRoaXMgbGluZS4KICAgICAgICAgTnVtYmVyT2ZG ZWF0dXJlcywgLy8gVGhpcyBlbnVtIHZhbHVlIG11c3QgYmUgbGFzdC4KICAgICB9Owo=