106998 2013-01-16 03:01:22 -0800 Web Inspector: array grouping does not work for float number keys 2013-01-16 08:57:45 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 106891 1 aandrey aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 808218 0 aandrey 2013-01-16 03:01:22 -0800 This is a follow-up to the https://bugs.webkit.org/show_bug.cgi?id=106891 fix, which was not quite correct. Now we do the array index check according to the ECMAScript 5, section 15.4: "A property name P (in the form of a String value) is an array index if and only if ToString(ToUint32(P)) is equal to P and ToUint32(P) is not equal to 2^32-1." Patch to follow. 808221 1 182949 aandrey 2013-01-16 03:03:28 -0800 Created attachment 182949 Patch 808413 2 182949 webkit.review.bot 2013-01-16 08:57:42 -0800 Comment on attachment 182949 Patch Clearing flags on attachment: 182949 Committed r139887: <http://trac.webkit.org/changeset/139887> 808414 3 webkit.review.bot 2013-01-16 08:57:45 -0800 All reviewed patches have been landed. Closing bug. 182949 2013-01-16 03:03:28 -0800 2013-01-16 08:57:41 -0800 Patch bug-106998-20130116150030.patch text/plain 6026 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWE4MmU1OGJhN2Y0Mjdj ZGUwZGM0NmIxMDhkMTdkZGVkZDZmZGM5OC4uNTA2ZWVhODY1YjkwZDYxNTdhZDZhNjc4Y2RlMTRj ZjZiNTdjZTQzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTE2ICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFycmF5IGdyb3VwaW5nIGRvZXMgbm90IHdvcmsgZm9yIGZsb2F0IG51bWJlciBrZXlzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY5OTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cgd2UgZG8g dGhlIGFycmF5IGluZGV4IGNoZWNrIGFjY29yZGluZyB0byB0aGUgRUNNQVNjcmlwdCA1LCBzZWN0 aW9uIDE1LjQ6CisgICAgICAgICJBIHByb3BlcnR5IG5hbWUgUCAoaW4gdGhlIGZvcm0gb2YgYSBT dHJpbmcgdmFsdWUpIGlzIGFuIGFycmF5IGluZGV4IGlmIGFuZCBvbmx5IGlmIFRvU3RyaW5nKFRv VWludDMyKFApKSBpcyBlcXVhbCB0byBQIGFuZCBUb1VpbnQzMihQKSBpcyBub3QgZXF1YWwgdG8g Ml4zMi0xLiIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGll c1NlY3Rpb24uanM6CisgICAgICAgICguYnVpbGRPYmplY3RGcmFnbWVudCk6CisKIDIwMTMtMDEt MTUgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogSW50cm9kdWNlIFVJU291cmNlQ29kZS5vcmlnaW5VUkwoKS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1Nl Y3Rpb24uanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFByb3Bl cnRpZXNTZWN0aW9uLmpzCmluZGV4IDQxNDFmYmNlNTdlNTI3ZjNlOTdlMTYxM2U1NjUxNzZiNjQ0 OWJmN2QuLmVlZDk4NmYxYTE3OTViZmU2MGYzMTdkYjgyMGI4NjU1MzE5NWFlYzkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1Nl Y3Rpb24uanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQ cm9wZXJ0aWVzU2VjdGlvbi5qcwpAQCAtNzYyLDcgKzc2Miw4IEBAIFdlYkluc3BlY3Rvci5BcnJh eUdyb3VwaW5nVHJlZUVsZW1lbnQuX3BvcHVsYXRlTm9uSW5kZXhQcm9wZXJ0aWVzID0gZnVuY3Rp b24odHJlCiAgICAgICAgIHZhciBuYW1lcyA9IE9iamVjdC5nZXRPd25Qcm9wZXJ0eU5hbWVzKHRo aXMpOwogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IG5hbWVzLmxlbmd0aDsgKytpKSB7CiAg ICAgICAgICAgICB2YXIgbmFtZSA9IG5hbWVzW2ldOwotICAgICAgICAgICAgaWYgKCFpc05hTihu YW1lKSAmJiAwIDw9IG5hbWUgJiYgbmFtZSA8IHRoaXMubGVuZ3RoKQorICAgICAgICAgICAgLy8g QXJyYXkgaW5kZXggY2hlY2sgYWNjb3JkaW5nIHRvIHRoZSBFUzUtMTUuNC4KKyAgICAgICAgICAg IGlmIChTdHJpbmcobmFtZSA+Pj4gMCkgPT0gbmFtZSAmJiBuYW1lID4+PiAwICE9PSAweGZmZmZm ZmZmKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgdmFyIGRlc2NyaXB0 b3IgPSBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHRoaXMsIG5hbWUpOwogICAgICAg ICAgICAgaWYgKGRlc2NyaXB0b3IpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjMyOWRkZTZlNTQ5MmY4M2IzMTkyZDllY2Rl ZjVjNzEyMjYwZjJhMi4uMWI4OTRjMThkNDc3YjU0YmEyMTdjODY4YjM1NjRhZjI2NzhhZThmYSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTE2ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRy ZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFycmF5IGdyb3VwaW5n IGRvZXMgbm90IHdvcmsgZm9yIGZsb2F0IG51bWJlciBrZXlzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY5OTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUt YmlnLWFycmF5LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNwZWN0b3IvY29uc29sZS9jb25z b2xlLWJpZy1hcnJheS5odG1sOgorCiAyMDEzLTAxLTE1ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2 aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEludHJvZHVjZSBVSVNv dXJjZUNvZGUub3JpZ2luVVJMKCkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y29uc29sZS9jb25zb2xlLWJpZy1hcnJheS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvY29uc29sZS9jb25zb2xlLWJpZy1hcnJheS1leHBlY3RlZC50eHQKaW5kZXggZjgwNjkz ZWI2ZWRkYmMyOGMyYTIwYmIzOTVmZDA3MTMxNDlkNzFmYy4uMGJlZTgzMjkyNzYzNTdlZGVmMDVm NmU3Y2YxZDM4ZTU4ZGU0N2RlMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nv bnNvbGUvY29uc29sZS1iaWctYXJyYXktZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2lu c3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtYmlnLWFycmF5LWV4cGVjdGVkLnR4dApAQCAtMiw3ICsy LDcgQEAgQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEzOiAwLDEsMiwzLDQsNSw2LDcsOCw5LDEwLDEx LDEyLDEzLDE0LDE1LDE2LDE3LDE4LDE5LDIwLDIKIENPTlNPTEUgTUVTU0FHRTogbGluZSAxODog LCwsLCwsLCwsCiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjQ6IDAsMSwyLDMsNCw1LDYsNyw4LDks LCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCws LCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsMTAwCiBDT05TT0xFIE1FU1NBR0U6IGxp bmUgMjk6IDAsMSwyLDMsNCw1LDYsNyw4LDksMTAsMTEsMTIsMTMsMTQsMTUsMTYsMTcsMTgsMTks MjAsMjEsMjIsMjMsMjQsMjUsMjYsMjcsMjgsMjksMzAsMzEsMzIsMzMsMzQsMzUsMzYsMzcsMzgs MzksNDAsNDEsNDIsNDMsNDQsNDUsNDYsNDcsNDgsNDksNTAsNTEsNTIsNTMsNTQsNTUsNTYsNTcs NTgsNTksNjAsNjEsNjIsNjMsNjQsNjUsNjYsNjcsNjgsNjksNzAsNzEsNzIsNzMsNzQsNzUsNzYs NzcsNzgsNzksODAsODEsODIsODMsODQsODUsODYsODcsODgsODksOTAsOTEsOTIsOTMsOTQsOTUs OTYsOTcsOTgsOTksMTAwLDEwMSwxMDIsMTAzLDEwNCwxMDUsMTA2LDEwNywxMDgsMTA5LDExMCwx MTEsMTEyLDExMywxMTQsMTE1LDExNiwxMTcsMTE4LDExOSwxMjAsMTIxLDEyMiwxMjMsMTI0LDEy NSwxMjYsMTI3LDEyOCwxMjksMTMwLDEzMSwxMzIsMTMzLDEzNCwxMzUsMTM2LDEzNywxMzgsMTM5 LDE0MCwxNDEsMTQyLDE0MywxNDQsMTQ1LDE0NiwxNDcsMTQ4LDE0OSwxNTAsMTUxLDE1MiwxNTMs MTU0LDE1NSwxNTYsMTU3LDE1OCwxNTksMTYwLDE2MSwxNjIsMTYzLDE2NCwxNjUsMTY2LDE2Nywx NjgsMTY5LDE3MCwxNzEsMTcyLDE3MywxNzQsMTc1LDE3NiwxNzcsMTc4LDE3OSwxODAsMTgxLDE4 MiwxODMsMTg0LDE4NSwxODYsMTg3LDE4OCwxODksMTkwLDE5MSwxOTIsMTkzLDE5NCwxOTUsMTk2 LDE5NywxOTgsMTk5LDIwMCwyMDEsMjAyLDIwMywyMDQsMjA1LDIwNiwyMDcsMjA4LDIwOSwyMTAs MjExLDIxMiwyMTMsMjE0LDIxNSwyMTYsMjE3LDIxOCwyMTksMjIwLDIyMSwyMjIsMjIzLDIyNCwy MjUsMjI2LDIyNywyMjgsMjI5LDIzMCwyMzEsMjMyLDIzMywyMzQsMjM1LDIzNiwyMzcsMjM4LDIz OSwyNDAsMjQxLDI0MiwyNDMsMjQ0LDI0NSwyNDYsMjQ3LDI0OCwyNDksMjUwLDI1MSwyNTIsMjUz LDI1NCwyNTUsMjU2LDI1NywyNTgsMjU5LDI2MCwyNjEsMjYyLDI2MywyNjQsMjY1LDI2NiwyNjcs MjY4LDI2OSwyNzAsMjcxLDI3MiwyNzMsMjc0LDI3NSwyNzYsMjc3LDI3OCwyNzksMjgwLDI4MSwy ODIsMjgzLDI4NCwyODUsMjg2LDI4NywyODgsMjg5LDI5MCwyOTEsMjkyLDI5MywyOTQsMjk1LDI5 NiwyOTcsMjk4LDI5OSwzMDAsMzAxLDMwMiwzMDMsMzA0LDMwNSwzMDYsMzA3LDMwOCwzMDksMzEw LDMxMSwzMTIsMzEzLDMxNCwzMTUsMzE2LDMxNywzMTgsMzE5LDMyMCwzMjEsMzIyLDMyMywzMjQs MzI1LDMyNiwzMjcsMzI4LDMyOSwzMzAsMzMxLDMzMiwzMzMsMzM0LDMzNSwzMzYsMzM3LDMzOCwz MzksMzQwLDM0MSwzNDIsMzQzLDM0NCwzNDUsMzQ2LDM0NywzNDgsMzQ5LDM1MCwzNTEsMzUyLDM1 MywzNTQsMzU1LDM1NiwzNTcsMzU4LDM1OSwzNjAsMzYxLDM2MiwzNjMsMzY0LDM2NSwzNjYsMzY3 LDM2OCwzNjksMzcwLDM3MSwzNzIsMzczLDM3NCwzNzUsMzc2LDM3NywzNzgsMzc5LDM4MCwzODEs MzgyLDM4MywzODQsMzg1LDM4NiwzODcsMzg4LDM4OSwzOTAsMzkxLDM5MiwzOTMsMzk0LDM5NSwz OTYsMzk3LDM5OCwzOTksNDAwLDQwMSw0MDIsNDAzLDQwNAotQ09OU09MRSBNRVNTQUdFOiBsaW5l IDM4OiAwLDEsMiwzLDQsNSw2LDcsOCw5LCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCws LCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCws LCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsMTIzCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgNDI6ICVP CiBUZXN0cyB0aGF0IGNvbnNvbGUgbG9nZ2luZyBkdW1wcyBsYXJnZSBhcnJheXMgcHJvcGVybHku CiAKIApAQCAtMTI5LDkgKzEyOSwxMyBAQCBBcnJheVsxMjRdCiAgICAgODogOAogICAgIDk6IDkK ICAgICAxMjM6IDEyMworICAgIC1JbmZpbml0eTogLUluZmluaXR5CisgICAgMy4xNDogMy4xNAog ICAgIDQyOTQ5NjcyOTU6IDQyOTQ5NjcyOTUKICAgICA0Mjk0OTY3Mjk2OiA0Mjk0OTY3Mjk2Cisg ICAgSW5maW5pdHk6IEluZmluaXR5CiAgICAgLTEyMzogLTEyMworICAgIE5hTjogTmFOCiAgICAg bGVuZ3RoOiAxMjQKLSAgICBfX3Byb3RvX186IEFycmF5WzBdIGNvbnNvbGUtYmlnLWFycmF5Lmh0 bWw6MzgKKyAgICBfX3Byb3RvX186IEFycmF5WzBdIGNvbnNvbGUtYmlnLWFycmF5Lmh0bWw6NDIK IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1iaWct YXJyYXkuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtYmlnLWFy cmF5Lmh0bWwKaW5kZXggYWI0OGFkNmU1NTA3YmQwYzA1YzY3NjNkODZkNTlkNGVhZDkyYzBmZC4u ZmE3MWM4MzViYjcyOTYxZDYwMmZmZjkxNmNhMTg4NWNmODJjOWMwYyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1iaWctYXJyYXkuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWJpZy1hcnJheS5odG1sCkBAIC0z Myw5ICszMywxMyBAQCBmdW5jdGlvbiBvbmxvYWQoKQogICAgICAgICBlW2ldID0gaTsKICAgICBl WzEyM10gPSAxMjM7CiAgICAgZVstMTIzXSA9IC0xMjM7CisgICAgZVszLjE0XSA9IDMuMTQ7CiAg ICAgZVs0Mjk0OTY3Mjk1XSA9IDQyOTQ5NjcyOTU7CiAgICAgZVs0Mjk0OTY3Mjk2XSA9IDQyOTQ5 NjcyOTY7Ci0gICAgY29uc29sZS5kaXIoZSk7CisgICAgZVtJbmZpbml0eV0gPSBJbmZpbml0eTsK KyAgICBlWy1JbmZpbml0eV0gPSAtSW5maW5pdHk7CisgICAgZVtOYU5dID0gTmFOOworICAgIGNv bnNvbGUubG9nKCIlTyIsIGUpOwogCiAgICAgcnVuVGVzdCgpOwogfQo=