106993 2013-01-16 01:46:40 -0800 Web Inspector: fix Сlosure warnings in devTools front-end 2013-01-16 05:12:56 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 808172 0 lushnikov 2013-01-16 01:46:40 -0800 Fix closure warnings in devTools front-end. 808205 1 182944 lushnikov 2013-01-16 02:40:55 -0800 Created attachment 182944 Patch 808291 2 182944 webkit.review.bot 2013-01-16 05:12:52 -0800 Comment on attachment 182944 Patch Clearing flags on attachment: 182944 Committed r139873: <http://trac.webkit.org/changeset/139873> 808292 3 webkit.review.bot 2013-01-16 05:12:56 -0800 All reviewed patches have been landed. Closing bug. 182944 2013-01-16 02:40:55 -0800 2013-01-16 05:12:52 -0800 Patch bug-106993-20130116143757.patch text/plain 6661 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhiMTljNWUxYjFlYTFl Y2M1Y2M0YjE5ZGIyMDFiZDhhYTRhNWE4My4uZDQ2ZjBlYjdlNzJlYWE3MTU3YWJjMGIwNGMyYjQw MTY1NzNhNjkzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDEzLTAxLTE2ICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5z cGVjdG9yOiBmaXgg0KFsb3N1cmUgd2FybmluZ3MgaW4gZGV2VG9vbHMgZnJvbnQtZW5kCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY5OTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlzc2luZyBh bm5vdGF0aW9ucyBhbmQgcmVuYW1lIEVsZW1lbnQucmVtb3ZlKCkgbWV0aG9kIHRvIGF2b2lkIGNv bGxpc2lvbiB3aXRoIEhUTUxTZWxlY3RFbGVtZW50LnJlbW92ZSgpIG1ldGhvZC4KKworICAgICAg ICBObyBuZXcgdGVzdHM6IG5vIGNoYW5nZSBpbiBiZWhhdmlvdXIuCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTU5v ZGUucHJvdG90eXBlLmhhc0NoaWxkTm9kZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTU5v ZGUucHJvdG90eXBlLmdldENoaWxkTm9kZXMpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvRE9NRXh0ZW5zaW9uLmpzOgorICAgICAgICAoRWxlbWVudC5wcm90b3R5cGUucmVtb3ZlU2Vs Zik6CisgICAgICAgIChyZW1vdmVTdWJzZXF1ZW50Tm9kZXMpOgorICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanM6CisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9TZXR0aW5nc1NjcmVlbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PdmVycmlk ZXNTZXR0aW5nc1RhYik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VUb2tl bml6ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlVG9rZW5pemVyKToKKworMjAx My0wMS0xNiAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJvbWl1bS5vcmc+CisKICAg ICAgICAgV2ViIEluc3BlY3RvcjogZml4IGJhY2t3YXJkIGNvbXBhdGliaWxpdHkgaXNzdWVzIHdp dGggRWxlbWVudC5yZW1vdmUoKSBtZXRob2QKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwNjk5NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9ET01BZ2VudC5qcwppbmRleCA5MTViNmNmYzlkMjM2NzUyY2U1NTAxZWQ5OWYy NTc0MzRhNWM2ZTVlLi40YTZlM2Y2NzE1YmFkZDAwMzE3MzE1Mjg2MGRiNDFlNTllOTM3MTQ2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50Lmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMKQEAg LTEzNSw3ICsxMzUsNyBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZS5wcm90b3R5cGUgPSB7CiAgICAg ICovCiAgICAgaGFzQ2hpbGROb2RlczogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgcmV0dXJu IHRoaXMuX2NoaWxkTm9kZUNvdW50ID4gMCB8fCAhIXRoaXMuX3NoYWRvd1Jvb3RzLmxlbmd0aCB8 fCB0aGlzLl90ZW1wbGF0ZUNvbnRlbnQ7CisgICAgICAgIHJldHVybiB0aGlzLl9jaGlsZE5vZGVD b3VudCA+IDAgfHwgISF0aGlzLl9zaGFkb3dSb290cy5sZW5ndGggfHwgISF0aGlzLl90ZW1wbGF0 ZUNvbnRlbnQ7CiAgICAgfSwKIAogICAgIC8qKgpAQCAtMjk3LDcgKzI5Nyw3IEBAIFdlYkluc3Bl Y3Rvci5ET01Ob2RlLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICBjYWxsYmFjayh0aGlz LmNoaWxkcmVuKTsKICAgICAgICAgfQogCi0gICAgICAgIERPTUFnZW50LnJlcXVlc3RDaGlsZE5v ZGVzKHRoaXMuaWQsIG15Y2FsbGJhY2suYmluZCh0aGlzKSk7CisgICAgICAgIERPTUFnZW50LnJl cXVlc3RDaGlsZE5vZGVzKHRoaXMuaWQsIHVuZGVmaW5lZCwgbXljYWxsYmFjay5iaW5kKHRoaXMp KTsKICAgICB9LAogCiAgICAgLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0RPTUV4dGVuc2lvbi5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRE9NRXh0ZW5zaW9uLmpzCmluZGV4IDQ1ZTU5ZjRhZTY1MjEwNjk3ODBkZTM5Y2Fi YWI5ZjMyYjkxZjVkMDAuLjQzNDM2ZmNmMzFhNmVhNTFkMTgwMzQyY2M5ZWQ3ZjNjZThjY2ViYTIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NRXh0ZW5z aW9uLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NRXh0ZW5z aW9uLmpzCkBAIC0yMTEsMTQgKzIxMSwxNCBAQCBFbGVtZW50LnByb3RvdHlwZS5pc1Njcm9sbGVk VG9Cb3R0b20gPSBmdW5jdGlvbigpCiAgICAgcmV0dXJuIHRoaXMuc2Nyb2xsVG9wICsgdGhpcy5j bGllbnRIZWlnaHQgPT09IHRoaXMuc2Nyb2xsSGVpZ2h0OwogfQogCi1FbGVtZW50LnByb3RvdHlw ZS5yZW1vdmUgPSBmdW5jdGlvbigpCitFbGVtZW50LnByb3RvdHlwZS5yZW1vdmVTZWxmID0gZnVu Y3Rpb24oKQogewogICAgIGlmICh0aGlzLnBhcmVudEVsZW1lbnQpCiAgICAgICAgIHRoaXMucGFy ZW50RWxlbWVudC5yZW1vdmVDaGlsZCh0aGlzKTsKIH0KIAotQ2hhcmFjdGVyRGF0YS5wcm90b3R5 cGUucmVtb3ZlID0gRWxlbWVudC5wcm90b3R5cGUucmVtb3ZlOwotRG9jdW1lbnRUeXBlLnByb3Rv dHlwZS5yZW1vdmUgPSBFbGVtZW50LnByb3RvdHlwZS5yZW1vdmU7CitDaGFyYWN0ZXJEYXRhLnBy b3RvdHlwZS5yZW1vdmVTZWxmID0gRWxlbWVudC5wcm90b3R5cGUucmVtb3ZlU2VsZjsKK0RvY3Vt ZW50VHlwZS5wcm90b3R5cGUucmVtb3ZlU2VsZiA9IEVsZW1lbnQucHJvdG90eXBlLnJlbW92ZVNl bGY7CiAKIC8qKgogICogQHBhcmFtIHtOb2RlfSBmcm9tTm9kZQpAQCAtMjI5LDcgKzIyOSw3IEBA IGZ1bmN0aW9uIHJlbW92ZVN1YnNlcXVlbnROb2Rlcyhmcm9tTm9kZSwgdG9Ob2RlKQogICAgIGZv ciAodmFyIG5vZGUgPSBmcm9tTm9kZTsgbm9kZSAmJiBub2RlICE9PSB0b05vZGU7ICkgewogICAg ICAgICB2YXIgbm9kZVRvUmVtb3ZlID0gbm9kZTsKICAgICAgICAgbm9kZSA9IG5vZGUubmV4dFNp Ymxpbmc7Ci0gICAgICAgIG5vZGVUb1JlbW92ZS5yZW1vdmUoKTsKKyAgICAgICAgbm9kZVRvUmVt b3ZlLnJlbW92ZVNlbGYoKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzCmluZGV4IGNmN2MyNjI2 MjI1ODlmZTc3Zjc1NThiNzNlOTVlODJhYTM3Yzc5MDQuLmViM2RkYjZiZTIxNWE0YzVhY2QxYTEy NjlmZjZmZjc2ZGE0YmE3OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcwpAQCAtMTg2Niw3ICsxODY2LDcgQEAg V2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlID0gewogICAgIC8qKgog ICAgICAqIEBwYXJhbSB7RWxlbWVudH0gbGluZVJvdwogICAgICAqIEBwYXJhbSB7c3RyaW5nfSBs aW5lCi0gICAgICogQHBhcmFtIHtBcnJheS48e3N0YXJ0Q29sdW1uOiBudW1iZXIsIGVuZENvbHVt bjogbnVtYmVyLCBjc3NDbGFzczogc3RyaW5nfT59IHJhbmdlcworICAgICAqIEBwYXJhbSB7QXJy YXkuPHtzdGFydENvbHVtbjogbnVtYmVyLCBlbmRDb2x1bW46IG51bWJlciwgdG9rZW46ID9zdHJp bmd9Pn0gcmFuZ2VzCiAgICAgICovCiAgICAgX3JlbmRlclJhbmdlczogZnVuY3Rpb24obGluZVJv dywgbGluZSwgcmFuZ2VzKQogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU2V0dGluZ3NTY3JlZW4uanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1NldHRpbmdzU2NyZWVuLmpzCmluZGV4IDJhYzE5YTRhZGY3NjY5NmU2Zjdl OWFmYTFiNGRkZGY5YWFiYjA5ZWIuLjhkZjBkNmNhMWYzN2ViYTAyMTZmNmJjY2NjMGU2NTFjNzQ5 NzE4MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0 dGluZ3NTY3JlZW4uanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T ZXR0aW5nc1NjcmVlbi5qcwpAQCAtNDI0LDcgKzQyNCw3IEBAIFdlYkluc3BlY3Rvci5PdmVycmlk ZXNTZXR0aW5nc1RhYiA9IGZ1bmN0aW9uKCkKICAgICBXZWJJbnNwZWN0b3IuU2V0dGluZ3NUYWIu Y2FsbCh0aGlzLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIk92ZXJyaWRlcyIpLCAib3ZlcnJpZGVz LXRhYi1jb250ZW50Iik7CiAgICAgdGhpcy5fdmlldyA9IG5ldyBXZWJJbnNwZWN0b3IuT3ZlcnJp ZGVzVmlldygpOwogICAgIHRoaXMuY29udGFpbmVyRWxlbWVudC5wYXJlbnRFbGVtZW50LmFwcGVu ZENoaWxkKHRoaXMuX3ZpZXcuY29udGFpbmVyRWxlbWVudCk7Ci0gICAgdGhpcy5jb250YWluZXJF bGVtZW50LnJlbW92ZSgpOworICAgIHRoaXMuY29udGFpbmVyRWxlbWVudC5yZW1vdmVTZWxmKCk7 CiAgICAgdGhpcy5jb250YWluZXJFbGVtZW50ID0gdGhpcy5fdmlldy5jb250YWluZXJFbGVtZW50 OwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Nv dXJjZVRva2VuaXplci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291 cmNlVG9rZW5pemVyLmpzCmluZGV4IDlhZTc4YTY1ZDk2MDA2OWI1YTViZGFhMDU3MmU2ZmQwMWQ0 YTcwZDguLjhiYzNkYjIzZjY4NmQyMGRjZWYzOWZkMjc2YTIyYTFjMmYxYTE0Y2IgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlVG9rZW5pemVyLmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlVG9rZW5pemVy LmpzCkBAIC0zNCw2ICszNCw4IEBACiAgKi8KIFdlYkluc3BlY3Rvci5Tb3VyY2VUb2tlbml6ZXIg PSBmdW5jdGlvbigpCiB7CisgICAgLyoqIEB0eXBlIHs/c3RyaW5nfSAqLworICAgIHRoaXMudG9r ZW5UeXBlID0gbnVsbDsKIH0KIAogV2ViSW5zcGVjdG9yLlNvdXJjZVRva2VuaXplci5wcm90b3R5 cGUgPSB7CkBAIC02MSw2ICs2MywxMCBAQCBXZWJJbnNwZWN0b3IuU291cmNlVG9rZW5pemVyLnBy b3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5jb25kaXRpb24ubGV4Q29uZGl0aW9uID0gbGV4Q29u ZGl0aW9uOwogICAgIH0sCiAKKyAgICAvKioKKyAgICAgKiBAcGFyYW0ge251bWJlcn0gY3Vyc29y CisgICAgICogQHJldHVybiB7c3RyaW5nfQorICAgICAqLwogICAgIF9jaGFyQXQ6IGZ1bmN0aW9u KGN1cnNvcikKICAgICB7CiAgICAgICAgIHJldHVybiBjdXJzb3IgPCB0aGlzLl9saW5lLmxlbmd0 aCA/IHRoaXMuX2xpbmUuY2hhckF0KGN1cnNvcikgOiAiXG4iOwpAQCAtNzAsNiArNzYsMTAgQEAg V2ViSW5zcGVjdG9yLlNvdXJjZVRva2VuaXplci5wcm90b3R5cGUgPSB7CiAgICAgewogICAgIH0s CiAKKyAgICAvKioKKyAgICAgKiBAcGFyYW0ge251bWJlcn0gY3Vyc29yCisgICAgICogQHJldHVy biB7bnVtYmVyfQorICAgICAqLwogICAgIG5leHRUb2tlbjogZnVuY3Rpb24oY3Vyc29yKQogICAg IHsKICAgICB9CkBAIC04OCw2ICs5OCw5IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VUb2tlbml6ZXIu UmVnaXN0cnkgPSBmdW5jdGlvbigpIHsKICAgICB9OwogfQogCisvKioKKyAqIEByZXR1cm4ge1dl Ykluc3BlY3Rvci5Tb3VyY2VUb2tlbml6ZXIuUmVnaXN0cnl9CisgKi8KIFdlYkluc3BlY3Rvci5T b3VyY2VUb2tlbml6ZXIuUmVnaXN0cnkuZ2V0SW5zdGFuY2UgPSBmdW5jdGlvbigpCiB7CiAgICAg aWYgKCFXZWJJbnNwZWN0b3IuU291cmNlVG9rZW5pemVyLlJlZ2lzdHJ5Ll9pbnN0YW5jZSkKQEAg LTk2LDYgKzEwOSwxMCBAQCBXZWJJbnNwZWN0b3IuU291cmNlVG9rZW5pemVyLlJlZ2lzdHJ5Lmdl dEluc3RhbmNlID0gZnVuY3Rpb24oKQogfQogCiBXZWJJbnNwZWN0b3IuU291cmNlVG9rZW5pemVy LlJlZ2lzdHJ5LnByb3RvdHlwZSA9IHsKKyAgICAvKioKKyAgICAgKiBAcGFyYW0ge3N0cmluZ30g bWltZVR5cGUKKyAgICAgKiBAcmV0dXJuIHtXZWJJbnNwZWN0b3IuU291cmNlVG9rZW5pemVyfQor ICAgICAqLwogICAgIGdldFRva2VuaXplcjogZnVuY3Rpb24obWltZVR5cGUpCiAgICAgewogICAg ICAgICBpZiAoIXRoaXMuX3Rva2VuaXplckNvbnN0cnVjdG9yc1ttaW1lVHlwZV0pCg==