106981 2013-01-15 21:51:16 -0800 Get rid of Node::createRareData 2013-01-15 23:38:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106965 1 rniwa rniwa benjamin cmarcelo eric esprehn kling koivisto ojan.autocc webkit.review.bot oldest_to_newest 808042 0 rniwa 2013-01-15 21:51:16 -0800 Get rid of Node::createRareData 808044 1 182918 rniwa 2013-01-15 21:53:29 -0800 Created attachment 182918 Cleanup 808047 2 eric 2013-01-15 22:05:37 -0800 Looks reasonable. I'd like to see esprehn comment since he's been in here most recently (I know he's not a reviewer). :) 808054 3 182918 benjamin 2013-01-15 22:28:12 -0800 Comment on attachment 182918 Cleanup I like it! Thank you for quickly coding the follow up. 808087 4 rniwa 2013-01-15 23:38:10 -0800 Committed r139839: <http://trac.webkit.org/changeset/139839> 182918 2013-01-15 21:53:29 -0800 2013-01-15 22:28:12 -0800 Cleanup bug-106981-20130115215034.patch text/plain 6257 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTgzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDEzLTAxLTE1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEdldCByaWQgb2YgTm9kZTo6Y3Jl YXRlUmFyZURhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNjk4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIERlbGV0ZWQgTm9kZTo6Y3JlYXRlUmFyZURhdGEuIE5vZGU6OmVuc3VyZVJhcmVEYXRhKCkg aW5zdGFudGlhdGVzIE5vZGVSYXJlRGF0YQorICAgICAgICBvciBFbGVtZW50UmFyZURhdGEgYWNj b3JkaW5nIHRvIHRoZSBub2RlIHR5cGUuIEFsc28gZW5jYXBzdWxhdGUgbmV3IGJ5IGNyZWF0ZQor ICAgICAgICBmdW5jdGlvbnMgaW4gTm9kZVJhcmVEYXRhIGFuZCBFbGVtZW50UmFyZURhdGEuCisK KyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAg KiBkb20vRWxlbWVudC5oOgorICAgICAgICAoRWxlbWVudCk6CisgICAgICAgICogZG9tL0VsZW1l bnRSYXJlRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudFJhcmVEYXRhOjpjcmVhdGUp OgorICAgICAgICAoRWxlbWVudFJhcmVEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnRS YXJlRGF0YTo6RWxlbWVudFJhcmVEYXRhKToKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpOb2RlOjplbnN1cmVSYXJlRGF0YSk6CisgICAgICAgIChXZWJDb3JlKToK KyAgICAgICAgKiBkb20vTm9kZS5oOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZVJhcmVEYXRhQmFz ZTo6Tm9kZVJhcmVEYXRhQmFzZSk6CisgICAgICAgICogZG9tL05vZGVSYXJlRGF0YS5oOgorICAg ICAgICAoTm9kZVJhcmVEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGVSYXJlRGF0YTo6Y3Jl YXRlKToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGVSYXJlRGF0YTo6Tm9kZVJhcmVEYXRhKToKKwog MjAxMy0wMS0xNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBO b2RlUmFyZURhdGEgZG9lc24ndCBuZWVkIHRvIGhhdmUgYSB2dGFibGUgcG9pbnRlcgpJbmRleDog U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gMTM5ODMzKQorKysgU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjMsMTEgKzIyMyw2IEBAIGlubGlu ZSBFbGVtZW50UmFyZURhdGEqIEVsZW1lbnQ6OmVuc3VyZUUKICAgICByZXR1cm4gc3RhdGljX2Nh c3Q8RWxlbWVudFJhcmVEYXRhKj4oZW5zdXJlUmFyZURhdGEoKSk7CiB9CiAKLVBhc3NPd25QdHI8 Tm9kZVJhcmVEYXRhPiBFbGVtZW50OjpjcmVhdGVSYXJlRGF0YSgpCi17Ci0gICAgcmV0dXJuIGFk b3B0UHRyKG5ldyBFbGVtZW50UmFyZURhdGEoKSk7Ci19Ci0KIHZvaWQgRWxlbWVudDo6Y2xlYXJU YWJJbmRleEV4cGxpY2l0bHlJZk5lZWRlZCgpCiB7CiAgICAgaWYgKGhhc1JhcmVEYXRhKCkpCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50LmgJKHJldmlzaW9uIDEzOTgzMykKKysrIFNvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTU4MCw3ICs1ODAsNiBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxFbGVtZW50PiBjbG9uZUVsZW1lbnRXaXRob3V0QXR0 cmlidXRlc0FuZENoaWxkcmVuKCk7CiAKICAgICBRdWFsaWZpZWROYW1lIG1fdGFnTmFtZTsKLSAg ICB2aXJ0dWFsIFBhc3NPd25QdHI8Tm9kZVJhcmVEYXRhPiBjcmVhdGVSYXJlRGF0YSgpOwogICAg IGJvb2wgcmFyZURhdGFTdHlsZUFmZmVjdGVkQnlFbXB0eSgpIGNvbnN0OwogICAgIGJvb2wgcmFy ZURhdGFDaGlsZHJlbkFmZmVjdGVkQnlIb3ZlcigpIGNvbnN0OwogICAgIGJvb2wgcmFyZURhdGFD aGlsZHJlbkFmZmVjdGVkQnlBY3RpdmUoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50UmFyZURhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudFJhcmVEYXRhLmgJKHJldmlzaW9uIDEzOTgzMykKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50UmFyZURhdGEuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsNyArMzUsOCBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIGNsYXNzIEVsZW1lbnRSYXJlRGF0YSA6IHB1YmxpYyBOb2RlUmFyZURh dGEgewogcHVibGljOgotICAgIEVsZW1lbnRSYXJlRGF0YSgpOworICAgIHN0YXRpYyBQYXNzT3du UHRyPEVsZW1lbnRSYXJlRGF0YT4gY3JlYXRlKFJlbmRlck9iamVjdCogcmVuZGVyZXIpIHsgcmV0 dXJuIGFkb3B0UHRyKG5ldyBFbGVtZW50UmFyZURhdGEocmVuZGVyZXIpKTsgfQorCiAgICAgfkVs ZW1lbnRSYXJlRGF0YSgpOwogCiAgICAgdm9pZCBzZXRQc2V1ZG9FbGVtZW50KFBzZXVkb0lkLCBQ YXNzUmVmUHRyPFBzZXVkb0VsZW1lbnQ+KTsKQEAgLTE3Miw2ICsxNzMsNyBAQCBwcml2YXRlOgog ICAgIFJlZlB0cjxQc2V1ZG9FbGVtZW50PiBtX2dlbmVyYXRlZEJlZm9yZTsKICAgICBSZWZQdHI8 UHNldWRvRWxlbWVudD4gbV9nZW5lcmF0ZWRBZnRlcjsKIAorICAgIEVsZW1lbnRSYXJlRGF0YShS ZW5kZXJPYmplY3QqKTsKICAgICB2b2lkIHJlbGVhc2VQc2V1ZG9FbGVtZW50KFBzZXVkb0VsZW1l bnQqKTsKIH07CiAKQEAgLTE4MCw4ICsxODIsOSBAQCBpbmxpbmUgSW50U2l6ZSBkZWZhdWx0TWlu aW11bVNpemVGb3JSZXNpCiAgICAgcmV0dXJuIEludFNpemUoTGF5b3V0VW5pdDo6bWF4KCksIExh eW91dFVuaXQ6Om1heCgpKTsKIH0KIAotaW5saW5lIEVsZW1lbnRSYXJlRGF0YTo6RWxlbWVudFJh cmVEYXRhKCkKLSAgICA6IG1fdGFiSW5kZXgoMCkKK2lubGluZSBFbGVtZW50UmFyZURhdGE6OkVs ZW1lbnRSYXJlRGF0YShSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQorICAgIDogTm9kZVJhcmVEYXRh KHJlbmRlcmVyKQorICAgICwgbV90YWJJbmRleCgwKQogICAgICwgbV9jaGlsZEluZGV4KDApCiAg ICAgLCBtX3RhYkluZGV4V2FzU2V0RXhwbGljaXRseShmYWxzZSkKICAgICAsIG1fbmVlZHNGb2N1 c0FwcGVhcmFuY2VVcGRhdGVTb29uQWZ0ZXJBdHRhY2goZmFsc2UpCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL05vZGUu Y3BwCShyZXZpc2lvbiAxMzk4MzMpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ1MiwxOSArNDUyLDE4IEBAIE5vZGVSYXJlRGF0YSogTm9kZTo6ZW5z dXJlUmFyZURhdGEoKQogICAgIGlmIChoYXNSYXJlRGF0YSgpKQogICAgICAgICByZXR1cm4gcmFy ZURhdGEoKTsKIAotICAgIE5vZGVSYXJlRGF0YSogZGF0YSA9IGNyZWF0ZVJhcmVEYXRhKCkubGVh a1B0cigpOworICAgIE5vZGVSYXJlRGF0YSogZGF0YTsKKyAgICBpZiAoaXNFbGVtZW50Tm9kZSgp KQorICAgICAgICBkYXRhID0gRWxlbWVudFJhcmVEYXRhOjpjcmVhdGUobV9kYXRhLm1fcmVuZGVy ZXIpLmxlYWtQdHIoKTsKKyAgICBlbHNlCisgICAgICAgIGRhdGEgPSBOb2RlUmFyZURhdGE6OmNy ZWF0ZShtX2RhdGEubV9yZW5kZXJlcikubGVha1B0cigpOwogICAgIEFTU0VSVChkYXRhKTsKLSAg ICBkYXRhLT5zZXRSZW5kZXJlcihtX2RhdGEubV9yZW5kZXJlcik7CisKICAgICBtX2RhdGEubV9y YXJlRGF0YSA9IGRhdGE7CiAgICAgc2V0RmxhZyhIYXNSYXJlRGF0YUZsYWcpOwogICAgIHJldHVy biBkYXRhOwogfQogCi1QYXNzT3duUHRyPE5vZGVSYXJlRGF0YT4gTm9kZTo6Y3JlYXRlUmFyZURh dGEoKQotewotICAgIHJldHVybiBhZG9wdFB0cihuZXcgTm9kZVJhcmVEYXRhKCkpOwotfQotCiB2 b2lkIE5vZGU6OmNsZWFyUmFyZURhdGEoKQogewogICAgIEFTU0VSVChoYXNSYXJlRGF0YSgpKTsK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvZG9tL05vZGUuaAkocmV2aXNpb24gMTM5ODMzKQorKysgU291cmNlL1dlYkNvcmUvZG9t L05vZGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTE2LDcgKzExNiw5IEBAIHB1YmxpYzoKICAgICB2 b2lkIHNldFJlbmRlcmVyKFJlbmRlck9iamVjdCogcmVuZGVyZXIpIHsgbV9yZW5kZXJlciA9IHJl bmRlcmVyOyB9CiAKIHByb3RlY3RlZDoKLSAgICBOb2RlUmFyZURhdGFCYXNlKCkgeyB9CisgICAg Tm9kZVJhcmVEYXRhQmFzZShSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQorICAgICAgICA6IG1fcmVu ZGVyZXIocmVuZGVyZXIpCisgICAgeyB9CiAKIHByaXZhdGU6CiAgICAgUmVuZGVyT2JqZWN0KiBt X3JlbmRlcmVyOwpAQCAtNzg1LDggKzc4Nyw2IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lk IHJlZkV2ZW50VGFyZ2V0KCk7CiAgICAgdmlydHVhbCB2b2lkIGRlcmVmRXZlbnRUYXJnZXQoKTsK IAotICAgIHZpcnR1YWwgUGFzc093blB0cjxOb2RlUmFyZURhdGE+IGNyZWF0ZVJhcmVEYXRhKCk7 Ci0KICAgICB2aXJ0dWFsIFJlbmRlclN0eWxlKiBub25SZW5kZXJlclN0eWxlKCkgY29uc3QgeyBy ZXR1cm4gMDsgfQogCiAgICAgdmlydHVhbCBjb25zdCBBdG9taWNTdHJpbmcmIHZpcnR1YWxQcmVm aXgoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFyZURhdGEuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJhcmVEYXRhLmgJKHJldmlzaW9uIDEz OTgzMykKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFyZURhdGEuaAkod29ya2luZyBjb3B5 KQpAQCAtMjc2LDkgKzI3Niw4IEBAIHByaXZhdGU6CiAKIGNsYXNzIE5vZGVSYXJlRGF0YSA6IHB1 YmxpYyBOb2RlUmFyZURhdGFCYXNlIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShOb2RlUmFy ZURhdGEpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKLXB1YmxpYzogICAgCi0gICAgTm9kZVJh cmVEYXRhKCkKLSAgICB7IH0KK3B1YmxpYzoKKyAgICBzdGF0aWMgUGFzc093blB0cjxOb2RlUmFy ZURhdGE+IGNyZWF0ZShSZW5kZXJPYmplY3QqIHJlbmRlcmVyKSB7IHJldHVybiBhZG9wdFB0cihu ZXcgTm9kZVJhcmVEYXRhKHJlbmRlcmVyKSk7IH0KIAogICAgIHZvaWQgY2xlYXJOb2RlTGlzdHMo KSB7IG1fbm9kZUxpc3RzLmNsZWFyKCk7IH0KICAgICBOb2RlTGlzdHNOb2RlRGF0YSogbm9kZUxp c3RzKCkgY29uc3QgeyByZXR1cm4gbV9ub2RlTGlzdHMuZ2V0KCk7IH0KQEAgLTMwOSw2ICszMDgs MTEgQEAgcHVibGljOiAgICAKICAgICAvLyBUaGlzIG1lbWJlciBmdW5jdGlvbiBpcyBpbnRlbnRp b25pYWxseSBub3QgdmlydHVhbCB0byBhdm9pZCBhZGRpbmcgYSB2dGFibGUgcG9pbnRlci4KICAg ICB2b2lkIHJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qKSBjb25zdDsKIAorcHJv dGVjdGVkOgorICAgIE5vZGVSYXJlRGF0YShSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQorICAgICAg ICA6IE5vZGVSYXJlRGF0YUJhc2UocmVuZGVyZXIpCisgICAgeyB9CisKIHByaXZhdGU6CiAgICAg T3duUHRyPE5vZGVMaXN0c05vZGVEYXRhPiBtX25vZGVMaXN0czsKICAgICBPd25QdHI8Tm9kZU11 dGF0aW9uT2JzZXJ2ZXJEYXRhPiBtX211dGF0aW9uT2JzZXJ2ZXJEYXRhOwo=