106940 2013-01-15 13:19:14 -0800 Suspend CSS animations for background tabs 2013-01-15 15:45:43 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin dino simon.fraser thorton oldest_to_newest 807629 0 bdakin 2013-01-15 13:19:14 -0800 We should suspend CSS animations when a page is in the background. <rdar://problem/12961725> 807630 1 182838 bdakin 2013-01-15 13:20:57 -0800 Created attachment 182838 Patch 807657 2 182838 dino 2013-01-15 13:46:53 -0800 Comment on attachment 182838 Patch I'm surprised that this is all it takes. I wonder if it should be a setting so ports could toggle it? 807665 3 182838 simon.fraser 2013-01-15 13:53:18 -0800 Comment on attachment 182838 Patch IIRC these suspend/resume calls don't work very well; if JS runs and starts an animation while animations are "suspended" it will actually run. 807666 4 dino 2013-01-15 13:54:22 -0800 Also, we have some bugs with fill mode iirc. But, we'll just have to fix all this :( 807668 5 simon.fraser 2013-01-15 13:55:18 -0800 We also have Frame::suspendActiveDOMObjectsAndAnimations (added in r109548). Should we be using that instead? FocusController doesn't seem like the right place to do this. 807739 6 bdakin 2013-01-15 15:23:10 -0800 Actually, I think I found a place that I prefer for this code to live. I think it should be grouped with Kiran's DOM timer throttling (see http://trac.webkit.org/changeset/130720 ) which is in Page::setVisibilityState(). As far as I can tell, Page::setVisibilityState() and FocusController::setContainingWindowIsVisible() are pretty much equivalent, but it would be nice to have all of this throttling/suspending in the same place. I am going to post a new patch that moves this code to Page::setVisibilityState(). 807740 7 182855 bdakin 2013-01-15 15:25:16 -0800 Created attachment 182855 Patch in Page We might want to re-name HIDDEN_PAGE_DOM_TIMER_THROTTLING to HIDDEN_PAGE_THROTTLING if we go with this. 807743 8 182855 simon.fraser 2013-01-15 15:29:44 -0800 Comment on attachment 182855 Patch in Page I like this better but I don't think it should be inside #if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING). 807764 9 bdakin 2013-01-15 15:45:43 -0800 http://trac.webkit.org/changeset/139800 182838 2013-01-15 13:20:57 -0800 2013-01-15 15:25:16 -0800 Patch for-review.txt text/plain 1369 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTc3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTE1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA2OTQwCisgICAgICAgIFN1c3BlbmQgQ1NTIGFuaW1hdGlvbnMg Zm9yIGJhY2tncm91bmQgdGFicworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Rm9jdXNDb250cm9sbGVyOjpzZXRDb250YWluaW5nV2luZG93SXNWaXNpYmxlKToKKwogMjAx My0wMS0xNSAgSmFtZXMgU2ltb25zZW4gIDxzaW1vbmphbUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW1VzZXIgVGltaW5nXSBJTlZBTElEX0FDQ0VTU19FUlIgc2hvdWxkIGJlIHRocm93biBpZiBt ZWFzdXJpbmcgZnJvbSBhIDAgTmF2IFRpbWluZyB2YWx1ZQpJbmRleDogU291cmNlL1dlYkNvcmUv cGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvRm9jdXNDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMTM5NzcxKQorKysgU291cmNlL1dlYkNv cmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NjksNiArNjY5 LDExIEBAIHZvaWQgRm9jdXNDb250cm9sbGVyOjpzZXRDb250YWluaW5nV2luZG8KIAogICAgIGNv bnRlbnRBcmVhRGlkU2hvd09ySGlkZSh2aWV3LCBjb250YWluaW5nV2luZG93SXNWaXNpYmxlKTsK IAorICAgIGlmIChjb250YWluaW5nV2luZG93SXNWaXNpYmxlKQorICAgICAgICBtX3BhZ2UtPm1h aW5GcmFtZSgpLT5hbmltYXRpb24oKS0+cmVzdW1lQW5pbWF0aW9ucygpOworICAgIGVsc2UKKyAg ICAgICAgbV9wYWdlLT5tYWluRnJhbWUoKS0+YW5pbWF0aW9uKCktPnN1c3BlbmRBbmltYXRpb25z KCk7CisKICAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1fcGFnZS0+bWFpbkZyYW1lKCk7IGZyYW1l OyBmcmFtZSA9IGZyYW1lLT50cmVlKCktPnRyYXZlcnNlTmV4dCgpKSB7CiAgICAgICAgIEZyYW1l VmlldyogZnJhbWVWaWV3ID0gZnJhbWUtPnZpZXcoKTsKICAgICAgICAgaWYgKCFmcmFtZVZpZXcp Cg== 182855 2013-01-15 15:25:16 -0800 2013-01-15 15:29:44 -0800 Patch in Page for-review-2.txt text/plain 1434 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTc5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTE1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA2OTQwCisgICAgICAgIFN1c3BlbmQgQ1NTIGFuaW1hdGlvbnMg Zm9yIGJhY2tncm91bmQgdGFicworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnNl dFZpc2liaWxpdHlTdGF0ZSk6CisKIDIwMTMtMDEtMTUgIEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxMjE1OTkpOiBpbmNvcnJlY3QgYm9y ZGVyIHNjYWxpbmcgd2hlbiB6b29tZWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAkocmV2aXNpb24g MTM5NzcxKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTE1NCwxMCArMTE1NCwxMyBAQCB2b2lkIFBhZ2U6OnNldFZpc2liaWxpdHlTdGF0ZShQYWdl VmlzaWJpCiAjZW5kaWYKIAogI2lmIEVOQUJMRShISURERU5fUEFHRV9ET01fVElNRVJfVEhST1RU TElORykKLSAgICBpZiAodmlzaWJpbGl0eVN0YXRlID09IFdlYkNvcmU6OlBhZ2VWaXNpYmlsaXR5 U3RhdGVIaWRkZW4pCisgICAgaWYgKHZpc2liaWxpdHlTdGF0ZSA9PSBXZWJDb3JlOjpQYWdlVmlz aWJpbGl0eVN0YXRlSGlkZGVuKSB7CiAgICAgICAgIHNldFRpbWVyQWxpZ25tZW50SW50ZXJ2YWwo U2V0dGluZ3M6OmhpZGRlblBhZ2VET01UaW1lckFsaWdubWVudEludGVydmFsKCkpOwotICAgIGVs c2UKKyAgICAgICAgbWFpbkZyYW1lKCktPmFuaW1hdGlvbigpLT5zdXNwZW5kQW5pbWF0aW9ucygp OworICAgIH0gZWxzZSB7CiAgICAgICAgIHNldFRpbWVyQWxpZ25tZW50SW50ZXJ2YWwoU2V0dGlu Z3M6OmRlZmF1bHRET01UaW1lckFsaWdubWVudEludGVydmFsKCkpOworICAgICAgICBtYWluRnJh bWUoKS0+YW5pbWF0aW9uKCktPnJlc3VtZUFuaW1hdGlvbnMoKTsKKyAgICB9CiAjaWYgIUVOQUJM RShQQUdFX1ZJU0lCSUxJVFlfQVBJKQogICAgIFVOVVNFRF9QQVJBTShpc0luaXRpYWxTdGF0ZSk7 CiAjZW5kaWYK