106934 2013-01-15 12:18:38 -0800 RenderText::computePreferredLogicalWidths does not need to be public 2013-01-15 12:45:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric jchaffraix leviw ojan.autocc tony webkit.review.bot oldest_to_newest 807552 0 ojan 2013-01-15 12:18:38 -0800 RenderText::computePreferredLogicalWidths does not need to be public 807554 1 182824 ojan 2013-01-15 12:19:38 -0800 Created attachment 182824 Patch 807556 2 182824 leviw 2013-01-15 12:20:45 -0800 Comment on attachment 182824 Patch Ojan, destroyer of janky computePreferredLogicalWidths definitions. 807585 3 182824 webkit.review.bot 2013-01-15 12:45:50 -0800 Comment on attachment 182824 Patch Clearing flags on attachment: 182824 Committed r139773: <http://trac.webkit.org/changeset/139773> 807586 4 webkit.review.bot 2013-01-15 12:45:53 -0800 All reviewed patches have been landed. Closing bug. 182824 2013-01-15 12:19:38 -0800 2013-01-15 12:45:50 -0800 Patch bug-106934-20130115121640.patch text/plain 2329 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5Njg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhkNmQ0Y2Q1OGZlY2Jm MjM0NDBlMjZkZGVjNTY0NGNkOTc3MGQ1OS4uYWFiZDEwOTJkOGIxMDYxZjYyNzg3MWI0YmRkNjJl YzViMGJlOWFmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTE1ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVuZGVyVGV4dDo6Y29tcHV0 ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMgZG9lcyBub3QgbmVlZCB0byBiZSBwdWJsaWMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjkzNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckNvdW50ZXIuaDoKKyAgICAgICAgQWRkIE9WRVJSSURFIGtleXdvcmQuCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclRleHQuaDoKKyAgICAgICAgTWFrZSBwcm90ZWN0ZWQuCisKIDIwMTMt MDEtMTQgIFRpZW4tUmVuIENoZW4gIDx0cmNoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENv cnJlY3QgRnJhbWVWaWV3OjpzY3JvbGxhYmxlQXJlYUJvdW5kaW5nQm94KCkgY2FsY3VsYXRpb24g aW4gdGhlIHByZXNlbmNlIG9mIHRyYW5zZm9ybXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJDb3VudGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQ291bnRlci5oCmluZGV4IDU0ODgyODY0NzkyNGVkYWE4NWE2ZDMwOTIwZmQyZjRhNWUxYTA4 OTguLmIxZTJjZTQ2MDQzMDAwYTNjY2FiNzA1YzNkM2RiODNkMzA3ZGZhYmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJDb3VudGVyLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIuaApAQCAtNDksNyArNDksNyBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBvcmlnaW5hbFRleHQoKSBjb25z dDsKICAgICAKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlVGV4dCgpIE9WRVJSSURFOwotICAgIHZp cnR1YWwgdm9pZCBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhmbG9hdCBsZWFkV2lkdGgp OworICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhmbG9hdCBs ZWFkV2lkdGgpIE9WRVJSSURFOwogCiAgICAgLy8gUmVtb3ZlcyB0aGUgcmVmZXJlbmNlIHRvIHRo ZSBDb3VudGVyTm9kZSBhc3NvY2lhdGVkIHdpdGggdGhpcyByZW5kZXJlci4KICAgICAvLyBUaGlz IGlzIHVzZWQgdG8gY2F1c2UgYSBjb3VudGVyIGRpc3BsYXkgdXBkYXRlIHdoZW4gdGhlIENvdW50 ZXJOb2RlIHRyZWUgY2hhbmdlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5oCmlu ZGV4IDVjNjZmMWE0ZjI0YTY2ODUxOGY3MzBhMTVkNjU0OTM2NzJmMmI1ZjQuLjlkMTI2YjdmY2Rh ODRiYjM0NGJkYzQxOWQyOGMyMTAzZTFhYzNkYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHQuaApAQCAtMTM3LDcgKzEzNyw2IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgY2hlY2tD b25zaXN0ZW5jeSgpIGNvbnN0OwogCi0gICAgdmlydHVhbCB2b2lkIGNvbXB1dGVQcmVmZXJyZWRM b2dpY2FsV2lkdGhzKGZsb2F0IGxlYWRXaWR0aCk7CiAgICAgYm9vbCBpc0FsbENvbGxhcHNpYmxl V2hpdGVzcGFjZSgpOwogCiAgICAgYm9vbCBjYW5Vc2VTaW1wbGVGb250Q29kZVBhdGgoKSBjb25z dCB7IHJldHVybiBtX2NhblVzZVNpbXBsZUZvbnRDb2RlUGF0aDsgfQpAQCAtMTQ4LDYgKzE0Nyw3 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2Jq ZWN0SW5mbyopIGNvbnN0IE9WRVJSSURFOwogCiBwcm90ZWN0ZWQ6CisgICAgdmlydHVhbCB2b2lk IGNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKGZsb2F0IGxlYWRXaWR0aCk7CiAgICAgdmly dHVhbCB2b2lkIHdpbGxCZURlc3Ryb3llZCgpOwogCiAgICAgdmlydHVhbCB2b2lkIHN0eWxlV2ls bENoYW5nZShTdHlsZURpZmZlcmVuY2UsIGNvbnN0IFJlbmRlclN0eWxlKikgeyB9Cg==